From: Jens Axboe <axboe@kernel.dk>
To: Stephen Bates <sbates@raithlin.com>, Omar Sandoval <osandov@osandov.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"Damien.LeMoal@wdc.com" <Damien.LeMoal@wdc.com>,
"sagi@grimberg.me" <sagi@grimberg.me>
Subject: Re: [PATCH v3 2/2] blk-mq: Add a polling specific stats function
Date: Thu, 20 Apr 2017 16:06:42 -0600 [thread overview]
Message-ID: <c8a630f0-2745-3c3c-3e2f-e6515d39f75d@kernel.dk> (raw)
In-Reply-To: <F1D4091B-6AA1-46D0-A99E-0A891DE4939E@raithlin.com>
On 04/20/2017 04:05 PM, Stephen Bates wrote:
>
>> You can, but it won't do much good since v3 is already applied. Any
>> further changes must be incremental.
>
> BTW getting a compile error from the Kyber code in for-4.12/block due to the fact we now return a signed from the bucket function…
>
> batesste@ubuntu64-batesste:~/kernel/linux$ make -j 2 all
> CHK include/config/kernel.release
> CHK include/generated/uapi/linux/version.h
> CHK include/generated/utsrelease.h
> CHK include/generated/timeconst.h
> CHK include/generated/bounds.h
> CHK include/generated/asm-offsets.h
> CALL scripts/checksyscalls.sh
> CHK include/generated/compile.h
> CC block/kyber-iosched.o
> block/kyber-iosched.c: In function ‘kyber_queue_data_alloc’:
> block/kyber-iosched.c:295:57: error: passing argument 2 of ‘blk_stat_alloc_callback’ from incompatible pointer type [-Werror=incompatible-pointer-types]
> kqd->cb = blk_stat_alloc_callback(kyber_stat_timer_fn, rq_sched_domain,
> ^
> In file included from block/blk-mq.h:4:0,
> from block/blk.h:6,
> from block/kyber-iosched.c:27:
> block/blk-stat.h:138:1: note: expected ‘int (*)(const struct request *)’ but argument is of type ‘unsigned int (*)(const struct request *)’
> blk_stat_alloc_callback(void (*timer_fn)(struct blk_stat_callback *),
> ^
> CC block/compat_ioctl.o
> cc1: some warnings being treated as errors
I did fix that one up, I did a ninja rebase, but apparently you pulled in the
few minutes it existed. So just update, and you should be fine.
--
Jens Axboe
WARNING: multiple messages have this Message-ID (diff)
From: axboe@kernel.dk (Jens Axboe)
Subject: [PATCH v3 2/2] blk-mq: Add a polling specific stats function
Date: Thu, 20 Apr 2017 16:06:42 -0600 [thread overview]
Message-ID: <c8a630f0-2745-3c3c-3e2f-e6515d39f75d@kernel.dk> (raw)
In-Reply-To: <F1D4091B-6AA1-46D0-A99E-0A891DE4939E@raithlin.com>
On 04/20/2017 04:05 PM, Stephen Bates wrote:
>
>> You can, but it won't do much good since v3 is already applied. Any
>> further changes must be incremental.
>
> BTW getting a compile error from the Kyber code in for-4.12/block due to the fact we now return a signed from the bucket function?
>
> batesste at ubuntu64-batesste:~/kernel/linux$ make -j 2 all
> CHK include/config/kernel.release
> CHK include/generated/uapi/linux/version.h
> CHK include/generated/utsrelease.h
> CHK include/generated/timeconst.h
> CHK include/generated/bounds.h
> CHK include/generated/asm-offsets.h
> CALL scripts/checksyscalls.sh
> CHK include/generated/compile.h
> CC block/kyber-iosched.o
> block/kyber-iosched.c: In function ?kyber_queue_data_alloc?:
> block/kyber-iosched.c:295:57: error: passing argument 2 of ?blk_stat_alloc_callback? from incompatible pointer type [-Werror=incompatible-pointer-types]
> kqd->cb = blk_stat_alloc_callback(kyber_stat_timer_fn, rq_sched_domain,
> ^
> In file included from block/blk-mq.h:4:0,
> from block/blk.h:6,
> from block/kyber-iosched.c:27:
> block/blk-stat.h:138:1: note: expected ?int (*)(const struct request *)? but argument is of type ?unsigned int (*)(const struct request *)?
> blk_stat_alloc_callback(void (*timer_fn)(struct blk_stat_callback *),
> ^
> CC block/compat_ioctl.o
> cc1: some warnings being treated as errors
I did fix that one up, I did a ninja rebase, but apparently you pulled in the
few minutes it existed. So just update, and you should be fine.
--
Jens Axboe
next prev parent reply other threads:[~2017-04-20 22:06 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 12:24 [PATCH v3 0/2] blk-stat: Add ability to not bucket IO; improve IO polling sbates
2017-04-07 12:24 ` sbates
2017-04-07 12:24 ` [PATCH v3 1/2] blk-stat: convert blk-stat bucket callback to signed sbates
2017-04-07 12:24 ` sbates
2017-04-07 12:24 ` [PATCH v3 2/2] blk-mq: Add a polling specific stats function sbates
2017-04-07 12:24 ` sbates
2017-04-20 20:07 ` Omar Sandoval
2017-04-20 20:07 ` Omar Sandoval
2017-04-20 20:16 ` Jens Axboe
2017-04-20 20:16 ` Jens Axboe
2017-04-20 20:20 ` Omar Sandoval
2017-04-20 20:20 ` Omar Sandoval
2017-04-20 20:22 ` Jens Axboe
2017-04-20 20:22 ` Jens Axboe
2017-04-20 20:33 ` Stephen Bates
2017-04-20 20:33 ` Stephen Bates
2017-04-20 20:34 ` Jens Axboe
2017-04-20 20:34 ` Jens Axboe
2017-04-20 20:47 ` Stephen Bates
2017-04-20 20:47 ` Stephen Bates
2017-04-20 20:53 ` Jens Axboe
2017-04-20 20:53 ` Jens Axboe
2017-04-20 21:08 ` Stephen Bates
2017-04-20 21:08 ` Stephen Bates
2017-04-20 21:14 ` Jens Axboe
2017-04-20 21:14 ` Jens Axboe
2017-04-20 21:41 ` Stephen Bates
2017-04-20 21:41 ` Stephen Bates
2017-04-20 21:42 ` Jens Axboe
2017-04-20 21:42 ` Jens Axboe
2017-04-20 21:45 ` Stephen Bates
2017-04-20 21:45 ` Stephen Bates
2017-04-20 22:05 ` Stephen Bates
2017-04-20 22:05 ` Stephen Bates
2017-04-20 22:06 ` Jens Axboe [this message]
2017-04-20 22:06 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8a630f0-2745-3c3c-3e2f-e6515d39f75d@kernel.dk \
--to=axboe@kernel.dk \
--cc=Damien.LeMoal@wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=osandov@osandov.com \
--cc=sagi@grimberg.me \
--cc=sbates@raithlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.