[PATCH 0/3] drm/imagination: small series of fixes for the pvr documentation

[PATCH 0/3] drm/imagination: small series of fixes for the pvr documentation

[Luigi Santivetti]

Small collection of fixes for out of date and incorrect comments
documenting pvr code.

Signed-off-by: Luigi Santivetti <luigi.santivetti@imgtec.com>
---
Alessio Belle (1):
      drm/imagination: Fix repeated typo in KCCB documentation

Alexandru Dadu (1):
      drm/imagination: Update Rogue heap comments

Matt Coster (1):
      drm/imagination: fixup some docs in pvr_gem.h

 drivers/gpu/drm/imagination/pvr_ccb.c               |  6 +++---
 drivers/gpu/drm/imagination/pvr_gem.h               | 15 +++++----------
 drivers/gpu/drm/imagination/pvr_rogue_heap_config.h | 10 +++++-----
 3 files changed, 13 insertions(+), 18 deletions(-)
---
base-commit: d6c075f797a672a6e3bd2fd44aee713801698ec2
change-id: 20260803-staging-pvr-docs-fixes-6ef8fa78a9e0

Best regards,
--  
Luigi Santivetti <luigi.santivetti@imgtec.com>

[PATCH 1/3] drm/imagination: fixup some docs in pvr_gem.h

[Luigi Santivetti]

From: Matt Coster <matt.coster@imgtec.com>

Update and remove some old comment in the PVR gem documentation.

Signed-off-by: Matt Coster <matt.coster@imgtec.com>
Signed-off-by: Luigi Santivetti <luigi.santivetti@imgtec.com>
---
 drivers/gpu/drm/imagination/pvr_gem.h | 15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/imagination/pvr_gem.h b/drivers/gpu/drm/imagination/pvr_gem.h
index c99f30cc6208..c57b0834b7ae 100644
--- a/drivers/gpu/drm/imagination/pvr_gem.h
+++ b/drivers/gpu/drm/imagination/pvr_gem.h
@@ -81,11 +81,12 @@ struct pvr_file;
  * struct pvr_gem_object - powervr-specific wrapper for &struct drm_gem_object
  */
 struct pvr_gem_object {
-	/**
-	 * @base: The underlying &struct drm_gem_shmem_object.
+	/** @base: The underlying &struct drm_gem_shmem_object.
+	 *
+	 * .. note::
 	 *
-	 * Do not access this member directly, instead call
-	 * shem_gem_from_pvr_gem().
+	 *    This member should not be accessed directly, but instead by
+	 *    calling shmem_gem_from_pvr_gem().
 	 */
 	struct drm_gem_shmem_object base;
 
@@ -97,12 +98,6 @@ struct pvr_gem_object {
 	 * changed after creation.
 	 *
 	 * Must be a combination of DRM_PVR_BO_* and/or PVR_BO_* flags.
-	 *
-	 * .. note::
-	 *
-	 *    This member is declared const to indicate that none of these
-	 *    options may change or be changed throughout the object's
-	 *    lifetime.
 	 */
 	u64 flags;
 

-- 
2.43.0

Re: [PATCH 1/3] drm/imagination: fixup some docs in pvr_gem.h

[Alessio Belle]

On Mon, 2026-08-03 at 11:22 +0100, Luigi Santivetti wrote:
> From: Matt Coster <matt.coster@imgtec.com>
> 
> Update and remove some old comment in the PVR gem documentation.

nit: comment -> comments, maybe gem -> GEM

> 
> Signed-off-by: Matt Coster <matt.coster@imgtec.com>
> Signed-off-by: Luigi Santivetti <luigi.santivetti@imgtec.com>
> ---
>  drivers/gpu/drm/imagination/pvr_gem.h | 15 +++++----------
>  1 file changed, 5 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/gpu/drm/imagination/pvr_gem.h b/drivers/gpu/drm/imagination/pvr_gem.h
> index c99f30cc6208..c57b0834b7ae 100644
> --- a/drivers/gpu/drm/imagination/pvr_gem.h
> +++ b/drivers/gpu/drm/imagination/pvr_gem.h
> @@ -81,11 +81,12 @@ struct pvr_file;
>   * struct pvr_gem_object - powervr-specific wrapper for &struct drm_gem_object
>   */
>  struct pvr_gem_object {
> -	/**
> -	 * @base: The underlying &struct drm_gem_shmem_object.
> +	/** @base: The underlying &struct drm_gem_shmem_object.

This was correct before, on its own line (kernel-doc is throwing a warning).

With this updated,

Reviewed-by: Alessio Belle <alessio.belle@imgtec.com>

Thanks,
Alessio

> +	 *
> +	 * .. note::
>  	 *
> -	 * Do not access this member directly, instead call
> -	 * shem_gem_from_pvr_gem().
> +	 *    This member should not be accessed directly, but instead by
> +	 *    calling shmem_gem_from_pvr_gem().
>  	 */
>  	struct drm_gem_shmem_object base;
>  
> @@ -97,12 +98,6 @@ struct pvr_gem_object {
>  	 * changed after creation.
>  	 *
>  	 * Must be a combination of DRM_PVR_BO_* and/or PVR_BO_* flags.
> -	 *
> -	 * .. note::
> -	 *
> -	 *    This member is declared const to indicate that none of these
> -	 *    options may change or be changed throughout the object's
> -	 *    lifetime.
>  	 */
>  	u64 flags;
>  
> 

[PATCH 2/3] drm/imagination: Update Rogue heap comments

[Luigi Santivetti]

From: Alexandru Dadu <alexandru.dadu@imgtec.com>

Update Rogue heap memory comments to fix typos.

Signed-off-by: Alexandru Dadu <alexandru.dadu@imgtec.com>
Signed-off-by: Luigi Santivetti <luigi.santivetti@imgtec.com>
---
 drivers/gpu/drm/imagination/pvr_rogue_heap_config.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/imagination/pvr_rogue_heap_config.h b/drivers/gpu/drm/imagination/pvr_rogue_heap_config.h
index 684766006703..5c33b342dda5 100644
--- a/drivers/gpu/drm/imagination/pvr_rogue_heap_config.h
+++ b/drivers/gpu/drm/imagination/pvr_rogue_heap_config.h
@@ -33,12 +33,12 @@
 /* 0 MiB to 4 MiB, size of 4 MiB : RESERVED */
 
 /* 0x00_0040_0000 - 0x7F_FFC0_0000 **/
-/* 4 MiB to 512 GiB, size of 512 GiB less 4 MiB : RESERVED **/
+/* 4 MiB to 512 GiB, size of 512 GiB less 4 MiB : RESERVED */
 
 /* 0x80_0000_0000 ************************************************************/
 
 /* 0x80_0000_0000 - 0x9F_FFFF_FFFF **/
-/* 512 GiB to 640 GiB, size of 128 GiB : GENERAL_HEAP **/
+/* 512 GiB to 640 GiB, size of 128 GiB : GENERAL_HEAP */
 #define ROGUE_GENERAL_HEAP_BASE 0x8000000000ull
 #define ROGUE_GENERAL_HEAP_SIZE SZ_128G
 
@@ -62,7 +62,7 @@
 #define ROGUE_PDSCODEDATA_HEAP_SIZE SZ_4G
 
 /* 0xDB_0000_0000 - 0xDB_FFFF_FFFF */
-/* 876 GiB to 880 GiB, size of 256 MiB (reserved 4GiB) : BRN **/
+/* 876 GiB to 880 GiB, size of 256 MiB (reserved 4GiB) : BRN */
 /*
  * The BRN63142 quirk workaround requires Region Header memory to be at the top
  * of a 16GiB aligned range. This is so when masked with 0x03FFFFFFFF the
@@ -82,7 +82,7 @@
 /* 0xE1_0000_0000 - 0xE1_BFFF_FFFF */
 /* 900 GiB to 903 GiB, size of 3 GiB : RESERVED */
 
-/* 0xE1_C000_000 - 0xE1_FFFF_FFFF */
+/* 0xE1_C000_0000 - 0xE1_FFFF_FFFF */
 /* 903 GiB to 904 GiB, reserved 1 GiB, : FIRMWARE_HEAP */
 #define ROGUE_FW_HEAP_BASE 0xE1C0000000ull
 
@@ -90,7 +90,7 @@
 /* 904 GiB to 912 GiB, size of 8 GiB : FREE */
 
 /* 0xE4_0000_0000 - 0xE7_FFFF_FFFF */
-/* 912 GiB to 968 GiB, size of 16 GiB : TRANSFER_FRAG */
+/* 912 GiB to 928 GiB, size of 16 GiB : TRANSFER_FRAG */
 #define ROGUE_TRANSFER_FRAG_HEAP_BASE 0xE400000000ull
 #define ROGUE_TRANSFER_FRAG_HEAP_SIZE SZ_16G
 

-- 
2.43.0

Re: [PATCH 2/3] drm/imagination: Update Rogue heap comments

[Alessio Belle]

On Mon, 2026-08-03 at 11:22 +0100, Luigi Santivetti wrote:
> From: Alexandru Dadu <alexandru.dadu@imgtec.com>
> 
> Update Rogue heap memory comments to fix typos.
> 
> Signed-off-by: Alexandru Dadu <alexandru.dadu@imgtec.com>
> Signed-off-by: Luigi Santivetti <luigi.santivetti@imgtec.com>

Reviewed-by: Alessio Belle <alessio.belle@imgtec.com>

Thanks,
Alessio

> ---
>  drivers/gpu/drm/imagination/pvr_rogue_heap_config.h | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/imagination/pvr_rogue_heap_config.h b/drivers/gpu/drm/imagination/pvr_rogue_heap_config.h
> index 684766006703..5c33b342dda5 100644
> --- a/drivers/gpu/drm/imagination/pvr_rogue_heap_config.h
> +++ b/drivers/gpu/drm/imagination/pvr_rogue_heap_config.h
> @@ -33,12 +33,12 @@
>  /* 0 MiB to 4 MiB, size of 4 MiB : RESERVED */
>  
>  /* 0x00_0040_0000 - 0x7F_FFC0_0000 **/
> -/* 4 MiB to 512 GiB, size of 512 GiB less 4 MiB : RESERVED **/
> +/* 4 MiB to 512 GiB, size of 512 GiB less 4 MiB : RESERVED */
>  
>  /* 0x80_0000_0000 ************************************************************/
>  
>  /* 0x80_0000_0000 - 0x9F_FFFF_FFFF **/
> -/* 512 GiB to 640 GiB, size of 128 GiB : GENERAL_HEAP **/
> +/* 512 GiB to 640 GiB, size of 128 GiB : GENERAL_HEAP */
>  #define ROGUE_GENERAL_HEAP_BASE 0x8000000000ull
>  #define ROGUE_GENERAL_HEAP_SIZE SZ_128G
>  
> @@ -62,7 +62,7 @@
>  #define ROGUE_PDSCODEDATA_HEAP_SIZE SZ_4G
>  
>  /* 0xDB_0000_0000 - 0xDB_FFFF_FFFF */
> -/* 876 GiB to 880 GiB, size of 256 MiB (reserved 4GiB) : BRN **/
> +/* 876 GiB to 880 GiB, size of 256 MiB (reserved 4GiB) : BRN */
>  /*
>   * The BRN63142 quirk workaround requires Region Header memory to be at the top
>   * of a 16GiB aligned range. This is so when masked with 0x03FFFFFFFF the
> @@ -82,7 +82,7 @@
>  /* 0xE1_0000_0000 - 0xE1_BFFF_FFFF */
>  /* 900 GiB to 903 GiB, size of 3 GiB : RESERVED */
>  
> -/* 0xE1_C000_000 - 0xE1_FFFF_FFFF */
> +/* 0xE1_C000_0000 - 0xE1_FFFF_FFFF */
>  /* 903 GiB to 904 GiB, reserved 1 GiB, : FIRMWARE_HEAP */
>  #define ROGUE_FW_HEAP_BASE 0xE1C0000000ull
>  
> @@ -90,7 +90,7 @@
>  /* 904 GiB to 912 GiB, size of 8 GiB : FREE */
>  
>  /* 0xE4_0000_0000 - 0xE7_FFFF_FFFF */
> -/* 912 GiB to 968 GiB, size of 16 GiB : TRANSFER_FRAG */
> +/* 912 GiB to 928 GiB, size of 16 GiB : TRANSFER_FRAG */
>  #define ROGUE_TRANSFER_FRAG_HEAP_BASE 0xE400000000ull
>  #define ROGUE_TRANSFER_FRAG_HEAP_SIZE SZ_16G
>  
> 

[PATCH 3/3] drm/imagination: Fix repeated typo in KCCB documentation

[Luigi Santivetti]

From: Alessio Belle <alessio.belle@imgtec.com>

Fix sent -> send in the documentation for all variants of
pvr_kccb_send_cmd*().

Signed-off-by: Alessio Belle <alessio.belle@imgtec.com>
Signed-off-by: Luigi Santivetti <luigi.santivetti@imgtec.com>
---
 drivers/gpu/drm/imagination/pvr_ccb.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/imagination/pvr_ccb.c b/drivers/gpu/drm/imagination/pvr_ccb.c
index 4accf18e2341..b702d122d791 100644
--- a/drivers/gpu/drm/imagination/pvr_ccb.c
+++ b/drivers/gpu/drm/imagination/pvr_ccb.c
@@ -255,7 +255,7 @@ pvr_kccb_used_slot_count_locked(struct pvr_device *pvr_dev)
  * pvr_kccb_send_cmd_reserved_powered() - Send command to the KCCB, with the PM ref
  * held and a slot pre-reserved
  * @pvr_dev: Device pointer.
- * @cmd: Command to sent.
+ * @cmd: Command to send.
  * @kccb_slot: Address to store the KCCB slot for this command. May be %NULL.
  */
 void
@@ -361,7 +361,7 @@ static int pvr_kccb_reserve_slot_sync(struct pvr_device *pvr_dev)
 /**
  * pvr_kccb_send_cmd_powered() - Send command to the KCCB, with a PM ref held
  * @pvr_dev: Device pointer.
- * @cmd: Command to sent.
+ * @cmd: Command to send.
  * @kccb_slot: Address to store the KCCB slot for this command. May be %NULL.
  *
  * Returns:
@@ -385,7 +385,7 @@ pvr_kccb_send_cmd_powered(struct pvr_device *pvr_dev, struct rogue_fwif_kccb_cmd
 /**
  * pvr_kccb_send_cmd() - Send command to the KCCB
  * @pvr_dev: Device pointer.
- * @cmd: Command to sent.
+ * @cmd: Command to send.
  * @kccb_slot: Address to store the KCCB slot for this command. May be %NULL.
  *
  * Returns:

-- 
2.43.0