Re: [PATCH 3/7] dt-bindings: misc: Add binding for R-Car DAB

[Sergei Shtylyov <sergei.shtylyov@gmail.com>]

Hello!

On 26.02.2021 1:51, Fabrizio Castro wrote:

> Document bindings for R-Car DAB hardware accelerator, currently
> found on the r8a77990 SoC (a.k.a. R-Car E3) and on the r8a77965
> SoC (a.k.a. R-Car M3-N).
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> ---
>   .../devicetree/bindings/misc/renesas,dab.yaml | 75 +++++++++++++++++++
>   1 file changed, 75 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/misc/renesas,dab.yaml
> 
> diff --git a/Documentation/devicetree/bindings/misc/renesas,dab.yaml b/Documentation/devicetree/bindings/misc/renesas,dab.yaml
> new file mode 100644
> index 000000000000..e9494add13d7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/misc/renesas,dab.yaml
> @@ -0,0 +1,75 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (C) 2021 Renesas Electronics Corporation
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/misc/renesas,dab.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Renesas R-Car DAB Hardware Accelerator
> +
> +maintainers:
> +  - Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> +
> +description:
> +  The DAB hardware accelerator found on some R-Car devices is a hardware
> +  accelerator for software DAB demodulators.
> +  It consists of one FFT (Fast Fourier Transform) module and one decoder module,
> +  compatible with DAB specification (ETSI EN 300 401 and ETSI TS 102 563).
> +  The decoder module can perform FIC decoding and MSC decoding processing from
> +  de-puncture to final decoded result.
> +
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +          - renesas,dab-r8a77965     # R-Car M3-N
> +          - renesas,dab-r8a77990     # R-Car E3

    Why not renesas,<soc>-dab?

> +      - const: renesas,rcar-gen3-dab # Generic fallback for R-Car Gen3 devices
[...]

MBR, Sergei