From: Robin Murphy <robin.murphy@arm.com>
To: Johan Jonker <jbx6244@gmail.com>, heiko@sntech.de
Cc: linux-rockchip@lists.infradead.org, robh+dt@kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: rockchip: rename thermal subnodes for rk3399.dtsi
Date: Mon, 18 Jan 2021 14:20:23 +0000 [thread overview]
Message-ID: <c92467e0-3901-4a1c-3857-6ef055acc381@arm.com> (raw)
In-Reply-To: <20210117150953.16475-3-jbx6244@gmail.com>
On 2021-01-17 15:09, Johan Jonker wrote:
> A test with the command below gives for example this error:
> /arch/arm64/boot/dts/rockchip/rk3399-evb.dt.yaml:
> thermal-zones: 'cpu', 'gpu' do not match any of the regexes:
> '^[a-zA-Z][a-zA-Z0-9\\-]{1,12}-thermal$', 'pinctrl-[0-9]+'
>
> Rename Rockchip rk3399 thermal subnodes so that it ends
> with "-thermal"
>
> make ARCH=arm64 dtbs_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/
> thermal/thermal-zones.yaml
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> ---
> arch/arm64/boot/dts/rockchip/rk3399-rock960.dts | 2 +-
> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts
> index c88295782..b20774081 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts
> @@ -126,7 +126,7 @@
> };
>
> &thermal_zones {
> - cpu_thermal: cpu {
> + cpu_thermal: cpu-thermal {
> polling-delay-passive = <100>;
> polling-delay = <1000>;
> thermal-sensors = <&tsadc 0>;
Passing observation: why is this DT not just referencing &cpu_thermal
directly to add the board-specific parts (and not repeat all the SoC
default properties) anyway? Cleaning the whole thing up might have been
a good idea :/
Robin.
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> index 4e94b7ebd..3de493ad6 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -761,7 +761,7 @@
> };
>
> thermal_zones: thermal-zones {
> - cpu_thermal: cpu {
> + cpu_thermal: cpu-thermal {
> polling-delay-passive = <100>;
> polling-delay = <1000>;
>
> @@ -805,7 +805,7 @@
> };
> };
>
> - gpu_thermal: gpu {
> + gpu_thermal: gpu-thermal {
> polling-delay-passive = <100>;
> polling-delay = <1000>;
>
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Robin Murphy <robin.murphy@arm.com>
To: Johan Jonker <jbx6244@gmail.com>, heiko@sntech.de
Cc: linux-rockchip@lists.infradead.org, robh+dt@kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: rockchip: rename thermal subnodes for rk3399.dtsi
Date: Mon, 18 Jan 2021 14:20:23 +0000 [thread overview]
Message-ID: <c92467e0-3901-4a1c-3857-6ef055acc381@arm.com> (raw)
In-Reply-To: <20210117150953.16475-3-jbx6244@gmail.com>
On 2021-01-17 15:09, Johan Jonker wrote:
> A test with the command below gives for example this error:
> /arch/arm64/boot/dts/rockchip/rk3399-evb.dt.yaml:
> thermal-zones: 'cpu', 'gpu' do not match any of the regexes:
> '^[a-zA-Z][a-zA-Z0-9\\-]{1,12}-thermal$', 'pinctrl-[0-9]+'
>
> Rename Rockchip rk3399 thermal subnodes so that it ends
> with "-thermal"
>
> make ARCH=arm64 dtbs_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/
> thermal/thermal-zones.yaml
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> ---
> arch/arm64/boot/dts/rockchip/rk3399-rock960.dts | 2 +-
> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts
> index c88295782..b20774081 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts
> @@ -126,7 +126,7 @@
> };
>
> &thermal_zones {
> - cpu_thermal: cpu {
> + cpu_thermal: cpu-thermal {
> polling-delay-passive = <100>;
> polling-delay = <1000>;
> thermal-sensors = <&tsadc 0>;
Passing observation: why is this DT not just referencing &cpu_thermal
directly to add the board-specific parts (and not repeat all the SoC
default properties) anyway? Cleaning the whole thing up might have been
a good idea :/
Robin.
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> index 4e94b7ebd..3de493ad6 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -761,7 +761,7 @@
> };
>
> thermal_zones: thermal-zones {
> - cpu_thermal: cpu {
> + cpu_thermal: cpu-thermal {
> polling-delay-passive = <100>;
> polling-delay = <1000>;
>
> @@ -805,7 +805,7 @@
> };
> };
>
> - gpu_thermal: gpu {
> + gpu_thermal: gpu-thermal {
> polling-delay-passive = <100>;
> polling-delay = <1000>;
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Robin Murphy <robin.murphy@arm.com>
To: Johan Jonker <jbx6244@gmail.com>, heiko@sntech.de
Cc: linux-rockchip@lists.infradead.org, robh+dt@kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: rockchip: rename thermal subnodes for rk3399.dtsi
Date: Mon, 18 Jan 2021 14:20:23 +0000 [thread overview]
Message-ID: <c92467e0-3901-4a1c-3857-6ef055acc381@arm.com> (raw)
In-Reply-To: <20210117150953.16475-3-jbx6244@gmail.com>
On 2021-01-17 15:09, Johan Jonker wrote:
> A test with the command below gives for example this error:
> /arch/arm64/boot/dts/rockchip/rk3399-evb.dt.yaml:
> thermal-zones: 'cpu', 'gpu' do not match any of the regexes:
> '^[a-zA-Z][a-zA-Z0-9\\-]{1,12}-thermal$', 'pinctrl-[0-9]+'
>
> Rename Rockchip rk3399 thermal subnodes so that it ends
> with "-thermal"
>
> make ARCH=arm64 dtbs_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/
> thermal/thermal-zones.yaml
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> ---
> arch/arm64/boot/dts/rockchip/rk3399-rock960.dts | 2 +-
> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts
> index c88295782..b20774081 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts
> @@ -126,7 +126,7 @@
> };
>
> &thermal_zones {
> - cpu_thermal: cpu {
> + cpu_thermal: cpu-thermal {
> polling-delay-passive = <100>;
> polling-delay = <1000>;
> thermal-sensors = <&tsadc 0>;
Passing observation: why is this DT not just referencing &cpu_thermal
directly to add the board-specific parts (and not repeat all the SoC
default properties) anyway? Cleaning the whole thing up might have been
a good idea :/
Robin.
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> index 4e94b7ebd..3de493ad6 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -761,7 +761,7 @@
> };
>
> thermal_zones: thermal-zones {
> - cpu_thermal: cpu {
> + cpu_thermal: cpu-thermal {
> polling-delay-passive = <100>;
> polling-delay = <1000>;
>
> @@ -805,7 +805,7 @@
> };
> };
>
> - gpu_thermal: gpu {
> + gpu_thermal: gpu-thermal {
> polling-delay-passive = <100>;
> polling-delay = <1000>;
>
>
next prev parent reply other threads:[~2021-01-18 14:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-17 15:09 [PATCH 1/3] ARM: dts: rockchip: rename thermal subnodes for rk3288.dtsi Johan Jonker
2021-01-17 15:09 ` Johan Jonker
2021-01-17 15:09 ` Johan Jonker
2021-01-17 15:09 ` [PATCH 2/3] arm64: dts: rockchip: rename thermal subnodes for rk3368.dtsi Johan Jonker
2021-01-17 15:09 ` Johan Jonker
2021-01-17 15:09 ` Johan Jonker
2021-01-17 15:09 ` [PATCH 3/3] arm64: dts: rockchip: rename thermal subnodes for rk3399.dtsi Johan Jonker
2021-01-17 15:09 ` Johan Jonker
2021-01-17 15:09 ` Johan Jonker
2021-01-18 14:20 ` Robin Murphy [this message]
2021-01-18 14:20 ` Robin Murphy
2021-01-18 14:20 ` Robin Murphy
2021-01-18 12:57 ` (subset) [PATCH 1/3] ARM: dts: rockchip: rename thermal subnodes for rk3288.dtsi Heiko Stuebner
2021-01-18 12:57 ` Heiko Stuebner
2021-01-18 12:57 ` Heiko Stuebner
2021-01-18 13:01 ` Heiko Stübner
2021-01-18 13:01 ` Heiko Stübner
2021-01-18 13:01 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c92467e0-3901-4a1c-3857-6ef055acc381@arm.com \
--to=robin.murphy@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.