Re: [PATCH mptcp-next v3] selftests: net: mptcp: add checks for fallback counters

[Matthieu Baerts <matttbe@kernel.org>]

Hi Gang,

On 15/08/2025 11:13, GangYan wrote:
>> On Fri, Aug 15, 2025 at 10:24:18AM +0200, Matthieu Baerts wrote:
>> 15 Aug 2025 09:32:11 Gang Yan <yangang@kylinos.cn>:
>>
>>> Recently, some mib counters about fallback has been added, this patch
>>> provides a method to check the expected behavior of these mib counters
>>> during the test execution.
>>>
>>> Link: https://github.com/multipath-tcp/mptcp_net-next/issues/571
>>> Signed-off-by: Gang Yan <yangang@kylinos.cn>

(...)
>>> diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh b/tools/testing/selftests/net/mptcp/mptcp_join.sh
>>> index b8af65373b3a..898779a9af58 100755
>>> --- a/tools/testing/selftests/net/mptcp/mptcp_join.sh
>>> +++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh

(...)

>>> +chk_fallback_nr_all()
>>> +{
>>> +   local netns=("ns1" "ns2")
>>> +   local fb_ns=("fb_ns1" "fb_ns2")
>>> +   local rc=${KSFT_PASS}
>>> +
>>> +   for i in 0 1; do

I forgot to add: 'i' should be declared as 'local' as well.

>>> +       if [ -n "${!fb_ns[i]}" ]; then
>>> +           eval "${!fb_ns[i]}" \
>>> +               chk_fallback_nr ${netns[i]} || rc={?}
>>> +       else
>>> +           chk_fallback_nr ${netns[i]} || rc={?}
> CI has reported some errors in 'rc={?}'

I guess the issue is with ${netns[i]}: is it not enough to add double
quotes around it?

  chk_fallback_nr "${netns[i]}" || rc={?}

or explicitly use the variable $i?

  chk_fallback_nr "${netns[$i]}" || rc={?}

(same above)

>  I'll fix this in the next version

OK, I will wait for the next version.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.