[PATCH mptcp-next] selftests: mptcp: remove unused configs

[PATCH mptcp-next] selftests: mptcp: remove unused configs

[Hangbin Liu]

From: Hangbin Liu <liuhangbin@kylinos.cn>

After converting the mptcp selftests from iptables to nftables,
the xtables-only options are no longer needed.

Signed-off-by: Hangbin Liu <liuhangbin@kylinos.cn>
---
 tools/testing/selftests/net/mptcp/config | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/tools/testing/selftests/net/mptcp/config b/tools/testing/selftests/net/mptcp/config
index 61057a066719..6a96cfbbc461 100644
--- a/tools/testing/selftests/net/mptcp/config
+++ b/tools/testing/selftests/net/mptcp/config
@@ -1,12 +1,7 @@
 CONFIG_INET_DIAG=m
 CONFIG_INET_MPTCP_DIAG=m
-CONFIG_IP6_NF_FILTER=m
-CONFIG_IP6_NF_TARGET_REJECT=m
 CONFIG_IP_ADVANCED_ROUTER=y
 CONFIG_IP_MULTIPLE_TABLES=y
-CONFIG_IP_NF_FILTER=m
-CONFIG_IP_NF_MANGLE=m
-CONFIG_IP_NF_TARGET_REJECT=m
 CONFIG_IPV6=y
 CONFIG_IPV6_MULTIPLE_TABLES=y
 CONFIG_KALLSYMS=y
@@ -19,12 +14,6 @@ CONFIG_NET_CLS_FW=m
 CONFIG_NETFILTER=y
 CONFIG_NETFILTER_ADVANCED=y
 CONFIG_NETFILTER_NETLINK=y
-CONFIG_NETFILTER_XTABLES=m
-CONFIG_NETFILTER_XTABLES_LEGACY=y
-CONFIG_NETFILTER_XT_MATCH_BPF=m
-CONFIG_NETFILTER_XT_MATCH_LENGTH=m
-CONFIG_NETFILTER_XT_MATCH_STATISTIC=m
-CONFIG_NETFILTER_XT_TARGET_MARK=m
 CONFIG_NET_SCH_INGRESS=m
 CONFIG_NET_SCH_NETEM=m
 CONFIG_NF_TABLES=m

---
base-commit: 9651c766735c19e7a6b90d731bab53ef7959def8
change-id: 20261008-mptcp_config-37a6edde4a18

Best regards,
-- 
Hangbin Liu <liuhangbin@kylinos.cn>

Re: [PATCH mptcp-next] selftests: mptcp: remove unused configs

[MPTCP CI]

Hi Hangbin,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal (except selftest_mptcp_join): Success! ✅
- KVM Validation: normal (only selftest_mptcp_join): Success! ✅
- KVM Validation: debug (except selftest_mptcp_join): Success! ✅
- KVM Validation: debug (only selftest_mptcp_join): Success! ✅
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Success! ✅
- Perf: Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/37758614350

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/95c1feb8aa98
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=1181492


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)

Re: [PATCH mptcp-next] selftests: mptcp: remove unused configs

[Matthieu Baerts]

Hi Hangbin,

On 08/10/2026 11:28, Hangbin Liu wrote:
> From: Hangbin Liu <liuhangbin@kylinos.cn>
> 
> After converting the mptcp selftests from iptables to nftables,
> the xtables-only options are no longer needed.
Thank you for the follow-up. Should we squash this into "selftests:
mptcp: convert iptables to nftables for mptcp_join.sh"? This commit
already removes one unused option, plus ip*tables* from mptcp_lib.sh.

WDYT?

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.

Re: [PATCH mptcp-next] selftests: mptcp: remove unused configs

[hangbin.liu]

Hi Matthieu,
October 8, 2026 at 7:48 PM, "Matthieu Baerts" <matttbe@kernel.org> wrote:
> 
> Hi Hangbin,
> 
> On 08/10/2026 11:28, Hangbin Liu wrote:
> 
> > 
> > From: Hangbin Liu <liuhangbin@kylinos.cn>
> >  
> >  After converting the mptcp selftests from iptables to nftables,
> >  the xtables-only options are no longer needed.
> > 
> Thank you for the follow-up. Should we squash this into "selftests:
> mptcp: convert iptables to nftables for mptcp_join.sh"? This commit
> already removes one unused option, plus ip*tables* from mptcp_lib.sh.
> 
> WDYT?

Sure, makes sense to me. Feel free to squash the patch.

Regards
Hangbin

Re: [PATCH mptcp-next] selftests: mptcp: remove unused configs

[Matthieu Baerts]

On 08/10/2026 11:28, Hangbin Liu wrote:
> From: Hangbin Liu <liuhangbin@kylinos.cn>
> 
> After converting the mptcp selftests from iptables to nftables,
> the xtables-only options are no longer needed.

Now in our tree:

New patches for t/upstream:
- b42770a556c1: selftests: mptcp: remove unused configs
- 94a1df161f1a: tg:msg: add notes from the squash-to commit
- Results: b5271fd130ae..4edaecd07abe (export)

Tests are now in progress:

- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/5ac58fb7c561392ec051c390479ca746c42ca989/checks

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.