All of lore.kernel.org
 help / color / mirror / Atom feed
From: Karthikeyan Periyasamy <periyasa@codeaurora.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org,
	Kalle Valo <kvalo@codeaurora.org>
Subject: Re: [RFC 2/2] ath10k: Add QCA vendor command/attr support to filterneighbor BSS frames
Date: Tue, 20 Nov 2018 08:10:00 +0530	[thread overview]
Message-ID: <c9b16303e344b2dcd4d52cf9c0830846@codeaurora.org> (raw)
In-Reply-To: <a28348956ba3fbfded80bc78ba1c0335df7edb75.camel@sipsolutions.net>

On 2018-10-18 13:59, Johannes Berg wrote:

>> So I'm not sure what to do with this. A bpf type of filtering system 
>> in
>> mac80211 would be nice
> 
> Yes, I think we really need to start implementing that sooner rather
> than later. I had something, must see if I can find time for it.
> 
>> but then again we cannot benefit from HW offloading.
> 
> Yes, that's a concern. But how big of a concern is it really?
> 
> This patch only talks about "allow an AP" etc. and so while important,
> power isn't the _utmost_ concern like on mobile. Given an efficient
> filtering solution in software, would that be sufficient?

Assume in a scenario where there are multiple APs (One Center AP and 
Multiple repeater AP) in same operating channel.
Clients present in Neighbor APs causing higher traffic.

when we try to filter desire client packets,
In HW offload case, all Neighbor BSS packets are filtered by HW. so 
there is no impact in CPU load. AP performance not get impacted.
In bpf (enabling monitor mode) case, all Neighbor BSS packets get 
filtered by software. It will consume CPU load which will impact AP 
performance.

Irrespective of how many neighbor APs present in the topology, HW 
offload take care of neighbor BSS filtering. Hence no impact in CPU 
load.
so we decided to use HW offload. To use our HW offload feature, we ended 
up in vendor command approach.

Karthikeyan

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Karthikeyan Periyasamy <periyasa@codeaurora.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Kalle Valo <kvalo@codeaurora.org>,
	ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [RFC 2/2] ath10k: Add QCA vendor command/attr support to filterneighbor BSS frames
Date: Tue, 20 Nov 2018 08:10:00 +0530	[thread overview]
Message-ID: <c9b16303e344b2dcd4d52cf9c0830846@codeaurora.org> (raw)
In-Reply-To: <a28348956ba3fbfded80bc78ba1c0335df7edb75.camel@sipsolutions.net>

On 2018-10-18 13:59, Johannes Berg wrote:

>> So I'm not sure what to do with this. A bpf type of filtering system 
>> in
>> mac80211 would be nice
> 
> Yes, I think we really need to start implementing that sooner rather
> than later. I had something, must see if I can find time for it.
> 
>> but then again we cannot benefit from HW offloading.
> 
> Yes, that's a concern. But how big of a concern is it really?
> 
> This patch only talks about "allow an AP" etc. and so while important,
> power isn't the _utmost_ concern like on mobile. Given an efficient
> filtering solution in software, would that be sufficient?

Assume in a scenario where there are multiple APs (One Center AP and 
Multiple repeater AP) in same operating channel.
Clients present in Neighbor APs causing higher traffic.

when we try to filter desire client packets,
In HW offload case, all Neighbor BSS packets are filtered by HW. so 
there is no impact in CPU load. AP performance not get impacted.
In bpf (enabling monitor mode) case, all Neighbor BSS packets get 
filtered by software. It will consume CPU load which will impact AP 
performance.

Irrespective of how many neighbor APs present in the topology, HW 
offload take care of neighbor BSS filtering. Hence no impact in CPU 
load.
so we decided to use HW offload. To use our HW offload feature, we ended 
up in vendor command approach.

Karthikeyan

  reply	other threads:[~2018-11-20  2:40 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-05 11:51 [RFC 0/2] ath10k: Add QCA vendor command/attr support to filter neighbor BSS frames Karthikeyan Periyasamy
2018-07-05 11:51 ` Karthikeyan Periyasamy
2018-07-05 11:51 ` [RFC 1/2] ath10k: add wmi interface for vdev_set_neighbor_rx_param Karthikeyan Periyasamy
2018-07-05 11:51   ` Karthikeyan Periyasamy
2018-07-05 11:51 ` [RFC 2/2] ath10k: Add QCA vendor command/attr support to filter neighbor BSS frames Karthikeyan Periyasamy
2018-07-05 11:51   ` Karthikeyan Periyasamy
2018-10-05  6:00   ` [RFC 2/2] ath10k: Add QCA vendor command/attr support to filterneighbor " Kalle Valo
2018-10-05  6:00   ` Kalle Valo
     [not found]   ` <20181005060031.BA1EB60BF4@smtp.codeaurora.org>
2018-10-18  8:29     ` Johannes Berg
2018-10-18  8:29       ` Johannes Berg
2018-11-20  2:40       ` Karthikeyan Periyasamy [this message]
2018-11-20  2:40         ` Karthikeyan Periyasamy
2019-01-25 20:49         ` Johannes Berg
2019-01-25 20:49           ` Johannes Berg
2019-01-28  4:49           ` Karthikeyan Periyasamy
2019-01-28  4:49             ` Karthikeyan Periyasamy
2019-02-15 12:37             ` Johannes Berg
2019-02-15 12:37               ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c9b16303e344b2dcd4d52cf9c0830846@codeaurora.org \
    --to=periyasa@codeaurora.org \
    --cc=ath10k@lists.infradead.org \
    --cc=johannes@sipsolutions.net \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.