* [PATCH -next] irqchip/mbigen: fix compile warning when CONFIG_ACPI is disabled
@ 2021-05-19 5:04 Yang Yingliang
2021-05-19 7:49 ` Marc Zyngier
2021-06-06 13:07 ` [irqchip: irq/irqchip-next] irqchip/mbigen: Fix " irqchip-bot for Yang Yingliang
0 siblings, 2 replies; 4+ messages in thread
From: Yang Yingliang @ 2021-05-19 5:04 UTC (permalink / raw)
To: linux-kernel; +Cc: tglx, maz
Fix the following compile warning:
drivers/irqchip/irq-mbigen.c:372:36: warning: ‘mbigen_acpi_match’ defined but not used [-Wunused-const-variable=]
static const struct acpi_device_id mbigen_acpi_match[] = {
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/irqchip/irq-mbigen.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/irqchip/irq-mbigen.c b/drivers/irqchip/irq-mbigen.c
index 2cb45c6b8501..f565317a3da3 100644
--- a/drivers/irqchip/irq-mbigen.c
+++ b/drivers/irqchip/irq-mbigen.c
@@ -273,6 +273,12 @@ static int mbigen_of_create_domain(struct platform_device *pdev,
}
#ifdef CONFIG_ACPI
+static const struct acpi_device_id mbigen_acpi_match[] = {
+ { "HISI0152", 0 },
+ {}
+};
+MODULE_DEVICE_TABLE(acpi, mbigen_acpi_match);
+
static int mbigen_acpi_create_domain(struct platform_device *pdev,
struct mbigen_device *mgn_chip)
{
@@ -369,12 +375,6 @@ static const struct of_device_id mbigen_of_match[] = {
};
MODULE_DEVICE_TABLE(of, mbigen_of_match);
-static const struct acpi_device_id mbigen_acpi_match[] = {
- { "HISI0152", 0 },
- {}
-};
-MODULE_DEVICE_TABLE(acpi, mbigen_acpi_match);
-
static struct platform_driver mbigen_platform_driver = {
.driver = {
.name = "Hisilicon MBIGEN-V2",
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] irqchip/mbigen: fix compile warning when CONFIG_ACPI is disabled
2021-05-19 5:04 [PATCH -next] irqchip/mbigen: fix compile warning when CONFIG_ACPI is disabled Yang Yingliang
@ 2021-05-19 7:49 ` Marc Zyngier
2021-05-19 9:00 ` Yang Yingliang
2021-06-06 13:07 ` [irqchip: irq/irqchip-next] irqchip/mbigen: Fix " irqchip-bot for Yang Yingliang
1 sibling, 1 reply; 4+ messages in thread
From: Marc Zyngier @ 2021-05-19 7:49 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-kernel, tglx
On 2021-05-19 06:04, Yang Yingliang wrote:
> Fix the following compile warning:
>
> drivers/irqchip/irq-mbigen.c:372:36: warning: ‘mbigen_acpi_match’
> defined but not used [-Wunused-const-variable=]
> static const struct acpi_device_id mbigen_acpi_match[] = {
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/irqchip/irq-mbigen.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/irqchip/irq-mbigen.c
> b/drivers/irqchip/irq-mbigen.c
> index 2cb45c6b8501..f565317a3da3 100644
> --- a/drivers/irqchip/irq-mbigen.c
> +++ b/drivers/irqchip/irq-mbigen.c
> @@ -273,6 +273,12 @@ static int mbigen_of_create_domain(struct
> platform_device *pdev,
> }
>
> #ifdef CONFIG_ACPI
> +static const struct acpi_device_id mbigen_acpi_match[] = {
> + { "HISI0152", 0 },
> + {}
> +};
> +MODULE_DEVICE_TABLE(acpi, mbigen_acpi_match);
> +
> static int mbigen_acpi_create_domain(struct platform_device *pdev,
> struct mbigen_device *mgn_chip)
> {
> @@ -369,12 +375,6 @@ static const struct of_device_id mbigen_of_match[]
> = {
> };
> MODULE_DEVICE_TABLE(of, mbigen_of_match);
>
> -static const struct acpi_device_id mbigen_acpi_match[] = {
> - { "HISI0152", 0 },
> - {}
> -};
> -MODULE_DEVICE_TABLE(acpi, mbigen_acpi_match);
> -
> static struct platform_driver mbigen_platform_driver = {
> .driver = {
> .name = "Hisilicon MBIGEN-V2",
Is it actually a thing to have mbigen without ACPI? As far as I can
tell, all the mbigen-equipped machines in existence use ACPI.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] irqchip/mbigen: fix compile warning when CONFIG_ACPI is disabled
2021-05-19 7:49 ` Marc Zyngier
@ 2021-05-19 9:00 ` Yang Yingliang
0 siblings, 0 replies; 4+ messages in thread
From: Yang Yingliang @ 2021-05-19 9:00 UTC (permalink / raw)
To: Marc Zyngier; +Cc: linux-kernel, tglx
On 2021/5/19 15:49, Marc Zyngier wrote:
> On 2021-05-19 06:04, Yang Yingliang wrote:
>> Fix the following compile warning:
>>
>> drivers/irqchip/irq-mbigen.c:372:36: warning: ‘mbigen_acpi_match’
>> defined but not used [-Wunused-const-variable=]
>> static const struct acpi_device_id mbigen_acpi_match[] = {
>>
>> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
>> ---
>> drivers/irqchip/irq-mbigen.c | 12 ++++++------
>> 1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/irqchip/irq-mbigen.c b/drivers/irqchip/irq-mbigen.c
>> index 2cb45c6b8501..f565317a3da3 100644
>> --- a/drivers/irqchip/irq-mbigen.c
>> +++ b/drivers/irqchip/irq-mbigen.c
>> @@ -273,6 +273,12 @@ static int mbigen_of_create_domain(struct
>> platform_device *pdev,
>> }
>>
>> #ifdef CONFIG_ACPI
>> +static const struct acpi_device_id mbigen_acpi_match[] = {
>> + { "HISI0152", 0 },
>> + {}
>> +};
>> +MODULE_DEVICE_TABLE(acpi, mbigen_acpi_match);
>> +
>> static int mbigen_acpi_create_domain(struct platform_device *pdev,
>> struct mbigen_device *mgn_chip)
>> {
>> @@ -369,12 +375,6 @@ static const struct of_device_id
>> mbigen_of_match[] = {
>> };
>> MODULE_DEVICE_TABLE(of, mbigen_of_match);
>>
>> -static const struct acpi_device_id mbigen_acpi_match[] = {
>> - { "HISI0152", 0 },
>> - {}
>> -};
>> -MODULE_DEVICE_TABLE(acpi, mbigen_acpi_match);
>> -
>> static struct platform_driver mbigen_platform_driver = {
>> .driver = {
>> .name = "Hisilicon MBIGEN-V2",
>
> Is it actually a thing to have mbigen without ACPI? As far as I can
> tell, all the mbigen-equipped machines in existence use ACPI.
We also use mbigen on embedded board that uses device tree,
and mbigen driver already support device tree mode.
Thanks,
Yang
>
> Thanks,
>
> M.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [irqchip: irq/irqchip-next] irqchip/mbigen: Fix compile warning when CONFIG_ACPI is disabled
2021-05-19 5:04 [PATCH -next] irqchip/mbigen: fix compile warning when CONFIG_ACPI is disabled Yang Yingliang
2021-05-19 7:49 ` Marc Zyngier
@ 2021-06-06 13:07 ` irqchip-bot for Yang Yingliang
1 sibling, 0 replies; 4+ messages in thread
From: irqchip-bot for Yang Yingliang @ 2021-06-06 13:07 UTC (permalink / raw)
To: linux-kernel; +Cc: Yang Yingliang, Marc Zyngier, tglx
The following commit has been merged into the irq/irqchip-next branch of irqchip:
Commit-ID: c96d6abbec52d6723bef6b50846f40f7fb27e93c
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/c96d6abbec52d6723bef6b50846f40f7fb27e93c
Author: Yang Yingliang <yangyingliang@huawei.com>
AuthorDate: Wed, 19 May 2021 13:04:55 +08:00
Committer: Marc Zyngier <maz@kernel.org>
CommitterDate: Sun, 06 Jun 2021 13:59:09 +01:00
irqchip/mbigen: Fix compile warning when CONFIG_ACPI is disabled
Fix the following compile warning:
drivers/irqchip/irq-mbigen.c:372:36: warning: ‘mbigen_acpi_match’ defined but not used [-Wunused-const-variable=]
static const struct acpi_device_id mbigen_acpi_match[] = {
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20210519050455.1693953-1-yangyingliang@huawei.com
---
drivers/irqchip/irq-mbigen.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/irqchip/irq-mbigen.c b/drivers/irqchip/irq-mbigen.c
index 2cb45c6..f565317 100644
--- a/drivers/irqchip/irq-mbigen.c
+++ b/drivers/irqchip/irq-mbigen.c
@@ -273,6 +273,12 @@ static int mbigen_of_create_domain(struct platform_device *pdev,
}
#ifdef CONFIG_ACPI
+static const struct acpi_device_id mbigen_acpi_match[] = {
+ { "HISI0152", 0 },
+ {}
+};
+MODULE_DEVICE_TABLE(acpi, mbigen_acpi_match);
+
static int mbigen_acpi_create_domain(struct platform_device *pdev,
struct mbigen_device *mgn_chip)
{
@@ -369,12 +375,6 @@ static const struct of_device_id mbigen_of_match[] = {
};
MODULE_DEVICE_TABLE(of, mbigen_of_match);
-static const struct acpi_device_id mbigen_acpi_match[] = {
- { "HISI0152", 0 },
- {}
-};
-MODULE_DEVICE_TABLE(acpi, mbigen_acpi_match);
-
static struct platform_driver mbigen_platform_driver = {
.driver = {
.name = "Hisilicon MBIGEN-V2",
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-06 13:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-05-19 5:04 [PATCH -next] irqchip/mbigen: fix compile warning when CONFIG_ACPI is disabled Yang Yingliang
2021-05-19 7:49 ` Marc Zyngier
2021-05-19 9:00 ` Yang Yingliang
2021-06-06 13:07 ` [irqchip: irq/irqchip-next] irqchip/mbigen: Fix " irqchip-bot for Yang Yingliang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.