From: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
To: Joel Stanley <joel@jms.id.au>
Cc: Ryan Chen <ryan_chen@aspeedtech.com>,
Andrew Jeffery <andrew@aj.id.au>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Brendan Higgins <brendanhiggins@google.com>,
Tao Ren <taoren@fb.com>
Subject: Re: [PATCH dev-5.2 0/2] i2c: aspeed: Add H/W timeout support
Date: Wed, 4 Sep 2019 16:01:30 -0700 [thread overview]
Message-ID: <ca423521-05a5-1fcd-27f1-bb5f68fa3c23@linux.intel.com> (raw)
In-Reply-To: <CACPK8Xfzn3A7nCFqCbSm=6qsB-5dgJOcz1rgSGhRH=xojb4m_w@mail.gmail.com>
Hi Joel,
On 9/4/2019 3:54 PM, Joel Stanley wrote:
> Hi Jae,
>
> On Wed, 4 Sep 2019 at 20:08, Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com> wrote:
>>
>> In case of multi-master environment, if a peer master incorrectly handles
>> a bus in the middle of a transaction, I2C hardware hangs in slave state
>> and it can't escape from the slave state, so this commit adds slave
>> inactive timeout support to recover the bus in the case.
>>
>> By applying this change, SDA data-low and SCL clock-low timeout feature
>> also could be enabled which was disabled previously.
>
> Please consider sending your RFC patches to the upstream list. You
> have a big backlog of patches now.
Thanks for the reminding. I can't send the RFC patches yet because QEMU
H/W model isn't ready yet. I'm still waiting for the fix from Cedric.
Thanks,
Jae
>
> Cheers,
>
> Joel
>
>>
>> Jae Hyun Yoo (2):
>> dt-bindings: i2c: aspeed: add hardware timeout support
>> i2c: aspeed: add slave inactive timeout support
>>
>> .../devicetree/bindings/i2c/i2c-aspeed.txt | 2 +
>> drivers/i2c/busses/i2c-aspeed.c | 79 +++++++++++++++++--
>> 2 files changed, 75 insertions(+), 6 deletions(-)
>>
>> --
>> 2.23.0
>>
next prev parent reply other threads:[~2019-09-04 23:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 20:07 [PATCH dev-5.2 0/2] i2c: aspeed: Add H/W timeout support Jae Hyun Yoo
2019-09-04 20:07 ` [PATCH dev-5.2 1/2] dt-bindings: i2c: aspeed: add hardware " Jae Hyun Yoo
2019-09-04 20:07 ` [PATCH dev-5.2 2/2] i2c: aspeed: add slave inactive " Jae Hyun Yoo
2019-09-04 22:37 ` Tao Ren
2019-09-05 22:28 ` Tao Ren
2019-09-05 22:48 ` Jae Hyun Yoo
2019-09-05 23:19 ` Tao Ren
2019-09-05 23:35 ` Jae Hyun Yoo
2019-09-06 1:16 ` Tao Ren
2019-09-06 1:56 ` [Potential Spoof] " Tao Ren
2019-09-06 2:35 ` Tao Ren
2019-09-06 16:20 ` Jae Hyun Yoo
2019-09-04 22:54 ` [PATCH dev-5.2 0/2] i2c: aspeed: Add H/W " Joel Stanley
2019-09-04 23:01 ` Jae Hyun Yoo [this message]
2019-09-04 23:12 ` Andrew Jeffery
2019-09-04 23:40 ` Jae Hyun Yoo
2019-09-05 0:10 ` Andrew Jeffery
2019-09-05 0:54 ` Jae Hyun Yoo
2019-09-11 18:56 ` Jae Hyun Yoo
2019-09-12 1:22 ` Andrew Jeffery
2019-09-12 1:26 ` Jae Hyun Yoo
2019-09-04 23:50 ` Brendan Higgins
2019-09-05 0:56 ` Jae Hyun Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca423521-05a5-1fcd-27f1-bb5f68fa3c23@linux.intel.com \
--to=jae.hyun.yoo@linux.intel.com \
--cc=andrew@aj.id.au \
--cc=brendanhiggins@google.com \
--cc=joel@jms.id.au \
--cc=openbmc@lists.ozlabs.org \
--cc=ryan_chen@aspeedtech.com \
--cc=taoren@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.