Re: [PATCH v2 3/8] dt-bindings: marvell: a38x: add solidrun armada 388 clearfog boards

From: Josua Mayer <josua@solid-run.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Gregory Clement <gregory.clement@bootlin.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH v2 3/8] dt-bindings: marvell: a38x: add solidrun armada 388 clearfog boards
Date: Sun, 24 Dec 2023 16:02:00 +0000	[thread overview]
Message-ID: <cadd49fe-8910-4c41-a1de-6efde20d001a@solid-run.com> (raw)
In-Reply-To: <d5698668-e589-4ce0-a66f-3b6f107aa257@kernel.org>

Am 24.12.23 um 15:55 schrieb Krzysztof Kozlowski:
> On 24/12/2023 15:38, Josua Mayer wrote:
>> Add DT compatible for SolidRun Armada-388 based Clearfog Base and Pro
>> boards.
>>
>> While they are just two variants, we have 3 device-tree:
>> - armada-388-clearfog.dts
>> - armada-388-clearfog-base.dts
>> - armada-388-clearfog-pro.dts
>>
>> While the first one is identical to the pro variant, the filename is
>> not, and neither are the compatible strings.
>>
>> The first is compatible to armada-380, 385, 388 and
>> solidrun,clearfog-a1.
>> The other two are compatible to the same, plus an additional string
>> including the pro/base as suffix.
>>
>> Add two bindings, one for the explicit pro and base variants using a
>> total of 5 compatibles, and one for the generic name using just 4.
>>
>> Signed-off-by: Josua Mayer <josua@solid-run.com>
>> ---
>>   .../bindings/arm/marvell/armada-38x.yaml      | 20 +++++++++++++++++++
>>   1 file changed, 20 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml
>> index 5bc69c4fe34d..25c29b466094 100644
>> --- a/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml
>> +++ b/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml
>> @@ -38,4 +38,24 @@ properties:
>>             - const: marvell,armada385
>>             - const: marvell,armada380
>>   
>> +      - description: |
>> +          SolidRun Armada 388 SoM based clearfog board. This is
>> +          equivalent to clearfog pro, but lacks the "pro" label
>> +          in dtb filename and compatible strings.
>> +        items:
>> +          - const: solidrun,clearfog-a1
> SoM cannot be alone.

Please confirm, I think my wording above was not clear.

I meant to say "clearfog" devices based on a SoM,.
Armada 388 Clearfog Base / Pro are combinations of SoM and carrier.
Current device-trees do not mention a som-specific compatible string though.

This is in contrast to "Clearfog GTR" which
a) uses aramda-385
b) solders SoC to the board.

>
>> +          - const: marvell,armada388
>> +          - const: marvell,armada385
>> +          - const: marvell,armada380
>> +
>> +      - description: SolidRun Armada 388 SoM based clearfog board variants
>> +        items:
>> +          - enum:
>> +             - solidrun,clearfog-base-a1
> Board has name "base"?
Yes.
In marketing and in device-tree model field the board names are
Clearfog Base, Clearfog Pro
and historically just Clearfog, for the Pro.
>
> Still not tested...
>
> Best regards,
> Krzysztof
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel