All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Josua Mayer <josua@solid-run.com>, linux-arm-kernel@lists.infradead.org
Cc: Andrew Lunn <andrew@lunn.ch>,
	Gregory Clement <gregory.clement@bootlin.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH v2 3/8] dt-bindings: marvell: a38x: add solidrun armada 388 clearfog boards
Date: Sun, 24 Dec 2023 15:55:26 +0100	[thread overview]
Message-ID: <d5698668-e589-4ce0-a66f-3b6f107aa257@kernel.org> (raw)
In-Reply-To: <20231224143850.5671-4-josua@solid-run.com>

On 24/12/2023 15:38, Josua Mayer wrote:
> Add DT compatible for SolidRun Armada-388 based Clearfog Base and Pro
> boards.
> 
> While they are just two variants, we have 3 device-tree:
> - armada-388-clearfog.dts
> - armada-388-clearfog-base.dts
> - armada-388-clearfog-pro.dts
> 
> While the first one is identical to the pro variant, the filename is
> not, and neither are the compatible strings.
> 
> The first is compatible to armada-380, 385, 388 and
> solidrun,clearfog-a1.
> The other two are compatible to the same, plus an additional string
> including the pro/base as suffix.
> 
> Add two bindings, one for the explicit pro and base variants using a
> total of 5 compatibles, and one for the generic name using just 4.
> 
> Signed-off-by: Josua Mayer <josua@solid-run.com>
> ---
>  .../bindings/arm/marvell/armada-38x.yaml      | 20 +++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml
> index 5bc69c4fe34d..25c29b466094 100644
> --- a/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml
> +++ b/Documentation/devicetree/bindings/arm/marvell/armada-38x.yaml
> @@ -38,4 +38,24 @@ properties:
>            - const: marvell,armada385
>            - const: marvell,armada380
>  
> +      - description: |
> +          SolidRun Armada 388 SoM based clearfog board. This is
> +          equivalent to clearfog pro, but lacks the "pro" label
> +          in dtb filename and compatible strings.
> +        items:
> +          - const: solidrun,clearfog-a1

SoM cannot be alone.

> +          - const: marvell,armada388
> +          - const: marvell,armada385
> +          - const: marvell,armada380
> +
> +      - description: SolidRun Armada 388 SoM based clearfog board variants
> +        items:
> +          - enum:
> +             - solidrun,clearfog-base-a1

Board has name "base"?

Still not tested...

Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2023-12-24 14:55 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-24 14:38 [PATCH v2 2/8] dt-bindings: marvell: a38x: add solidrun armada 385 clearfog gtr boards Josua Mayer
2023-12-24 14:38 ` [PATCH v2 3/8] dt-bindings: marvell: a38x: add solidrun armada 388 clearfog boards Josua Mayer
2023-12-24 14:42   ` Conor Dooley
     [not found]     ` <655855b6-ff68-4a3c-9ec7-fc72967b702a@solid-run.com>
2023-12-26 12:10       ` Conor Dooley
2023-12-26 16:39         ` Josua Mayer
2023-12-24 14:55   ` Krzysztof Kozlowski [this message]
2023-12-24 16:02     ` Josua Mayer
2023-12-24 16:09       ` Krzysztof Kozlowski
2023-12-24 16:29         ` Josua Mayer
2023-12-25  9:24           ` Krzysztof Kozlowski
2023-12-24 14:38 ` [PATCH v2 4/8] arm: dts: marvell: clearfog-gtr: add board-specific compatible strings Josua Mayer
2023-12-24 14:38 ` [PATCH v2 5/8] arm: dts: marvell: clearfog-gtr: sort pinctrl nodes alphabetically Josua Mayer
2023-12-24 14:38 ` [PATCH v2 6/8] arm: dts: marvell: clearfog-gtr: add missing pinctrl for all used gpios Josua Mayer
2023-12-24 14:38 ` [PATCH v2 7/8] arm: dts: marvell: clearfog-gtr-l8: add support for second sfp connector Josua Mayer
2023-12-24 14:38 ` [PATCH v2 8/8] arm: dts: marvell: clearfog-gtr-l8: align port numbers with enclosure Josua Mayer
2023-12-24 14:54 ` [PATCH v2 2/8] dt-bindings: marvell: a38x: add solidrun armada 385 clearfog gtr boards Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d5698668-e589-4ce0-a66f-3b6f107aa257@kernel.org \
    --to=krzk@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=gregory.clement@bootlin.com \
    --cc=josua@solid-run.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.