From: Sathyanarayanan Kuppuswamy <sathyanarayanan.kuppuswamy@linux.intel.com>
To: Zhuo Chen <chenzhuo.1@bytedance.com>,
bhelgaas@google.com, ruscur@russell.cc, oohall@gmail.com,
fancer.lancer@gmail.com, jdmason@kudzu.us, dave.jiang@intel.com,
allenbh@gmail.com, james.smart@broadcom.com,
dick.kennedy@broadcom.com, jejb@linux.ibm.com,
martin.petersen@oracle.com
Cc: linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, ntb@lists.linux.dev,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH v2 2/9] PCI/DPC: Use pci_aer_clear_uncorrect_error_status() to clear uncorrectable error status
Date: Tue, 27 Sep 2022 12:34:52 -0700 [thread overview]
Message-ID: <caf2949a-e98d-e0a2-dc8a-af632d9b610a@linux.intel.com> (raw)
In-Reply-To: <20220927153524.49172-3-chenzhuo.1@bytedance.com>
Hi,
On 9/27/22 8:35 AM, Zhuo Chen wrote:
> Use pci_aer_clear_nonfatal_status() in dpc_process_error(), which has
> no functional changes.
Just say pci_aer_clear_uncorrect_error_status() clears both fatal and
non-fatal errors. So use it in place of pci_aer_clear_nonfatal_status()
and pci_aer_clear_fatal_status().
>
> Signed-off-by: Zhuo Chen <chenzhuo.1@bytedance.com>
> ---
> drivers/pci/pcie/dpc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/pci/pcie/dpc.c b/drivers/pci/pcie/dpc.c
> index 3e9afee02e8d..7942073fbb34 100644
> --- a/drivers/pci/pcie/dpc.c
> +++ b/drivers/pci/pcie/dpc.c
> @@ -288,8 +288,7 @@ void dpc_process_error(struct pci_dev *pdev)
> dpc_get_aer_uncorrect_severity(pdev, &info) &&
> aer_get_device_error_info(pdev, &info)) {
> aer_print_error(pdev, &info);
> - pci_aer_clear_nonfatal_status(pdev);
> - pci_aer_clear_fatal_status(pdev);
> + pci_aer_clear_uncorrect_error_status(pdev);
> }
> }
>
--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer
WARNING: multiple messages have this Message-ID (diff)
From: Sathyanarayanan Kuppuswamy <sathyanarayanan.kuppuswamy@linux.intel.com>
To: Zhuo Chen <chenzhuo.1@bytedance.com>,
bhelgaas@google.com, ruscur@russell.cc, oohall@gmail.com,
fancer.lancer@gmail.com, jdmason@kudzu.us, dave.jiang@intel.com,
allenbh@gmail.com, james.smart@broadcom.com,
dick.kennedy@broadcom.com, jejb@linux.ibm.com,
martin.petersen@oracle.com
Cc: linux-pci@vger.kernel.org, ntb@lists.linux.dev,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH v2 2/9] PCI/DPC: Use pci_aer_clear_uncorrect_error_status() to clear uncorrectable error status
Date: Tue, 27 Sep 2022 12:34:52 -0700 [thread overview]
Message-ID: <caf2949a-e98d-e0a2-dc8a-af632d9b610a@linux.intel.com> (raw)
In-Reply-To: <20220927153524.49172-3-chenzhuo.1@bytedance.com>
Hi,
On 9/27/22 8:35 AM, Zhuo Chen wrote:
> Use pci_aer_clear_nonfatal_status() in dpc_process_error(), which has
> no functional changes.
Just say pci_aer_clear_uncorrect_error_status() clears both fatal and
non-fatal errors. So use it in place of pci_aer_clear_nonfatal_status()
and pci_aer_clear_fatal_status().
>
> Signed-off-by: Zhuo Chen <chenzhuo.1@bytedance.com>
> ---
> drivers/pci/pcie/dpc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/pci/pcie/dpc.c b/drivers/pci/pcie/dpc.c
> index 3e9afee02e8d..7942073fbb34 100644
> --- a/drivers/pci/pcie/dpc.c
> +++ b/drivers/pci/pcie/dpc.c
> @@ -288,8 +288,7 @@ void dpc_process_error(struct pci_dev *pdev)
> dpc_get_aer_uncorrect_severity(pdev, &info) &&
> aer_get_device_error_info(pdev, &info)) {
> aer_print_error(pdev, &info);
> - pci_aer_clear_nonfatal_status(pdev);
> - pci_aer_clear_fatal_status(pdev);
> + pci_aer_clear_uncorrect_error_status(pdev);
> }
> }
>
--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer
next prev parent reply other threads:[~2022-09-27 19:34 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 15:35 [PATCH v2 0/9] PCI/AER: Fix and optimize usage of status clearing api Zhuo Chen
2022-09-27 15:35 ` Zhuo Chen
2022-09-27 15:35 ` [PATCH v2 1/9] PCI/AER: Add pci_aer_clear_uncorrect_error_status() to PCI core Zhuo Chen
2022-09-27 15:35 ` Zhuo Chen
2022-09-27 19:31 ` Sathyanarayanan Kuppuswamy
2022-09-27 19:31 ` Sathyanarayanan Kuppuswamy
2022-09-28 8:32 ` Zhuo Chen
2022-09-28 8:32 ` Zhuo Chen
2022-09-27 15:35 ` [PATCH v2 2/9] PCI/DPC: Use pci_aer_clear_uncorrect_error_status() to clear uncorrectable error status Zhuo Chen
2022-09-27 15:35 ` Zhuo Chen
2022-09-27 19:34 ` Sathyanarayanan Kuppuswamy [this message]
2022-09-27 19:34 ` Sathyanarayanan Kuppuswamy
2022-09-27 15:35 ` [PATCH v2 3/9] NTB: Change to use pci_aer_clear_uncorrect_error_status() Zhuo Chen
2022-09-27 15:35 ` Zhuo Chen
2022-09-27 19:39 ` Sathyanarayanan Kuppuswamy
2022-09-27 19:39 ` Sathyanarayanan Kuppuswamy
2022-09-28 4:20 ` [External] " Zhuo Chen
2022-09-28 4:20 ` Zhuo Chen
2022-09-28 4:30 ` Sathyanarayanan Kuppuswamy
2022-09-28 4:30 ` Sathyanarayanan Kuppuswamy
2022-09-28 11:00 ` Serge Semin
2022-09-28 11:00 ` Serge Semin
2022-09-27 15:35 ` [PATCH v2 4/9] scsi: lpfc: " Zhuo Chen
2022-09-27 15:35 ` Zhuo Chen
2022-09-27 19:57 ` Sathyanarayanan Kuppuswamy
2022-09-27 19:57 ` Sathyanarayanan Kuppuswamy
2022-09-27 15:35 ` [PATCH v2 5/9] PCI/AER: Unexport pci_aer_clear_nonfatal_status() Zhuo Chen
2022-09-27 15:35 ` Zhuo Chen
2022-09-27 19:59 ` Sathyanarayanan Kuppuswamy
2022-09-27 19:59 ` Sathyanarayanan Kuppuswamy
2022-09-27 15:35 ` [PATCH v2 6/9] PCI/AER: Move check inside pcie_clear_device_status() Zhuo Chen
2022-09-27 15:35 ` Zhuo Chen
2022-09-27 15:35 ` [PATCH v2 7/9] PCI/AER: Use pcie_aer_is_native() to judge whether OS owns AER Zhuo Chen
2022-09-27 15:35 ` Zhuo Chen
2022-09-27 15:35 ` [PATCH v2 8/9] PCI/ERR: Clear fatal status when pci_channel_io_frozen Zhuo Chen
2022-09-27 15:35 ` Zhuo Chen
2022-09-27 15:35 ` [PATCH v2 9/9] PCI/AER: Refine status clearing process with api Zhuo Chen
2022-09-27 15:35 ` Zhuo Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=caf2949a-e98d-e0a2-dc8a-af632d9b610a@linux.intel.com \
--to=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=allenbh@gmail.com \
--cc=bhelgaas@google.com \
--cc=chenzhuo.1@bytedance.com \
--cc=dave.jiang@intel.com \
--cc=dick.kennedy@broadcom.com \
--cc=fancer.lancer@gmail.com \
--cc=james.smart@broadcom.com \
--cc=jdmason@kudzu.us \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=martin.petersen@oracle.com \
--cc=ntb@lists.linux.dev \
--cc=oohall@gmail.com \
--cc=ruscur@russell.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.