[PATCH] glib-2.0: Re-add the gettext depend

[PATCH] glib-2.0: Re-add the gettext depend

[Alistair Francis]

Commit "glib-2.0: rationalise build dependencies"
(8b0ca0cb54c91611213556bdb99316d5e7ac5b3b) broke mingw glib builds with
the following error:

This patch fixes the issue by re-adding the gettext dependency.

Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
---
 meta/recipes-core/glib-2.0/glib.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-core/glib-2.0/glib.inc b/meta/recipes-core/glib-2.0/glib.inc
index 354d95cfe3..e6997ae88f 100644
--- a/meta/recipes-core/glib-2.0/glib.inc
+++ b/meta/recipes-core/glib-2.0/glib.inc
@@ -24,6 +24,7 @@ DEPENDS = "glib-2.0-native \
            virtual/libiconv \
            libffi \
            zlib \
+           gettext \
            ${@bb.utils.contains('PTEST_ENABLED', '1', 'dbus', '', d)}"
 
 PACKAGES += "${PN}-codegen ${PN}-utils"
-- 
2.14.1

Re: [PATCH] glib-2.0: Re-add the gettext depend

[Joshua Lock]

On 18/01/18 19:12, Alistair Francis wrote:
> Commit "glib-2.0: rationalise build dependencies"
> (8b0ca0cb54c91611213556bdb99316d5e7ac5b3b) broke mingw glib builds with
> the following error:
> 
> This patch fixes the issue by re-adding the gettext dependency.
> 
> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
> ---
>   meta/recipes-core/glib-2.0/glib.inc | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/meta/recipes-core/glib-2.0/glib.inc b/meta/recipes-core/glib-2.0/glib.inc
> index 354d95cfe3..e6997ae88f 100644
> --- a/meta/recipes-core/glib-2.0/glib.inc
> +++ b/meta/recipes-core/glib-2.0/glib.inc
> @@ -24,6 +24,7 @@ DEPENDS = "glib-2.0-native \
>              virtual/libiconv \
>              libffi \
>              zlib \
> +           gettext \

If this is only required for mingw we should add it in a mingw override, 
something like (untested):

DEPENDS_mingw32 += "gettext"

That way we:
a) know that it's a mingw dependency (and to test that toolchain before 
removing)
b) don't bloat the DEPENDS where gettext isn't a strict requirement.

>              ${@bb.utils.contains('PTEST_ENABLED', '1', 'dbus', '', d)}"
>   
>   PACKAGES += "${PN}-codegen ${PN}-utils"
> 

Re: [PATCH] glib-2.0: Re-add the gettext depend

[Alistair Francis]

On Thu, Jan 18, 2018 at 11:23 AM, Joshua Lock
<joshua.g.lock@linux.intel.com> wrote:
>
>
> On 18/01/18 19:12, Alistair Francis wrote:
>>
>> Commit "glib-2.0: rationalise build dependencies"
>> (8b0ca0cb54c91611213556bdb99316d5e7ac5b3b) broke mingw glib builds with
>> the following error:
>>
>> This patch fixes the issue by re-adding the gettext dependency.
>>
>> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
>> ---
>>   meta/recipes-core/glib-2.0/glib.inc | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/meta/recipes-core/glib-2.0/glib.inc
>> b/meta/recipes-core/glib-2.0/glib.inc
>> index 354d95cfe3..e6997ae88f 100644
>> --- a/meta/recipes-core/glib-2.0/glib.inc
>> +++ b/meta/recipes-core/glib-2.0/glib.inc
>> @@ -24,6 +24,7 @@ DEPENDS = "glib-2.0-native \
>>              virtual/libiconv \
>>              libffi \
>>              zlib \
>> +           gettext \
>
>
> If this is only required for mingw we should add it in a mingw override,
> something like (untested):
>
> DEPENDS_mingw32 += "gettext"
>
> That way we:
> a) know that it's a mingw dependency (and to test that toolchain before
> removing)
> b) don't bloat the DEPENDS where gettext isn't a strict requirement.

That seems fine to me, the only issue I see is that previously this
wasn't just a mingw depend, so there could be other causes and mingw
is just what I test.

Alistair

>
>>              ${@bb.utils.contains('PTEST_ENABLED', '1', 'dbus', '', d)}"
>>     PACKAGES += "${PN}-codegen ${PN}-utils"
>>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH] glib-2.0: Re-add the gettext depend

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 515 bytes --]

On 18 January 2018 at 19:12, Alistair Francis <alistair.francis@xilinx.com>
wrote:

> Commit "glib-2.0: rationalise build dependencies"
> (8b0ca0cb54c91611213556bdb99316d5e7ac5b3b) broke mingw glib builds with
> the following error:
>

The error is missing from the log, but is this the libintl problem?  If so
that's what the libintl dependency a few lines up is for, the problem is in
meta-mingw.  I submitted a patch earlier but it wasn't merged by the
maintainer so I just pushed it myself.

Ross

[-- Attachment #2: Type: text/html, Size: 882 bytes --]

Re: [PATCH] glib-2.0: Re-add the gettext depend

[Alistair Francis]

On Thu, Jan 18, 2018 at 12:02 PM, Burton, Ross <ross.burton@intel.com> wrote:
> On 18 January 2018 at 19:12, Alistair Francis <alistair.francis@xilinx.com>
> wrote:
>>
>> Commit "glib-2.0: rationalise build dependencies"
>> (8b0ca0cb54c91611213556bdb99316d5e7ac5b3b) broke mingw glib builds with
>> the following error:
>
>
> The error is missing from the log, but is this the libintl problem?  If so
> that's what the libintl dependency a few lines up is for, the problem is in
> meta-mingw.  I submitted a patch earlier but it wasn't merged by the
> maintainer so I just pushed it myself.

That is the problem, it is fixed now. Thanks for fixing that Ross.

Alistair

>
> Ross
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>