From: "Jürgen Groß" <jgross@suse.com>
To: Roger Pau Monne <roger.pau@citrix.com>, linux-kernel@vger.kernel.org
Cc: xen-devel@lists.xenproject.org,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH v3 3/4] Revert "xen/balloon: Fix crash when ballooning on x86 32 bit PAE"
Date: Mon, 3 Aug 2020 08:19:14 +0200 [thread overview]
Message-ID: <cb9783d8-ba48-f290-95b5-adbdb3900cfd@suse.com> (raw)
In-Reply-To: <20200727091342.52325-4-roger.pau@citrix.com>
On 27.07.20 11:13, Roger Pau Monne wrote:
> This reverts commit dfd74a1edfaba5864276a2859190a8d242d18952.
>
> This has been fixed by commit dca4436d1cf9e0d237c which added the out
> of bounds check to __add_memory, so that trying to add blocks past
> MAX_PHYSMEM_BITS will fail.
>
> Note the check in the Xen balloon driver was bogus anyway, as it
> checked the start address of the resource, but it should instead test
> the end address to assert the whole resource falls below
> MAX_PHYSMEM_BITS.
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> Reviewed-by: Juergen Gross <jgross@suse.com>
Pushed to: xen/tip.git for-linus-5.9
Juergen
WARNING: multiple messages have this Message-ID (diff)
From: "Jürgen Groß" <jgross@suse.com>
To: Roger Pau Monne <roger.pau@citrix.com>, linux-kernel@vger.kernel.org
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Stefano Stabellini <sstabellini@kernel.org>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v3 3/4] Revert "xen/balloon: Fix crash when ballooning on x86 32 bit PAE"
Date: Mon, 3 Aug 2020 08:19:14 +0200 [thread overview]
Message-ID: <cb9783d8-ba48-f290-95b5-adbdb3900cfd@suse.com> (raw)
In-Reply-To: <20200727091342.52325-4-roger.pau@citrix.com>
On 27.07.20 11:13, Roger Pau Monne wrote:
> This reverts commit dfd74a1edfaba5864276a2859190a8d242d18952.
>
> This has been fixed by commit dca4436d1cf9e0d237c which added the out
> of bounds check to __add_memory, so that trying to add blocks past
> MAX_PHYSMEM_BITS will fail.
>
> Note the check in the Xen balloon driver was bogus anyway, as it
> checked the start address of the resource, but it should instead test
> the end address to assert the whole resource falls below
> MAX_PHYSMEM_BITS.
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> Reviewed-by: Juergen Gross <jgross@suse.com>
Pushed to: xen/tip.git for-linus-5.9
Juergen
next prev parent reply other threads:[~2020-08-03 6:19 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 9:13 [PATCH v3 0/4] xen/balloon: fixes for memory hotplug Roger Pau Monne
2020-07-27 9:13 ` Roger Pau Monne
2020-07-27 9:13 ` [PATCH v3 1/4] xen/balloon: fix accounting in alloc_xenballooned_pages error path Roger Pau Monne
2020-07-27 9:13 ` Roger Pau Monne
2020-08-03 6:18 ` Jürgen Groß
2020-08-03 6:18 ` Jürgen Groß
2020-07-27 9:13 ` [PATCH v3 2/4] xen/balloon: make the balloon wait interruptible Roger Pau Monne
2020-07-27 9:13 ` Roger Pau Monne
2020-08-03 6:18 ` Jürgen Groß
2020-08-03 6:18 ` Jürgen Groß
2020-07-27 9:13 ` [PATCH v3 3/4] Revert "xen/balloon: Fix crash when ballooning on x86 32 bit PAE" Roger Pau Monne
2020-07-27 9:13 ` Roger Pau Monne
2020-08-03 6:19 ` Jürgen Groß [this message]
2020-08-03 6:19 ` Jürgen Groß
2020-07-27 9:13 ` [PATCH v3 4/4] xen: add helpers to allocate unpopulated memory Roger Pau Monne
2020-07-27 9:13 ` Roger Pau Monne
2020-07-27 9:13 ` Roger Pau Monne
2020-07-27 15:09 ` Jürgen Groß
2020-07-27 15:09 ` Jürgen Groß
2020-07-27 15:09 ` Jürgen Groß
2020-07-27 18:04 ` kernel test robot
2020-07-27 18:04 ` kernel test robot
2020-07-28 11:42 ` [PATCH] xen/balloon: add header guard Roger Pau Monne
2020-07-28 11:42 ` Roger Pau Monne
2020-07-28 13:56 ` Boris Ostrovsky
2020-07-28 13:56 ` Boris Ostrovsky
2020-07-28 16:48 ` [PATCH v3 4/4] xen: add helpers to allocate unpopulated memory Julien Grall
2020-07-28 16:48 ` Julien Grall
2020-07-28 16:59 ` Roger Pau Monné
2020-07-28 16:59 ` Roger Pau Monné
2020-07-28 16:59 ` Roger Pau Monné
2020-07-28 17:06 ` Andrew Cooper
2020-07-28 17:06 ` Andrew Cooper
2020-07-28 17:06 ` Andrew Cooper
2020-07-28 17:42 ` Roger Pau Monné
2020-07-28 17:42 ` Roger Pau Monné
2020-07-28 17:42 ` Roger Pau Monné
2020-07-28 17:12 ` Julien Grall
2020-07-28 17:12 ` Julien Grall
2020-07-28 17:12 ` Julien Grall
2020-07-28 17:44 ` Roger Pau Monné
2020-07-28 17:44 ` Roger Pau Monné
2020-07-28 17:44 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb9783d8-ba48-f290-95b5-adbdb3900cfd@suse.com \
--to=jgross@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.