All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jia Jie Ho <jiajie.ho@starfivetech.com>
To: Conor Dooley <conor@kernel.org>
Cc: Emil Renner Berthing <kernel@esmil.dk>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>, <devicetree@vger.kernel.org>,
	<linux-riscv@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] riscv: dts: starfive - Add crypto and DMA node for JH7110
Date: Tue, 8 Aug 2023 15:38:41 +0800	[thread overview]
Message-ID: <cbc3c9db-6a47-4e4f-5e5d-892d048ef924@starfivetech.com> (raw)
In-Reply-To: <20230808-cilantro-fondue-21485b78e83e@spud>

On 8/8/2023 3:16 pm, Conor Dooley wrote:
> On Tue, Aug 08, 2023 at 02:11:49PM +0800, Jia Jie Ho wrote:
>> Add hardware crypto module and dedicated dma controller node to StarFive
>> JH7110 SoC.
>> 
>> Co-developed-by: Huan Feng <huan.feng@starfivetech.com>
>> Signed-off-by: Huan Feng <huan.feng@starfivetech.com>
>> Signed-off-by: Jia Jie Ho <jiajie.ho@starfivetech.com>
>> Acked-by: Palmer Dabbelt <palmer@rivosinc.com>
>> ---
>>  arch/riscv/boot/dts/starfive/jh7110.dtsi | 28 ++++++++++++++++++++++++
>>  1 file changed, 28 insertions(+)
>> 
>> diff --git a/arch/riscv/boot/dts/starfive/jh7110.dtsi b/arch/riscv/boot/dts/starfive/jh7110.dtsi
>> index a608433200e8..47cd12ccc988 100644
>> --- a/arch/riscv/boot/dts/starfive/jh7110.dtsi
>> +++ b/arch/riscv/boot/dts/starfive/jh7110.dtsi
>> @@ -821,6 +821,34 @@ watchdog@13070000 {
>>  				 <&syscrg JH7110_SYSRST_WDT_CORE>;
>>  		};
>>  
>> +		crypto: crypto@16000000 {
>> +			compatible = "starfive,jh7110-crypto";
>> +			reg = <0x0 0x16000000 0x0 0x4000>;
>> +			clocks = <&stgcrg JH7110_STGCLK_SEC_AHB>,
>> +				 <&stgcrg JH7110_STGCLK_SEC_MISC_AHB>;
>> +			clock-names = "hclk", "ahb";
>> +			interrupts = <28>;
>> +			resets = <&stgcrg JH7110_STGRST_SEC_AHB>;
>> +			dmas = <&sdma 1 2>, <&sdma 0 2>;
>> +			dma-names = "tx", "rx";
>> +		};
>> +
>> +		sdma: dma@16008000 {
>> +			compatible = "arm,pl080", "arm,primecell";
>> +			arm,primecell-periphid = <0x00041080>;
>> +			reg = <0x0 0x16008000 0x0 0x4000>;
>> +			interrupts = <29>;
>> +			clocks = <&stgcrg JH7110_STGCLK_SEC_AHB>,
>> +				 <&stgcrg JH7110_STGCLK_SEC_MISC_AHB>;
>> +			clock-names = "hclk", "apb_pclk";
>> +			resets = <&stgcrg JH7110_STGRST_SEC_AHB>;
>> +			lli-bus-interface-ahb1;
>> +			mem-bus-interface-ahb1;
>> +			memcpy-burst-size = <256>;
>> +			memcpy-bus-width = <32>;
>> +			#dma-cells = <2>;
>> +		};
>> +
> 
> Against linux-next, I get these warnings:
> arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.3b.dtb: dma@16008000: $nodename:0: 'dma@16008000' does not match '^dma-controller(@.*)?$'
>         from schema $id: http://devicetree.org/schemas/dma/arm-pl08x.yaml#
> arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.3b.dtb: dma@16008000: clocks: [[26, 15], [26, 16]] is too long
>         from schema $id: http://devicetree.org/schemas/dma/arm-pl08x.yaml#
> arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.3b.dtb: dma@16008000: clock-names: ['hclk', 'apb_pclk'] is too long
>         from schema $id: http://devicetree.org/schemas/dma/arm-pl08x.yaml#
> arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.3b.dtb: dma@16008000: Unevaluated properties are not allowed ('#dma-cells' was unexpected)
>         from schema $id: http://devicetree.org/schemas/dma/arm-pl08x.yaml#
> arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.2a.dtb: dma@16008000: $nodename:0: 'dma@16008000' does not match '^dma-controller(@.*)?$'
>         from schema $id: http://devicetree.org/schemas/dma/arm-pl08x.yaml#
> arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.2a.dtb: dma@16008000: clocks: [[26, 15], [26, 16]] is too long
>         from schema $id: http://devicetree.org/schemas/dma/arm-pl08x.yaml#
> arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.2a.dtb: dma@16008000: clock-names: ['hclk', 'apb_pclk'] is too long
>         from schema $id: http://devicetree.org/schemas/dma/arm-pl08x.yaml#
> arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.2a.dtb: dma@16008000: Unevaluated properties are not allowed ('#dma-cells' was unexpected)
>         from schema $id: http://devicetree.org/schemas/dma/arm-pl08x.yaml#
> 
> Please fix these & submit a tested v2.
> 

Sorry, I missed testing the dma node.
Will fix this in next version.

Regards,
Jia Jie


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Jia Jie Ho <jiajie.ho@starfivetech.com>
To: Conor Dooley <conor@kernel.org>
Cc: Emil Renner Berthing <kernel@esmil.dk>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>, <devicetree@vger.kernel.org>,
	<linux-riscv@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] riscv: dts: starfive - Add crypto and DMA node for JH7110
Date: Tue, 8 Aug 2023 15:38:41 +0800	[thread overview]
Message-ID: <cbc3c9db-6a47-4e4f-5e5d-892d048ef924@starfivetech.com> (raw)
In-Reply-To: <20230808-cilantro-fondue-21485b78e83e@spud>

On 8/8/2023 3:16 pm, Conor Dooley wrote:
> On Tue, Aug 08, 2023 at 02:11:49PM +0800, Jia Jie Ho wrote:
>> Add hardware crypto module and dedicated dma controller node to StarFive
>> JH7110 SoC.
>> 
>> Co-developed-by: Huan Feng <huan.feng@starfivetech.com>
>> Signed-off-by: Huan Feng <huan.feng@starfivetech.com>
>> Signed-off-by: Jia Jie Ho <jiajie.ho@starfivetech.com>
>> Acked-by: Palmer Dabbelt <palmer@rivosinc.com>
>> ---
>>  arch/riscv/boot/dts/starfive/jh7110.dtsi | 28 ++++++++++++++++++++++++
>>  1 file changed, 28 insertions(+)
>> 
>> diff --git a/arch/riscv/boot/dts/starfive/jh7110.dtsi b/arch/riscv/boot/dts/starfive/jh7110.dtsi
>> index a608433200e8..47cd12ccc988 100644
>> --- a/arch/riscv/boot/dts/starfive/jh7110.dtsi
>> +++ b/arch/riscv/boot/dts/starfive/jh7110.dtsi
>> @@ -821,6 +821,34 @@ watchdog@13070000 {
>>  				 <&syscrg JH7110_SYSRST_WDT_CORE>;
>>  		};
>>  
>> +		crypto: crypto@16000000 {
>> +			compatible = "starfive,jh7110-crypto";
>> +			reg = <0x0 0x16000000 0x0 0x4000>;
>> +			clocks = <&stgcrg JH7110_STGCLK_SEC_AHB>,
>> +				 <&stgcrg JH7110_STGCLK_SEC_MISC_AHB>;
>> +			clock-names = "hclk", "ahb";
>> +			interrupts = <28>;
>> +			resets = <&stgcrg JH7110_STGRST_SEC_AHB>;
>> +			dmas = <&sdma 1 2>, <&sdma 0 2>;
>> +			dma-names = "tx", "rx";
>> +		};
>> +
>> +		sdma: dma@16008000 {
>> +			compatible = "arm,pl080", "arm,primecell";
>> +			arm,primecell-periphid = <0x00041080>;
>> +			reg = <0x0 0x16008000 0x0 0x4000>;
>> +			interrupts = <29>;
>> +			clocks = <&stgcrg JH7110_STGCLK_SEC_AHB>,
>> +				 <&stgcrg JH7110_STGCLK_SEC_MISC_AHB>;
>> +			clock-names = "hclk", "apb_pclk";
>> +			resets = <&stgcrg JH7110_STGRST_SEC_AHB>;
>> +			lli-bus-interface-ahb1;
>> +			mem-bus-interface-ahb1;
>> +			memcpy-burst-size = <256>;
>> +			memcpy-bus-width = <32>;
>> +			#dma-cells = <2>;
>> +		};
>> +
> 
> Against linux-next, I get these warnings:
> arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.3b.dtb: dma@16008000: $nodename:0: 'dma@16008000' does not match '^dma-controller(@.*)?$'
>         from schema $id: http://devicetree.org/schemas/dma/arm-pl08x.yaml#
> arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.3b.dtb: dma@16008000: clocks: [[26, 15], [26, 16]] is too long
>         from schema $id: http://devicetree.org/schemas/dma/arm-pl08x.yaml#
> arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.3b.dtb: dma@16008000: clock-names: ['hclk', 'apb_pclk'] is too long
>         from schema $id: http://devicetree.org/schemas/dma/arm-pl08x.yaml#
> arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.3b.dtb: dma@16008000: Unevaluated properties are not allowed ('#dma-cells' was unexpected)
>         from schema $id: http://devicetree.org/schemas/dma/arm-pl08x.yaml#
> arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.2a.dtb: dma@16008000: $nodename:0: 'dma@16008000' does not match '^dma-controller(@.*)?$'
>         from schema $id: http://devicetree.org/schemas/dma/arm-pl08x.yaml#
> arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.2a.dtb: dma@16008000: clocks: [[26, 15], [26, 16]] is too long
>         from schema $id: http://devicetree.org/schemas/dma/arm-pl08x.yaml#
> arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.2a.dtb: dma@16008000: clock-names: ['hclk', 'apb_pclk'] is too long
>         from schema $id: http://devicetree.org/schemas/dma/arm-pl08x.yaml#
> arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2-v1.2a.dtb: dma@16008000: Unevaluated properties are not allowed ('#dma-cells' was unexpected)
>         from schema $id: http://devicetree.org/schemas/dma/arm-pl08x.yaml#
> 
> Please fix these & submit a tested v2.
> 

Sorry, I missed testing the dma node.
Will fix this in next version.

Regards,
Jia Jie


  reply	other threads:[~2023-08-08  7:39 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-08  6:11 [PATCH 0/2] riscv: dts: starfive - Add crypto and trng node Jia Jie Ho
2023-08-08  6:11 ` Jia Jie Ho
2023-08-08  6:11 ` [PATCH 1/2] riscv: dts: starfive - Add crypto and DMA node for JH7110 Jia Jie Ho
2023-08-08  6:11   ` Jia Jie Ho
2023-08-08  7:16   ` Conor Dooley
2023-08-08  7:16     ` Conor Dooley
2023-08-08  7:38     ` Jia Jie Ho [this message]
2023-08-08  7:38       ` Jia Jie Ho
2023-08-08  7:13 ` [PATCH 0/2] riscv: dts: starfive - Add crypto and trng node Conor Dooley
2023-08-08  7:13   ` Conor Dooley
2023-08-08 10:17   ` JiaJie Ho
2023-08-08 10:17     ` JiaJie Ho
2023-08-08 10:44     ` Conor Dooley
2023-08-08 10:44       ` Conor Dooley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cbc3c9db-6a47-4e4f-5e5d-892d048ef924@starfivetech.com \
    --to=jiajie.ho@starfivetech.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@esmil.dk \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.