[uml-devel] Broken compiling under 2.6.12-rc2 on my machine

[uml-devel] Broken compiling under 2.6.12-rc2 on my machine

[Ian McDonald]

Hi there,

I have applied 2.6.12-rc2 patches against 2.6.11 and gone to compile
and it fails...

Here is what I have done:
make menuconfig ARCH=um
Added in hostfs, UML networking - daemon (but also tried with these
off, no difference)
make linux ARCH=um

Output:
  HOSTCC  usr/gen_init_cpio
  CHK     usr/initramfs_list
  UPD     usr/initramfs_list
  CPIO    usr/initramfs_data.cpio
  GZIP    usr/initramfs_data.cpio.gz
  AS      usr/initramfs_data.o
  LD      usr/built-in.o
  CC      arch/um/kernel/checksum.o
  QUOTE   arch/um/kernel/config.tmp
  QUOTE   arch/um/kernel/config.c
sed: -e expression #4, char 2: Extra characters after command
make[1]: *** [arch/um/kernel/config.c] Error 1
make: *** [arch/um/kernel] Error 2

and here is the file arch/um/kernel/.config.tmp.cmd that gets created
which I am guessing has the sed error
cmd_arch/um/kernel/config.tmp := sed -e 's/"/\\"/g' -e 's/^/"/' -e
's/$$/\\n"/' /home/iam4/linuxsrc/linux-2.6.12-rc2/.config >
arch/um/kernel/config.tmp

config.c also is 0 characters length

I can supply any other files needed.
System is Debian Woody, gcc 2.95.4

I don't know much yet about sed or the kernel build process but can
look into if nobody else makes sense of this. Just thought it was good
to get it out there considering it doesn't compile and rc2 has just
come out.

And UML does compile under 2.6.11 with a patch for gcc (which is
include in 2.6.12-rc4). Haven't yet tried 2.6.12-rc1 but can do later
if this will help.

Ian


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] Broken compiling under 2.6.12-rc2 on my machine

[Rob Landley]

On Tuesday 05 April 2005 11:51 pm, Ian McDonald wrote:
> Hi there,
>
> I have applied 2.6.12-rc2 patches against 2.6.11 and gone to compile
> and it fails...
>
> Here is what I have done:
> make menuconfig ARCH=um
> Added in hostfs, UML networking - daemon (but also tried with these
> off, no difference)
> make linux ARCH=um
>
> Output:
>   HOSTCC  usr/gen_init_cpio
>   CHK     usr/initramfs_list
>   UPD     usr/initramfs_list
>   CPIO    usr/initramfs_data.cpio
>   GZIP    usr/initramfs_data.cpio.gz
>   AS      usr/initramfs_data.o
>   LD      usr/built-in.o
>   CC      arch/um/kernel/checksum.o
>   QUOTE   arch/um/kernel/config.tmp
>   QUOTE   arch/um/kernel/config.c

I'm trying to track this down and fix it, but mine didn't even get that far, 
it died with:

  CC      arch/um/kernel/ptrace.o
arch/um/kernel/ptrace.c: In function `send_sigtrap':
arch/um/kernel/ptrace.c:324: warning: implicit declaration of function 
`REGS_SP'
arch/um/kernel/ptrace.c:324: error: union has no member named `skas'
arch/um/kernel/ptrace.c:324: error: invalid lvalue in unary `&'
arch/um/kernel/ptrace.c:324: warning: implicit declaration of function 
`REGS_IP'
arch/um/kernel/ptrace.c:324: error: union has no member named `skas'
arch/um/kernel/ptrace.c:324: error: invalid lvalue in unary `&'
make[1]: *** [arch/um/kernel/ptrace.o] Error 1

> sed: -e expression #4, char 2: Extra characters after command
> make[1]: *** [arch/um/kernel/config.c] Error 1
> make: *** [arch/um/kernel] Error 2
>
> and here is the file arch/um/kernel/.config.tmp.cmd that gets created
> which I am guessing has the sed error
> cmd_arch/um/kernel/config.tmp := sed -e 's/"/\\"/g' -e 's/^/"/' -e
> 's/$$/\\n"/' /home/iam4/linuxsrc/linux-2.6.12-rc2/.config >
> arch/um/kernel/config.tmp

There is no expression #4 in that.  It has three expressions (-e arguments) 
and a filename...

> config.c also is 0 characters length
>
> I can supply any other files needed.
> System is Debian Woody, gcc 2.95.4
>
> I don't know much yet about sed or the kernel build process but can
> look into if nobody else makes sense of this. Just thought it was good
> to get it out there considering it doesn't compile and rc2 has just
> come out.

I know sed.  I wrote and maintain the current busybox sed implementation.  I 
just don't know what the build's doing.

Could you send me your .config?

> And UML does compile under 2.6.11 with a patch for gcc (which is
> include in 2.6.12-rc4). Haven't yet tried 2.6.12-rc1 but can do later
> if this will help.

I'm confused: what?

> Ian
>
>
> -------------------------------------------------------
> SF email is sponsored by - The IT Product Guide
> Read honest & candid reviews on hundreds of IT Products from real users.
> Discover which products truly live up to the hype. Start reading now.
> http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
> _______________________________________________
> User-mode-linux-devel mailing list
> User-mode-linux-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] Broken compiling under 2.6.12-rc2 on my machine

[Ian McDonald]

> > And UML does compile under 2.6.11 with a patch for gcc (which is
> > include in 2.6.12-rc4). Haven't yet tried 2.6.12-rc1 but can do later
> > if this will help.
> 
> I'm confused: what?
> 
That should read 2.6.12-rc2 not 2.6.12-rc4.

I will supply the .config when I get into university. I will try to
replicate yours as well - I was running without SKAS I think which is
where your problem appears to be....


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] Broken compiling under 2.6.12-rc2 on my machine

[Blaisorblade]

On Wednesday 06 April 2005 07:45, Rob Landley wrote:
> On Tuesday 05 April 2005 11:51 pm, Ian McDonald wrote:
> > Hi there,
> >

> I'm trying to track this down and fix it, but mine didn't even get that
> far, it died with:
>
>   CC      arch/um/kernel/ptrace.o
> arch/um/kernel/ptrace.c: In function `send_sigtrap':
> arch/um/kernel/ptrace.c:324: warning: implicit declaration of function
> `REGS_SP'
> arch/um/kernel/ptrace.c:324: error: union has no member named `skas'
> arch/um/kernel/ptrace.c:324: error: invalid lvalue in unary `&'
> arch/um/kernel/ptrace.c:324: warning: implicit declaration of function
> `REGS_IP'
> arch/um/kernel/ptrace.c:324: error: union has no member named `skas'
> arch/um/kernel/ptrace.c:324: error: invalid lvalue in unary `&'
> make[1]: *** [arch/um/kernel/ptrace.o] Error 1
Yes, that's true, the fix is in -mm, enable SKAS mode too during compilation 
(even if you don't use it) and it will work. See the answer to the latest 
"[uml-devel] [linux-2.6-bk] UML compile broken!" thread for this problem.

> > sed: -e expression #4, char 2: Extra characters after command
> > make[1]: *** [arch/um/kernel/config.c] Error 1
> > make: *** [arch/um/kernel] Error 2
> >
> > and here is the file arch/um/kernel/.config.tmp.cmd that gets created
> > which I am guessing has the sed error
> > cmd_arch/um/kernel/config.tmp := sed -e 's/"/\\"/g' -e 's/^/"/' -e
> > 's/$$/\\n"/' /home/iam4/linuxsrc/linux-2.6.12-rc2/.config >
> > arch/um/kernel/config.tmp
>
> There is no expression #4 in that.  It has three expressions (-e arguments)
> and a filename...
Ian, good catch, but you're quoting the wrong .cmd file. config.tmp is built 
correctly, config.c is not, so you should quote .config.c.cmd.

Anyway, from looking at what you quote, it's identical to the code in 
arch/um/kernel/Makefile. Quoting the correct code:

quiet_cmd_quote2 = QUOTE   $@
cmd_quote2 = sed -e '/CONFIG/{'          \
                  -e 's/"CONFIG"\;/""/'        \
                  -e 'r $(obj)/config.tmp'     \
                  -e 'a""\;'                   \
                  -e '}'                       \
                  $< > $@

As you see, there is a fourth expression, *here*. But it's -e '}'.

This patch went in after 2.6.11, I'm noticing - wow, are releases getting so 
slow?

> > System is Debian Woody,
Can you post your sed version? and Rob, can you then test it and fix the code? 
Please save the correct config.c currently created and check it for 
reference.
> > I don't know much yet about sed or the kernel build process but can
> > look into if nobody else makes sense of this. Just thought it was good
> > to get it out there considering it doesn't compile and rc2 has just
> > come out.

> I know sed.  I wrote and maintain the current busybox sed implementation. 
> I just don't know what the build's doing.
Explained above.
> Could you send me your .config?

> > And UML does compile under 2.6.11 with a patch for gcc
The __va_copy fix, right? I'm trying to merge that in 2.6.11.7, it's under 
review. The only problem is that somebody complains about the fact Linux 
still supports 2.95. Luckily for you, Linus already shut them off once, so 
the support won't go away soon.
> > (which is 
> > include in 2.6.12-rc4). Haven't yet tried 2.6.12-rc1 but can do later
> > if this will help.
You mean -rc2, ok.
-- 
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729
http://www.user-mode-linux.org/~blaisorblade




-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] Broken compiling under 2.6.12-rc2 on my machine

[Ian McDonald]

[-- Attachment #1: Type: text/plain, Size: 2876 bytes --]

Comments inline

On Apr 7, 2005 7:36 AM, Blaisorblade <blaisorblade@yahoo.it> wrote:
> > > sed: -e expression #4, char 2: Extra characters after command
> > > make[1]: *** [arch/um/kernel/config.c] Error 1
> > > make: *** [arch/um/kernel] Error 2
> > >
> > > and here is the file arch/um/kernel/.config.tmp.cmd that gets created
> > > which I am guessing has the sed error
> > > cmd_arch/um/kernel/config.tmp := sed -e 's/"/\\"/g' -e 's/^/"/' -e
> > > 's/$$/\\n"/' /home/iam4/linuxsrc/linux-2.6.12-rc2/.config >
> > > arch/um/kernel/config.tmp
> >
> > There is no expression #4 in that.  It has three expressions (-e arguments)
> > and a filename...
> Ian, good catch, but you're quoting the wrong .cmd file. config.tmp is built
> correctly, config.c is not, so you should quote .config.c.cmd.
> 
There is no such file as .config.c.cmd and don't see it mentioned in
Makefile either.
There is however .checksum.o.cmd (8348 bytes), config.tmp (13609
bytes) if you want to see either.

> Anyway, from looking at what you quote, it's identical to the code in
> arch/um/kernel/Makefile. Quoting the correct code:
> 
> quiet_cmd_quote2 = QUOTE   $@
> cmd_quote2 = sed -e '/CONFIG/{'          \
>                   -e 's/"CONFIG"\;/""/'        \
>                   -e 'r $(obj)/config.tmp'     \
>                   -e 'a""\;'                   \
>                   -e '}'                       \
>                   $< > $@
> 
This matches my Makefile exactly

> As you see, there is a fourth expression, *here*. But it's -e '}'.
> 
> This patch went in after 2.6.11, I'm noticing - wow, are releases getting so
> slow?
> 
> > > System is Debian Woody,
> Can you post your sed version? and Rob, can you then test it and fix the code?

GNU sed version 3.02

> Please save the correct config.c currently created and check it for
> reference.
> > > I don't know much yet about sed or the kernel build process but can
> > > look into if nobody else makes sense of this. Just thought it was good
> > > to get it out there considering it doesn't compile and rc2 has just
> > > come out.
> 
> > I know sed.  I wrote and maintain the current busybox sed implementation.
> > I just don't know what the build's doing.
> Explained above.
> > Could you send me your .config?

Attached

> 
> > > And UML does compile under 2.6.11 with a patch for gcc
> The __va_copy fix, right? I'm trying to merge that in 2.6.11.7, it's under
> review. The only problem is that somebody complains about the fact Linux
> still supports 2.95. Luckily for you, Linus already shut them off once, so
> the support won't go away soon.

Yes lucky for me as I don't have root access to my box here and can't alter....

__va_copy and systables patch (duplicated enums)

> > > (which is
> > > include in 2.6.12-rc4). Haven't yet tried 2.6.12-rc1 but can do later
> > > if this will help.
> You mean -rc2, ok.

Yep :-)

[-- Attachment #2: .config --]
[-- Type: application/octet-stream, Size: 11527 bytes --]

#
# Automatically generated make config: don't edit
# Linux kernel version: 2.6.12-rc2
# Thu Apr  7 11:40:02 2005
#
CONFIG_GENERIC_HARDIRQS=y
CONFIG_UML=y
CONFIG_MMU=y
CONFIG_UID16=y
CONFIG_RWSEM_GENERIC_SPINLOCK=y
CONFIG_GENERIC_CALIBRATE_DELAY=y

#
# UML-specific options
#
CONFIG_MODE_TT=y
CONFIG_MODE_SKAS=y
# CONFIG_64_BIT is not set
CONFIG_TOP_ADDR=0xc0000000
# CONFIG_3_LEVEL_PGTABLES is not set
CONFIG_ARCH_HAS_SC_SIGNALS=y
CONFIG_ARCH_REUSE_HOST_VSYSCALL_AREA=y
CONFIG_LD_SCRIPT_STATIC=y
CONFIG_NET=y
CONFIG_BINFMT_ELF=y
CONFIG_BINFMT_MISC=y
CONFIG_HOSTFS=y
CONFIG_MCONSOLE=y
CONFIG_MAGIC_SYSRQ=y
# CONFIG_HOST_2G_2G is not set
CONFIG_SMP=y
CONFIG_NR_CPUS=2
CONFIG_NEST_LEVEL=0
CONFIG_KERNEL_HALF_GIGS=1
CONFIG_HIGHMEM=y
CONFIG_KERNEL_STACK_ORDER=2
CONFIG_UML_REAL_TIME_CLOCK=y

#
# Code maturity level options
#
CONFIG_EXPERIMENTAL=y
CONFIG_CLEAN_COMPILE=y
CONFIG_LOCK_KERNEL=y
CONFIG_INIT_ENV_ARG_LIMIT=32

#
# General setup
#
CONFIG_LOCALVERSION=""
CONFIG_SWAP=y
CONFIG_SYSVIPC=y
# CONFIG_POSIX_MQUEUE is not set
# CONFIG_BSD_PROCESS_ACCT is not set
CONFIG_SYSCTL=y
# CONFIG_AUDIT is not set
# CONFIG_HOTPLUG is not set
CONFIG_KOBJECT_UEVENT=y
# CONFIG_IKCONFIG is not set
# CONFIG_CPUSETS is not set
# CONFIG_EMBEDDED is not set
CONFIG_KALLSYMS=y
# CONFIG_KALLSYMS_ALL is not set
# CONFIG_KALLSYMS_EXTRA_PASS is not set
CONFIG_BASE_FULL=y
CONFIG_FUTEX=y
CONFIG_EPOLL=y
CONFIG_SHMEM=y
CONFIG_CC_ALIGN_FUNCTIONS=0
CONFIG_CC_ALIGN_LABELS=0
CONFIG_CC_ALIGN_LOOPS=0
CONFIG_CC_ALIGN_JUMPS=0
# CONFIG_TINY_SHMEM is not set
CONFIG_BASE_SMALL=0

#
# Loadable module support
#
CONFIG_MODULES=y
# CONFIG_MODULE_UNLOAD is not set
CONFIG_OBSOLETE_MODPARM=y
# CONFIG_MODULE_SRCVERSION_ALL is not set
CONFIG_KMOD=y

#
# Generic Driver Options
#
CONFIG_STANDALONE=y
CONFIG_PREVENT_FIRMWARE_BUILD=y
# CONFIG_FW_LOADER is not set
# CONFIG_DEBUG_DRIVER is not set

#
# Character Devices
#
CONFIG_STDERR_CONSOLE=y
CONFIG_STDIO_CONSOLE=y
# CONFIG_SSL is not set
# CONFIG_NULL_CHAN is not set
# CONFIG_PORT_CHAN is not set
# CONFIG_PTY_CHAN is not set
# CONFIG_TTY_CHAN is not set
# CONFIG_XTERM_CHAN is not set
CONFIG_NOCONFIG_CHAN=y
CONFIG_CON_ZERO_CHAN="fd:0,fd:1"
CONFIG_CON_CHAN="xterm"
CONFIG_SSL_CHAN="pty"
CONFIG_UNIX98_PTYS=y
CONFIG_LEGACY_PTYS=y
CONFIG_LEGACY_PTY_COUNT=256
# CONFIG_WATCHDOG is not set
# CONFIG_UML_SOUND is not set
# CONFIG_SOUND is not set
# CONFIG_HOSTAUDIO is not set
# CONFIG_UML_RANDOM is not set

#
# Block devices
#
# CONFIG_BLK_DEV_UBD is not set
# CONFIG_BLK_DEV_COW_COMMON is not set
CONFIG_BLK_DEV_LOOP=m
# CONFIG_BLK_DEV_CRYPTOLOOP is not set
# CONFIG_BLK_DEV_NBD is not set
# CONFIG_BLK_DEV_RAM is not set
CONFIG_BLK_DEV_RAM_COUNT=16
CONFIG_INITRAMFS_SOURCE=""
# CONFIG_LBD is not set

#
# IO Schedulers
#
CONFIG_IOSCHED_NOOP=y
CONFIG_IOSCHED_AS=y
CONFIG_IOSCHED_DEADLINE=y
CONFIG_IOSCHED_CFQ=y
# CONFIG_ATA_OVER_ETH is not set
CONFIG_NETDEVICES=y

#
# UML Network Devices
#
CONFIG_UML_NET=y
# CONFIG_UML_NET_ETHERTAP is not set
# CONFIG_UML_NET_TUNTAP is not set
# CONFIG_UML_NET_SLIP is not set
CONFIG_UML_NET_DAEMON=y
# CONFIG_UML_NET_MCAST is not set
# CONFIG_UML_NET_SLIRP is not set

#
# Networking support
#

#
# Networking options
#
CONFIG_PACKET=y
# CONFIG_PACKET_MMAP is not set
CONFIG_UNIX=y
# CONFIG_NET_KEY is not set
CONFIG_INET=y
CONFIG_IP_MULTICAST=y
# CONFIG_IP_ADVANCED_ROUTER is not set
# CONFIG_IP_PNP is not set
# CONFIG_NET_IPIP is not set
# CONFIG_NET_IPGRE is not set
# CONFIG_IP_MROUTE is not set
# CONFIG_ARPD is not set
CONFIG_SYN_COOKIES=y
# CONFIG_INET_AH is not set
# CONFIG_INET_ESP is not set
# CONFIG_INET_IPCOMP is not set
# CONFIG_INET_TUNNEL is not set
CONFIG_IP_TCPDIAG=y
# CONFIG_IP_TCPDIAG_IPV6 is not set

#
# IP: Virtual Server Configuration
#
# CONFIG_IP_VS is not set
CONFIG_IPV6=m
# CONFIG_IPV6_PRIVACY is not set
# CONFIG_INET6_AH is not set
# CONFIG_INET6_ESP is not set
# CONFIG_INET6_IPCOMP is not set
# CONFIG_INET6_TUNNEL is not set
# CONFIG_IPV6_TUNNEL is not set
CONFIG_NETFILTER=y
# CONFIG_NETFILTER_DEBUG is not set

#
# IP: Netfilter Configuration
#
CONFIG_IP_NF_CONNTRACK=m
# CONFIG_IP_NF_CT_ACCT is not set
# CONFIG_IP_NF_CONNTRACK_MARK is not set
# CONFIG_IP_NF_CT_PROTO_SCTP is not set
CONFIG_IP_NF_FTP=m
CONFIG_IP_NF_IRC=m
CONFIG_IP_NF_TFTP=m
CONFIG_IP_NF_AMANDA=m
CONFIG_IP_NF_QUEUE=m
CONFIG_IP_NF_IPTABLES=m
CONFIG_IP_NF_MATCH_LIMIT=m
# CONFIG_IP_NF_MATCH_IPRANGE is not set
CONFIG_IP_NF_MATCH_MAC=m
CONFIG_IP_NF_MATCH_PKTTYPE=m
CONFIG_IP_NF_MATCH_MARK=m
CONFIG_IP_NF_MATCH_MULTIPORT=m
CONFIG_IP_NF_MATCH_TOS=m
CONFIG_IP_NF_MATCH_RECENT=m
CONFIG_IP_NF_MATCH_ECN=m
CONFIG_IP_NF_MATCH_DSCP=m
CONFIG_IP_NF_MATCH_AH_ESP=m
CONFIG_IP_NF_MATCH_LENGTH=m
CONFIG_IP_NF_MATCH_TTL=m
CONFIG_IP_NF_MATCH_TCPMSS=m
CONFIG_IP_NF_MATCH_HELPER=m
CONFIG_IP_NF_MATCH_STATE=m
CONFIG_IP_NF_MATCH_CONNTRACK=m
CONFIG_IP_NF_MATCH_OWNER=m
# CONFIG_IP_NF_MATCH_ADDRTYPE is not set
# CONFIG_IP_NF_MATCH_REALM is not set
# CONFIG_IP_NF_MATCH_SCTP is not set
# CONFIG_IP_NF_MATCH_COMMENT is not set
# CONFIG_IP_NF_MATCH_HASHLIMIT is not set
CONFIG_IP_NF_FILTER=m
CONFIG_IP_NF_TARGET_REJECT=m
CONFIG_IP_NF_TARGET_LOG=m
CONFIG_IP_NF_TARGET_ULOG=m
CONFIG_IP_NF_TARGET_TCPMSS=m
CONFIG_IP_NF_NAT=m
CONFIG_IP_NF_NAT_NEEDED=y
CONFIG_IP_NF_TARGET_MASQUERADE=m
CONFIG_IP_NF_TARGET_REDIRECT=m
# CONFIG_IP_NF_TARGET_NETMAP is not set
# CONFIG_IP_NF_TARGET_SAME is not set
CONFIG_IP_NF_NAT_SNMP_BASIC=m
CONFIG_IP_NF_NAT_IRC=m
CONFIG_IP_NF_NAT_FTP=m
CONFIG_IP_NF_NAT_TFTP=m
CONFIG_IP_NF_NAT_AMANDA=m
CONFIG_IP_NF_MANGLE=m
CONFIG_IP_NF_TARGET_TOS=m
CONFIG_IP_NF_TARGET_ECN=m
CONFIG_IP_NF_TARGET_DSCP=m
CONFIG_IP_NF_TARGET_MARK=m
# CONFIG_IP_NF_TARGET_CLASSIFY is not set
# CONFIG_IP_NF_RAW is not set
CONFIG_IP_NF_ARPTABLES=m
CONFIG_IP_NF_ARPFILTER=m
CONFIG_IP_NF_ARP_MANGLE=m

#
# IPv6: Netfilter Configuration (EXPERIMENTAL)
#
CONFIG_IP6_NF_QUEUE=m
CONFIG_IP6_NF_IPTABLES=m
CONFIG_IP6_NF_MATCH_LIMIT=m
CONFIG_IP6_NF_MATCH_MAC=m
CONFIG_IP6_NF_MATCH_RT=m
CONFIG_IP6_NF_MATCH_OPTS=m
CONFIG_IP6_NF_MATCH_FRAG=m
CONFIG_IP6_NF_MATCH_HL=m
CONFIG_IP6_NF_MATCH_MULTIPORT=m
CONFIG_IP6_NF_MATCH_OWNER=m
CONFIG_IP6_NF_MATCH_MARK=m
CONFIG_IP6_NF_MATCH_IPV6HEADER=m
CONFIG_IP6_NF_MATCH_AHESP=m
CONFIG_IP6_NF_MATCH_LENGTH=m
CONFIG_IP6_NF_MATCH_EUI64=m
CONFIG_IP6_NF_FILTER=m
CONFIG_IP6_NF_TARGET_LOG=m
CONFIG_IP6_NF_MANGLE=m
CONFIG_IP6_NF_TARGET_MARK=m
# CONFIG_IP6_NF_RAW is not set

#
# SCTP Configuration (EXPERIMENTAL)
#
# CONFIG_IP_SCTP is not set
# CONFIG_ATM is not set
# CONFIG_BRIDGE is not set
# CONFIG_VLAN_8021Q is not set
# CONFIG_DECNET is not set
# CONFIG_LLC2 is not set
# CONFIG_IPX is not set
# CONFIG_ATALK is not set
# CONFIG_X25 is not set
# CONFIG_LAPB is not set
# CONFIG_NET_DIVERT is not set
# CONFIG_ECONET is not set
# CONFIG_WAN_ROUTER is not set

#
# QoS and/or fair queueing
#
# CONFIG_NET_SCHED is not set
# CONFIG_NET_CLS_ROUTE is not set

#
# Network testing
#
# CONFIG_NET_PKTGEN is not set
# CONFIG_NETPOLL is not set
# CONFIG_NET_POLL_CONTROLLER is not set
# CONFIG_HAMRADIO is not set
# CONFIG_IRDA is not set
# CONFIG_BT is not set
CONFIG_DUMMY=m
# CONFIG_BONDING is not set
# CONFIG_EQUALIZER is not set
CONFIG_TUN=m

#
# Wan interfaces
#
# CONFIG_WAN is not set
# CONFIG_PPP is not set
# CONFIG_SLIP is not set
# CONFIG_SHAPER is not set
# CONFIG_NETCONSOLE is not set

#
# File systems
#
CONFIG_EXT2_FS=y
# CONFIG_EXT2_FS_XATTR is not set
CONFIG_EXT3_FS=y
CONFIG_EXT3_FS_XATTR=y
# CONFIG_EXT3_FS_POSIX_ACL is not set
# CONFIG_EXT3_FS_SECURITY is not set
CONFIG_JBD=y
# CONFIG_JBD_DEBUG is not set
CONFIG_FS_MBCACHE=y
CONFIG_REISERFS_FS=y
# CONFIG_REISERFS_CHECK is not set
# CONFIG_REISERFS_PROC_INFO is not set
# CONFIG_REISERFS_FS_XATTR is not set
# CONFIG_JFS_FS is not set

#
# XFS support
#
# CONFIG_XFS_FS is not set
# CONFIG_MINIX_FS is not set
# CONFIG_ROMFS_FS is not set
# CONFIG_QUOTA is not set
CONFIG_DNOTIFY=y
# CONFIG_AUTOFS_FS is not set
# CONFIG_AUTOFS4_FS is not set

#
# CD-ROM/DVD Filesystems
#
CONFIG_ISO9660_FS=y
CONFIG_JOLIET=y
# CONFIG_ZISOFS is not set
# CONFIG_UDF_FS is not set

#
# DOS/FAT/NT Filesystems
#
CONFIG_FAT_FS=y
CONFIG_MSDOS_FS=y
CONFIG_VFAT_FS=y
CONFIG_FAT_DEFAULT_CODEPAGE=437
CONFIG_FAT_DEFAULT_IOCHARSET="iso8859-1"
# CONFIG_NTFS_FS is not set

#
# Pseudo filesystems
#
CONFIG_PROC_FS=y
# CONFIG_PROC_KCORE is not set
CONFIG_SYSFS=y
# CONFIG_DEVFS_FS is not set
# CONFIG_DEVPTS_FS_XATTR is not set
CONFIG_TMPFS=y
# CONFIG_TMPFS_XATTR is not set
# CONFIG_HUGETLB_PAGE is not set
CONFIG_RAMFS=y

#
# Miscellaneous filesystems
#
# CONFIG_ADFS_FS is not set
# CONFIG_AFFS_FS is not set
# CONFIG_HFS_FS is not set
# CONFIG_HFSPLUS_FS is not set
# CONFIG_BEFS_FS is not set
# CONFIG_BFS_FS is not set
# CONFIG_EFS_FS is not set
# CONFIG_CRAMFS is not set
# CONFIG_VXFS_FS is not set
# CONFIG_HPFS_FS is not set
# CONFIG_QNX4FS_FS is not set
# CONFIG_SYSV_FS is not set
# CONFIG_UFS_FS is not set

#
# Network File Systems
#
CONFIG_NFS_FS=y
CONFIG_NFS_V3=y
# CONFIG_NFS_V4 is not set
# CONFIG_NFS_DIRECTIO is not set
CONFIG_NFSD=y
CONFIG_NFSD_V3=y
# CONFIG_NFSD_V4 is not set
# CONFIG_NFSD_TCP is not set
CONFIG_LOCKD=y
CONFIG_LOCKD_V4=y
CONFIG_EXPORTFS=y
CONFIG_SUNRPC=y
# CONFIG_RPCSEC_GSS_KRB5 is not set
# CONFIG_RPCSEC_GSS_SPKM3 is not set
CONFIG_SMB_FS=y
# CONFIG_SMB_NLS_DEFAULT is not set
# CONFIG_CIFS is not set
# CONFIG_NCP_FS is not set
# CONFIG_CODA_FS is not set
# CONFIG_AFS_FS is not set

#
# Partition Types
#
# CONFIG_PARTITION_ADVANCED is not set
CONFIG_MSDOS_PARTITION=y

#
# Native Language Support
#
CONFIG_NLS=y
CONFIG_NLS_DEFAULT="iso8859-1"
CONFIG_NLS_CODEPAGE_437=y
# CONFIG_NLS_CODEPAGE_737 is not set
# CONFIG_NLS_CODEPAGE_775 is not set
# CONFIG_NLS_CODEPAGE_850 is not set
# CONFIG_NLS_CODEPAGE_852 is not set
# CONFIG_NLS_CODEPAGE_855 is not set
# CONFIG_NLS_CODEPAGE_857 is not set
# CONFIG_NLS_CODEPAGE_860 is not set
# CONFIG_NLS_CODEPAGE_861 is not set
# CONFIG_NLS_CODEPAGE_862 is not set
# CONFIG_NLS_CODEPAGE_863 is not set
# CONFIG_NLS_CODEPAGE_864 is not set
# CONFIG_NLS_CODEPAGE_865 is not set
# CONFIG_NLS_CODEPAGE_866 is not set
# CONFIG_NLS_CODEPAGE_869 is not set
# CONFIG_NLS_CODEPAGE_936 is not set
# CONFIG_NLS_CODEPAGE_950 is not set
# CONFIG_NLS_CODEPAGE_932 is not set
# CONFIG_NLS_CODEPAGE_949 is not set
# CONFIG_NLS_CODEPAGE_874 is not set
# CONFIG_NLS_ISO8859_8 is not set
# CONFIG_NLS_CODEPAGE_1250 is not set
# CONFIG_NLS_CODEPAGE_1251 is not set
# CONFIG_NLS_ASCII is not set
CONFIG_NLS_ISO8859_1=y
# CONFIG_NLS_ISO8859_2 is not set
# CONFIG_NLS_ISO8859_3 is not set
# CONFIG_NLS_ISO8859_4 is not set
# CONFIG_NLS_ISO8859_5 is not set
# CONFIG_NLS_ISO8859_6 is not set
# CONFIG_NLS_ISO8859_7 is not set
# CONFIG_NLS_ISO8859_9 is not set
# CONFIG_NLS_ISO8859_13 is not set
# CONFIG_NLS_ISO8859_14 is not set
# CONFIG_NLS_ISO8859_15 is not set
# CONFIG_NLS_KOI8_R is not set
# CONFIG_NLS_KOI8_U is not set
# CONFIG_NLS_UTF8 is not set

#
# Security options
#
# CONFIG_KEYS is not set
# CONFIG_SECURITY is not set

#
# Cryptographic options
#
# CONFIG_CRYPTO is not set

#
# Hardware crypto devices
#

#
# Library routines
#
# CONFIG_CRC_CCITT is not set
CONFIG_CRC32=y
# CONFIG_LIBCRC32C is not set

#
# Multi-device support (RAID and LVM)
#
# CONFIG_MD is not set
# CONFIG_INPUT is not set

#
# Kernel hacking
#
# CONFIG_PRINTK_TIME is not set
CONFIG_DEBUG_KERNEL=y
CONFIG_LOG_BUF_SHIFT=15
# CONFIG_SCHEDSTATS is not set
# CONFIG_DEBUG_SLAB is not set
# CONFIG_DEBUG_SPINLOCK is not set
# CONFIG_DEBUG_SPINLOCK_SLEEP is not set
# CONFIG_DEBUG_KOBJECT is not set
# CONFIG_DEBUG_HIGHMEM is not set
# CONFIG_DEBUG_INFO is not set
# CONFIG_DEBUG_FS is not set

Re: [uml-devel] Broken compiling under 2.6.12-rc2 on my machine

[Rob Landley]

On Wednesday 06 April 2005 03:36 pm, Blaisorblade wrote:

> Anyway, from looking at what you quote, it's identical to the code in
> arch/um/kernel/Makefile. Quoting the correct code:
>
> quiet_cmd_quote2 = QUOTE   $@
> cmd_quote2 = sed -e '/CONFIG/{'          \
>                   -e 's/"CONFIG"\;/""/'        \
>                   -e 'r $(obj)/config.tmp'     \
>                   -e 'a""\;'                   \
>                   -e '}'                       \
>                   $< > $@
>
> As you see, there is a fourth expression, *here*. But it's -e '}'.
>
> This patch went in after 2.6.11, I'm noticing - wow, are releases getting
> so slow?
>
> > > System is Debian Woody,
>
> Can you post your sed version? and Rob, can you then test it and fix the
> code? Please save the correct config.c currently created and check it for
> reference.

I enabled SKAS mode and the build finished.  The sed bit didn't break for me:

  CHK     usr/initramfs_list
  QUOTE   arch/um/kernel/config.tmp
  QUOTE   arch/um/kernel/config.c
  CC      arch/um/kernel/config.o

And I'm using knoppix, which is based on debian.

From the error message, it seems to be complaining about the "a" command.  If 
you're using a really really really old version of sed, it might insist on a 
gratuitous line break before the line to be added.  (I know it did back in 
the 1970's, but I didn't think anything remotely modern had that limitation.)  
So try splitting the command in half like this:

cmd_quote2 = sed -e '/CONFIG/{'          \
                  -e 's/"CONFIG"\;/""/'        \
                  -e 'r $(obj)/config.tmp'     \
                  -e 'a \'                   \
                  -e '""\;'                  \
                  -e '}'                       \
                  $< > $@

I just tried that here and it behaved the same way as the other version, for 
me...

Rob


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_ide95&alloc_id\x14396&opÌk
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] Broken compiling under 2.6.12-rc2 on my machine

[Rob Landley]

On Wednesday 06 April 2005 07:55 pm, Ian McDonald wrote:
> > As you see, there is a fourth expression, *here*. But it's -e '}'.
> >
> > This patch went in after 2.6.11, I'm noticing - wow, are releases getting
> > so slow?
> >
> > > > System is Debian Woody,
> >
> > Can you post your sed version? and Rob, can you then test it and fix the
> > code?
>
> GNU sed version 3.02

According to this:

ftp://ftp.gnu.org/gnu/sed

That's from august 1998.  It's even older than gcc 2.95, the tarball of which 
contains files dated 7/29/99 (a full year later).  Saying we should support 
that is roughly equivalent to saying we should be able to build with gcc 
2.8.1, the compiler that was released six months before that was.

That said, the change I posted earlier would probably make it work.  The 
question is, do we care?   Documentation/Changes doesn't list a required sed 
version (even though other things in the kernel build use it), but perhaps it 
should.

> > > > And UML does compile under 2.6.11 with a patch for gcc
> >
> > The __va_copy fix, right? I'm trying to merge that in 2.6.11.7, it's
> > under review. The only problem is that somebody complains about the fact
> > Linux still supports 2.95. Luckily for you, Linus already shut them off
> > once, so the support won't go away soon.
>
> Yes lucky for me as I don't have root access to my box here and can't
> alter....

Documentation/Changes says the kernel actually requires gcc 2.95.3, which has 
the newest file on 3/16/2001.

Not my call, and I posted a fix that should work on the ancient stuff (I'm 
curious if it actually does).  It's not a hard fix at all, just pointing out 
some context...

Rob


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] Broken compiling under 2.6.12-rc2 on my machine

[Adrian Phillips]

>>>>> "Rob" == Rob Landley <rob@landley.net> writes:

    >> > > > System is Debian Woody,
    >> >
    >> > Can you post your sed version? and Rob, can you then test it
    >> and fix the > code?
    >> 
    >> GNU sed version 3.02

    Rob> That said, the change I posted earlier would probably make it
    Rob> work.  The question is, do we care?  Documentation/Changes
    Rob> doesn't list a required sed version (even though other things
    Rob> in the kernel build use it), but perhaps it should.

Well, for Woody users there is always a backports sed - anyone using
2.6 with woody needs at least module-init-tools from backports so one
more package won't matter, even though one could be compiling 2.6 on a
2.4 system.

Sincerely,

Adrian Phillips

-- 
Who really wrote the works of William Shakespeare ?
http://www.pbs.org/wgbh/pages/frontline/shakespeare/


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] Broken compiling under 2.6.12-rc2 on my machine

[Blaisorblade]

On Thursday 07 April 2005 08:50, Rob Landley wrote:
> On Wednesday 06 April 2005 03:36 pm, Blaisorblade wrote:
> > Anyway, from looking at what you quote, it's identical to the code in
> > arch/um/kernel/Makefile. Quoting the correct code:
> >
> > quiet_cmd_quote2 = QUOTE   $@
> > cmd_quote2 = sed -e '/CONFIG/{'          \
> >                   -e 's/"CONFIG"\;/""/'        \
> >                   -e 'r $(obj)/config.tmp'     \
> >                   -e 'a""\;'                   \
> >                   -e '}'                       \
> >                   $< > $@
> >
> > As you see, there is a fourth expression, *here*. But it's -e '}'.
> >
> > This patch went in after 2.6.11, I'm noticing - wow, are releases getting
> > so slow?
> >
> > > > System is Debian Woody,
> >
> > Can you post your sed version? and Rob, can you then test it and fix the
> > code? Please save the correct config.c currently created and check it for
> > reference.
>
> I enabled SKAS mode and the build finished.  The sed bit didn't break for
> me:
>
>   CHK     usr/initramfs_list
>   QUOTE   arch/um/kernel/config.tmp
>   QUOTE   arch/um/kernel/config.c
>   CC      arch/um/kernel/config.o
>
> And I'm using knoppix, which is based on debian.
But with updated packages (i.e. unstable/testing). If the patch is so little 
and without downsides, there's no point in not merging it.
> From the error message, it seems to be complaining about the "a" command. 
> If you're using a really really really old version of sed, it might insist
> on a gratuitous line break before the line to be added.  (I know it did
> back in the 1970's, but I didn't think anything remotely modern had that
> limitation.) So try splitting the command in half like this:
>
> cmd_quote2 = sed -e '/CONFIG/{'          \
>                   -e 's/"CONFIG"\;/""/'        \
>                   -e 'r $(obj)/config.tmp'     \
>                   -e 'a \'                   \
>                   -e '""\;'                  \
>                   -e '}'                       \
>                   $< > $@
>
> I just tried that here and it behaved the same way as the other version,
> for me...
Ok, Rob, finish handling this issue this and email me the patch (with a 
suitable changelog) when it's ready.

Bye
-- 
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729
http://www.user-mode-linux.org/~blaisorblade




-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] Broken compiling under 2.6.12-rc2 on my machine

[Blaisorblade]

On Thursday 07 April 2005 12:57, Adrian Phillips wrote:
> >>>>> "Rob" == Rob Landley <rob@landley.net> writes:
>     >> > > > System is Debian Woody,
>     >> >
>     >> > Can you post your sed version? and Rob, can you then test it
>     >>
>     >> and fix the > code?
>     >>
>     >> GNU sed version 3.02
>
>     Rob> That said, the change I posted earlier would probably make it
>     Rob> work.  The question is, do we care?  Documentation/Changes
>     Rob> doesn't list a required sed version (even though other things
>     Rob> in the kernel build use it), but perhaps it should.
>
> Well, for Woody users there is always a backports sed - anyone using
> 2.6 with woody needs at least module-init-tools from backports so one
> more package won't matter, even though one could be compiling 2.6 on a
> 2.4 system.
This user hasn't root access. And the patch isn't difficult or problematic.
-- 
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729
http://www.user-mode-linux.org/~blaisorblade




-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] Broken compiling under 2.6.12-rc2 on my machine

[Blaisorblade]

On Thursday 07 April 2005 08:50, Rob Landley wrote:
> On Wednesday 06 April 2005 03:36 pm, Blaisorblade wrote:
> > Anyway, from looking at what you quote, it's identical to the code in
> > arch/um/kernel/Makefile. Quoting the correct code:
> >
> > quiet_cmd_quote2 = QUOTE   $@
> > cmd_quote2 = sed -e '/CONFIG/{'          \
> >                   -e 's/"CONFIG"\;/""/'        \
> >                   -e 'r $(obj)/config.tmp'     \
> >                   -e 'a""\;'                   \
> >                   -e '}'                       \
> >                   $< > $@
Btw, can you please explain me why both you and me didn't notice that 
config.tmp is not needed? Yesterday while at bed I thought to the world 
"pipe" and achieved enlightenment... Am I missing something?

I'll send the patch, unless I get a NACK.
-- 
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729
http://www.user-mode-linux.org/~blaisorblade




-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] Broken compiling under 2.6.12-rc2 on my machine

[Ian McDonald]

OK.

Tested this change to arch/um/kernel/Makefile:
cmd_quote2 = sed -e '/CONFIG/{'          \
                 -e 's/"CONFIG"\;/""/'        \
                 -e 'r $(obj)/config.tmp'     \
                 -e 'a \'                   \
                 -e '""\;'                  \
                 -e '}'                       \
                 $< > $@

and can report that it fixes my problems.

I can also report that vacopy patch works (which is also in 2.6.11.7 I
notice but I haven't tested yet - I will post a note when I have but
that may be next week) and syscall patch works (which is not yet in
2.6.11.x).

Paolo I agree from my angle that this should go forwards as a confirmed patch.

Thanks everybody for your support. I wish that I was running something
more recent than Debian woody but it is still the latest "official"
Debian. I'm sure that your fixes will help other users also.

Regards,

Ian

On Apr 8, 2005 6:22 AM, Blaisorblade <blaisorblade@yahoo.it> wrote:
> On Thursday 07 April 2005 08:50, Rob Landley wrote:
> > On Wednesday 06 April 2005 03:36 pm, Blaisorblade wrote:
> > > Anyway, from looking at what you quote, it's identical to the code in
> > > arch/um/kernel/Makefile. Quoting the correct code:
> > >
> > > quiet_cmd_quote2 = QUOTE   $@
> > > cmd_quote2 = sed -e '/CONFIG/{'          \
> > >                   -e 's/"CONFIG"\;/""/'        \
> > >                   -e 'r $(obj)/config.tmp'     \
> > >                   -e 'a""\;'                   \
> > >                   -e '}'                       \
> > >                   $< > $@
> Btw, can you please explain me why both you and me didn't notice that
> config.tmp is not needed? Yesterday while at bed I thought to the world
> "pipe" and achieved enlightenment... Am I missing something?
> 
> I'll send the patch, unless I get a NACK.
> --
> Paolo Giarrusso, aka Blaisorblade
> Linux registered user n. 292729
> http://www.user-mode-linux.org/~blaisorblade
> 
>


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] Broken compiling under 2.6.12-rc2 on my machine

[Rob Landley]

On Thursday 07 April 2005 02:19 pm, Blaisorblade wrote:

> >   CHK     usr/initramfs_list
> >   QUOTE   arch/um/kernel/config.tmp
> >   QUOTE   arch/um/kernel/config.c
> >   CC      arch/um/kernel/config.o
> >
> > And I'm using knoppix, which is based on debian.
>
> But with updated packages (i.e. unstable/testing). If the patch is so
> little and without downsides, there's no point in not merging it.

Agreed.

> > From the error message, it seems to be complaining about the "a" command.
> > If you're using a really really really old version of sed, it might
> > insist on a gratuitous line break before the line to be added.  (I know
> > it did back in the 1970's, but I didn't think anything remotely modern
> > had that limitation.) So try splitting the command in half like this:
> >
> > cmd_quote2 = sed -e '/CONFIG/{'          \
> >                   -e 's/"CONFIG"\;/""/'        \
> >                   -e 'r $(obj)/config.tmp'     \
> >                   -e 'a \'                   \
> >                   -e '""\;'                  \
> >                   -e '}'                       \
> >                   $< > $@
> >
> > I just tried that here and it behaved the same way as the other version,
> > for me...
>
> Ok, Rob, finish handling this issue this and email me the patch (with a
> suitable changelog) when it's ready.

Just waiting to hear back from Ian that it does indeed fix the problem, and I 
see a reply from further down the list...

Rob


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] Broken compiling under 2.6.12-rc2 on my machine

[Rob Landley]

On Thursday 07 April 2005 02:22 pm, Blaisorblade wrote:
> On Thursday 07 April 2005 08:50, Rob Landley wrote:
> > On Wednesday 06 April 2005 03:36 pm, Blaisorblade wrote:
> > > Anyway, from looking at what you quote, it's identical to the code in
> > > arch/um/kernel/Makefile. Quoting the correct code:
> > >
> > > quiet_cmd_quote2 = QUOTE   $@
> > > cmd_quote2 = sed -e '/CONFIG/{'          \
> > >                   -e 's/"CONFIG"\;/""/'        \
> > >                   -e 'r $(obj)/config.tmp'     \
> > >                   -e 'a""\;'                   \
> > >                   -e '}'                       \
> > >                   $< > $@
>
> Btw, can you please explain me why both you and me didn't notice that
> config.tmp is not needed? Yesterday while at bed I thought to the world
> "pipe" and achieved enlightenment... Am I missing something?
>
> I'll send the patch, unless I get a NACK.

If you can get the sed "r" command to read from a pipe, by my guest.  (I 
mentioned originally that there was probably a cleaner way to do it, but I 
wasn't seeing it at the time...)

Rob


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] Broken compiling under 2.6.12-rc2 on my machine

[Blaisorblade]

[-- Attachment #1: Type: text/plain, Size: 1391 bytes --]

On Friday 08 April 2005 01:21, Ian McDonald wrote:
> OK.
>
> Tested this change to arch/um/kernel/Makefile:
> cmd_quote2 = sed -e '/CONFIG/{'          \
>                  -e 's/"CONFIG"\;/""/'        \
>                  -e 'r $(obj)/config.tmp'     \
>                  -e 'a \'                   \
>                  -e '""\;'                  \
>                  -e '}'                       \
>                  $< > $@
>
> and can report that it fixes my problems.
>
> I can also report that vacopy patch works (which is also in 2.6.11.7 I
> notice but I haven't tested yet - I will post a note when I have but
> that may be next week) and syscall patch works (which is not yet in
> 2.6.11.x).
Test it from -bs3, please.
> Paolo I agree from my angle that this should go forwards as a confirmed
> patch.
Please make sure that the attached patch produces the same makefile as the 
manual change you did (yes, I'm a bit overzealous maybe, but copy and paste 
isn't perfect from mailers, patches are much better).

For me, I tested it on my Gentoo and produces the same output as the unpatched 
code.

Ah, Rob, I've re-read the code and re-understood pipes are not enough, and we 
must keep the temp step. Sorry (even if I blamed both, so I hope I've not 
been impolite).
-- 
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729
http://www.user-mode-linux.org/~blaisorblade

[-- Attachment #2: uml-workaround-sed-behaviour.patch --]
[-- Type: text/x-diff, Size: 1028 bytes --]


From: Rob Landley <rob@landley.net>

It is apparent that the sed 3.02 (from august 1998) is still used on Debian Woody, and
it is stricter on input expressions for the "a" command. So change the code to
make it work - it's not a big change.

Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
---

 linux-2.6.11-paolo/arch/um/kernel/Makefile |    3 ++-
 1 files changed, 2 insertions(+), 1 deletion(-)

diff -puN arch/um/kernel/Makefile~uml-workaround-sed-behaviour arch/um/kernel/Makefile
--- linux-2.6.11/arch/um/kernel/Makefile~uml-workaround-sed-behaviour	2005-04-08 07:00:07.000000000 +0200
+++ linux-2.6.11-paolo/arch/um/kernel/Makefile	2005-04-08 07:05:40.000000000 +0200
@@ -53,6 +53,7 @@ quiet_cmd_quote2 = QUOTE   $@
       cmd_quote2 = sed -e '/CONFIG/{'          \
 		  -e 's/"CONFIG"\;/""/'        \
 		  -e 'r $(obj)/config.tmp'     \
-		  -e 'a""\;'                   \
+		  -e 'a \'                     \
+		  -e '""\;'                    \
 		  -e '}'                       \
 		  $< > $@
_

[uml-devel] [patch] Fix broken compiling under 2.6.12-rc2 with sed 3.02

[Rob Landley]

Old versions of sed from 1998 (predating the first release of gcc 2.95, but 
still in use by debian stable) don't understand the single-line version of 
the sed append command.  Since newer versions of sed still understand the... 
ahem, "vintage" form of the command, change it to use that.

Signed-off-by: Rob Landley <rob@landley.net>
Acked-by: Ian McDonald <imcdnzl@gmail.com>

--- linux-2.6.11.old/arch/um/kernel/Makefile	2005-04-08 01:06:15.000000000 
-0400
+++ linux-2.6.11/arch/um/kernel/Makefile	2005-04-08 01:08:44.000000000 -0400
@@ -53,6 +53,7 @@
       cmd_quote2 = sed -e '/CONFIG/{'          \
 		  -e 's/"CONFIG"\;/""/'        \
 		  -e 'r $(obj)/config.tmp'     \
-		  -e 'a""\;'                   \
+		  -e 'a \'                     \
+		  -e '""\;'                    \
 		  -e '}'                       \
 		  $< > $@


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] Broken compiling under 2.6.12-rc2 on my machine

[Rob Landley]

On Friday 08 April 2005 12:59 am, Rob Landley wrote:

> If you can get the sed "r" command to read from a pipe, by my guest.  (I
> mentioned originally that there was probably a cleaner way to do it, but I
> wasn't seeing it at the time...)

P.S.  I terms of mentioning my obligatory "really disgusting solution to an 
otherwise seemingly impossible problem", I'd like to point to the existence 
of "/proc/self/fd/0".

But in comparison, the temp file doesn't really look all that bad... :)

Rob


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] [patch] Fix broken compiling under 2.6.12-rc2 with sed 3.02

[Blaisorblade]

On Friday 08 April 2005 07:26, Rob Landley wrote:
> Old versions of sed from 1998 (predating the first release of gcc 2.95, but
> still in use by debian stable) don't understand the single-line version of
> the sed append command.  Since newer versions of sed still understand
> the... ahem, "vintage" form of the command, change it to use that.
>
> Signed-off-by: Rob Landley <rob@landley.net>
> Acked-by: Ian McDonald <imcdnzl@gmail.com>
>
> --- linux-2.6.11.old/arch/um/kernel/Makefile	2005-04-08 01:06:15.000000000
> -0400

Note that your mailer wrapper the patch (only the first line), the saved file 
is wrapped like above. And Kmail doesn't mangle inline patches on saving 
(I've tested it multiple times). If you can't fix this, next time use 
attachments (with display as inline) with "7bit" encoding (i.e. not encoded).

> +++ linux-2.6.11/arch/um/kernel/Makefile	2005-04-08 01:08:44.000000000
> -0400 @@ -53,6 +53,7 @@
>        cmd_quote2 = sed -e '/CONFIG/{'          \
>  		  -e 's/"CONFIG"\;/""/'        \
>  		  -e 'r $(obj)/config.tmp'     \
> -		  -e 'a""\;'                   \
> +		  -e 'a \'                     \
> +		  -e '""\;'                    \
>  		  -e '}'                       \
>  		  $< > $@

Ok, it's the same I diffed, I'm using your log and queueing for the next 
merge. It'll be in -bs3.
-- 
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729
http://www.user-mode-linux.org/~blaisorblade




-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] Broken compiling under 2.6.12-rc2 on my machine

[Blaisorblade]

On Friday 08 April 2005 07:46, Rob Landley wrote:
> On Friday 08 April 2005 12:59 am, Rob Landley wrote:
> > If you can get the sed "r" command to read from a pipe, by my guest.  (I
> > mentioned originally that there was probably a cleaner way to do it, but
> > I wasn't seeing it at the time...)
>
> P.S.  I terms of mentioning my obligatory "really disgusting solution to an
> otherwise seemingly impossible problem", I'd like to point to the existence
> of "/proc/self/fd/0".
I was thinking to it too... but it wouldn't work... ouch, it would! Ok, sed is 
not reading from stdin but from a file...
> But in comparison, the temp file doesn't really look all that bad... :)
Hmm, instead I prefer this rather than the tmp file. However it's not that 
important, after all.
-- 
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729
http://www.user-mode-linux.org/~blaisorblade




-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] [patch] Fix broken compiling under 2.6.12-rc2 with sed 3.02

[Rob Landley]

On Friday 08 April 2005 02:56 am, Blaisorblade wrote:
> On Friday 08 April 2005 07:26, Rob Landley wrote:
> > Old versions of sed from 1998 (predating the first release of gcc 2.95,
> > but still in use by debian stable) don't understand the single-line
> > version of the sed append command.  Since newer versions of sed still
> > understand the... ahem, "vintage" form of the command, change it to use
> > that.
> >
> > Signed-off-by: Rob Landley <rob@landley.net>
> > Acked-by: Ian McDonald <imcdnzl@gmail.com>
> >
> > --- linux-2.6.11.old/arch/um/kernel/Makefile	2005-04-08
> > 01:06:15.000000000 -0400
>
> Note that your mailer wrapper the patch (only the first line), the saved
> file is wrapped like above. And Kmail doesn't mangle inline patches on
> saving (I've tested it multiple times). If you can't fix this, next time
> use attachments (with display as inline) with "7bit" encoding (i.e. not
> encoded).

Sigh.  I forgot to turn off wordwrap from the pulldown menu.  Long day...

Rob


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Re: [uml-devel] Broken compiling under 2.6.12-rc2 on my machine

[Rob Landley]

On Friday 08 April 2005 02:59 am, Blaisorblade wrote:
> > P.S.  I terms of mentioning my obligatory "really disgusting solution to
> > an otherwise seemingly impossible problem", I'd like to point to the
> > existence of "/proc/self/fd/0".
>
> I was thinking to it too... but it wouldn't work... ouch, it would! Ok, sed
> is not reading from stdin but from a file...
>
> > But in comparison, the temp file doesn't really look all that bad... :)
>
> Hmm, instead I prefer this rather than the tmp file. However it's not that
> important, after all.

Does the linux kernel build require /proc to be mounted?  It's a bit on the 
brittle side for me to be happy with.  The temp file is ugly, but robust...

Rob


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel