From: "Abhinav Gupta" <mail@abhinavg.net>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: "Phillip Wood" <phillip.wood123@gmail.com>,
git@vger.kernel.org, "Derrick Stolee" <stolee@gmail.com>
Subject: Re: [PATCH] rebase: ignore non-branch update-refs
Date: Sun, 10 May 2026 17:33:34 -0700 [thread overview]
Message-ID: <cc21dea8-2184-4db9-9aaf-6cd6910095f8@app.fastmail.com> (raw)
In-Reply-To: <xmqqmry6x0dm.fsf@gitster.g>
On Sun, May 10, 2026, at 17:20, Junio C Hamano wrote:
> I smell that you'd be suggesting to replace the patch we have
> discussed with another one that declares that it is a bug to use %d
> in insn format? I do not think how well it would fly.
No, I didn't meant to imply that. I'm happy with the patch as-is.
Using %d in insn format is desirable, and I would not try to remove that.
I ran into this issue because of my own use of %d in insn format.
I was sharing an additional example for how this currently misbehaves:
not only does it generate the 'update-ref HEAD' in interactive contexts,
but it also breaks all non-interactive rebases with a non-empty todo list.
next prev parent reply other threads:[~2026-05-11 0:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 2:39 [PATCH] rebase: ignore non-branch update-refs mail
2026-05-07 16:08 ` Phillip Wood
2026-05-08 1:58 ` [PATCH v2] " mail
2026-05-08 10:07 ` Phillip Wood
2026-05-10 22:41 ` [PATCH v3 0/1] " mail
2026-05-10 22:41 ` [PATCH v3 1/1] " mail
2026-05-10 1:11 ` [PATCH] " Junio C Hamano
2026-05-10 13:37 ` Phillip Wood
2026-05-10 23:37 ` Junio C Hamano
2026-05-11 0:15 ` Abhinav Gupta
2026-05-11 0:20 ` Junio C Hamano
2026-05-11 0:33 ` Abhinav Gupta [this message]
2026-05-12 15:10 ` Phillip Wood
2026-05-15 15:40 ` Phillip Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc21dea8-2184-4db9-9aaf-6cd6910095f8@app.fastmail.com \
--to=mail@abhinavg.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=phillip.wood123@gmail.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.