All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Abhinav Gupta" <mail@abhinavg.net>
Cc: "Phillip Wood" <phillip.wood123@gmail.com>,
	 git@vger.kernel.org, "Derrick Stolee" <stolee@gmail.com>
Subject: Re: [PATCH] rebase: ignore non-branch update-refs
Date: Mon, 11 May 2026 09:20:37 +0900	[thread overview]
Message-ID: <xmqqmry6x0dm.fsf@gitster.g> (raw)
In-Reply-To: <63e04828-5895-4deb-a698-5d6f494d23f3@app.fastmail.com> (Abhinav Gupta's message of "Sun, 10 May 2026 17:15:42 -0700")

"Abhinav Gupta" <mail@abhinavg.net> writes:

> On Sun, May 10, 2026, at 16:37, Junio C Hamano wrote:
>> it would have failed to work due to the "HEAD" thing, so even though
>> existing versions of Git may have added such local tags to the insn
>> sequence, it would not have been a workable configuration anyway.
>
> Yeah. One additional data point:
> non-interactive rebase is also broken under this configuration.
> Given a branch off main~1, it runs into the same issue:
>
>     $ git checkout -b foo main~1
>     $ git commit --allow-empty -m 'do things'
>     $ git rebase main
>       # ...
>     error: update-ref requires a fully qualified refname e.g. refs/heads/HEAD
>     error: invalid line 2: update-ref HEAD
>     You can fix this with 'git rebase --edit-todo' and then run 'git rebase --continue'.
>     Or you can abort the rebase with 'git rebase --abort'.
>
> I'm guessing non-interactive rebase works off the same todo list so that makes sense.

I smell that you'd be suggesting to replace the patch we have
discussed with another one that declares that it is a bug to use %d
in insn format?  I do not think how well it would fly.

  reply	other threads:[~2026-05-11  0:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-06  2:39 [PATCH] rebase: ignore non-branch update-refs mail
2026-05-07 16:08 ` Phillip Wood
2026-05-08  1:58 ` [PATCH v2] " mail
2026-05-08 10:07   ` Phillip Wood
2026-05-10 22:41   ` [PATCH v3 0/1] " mail
2026-05-10 22:41     ` [PATCH v3 1/1] " mail
2026-05-10  1:11 ` [PATCH] " Junio C Hamano
2026-05-10 13:37   ` Phillip Wood
2026-05-10 23:37     ` Junio C Hamano
2026-05-11  0:15       ` Abhinav Gupta
2026-05-11  0:20         ` Junio C Hamano [this message]
2026-05-11  0:33           ` Abhinav Gupta
2026-05-12 15:10         ` Phillip Wood
2026-05-15 15:40     ` Phillip Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqmry6x0dm.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=mail@abhinavg.net \
    --cc=phillip.wood123@gmail.com \
    --cc=stolee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.