From: "Teddy Astie" <teddy.astie@vates.tech>
To: "Jan Beulich" <jbeulich@suse.com>
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
"Roger Pau Monné" <roger.pau@citrix.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH 1/4] vtd: Move (un)map_vtd_domain_page to extern.h
Date: Wed, 22 Oct 2025 12:42:26 +0000 [thread overview]
Message-ID: <cc6aae2e-cbd4-4f5b-a558-5800a424e340@vates.tech> (raw)
In-Reply-To: <e8765029-3a8d-496d-a409-8e576618c1b8@suse.com>
Le 22/10/2025 à 12:28, Jan Beulich a écrit :
> On 22.10.2025 11:51, Teddy Astie wrote:
>> These functions are basically wrappers of map_domain_page;
>
> Given this, ...
>
>> move
>> them to the shared extern.h and make them inline to help with code
>> generation.
>
> ... rather than moving can't we just drop them?
>
That would be better, but that's a larger set of changes
(map_vtd_domain_page uses maddr instead of mfn).
Ideally, we would want to change the code to use mfn directly and avoid
converting all around between mfn and maddr when refering to pages.
> Jan
--
Teddy Astie | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
next prev parent reply other threads:[~2025-10-22 12:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-22 9:51 [PATCH 0/4] Various IOMMU related simplifications Teddy Astie
2025-10-22 9:51 ` [PATCH 2/4] vtd: Collapse x86 subdirectory Teddy Astie
2025-10-22 10:13 ` Andrew Cooper
2025-10-22 12:09 ` Teddy Astie
2025-10-22 10:33 ` Jan Beulich
2025-10-22 9:51 ` [PATCH 1/4] vtd: Move (un)map_vtd_domain_page to extern.h Teddy Astie
2025-10-22 9:58 ` Andrew Cooper
2025-10-22 10:27 ` Jan Beulich
2025-10-22 12:42 ` Teddy Astie [this message]
2025-10-22 9:51 ` [PATCH 3/4] vtd: Remove IO_xAPIC_route_entry macro Teddy Astie
2025-10-22 10:15 ` Andrew Cooper
2025-10-22 9:51 ` [PATCH 4/4] x86/ioapic: Don't open-code 32-bits rte reads Teddy Astie
2025-10-22 10:22 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc6aae2e-cbd4-4f5b-a558-5800a424e340@vates.tech \
--to=teddy.astie@vates.tech \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.