From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Teddy Astie <teddy.astie@vates.tech>, xen-devel@lists.xenproject.org
Cc: "Jan Beulich" <jbeulich@suse.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH 4/4] x86/ioapic: Don't open-code 32-bits rte reads
Date: Wed, 22 Oct 2025 11:22:22 +0100 [thread overview]
Message-ID: <f99480af-a67c-4e7e-b191-06859b625cdb@citrix.com> (raw)
In-Reply-To: <819a011a32c608f4aefaf692aeac5ee47381a998.1761124632.git.teddy.astie@vates.tech>
On 22/10/2025 10:51 am, Teddy Astie wrote:
> diff --git a/xen/drivers/passthrough/vtd/intremap.c b/xen/drivers/passthrough/vtd/intremap.c
> index e0314aa469..3cdb892559 100644
> --- a/xen/drivers/passthrough/vtd/intremap.c
> +++ b/xen/drivers/passthrough/vtd/intremap.c
> @@ -399,7 +399,7 @@ unsigned int cf_check io_apic_read_remap_rte(
> unsigned int ioapic_pin = (reg - 0x10) / 2;
> int index;
> struct IO_APIC_route_entry old_rte = { };
> - int rte_upper = (reg & 1) ? 1 : 0;
> + unsigned int rte_upper = reg & 1;
bool?
But overall, a very nice cleanup.
~Andrew
prev parent reply other threads:[~2025-10-22 10:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-22 9:51 [PATCH 0/4] Various IOMMU related simplifications Teddy Astie
2025-10-22 9:51 ` [PATCH 3/4] vtd: Remove IO_xAPIC_route_entry macro Teddy Astie
2025-10-22 10:15 ` Andrew Cooper
2025-10-22 9:51 ` [PATCH 1/4] vtd: Move (un)map_vtd_domain_page to extern.h Teddy Astie
2025-10-22 9:58 ` Andrew Cooper
2025-10-22 10:27 ` Jan Beulich
2025-10-22 12:42 ` Teddy Astie
2025-10-22 9:51 ` [PATCH 2/4] vtd: Collapse x86 subdirectory Teddy Astie
2025-10-22 10:13 ` Andrew Cooper
2025-10-22 12:09 ` Teddy Astie
2025-10-22 10:33 ` Jan Beulich
2025-10-22 9:51 ` [PATCH 4/4] x86/ioapic: Don't open-code 32-bits rte reads Teddy Astie
2025-10-22 10:22 ` Andrew Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f99480af-a67c-4e7e-b191-06859b625cdb@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=teddy.astie@vates.tech \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.