From: Jiri Slaby <jirislaby@kernel.org>
To: "Biju Das" <biju.das.jz@bp.renesas.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial <linux-serial@vger.kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v3 3/3] serial: 8250_em: Add serial_out() to struct serial8250_em_hw_info
Date: Mon, 13 Feb 2023 10:10:47 +0100 [thread overview]
Message-ID: <cc7f4d69-7e68-0d0a-4b89-c4e16dff716b@kernel.org> (raw)
In-Reply-To: <OS0PR01MB5922A860B77A9BC0C9E5E3AC86DD9@OS0PR01MB5922.jpnprd01.prod.outlook.com>
On 13. 02. 23, 9:53, Biju Das wrote:
>>> +static void serial8250_rzv2m_reg_update(struct uart_port *p, int off,
>>> +int value) {
>>> + unsigned int ier, fcr, lcr, mcr, hcr0;
>>> +
>>> + ier = serial8250_em_serial_in(p, UART_IER);
>>> + lcr = serial8250_em_serial_in(p, UART_LCR);
>>> + mcr = serial8250_em_serial_in(p, UART_MCR);
>>> + hcr0 = serial8250_em_serial_in(p, UART_HCR0);
>>> + /*
>>> + * The value of UART_IIR and UART_FCR are 2, but corresponding
>>> + * RZ/V2M address offset are different(0x08 and 0x0c). So we need to
>>> + * use readl() here.
>>> + */
>>> + fcr = readl(p->membase + ((UART_FCR + 1) << 2));
>>
>> I don't get the meaning of that comment. It doesn't seem to match what your
>> code does as the code seemingly has nothing to do with IIR (and none of you
>> changelogs refer to IIR either)?
>
> The generic macro UART_IIR and UART_FCR in linux/serial_reg.h has a value of 2.
Sure, IIR is normally WO and FCR RO and share the same register. I would
simply define UART_FCR_RZ (or alike) for 0x12.
--
js
suse labs
next prev parent reply other threads:[~2023-02-13 9:10 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 20:34 [PATCH v3 0/3] Update Renesas RZ/V2M UART Port type Biju Das
2023-02-10 20:34 ` [PATCH v3 1/3] serial: 8250_em: Use dev_err_probe() Biju Das
2023-02-13 6:23 ` Jiri Slaby
2023-02-14 11:07 ` Biju Das
2023-02-10 20:34 ` [PATCH v3 2/3] serial: 8250_em: Update RZ/V2M port type as PORT_16750 Biju Das
2023-02-12 11:02 ` Andy Shevchenko
2023-02-13 6:26 ` Jiri Slaby
2023-02-13 16:02 ` Biju Das
2023-02-10 20:34 ` [PATCH v3 3/3] serial: 8250_em: Add serial_out() to struct serial8250_em_hw_info Biju Das
2023-02-12 11:09 ` Andy Shevchenko
2023-02-13 8:42 ` Ilpo Järvinen
2023-02-13 8:53 ` Biju Das
2023-02-13 9:10 ` Jiri Slaby [this message]
2023-02-13 9:12 ` Jiri Slaby
2023-02-13 9:14 ` Jiri Slaby
2023-02-13 9:31 ` Biju Das
2023-02-13 9:32 ` Jiri Slaby
2023-02-13 11:12 ` Biju Das
2023-02-13 11:31 ` Ilpo Järvinen
2023-02-13 11:40 ` Biju Das
2023-02-13 12:05 ` Ilpo Järvinen
2023-02-13 12:18 ` Biju Das
2023-02-13 16:06 ` Biju Das
2023-02-13 9:57 ` Niklas Söderlund
2023-02-13 10:06 ` Biju Das
2023-02-13 10:29 ` Niklas Söderlund
2023-02-13 13:01 ` Biju Das
2023-02-13 14:09 ` Niklas Söderlund
2023-02-13 14:26 ` Biju Das
2023-02-13 9:22 ` Ilpo Järvinen
2023-02-13 9:28 ` Jiri Slaby
2023-02-13 9:40 ` Ilpo Järvinen
2023-02-13 9:53 ` Jiri Slaby
2023-02-13 9:12 ` Ilpo Järvinen
2023-02-13 8:37 ` [PATCH v3 0/3] Update Renesas RZ/V2M UART Port type Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc7f4d69-7e68-0d0a-4b89-c4e16dff716b@kernel.org \
--to=jirislaby@kernel.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=fabrizio.castro.jz@renesas.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.