Re: [PATCH v13 1/2] dt-bindings: phy: qcom: Add CSI2 C-PHY/DPHY schema

From: Bryan O'Donoghue <bod@kernel.org>
To: Frank Li <Frank.li@oss.nxp.com>,
	Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Cc: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Subject: Re: [PATCH v13 1/2] dt-bindings: phy: qcom: Add CSI2 C-PHY/DPHY schema
Date: Wed, 22 Jul 2026 02:53:10 +0100	[thread overview]
Message-ID: <cc9b087c-b985-416c-999a-a08f2abbf202@kernel.org> (raw)
In-Reply-To: <amAaKalbD749uZuK@SMW015318>

On 22/07/2026 02:17, Frank Li wrote:
>> Such design has a number of flaws and in general it looks overly
>> complicated. From the beginning it's unclear how to distinguish
>> a clock lane from a data lane, how to specify lane frequencies etc.
> Thanks, but phy-cell support more than one argument. like
> 
> 	<&phy 0 mode_cphy link_freq>
> 
> I ask these because simiar other phys may connect to display panel, some
> phys combine csi and dsi together.

For a combined CSI/DSI PHY that's a good model, and it re-establishes
the principle that the consumer chooses the mode.

For our simpler camera-only case the cell has less work to do. The
series carries #phy-cells = 1 per Rob's feedback and an RB from Krzysztof.

That's reviewed, tested and mergeable.

The one alternative under discussion with Vinod is bus-type in the CSID 
controller's endpoint with the mode conveyed via phy_configure(). Either 
way the consumer decides.

---
bod