* [PATCH v2] wifi: iwlwifi: pcie: add support for AX101NGW
@ 2023-01-06 5:05 Aiden Leong
2023-01-19 15:24 ` Greenman, Gregory
0 siblings, 1 reply; 2+ messages in thread
From: Aiden Leong @ 2023-01-06 5:05 UTC (permalink / raw)
To: linux-wireless
Cc: gregory.greenman, kvalo, davem, edumazet, kuba, pabeni,
Aiden Leong
Fix a bug introduced by:
commit 32ed101aa140 ("iwlwifi: convert all Qu with Jf devices to the new
config table"), so now we pick the FIRST matching config.
Signed-off-by: Aiden Leong <aiden.leong@aibsd.com>
---
I split patchset v1 to two standalone patches, since there are not that
strongly related to each other.
---
drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
index a46df1320372..5d74adbd49cf 100644
--- a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
+++ b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
@@ -1461,7 +1461,7 @@ iwl_pci_find_dev_info(u16 device, u16 subsystem_device,
if (!num_devices)
return NULL;
- for (i = num_devices - 1; i >= 0; i--) {
+ for (i = 0; i < num_devices; i++) {
const struct iwl_dev_info *dev_info = &iwl_dev_info_table[i];
if (dev_info->device != (u16)IWL_CFG_ANY &&
--
2.39.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2] wifi: iwlwifi: pcie: add support for AX101NGW
2023-01-06 5:05 [PATCH v2] wifi: iwlwifi: pcie: add support for AX101NGW Aiden Leong
@ 2023-01-19 15:24 ` Greenman, Gregory
0 siblings, 0 replies; 2+ messages in thread
From: Greenman, Gregory @ 2023-01-19 15:24 UTC (permalink / raw)
To: linux-wireless@vger.kernel.org, aiden.leong@aibsd.com
Cc: kvalo@kernel.org, edumazet@google.com, davem@davemloft.net,
kuba@kernel.org, pabeni@redhat.com
On Fri, 2023-01-06 at 13:05 +0800, Aiden Leong wrote:
> Fix a bug introduced by:
> commit 32ed101aa140 ("iwlwifi: convert all Qu with Jf devices to the new
> config table"), so now we pick the FIRST matching config.
>
> Signed-off-by: Aiden Leong <aiden.leong@aibsd.com>
> ---
>
> I split patchset v1 to two standalone patches, since there are not that
> strongly related to each other.
>
> ---
> drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
> index a46df1320372..5d74adbd49cf 100644
> --- a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
> +++ b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
> @@ -1461,7 +1461,7 @@ iwl_pci_find_dev_info(u16 device, u16 subsystem_device,
> if (!num_devices)
> return NULL;
>
> - for (i = num_devices - 1; i >= 0; i--) {
> + for (i = 0; i < num_devices; i++) {
> const struct iwl_dev_info *dev_info = &iwl_dev_info_table[i];
>
> if (dev_info->device != (u16)IWL_CFG_ANY &&
The fix is ok, but please update the subject... It's not only for this specific
device, but just fixing the order of scanning iwl_dev_info_table.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-19 15:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-06 5:05 [PATCH v2] wifi: iwlwifi: pcie: add support for AX101NGW Aiden Leong
2023-01-19 15:24 ` Greenman, Gregory
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.