From: Julien Olivain <ju.o@free.fr>
To: "Sébastien Szymanski" <sebastien.szymanski@armadeus.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/imx-firmware: new package
Date: Tue, 23 Apr 2024 21:30:21 +0200 [thread overview]
Message-ID: <cdcbd51bff3cf4e008ccde21d573dd80@free.fr> (raw)
In-Reply-To: <20240419154635.29601-1-sebastien.szymanski@armadeus.com>
Hi Sebastien,
Thanks for your patch!
On 19/04/2024 17:46, Sébastien Szymanski wrote:
> This package provides firmwares for NXP WiFi + Bluetooth chipsets.
I would like to point out that there is already another package called
"firmware-imx" in [1]. While it does provide firmwares for i.MX SoCs,
it is a different set of firmwares compared to this
"imx-firmware" you are proposing. This is a bit unfortunate as the
names are directly coming from NXP.
If you agree with my proposals below, you can add:
Reviewed-by: Julien Olivain <ju.o@free.fr>
> Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
> ---
> package/Config.in | 1 +
> package/imx-firmware/Config.in | 62 ++++++++++++++++++++++++++
> package/imx-firmware/imx-firmware.hash | 3 ++
> package/imx-firmware/imx-firmware.mk | 32 +++++++++++++
> 4 files changed, 98 insertions(+)
> create mode 100644 package/imx-firmware/Config.in
> create mode 100644 package/imx-firmware/imx-firmware.hash
> create mode 100644 package/imx-firmware/imx-firmware.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 1935077f0f45..3ecceefef4ec 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -450,6 +450,7 @@ menu "Firmware"
> source "package/armbian-firmware/Config.in"
> source "package/b43-firmware/Config.in"
> source "package/brcmfmac_sdio-firmware-rpi/Config.in"
> + source "package/imx-firmware/Config.in"
To keep some consistency within the Buildroot tree (and with upstream),
I suggest to move this "imx-firmware" package alongside the other, in
the "package/freescale-imx" directory. Maybe one day, we'll rename this
directory to "package/nxp-imx".
> source "package/linux-firmware/Config.in"
> source "package/murata-cyw-fw/Config.in"
> source "package/odroidc2-firmware/Config.in"
> diff --git a/package/imx-firmware/Config.in
> b/package/imx-firmware/Config.in
> new file mode 100644
> index 000000000000..d2037b270865
> --- /dev/null
> +++ b/package/imx-firmware/Config.in
> @@ -0,0 +1,62 @@
> +config BR2_PACKAGE_IMX_FIRMWARE
> + bool "imx-firmware"
> + help
> + Firmware for NXP Bluetooth / WiFi chipsets based modules
Moreover, to avoid confusion, could you add a note here like:
"""
Note: there is also a firmware-imx package containing another set of
firmwares for SDMA, VPU, HDMI, EDPC and DDR training.
"""
Finally, this patch could also add the opposite note in the
"firmware-imx" Kconfig help, like:
"""
Note: for NXP Bluetooth / WiFi chipsets, see the imx-firmware package.
"""
> +
> + https://github.com/nxp-imx/imx-firmware
> +
> +if BR2_PACKAGE_IMX_FIRMWARE
> +
> +config BR2_PACKAGE_IMX_FIRMWARE_8801
> + bool "8801 (SD)"
> + help
> + NXP 8801 module firmware files.
> +
> +config BR2_PACKAGE_IMX_FIRMWARE_8987
> + bool "8987 (SD)"
> + help
> + NXP 8987 module firmware files.
> +
> +config BR2_PACKAGE_IMX_FIRMWARE_8997
> + bool "8997"
> + help
> + NXP 8997 module firmware files.
> +
> +choice
> + prompt "8997 WiFi interface" if BR2_PACKAGE_IMX_FIRMWARE_8997
> +
> +config BR2_PACKAGE_IMX_FIRMWARE_8997_SD
> + bool "SD"
> +
> +config BR2_PACKAGE_IMX_FIRMWARE_8997_PCIE
> + bool "PCIe"
> +
> +endchoice
> +
> +config BR2_PACKAGE_IMX_FIRMWARE_9098
> + bool "9098"
> + help
> + NXP 9098 module firmware files.
> +
> +choice
> + prompt "9098 WiFi interface" if BR2_PACKAGE_IMX_FIRMWARE_9098
> +
> +config BR2_PACKAGE_IMX_FIRMWARE_9098_SD
> + bool "SD"
> +
> +config BR2_PACKAGE_IMX_FIRMWARE_9098_PCIE
> + bool "PCIe"
> +
> +endchoice
> +
> +config BR2_PACKAGE_IMX_FIRMWARE_IW416
> + bool "IW416 (SD)"
> + help
> + NXP IW416 module firmware files.
> +
> +config BR2_PACKAGE_IMX_FIRMWARE_IW612
> + bool "IW612 (SD)"
> + help
> + NXP IW612 module firmware files.
> +
> +endif
> diff --git a/package/imx-firmware/imx-firmware.hash
> b/package/imx-firmware/imx-firmware.hash
> new file mode 100644
> index 000000000000..323130d7c690
> --- /dev/null
> +++ b/package/imx-firmware/imx-firmware.hash
> @@ -0,0 +1,3 @@
> +# Locally calculated
> +sha256
> 2feba2969db7b6fc86aa0a13a0993ca241e155c23c0024c41316e67924778f5f
> imx-firmware-lf-6.6.3_1.0.0.tar.gz
> +sha256
> 3827bf3548bfd9de73bf51fbdd7a8c674dcecfb249cfa1a7cf17bd2dc4e08a8c
> LICENSE.txt
> diff --git a/package/imx-firmware/imx-firmware.mk
> b/package/imx-firmware/imx-firmware.mk
> new file mode 100644
> index 000000000000..8b5c3fb4a5d5
> --- /dev/null
> +++ b/package/imx-firmware/imx-firmware.mk
> @@ -0,0 +1,32 @@
> +################################################################################
> +#
> +# imx-firmware
> +#
> +################################################################################
> +
> +IMX_FIRMWARE_VERSION = lf-6.6.3_1.0.0
> +IMX_FIRMWARE_SITE = $(call
> github,nxp-imx,imx-firmware,$(IMX_FIRMWARE_VERSION))
> +IMX_FIRMWARE_LICENSE = NXP Software License Agreement
> +IMX_FIRMWARE_LICENSE_FILES = LICENSE.txt
> +IMX_FIRMWARE_REDISTRIBUTE = NO
> +
> +IMX_FIRMWARE_FILES_$(BR2_PACKAGE_IMX_FIRMWARE_8801) += FwImage_8801_SD
> +IMX_FIRMWARE_FILES_$(BR2_PACKAGE_IMX_FIRMWARE_8987) += FwImage_8987
> +IMX_FIRMWARE_FILES_$(BR2_PACKAGE_IMX_FIRMWARE_8997_SD) +=
> FwImage_8997_SD
> +IMX_FIRMWARE_FILES_$(BR2_PACKAGE_IMX_FIRMWARE_8997_PCIE) +=
> FwImage_8997
> +IMX_FIRMWARE_FILES_$(BR2_PACKAGE_IMX_FIRMWARE_9098_SD) +=
> FwImage_9098_SD
> +IMX_FIRMWARE_FILES_$(BR2_PACKAGE_IMX_FIRMWARE_9098_PCIE) +=
> FwImage_9098_PCIE
> +IMX_FIRMWARE_FILES_$(BR2_PACKAGE_IMX_FIRMWARE_IW416) +=
> FwImage_IW416_SD
> +IMX_FIRMWARE_FILES_$(BR2_PACKAGE_IMX_FIRMWARE_IW612) +=
> FwImage_IW612_SD
> +
> +define IMX_FIRMWARE_INSTALL_TARGET_CMDS
> + $(INSTALL) -m 0644 -D $(@D)/nxp/wifi_mod_para.conf \
> + $(TARGET_DIR)/lib/firmware/nxp/wifi_mod_para.conf
> + $(INSTALL) -m 0644 -D $(@D)/nxp/mfguart/helper_uart_3000000.bin \
> + $(TARGET_DIR)/lib/firmware/nxp/helper_uart_3000000.bin
> + $(foreach f,$(IMX_FIRMWARE_FILES_y), \
> + $(INSTALL) -m 0644 -D $(@D)/nxp/$(f)/*
> $(TARGET_DIR)/lib/firmware/nxp/
> + )
> +endef
> +
> +$(eval $(generic-package))
> --
> 2.43.2
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
Best regards,
Julien.
[1]
https://gitlab.com/buildroot.org/buildroot/-/tree/master/package/freescale-imx/firmware-imx
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-04-23 19:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 15:46 [Buildroot] [PATCH 1/1] package/imx-firmware: new package Sébastien Szymanski
2024-04-23 19:30 ` Julien Olivain [this message]
2024-04-23 19:58 ` Sébastien Szymanski
2024-04-24 11:55 ` Gilles Talis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cdcbd51bff3cf4e008ccde21d573dd80@free.fr \
--to=ju.o@free.fr \
--cc=buildroot@buildroot.org \
--cc=sebastien.szymanski@armadeus.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.