All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/imx-firmware: new package
@ 2024-04-19 15:46 Sébastien Szymanski
  2024-04-23 19:30 ` Julien Olivain
  0 siblings, 1 reply; 4+ messages in thread
From: Sébastien Szymanski @ 2024-04-19 15:46 UTC (permalink / raw)
  To: buildroot; +Cc: Thomas Petazzoni

This package provides firmwares for NXP WiFi + Bluetooth chipsets.

Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
---
 package/Config.in                      |  1 +
 package/imx-firmware/Config.in         | 62 ++++++++++++++++++++++++++
 package/imx-firmware/imx-firmware.hash |  3 ++
 package/imx-firmware/imx-firmware.mk   | 32 +++++++++++++
 4 files changed, 98 insertions(+)
 create mode 100644 package/imx-firmware/Config.in
 create mode 100644 package/imx-firmware/imx-firmware.hash
 create mode 100644 package/imx-firmware/imx-firmware.mk

diff --git a/package/Config.in b/package/Config.in
index 1935077f0f45..3ecceefef4ec 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -450,6 +450,7 @@ menu "Firmware"
 	source "package/armbian-firmware/Config.in"
 	source "package/b43-firmware/Config.in"
 	source "package/brcmfmac_sdio-firmware-rpi/Config.in"
+	source "package/imx-firmware/Config.in"
 	source "package/linux-firmware/Config.in"
 	source "package/murata-cyw-fw/Config.in"
 	source "package/odroidc2-firmware/Config.in"
diff --git a/package/imx-firmware/Config.in b/package/imx-firmware/Config.in
new file mode 100644
index 000000000000..d2037b270865
--- /dev/null
+++ b/package/imx-firmware/Config.in
@@ -0,0 +1,62 @@
+config BR2_PACKAGE_IMX_FIRMWARE
+	bool "imx-firmware"
+	help
+	  Firmware for NXP Bluetooth / WiFi chipsets based modules
+
+	  https://github.com/nxp-imx/imx-firmware
+
+if BR2_PACKAGE_IMX_FIRMWARE
+
+config BR2_PACKAGE_IMX_FIRMWARE_8801
+	bool "8801 (SD)"
+	help
+	  NXP 8801 module firmware files.
+
+config BR2_PACKAGE_IMX_FIRMWARE_8987
+	bool "8987 (SD)"
+	help
+	  NXP 8987 module firmware files.
+
+config BR2_PACKAGE_IMX_FIRMWARE_8997
+	bool "8997"
+	help
+	  NXP 8997 module firmware files.
+
+choice
+	prompt "8997 WiFi interface" if BR2_PACKAGE_IMX_FIRMWARE_8997
+
+config BR2_PACKAGE_IMX_FIRMWARE_8997_SD
+	bool "SD"
+
+config BR2_PACKAGE_IMX_FIRMWARE_8997_PCIE
+	bool "PCIe"
+
+endchoice
+
+config BR2_PACKAGE_IMX_FIRMWARE_9098
+	bool "9098"
+	help
+	  NXP 9098 module firmware files.
+
+choice
+	prompt "9098 WiFi interface" if BR2_PACKAGE_IMX_FIRMWARE_9098
+
+config BR2_PACKAGE_IMX_FIRMWARE_9098_SD
+	bool "SD"
+
+config BR2_PACKAGE_IMX_FIRMWARE_9098_PCIE
+	bool "PCIe"
+
+endchoice
+
+config BR2_PACKAGE_IMX_FIRMWARE_IW416
+	bool "IW416 (SD)"
+	help
+	  NXP IW416 module firmware files.
+
+config BR2_PACKAGE_IMX_FIRMWARE_IW612
+	bool "IW612 (SD)"
+	help
+	  NXP IW612 module firmware files.
+
+endif
diff --git a/package/imx-firmware/imx-firmware.hash b/package/imx-firmware/imx-firmware.hash
new file mode 100644
index 000000000000..323130d7c690
--- /dev/null
+++ b/package/imx-firmware/imx-firmware.hash
@@ -0,0 +1,3 @@
+# Locally calculated
+sha256  2feba2969db7b6fc86aa0a13a0993ca241e155c23c0024c41316e67924778f5f  imx-firmware-lf-6.6.3_1.0.0.tar.gz
+sha256  3827bf3548bfd9de73bf51fbdd7a8c674dcecfb249cfa1a7cf17bd2dc4e08a8c  LICENSE.txt
diff --git a/package/imx-firmware/imx-firmware.mk b/package/imx-firmware/imx-firmware.mk
new file mode 100644
index 000000000000..8b5c3fb4a5d5
--- /dev/null
+++ b/package/imx-firmware/imx-firmware.mk
@@ -0,0 +1,32 @@
+################################################################################
+#
+# imx-firmware
+#
+################################################################################
+
+IMX_FIRMWARE_VERSION = lf-6.6.3_1.0.0
+IMX_FIRMWARE_SITE = $(call github,nxp-imx,imx-firmware,$(IMX_FIRMWARE_VERSION))
+IMX_FIRMWARE_LICENSE = NXP Software License Agreement
+IMX_FIRMWARE_LICENSE_FILES = LICENSE.txt
+IMX_FIRMWARE_REDISTRIBUTE = NO
+
+IMX_FIRMWARE_FILES_$(BR2_PACKAGE_IMX_FIRMWARE_8801) += FwImage_8801_SD
+IMX_FIRMWARE_FILES_$(BR2_PACKAGE_IMX_FIRMWARE_8987) += FwImage_8987
+IMX_FIRMWARE_FILES_$(BR2_PACKAGE_IMX_FIRMWARE_8997_SD) += FwImage_8997_SD
+IMX_FIRMWARE_FILES_$(BR2_PACKAGE_IMX_FIRMWARE_8997_PCIE) += FwImage_8997
+IMX_FIRMWARE_FILES_$(BR2_PACKAGE_IMX_FIRMWARE_9098_SD) += FwImage_9098_SD
+IMX_FIRMWARE_FILES_$(BR2_PACKAGE_IMX_FIRMWARE_9098_PCIE) += FwImage_9098_PCIE
+IMX_FIRMWARE_FILES_$(BR2_PACKAGE_IMX_FIRMWARE_IW416) += FwImage_IW416_SD
+IMX_FIRMWARE_FILES_$(BR2_PACKAGE_IMX_FIRMWARE_IW612) += FwImage_IW612_SD
+
+define IMX_FIRMWARE_INSTALL_TARGET_CMDS
+	$(INSTALL) -m 0644 -D $(@D)/nxp/wifi_mod_para.conf \
+		$(TARGET_DIR)/lib/firmware/nxp/wifi_mod_para.conf
+	$(INSTALL) -m 0644 -D $(@D)/nxp/mfguart/helper_uart_3000000.bin \
+		$(TARGET_DIR)/lib/firmware/nxp/helper_uart_3000000.bin
+	$(foreach f,$(IMX_FIRMWARE_FILES_y), \
+		$(INSTALL) -m 0644 -D $(@D)/nxp/$(f)/* $(TARGET_DIR)/lib/firmware/nxp/
+	)
+endef
+
+$(eval $(generic-package))
-- 
2.43.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/imx-firmware: new package
  2024-04-19 15:46 [Buildroot] [PATCH 1/1] package/imx-firmware: new package Sébastien Szymanski
@ 2024-04-23 19:30 ` Julien Olivain
  2024-04-23 19:58   ` Sébastien Szymanski
  0 siblings, 1 reply; 4+ messages in thread
From: Julien Olivain @ 2024-04-23 19:30 UTC (permalink / raw)
  To: Sébastien Szymanski; +Cc: Thomas Petazzoni, buildroot

Hi Sebastien,

Thanks for your patch!

On 19/04/2024 17:46, Sébastien Szymanski wrote:
> This package provides firmwares for NXP WiFi + Bluetooth chipsets.

I would like to point out that there is already another package called
"firmware-imx" in [1]. While it does provide firmwares for i.MX SoCs,
it is a different set of firmwares compared to this
"imx-firmware" you are proposing. This is a bit unfortunate as the
names are directly coming from NXP.

If you agree with my proposals below, you can add:

Reviewed-by: Julien Olivain <ju.o@free.fr>

> Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
> ---
>  package/Config.in                      |  1 +
>  package/imx-firmware/Config.in         | 62 ++++++++++++++++++++++++++
>  package/imx-firmware/imx-firmware.hash |  3 ++
>  package/imx-firmware/imx-firmware.mk   | 32 +++++++++++++
>  4 files changed, 98 insertions(+)
>  create mode 100644 package/imx-firmware/Config.in
>  create mode 100644 package/imx-firmware/imx-firmware.hash
>  create mode 100644 package/imx-firmware/imx-firmware.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index 1935077f0f45..3ecceefef4ec 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -450,6 +450,7 @@ menu "Firmware"
>  	source "package/armbian-firmware/Config.in"
>  	source "package/b43-firmware/Config.in"
>  	source "package/brcmfmac_sdio-firmware-rpi/Config.in"
> +	source "package/imx-firmware/Config.in"

To keep some consistency within the Buildroot tree (and with upstream),
I suggest to move this "imx-firmware" package alongside the other, in
the "package/freescale-imx" directory. Maybe one day, we'll rename this
directory to "package/nxp-imx".

>  	source "package/linux-firmware/Config.in"
>  	source "package/murata-cyw-fw/Config.in"
>  	source "package/odroidc2-firmware/Config.in"
> diff --git a/package/imx-firmware/Config.in 
> b/package/imx-firmware/Config.in
> new file mode 100644
> index 000000000000..d2037b270865
> --- /dev/null
> +++ b/package/imx-firmware/Config.in
> @@ -0,0 +1,62 @@
> +config BR2_PACKAGE_IMX_FIRMWARE
> +	bool "imx-firmware"
> +	help
> +	  Firmware for NXP Bluetooth / WiFi chipsets based modules

Moreover, to avoid confusion, could you add a note here like:
"""
Note: there is also a firmware-imx package containing another set of
firmwares for SDMA, VPU, HDMI, EDPC and DDR training.
"""

Finally, this patch could also add the opposite note in the
"firmware-imx" Kconfig help, like:
"""
Note: for NXP Bluetooth / WiFi chipsets, see the imx-firmware package.
"""

> +
> +	  https://github.com/nxp-imx/imx-firmware
> +
> +if BR2_PACKAGE_IMX_FIRMWARE
> +
> +config BR2_PACKAGE_IMX_FIRMWARE_8801
> +	bool "8801 (SD)"
> +	help
> +	  NXP 8801 module firmware files.
> +
> +config BR2_PACKAGE_IMX_FIRMWARE_8987
> +	bool "8987 (SD)"
> +	help
> +	  NXP 8987 module firmware files.
> +
> +config BR2_PACKAGE_IMX_FIRMWARE_8997
> +	bool "8997"
> +	help
> +	  NXP 8997 module firmware files.
> +
> +choice
> +	prompt "8997 WiFi interface" if BR2_PACKAGE_IMX_FIRMWARE_8997
> +
> +config BR2_PACKAGE_IMX_FIRMWARE_8997_SD
> +	bool "SD"
> +
> +config BR2_PACKAGE_IMX_FIRMWARE_8997_PCIE
> +	bool "PCIe"
> +
> +endchoice
> +
> +config BR2_PACKAGE_IMX_FIRMWARE_9098
> +	bool "9098"
> +	help
> +	  NXP 9098 module firmware files.
> +
> +choice
> +	prompt "9098 WiFi interface" if BR2_PACKAGE_IMX_FIRMWARE_9098
> +
> +config BR2_PACKAGE_IMX_FIRMWARE_9098_SD
> +	bool "SD"
> +
> +config BR2_PACKAGE_IMX_FIRMWARE_9098_PCIE
> +	bool "PCIe"
> +
> +endchoice
> +
> +config BR2_PACKAGE_IMX_FIRMWARE_IW416
> +	bool "IW416 (SD)"
> +	help
> +	  NXP IW416 module firmware files.
> +
> +config BR2_PACKAGE_IMX_FIRMWARE_IW612
> +	bool "IW612 (SD)"
> +	help
> +	  NXP IW612 module firmware files.
> +
> +endif
> diff --git a/package/imx-firmware/imx-firmware.hash 
> b/package/imx-firmware/imx-firmware.hash
> new file mode 100644
> index 000000000000..323130d7c690
> --- /dev/null
> +++ b/package/imx-firmware/imx-firmware.hash
> @@ -0,0 +1,3 @@
> +# Locally calculated
> +sha256  
> 2feba2969db7b6fc86aa0a13a0993ca241e155c23c0024c41316e67924778f5f  
> imx-firmware-lf-6.6.3_1.0.0.tar.gz
> +sha256  
> 3827bf3548bfd9de73bf51fbdd7a8c674dcecfb249cfa1a7cf17bd2dc4e08a8c  
> LICENSE.txt
> diff --git a/package/imx-firmware/imx-firmware.mk 
> b/package/imx-firmware/imx-firmware.mk
> new file mode 100644
> index 000000000000..8b5c3fb4a5d5
> --- /dev/null
> +++ b/package/imx-firmware/imx-firmware.mk
> @@ -0,0 +1,32 @@
> +################################################################################
> +#
> +# imx-firmware
> +#
> +################################################################################
> +
> +IMX_FIRMWARE_VERSION = lf-6.6.3_1.0.0
> +IMX_FIRMWARE_SITE = $(call 
> github,nxp-imx,imx-firmware,$(IMX_FIRMWARE_VERSION))
> +IMX_FIRMWARE_LICENSE = NXP Software License Agreement
> +IMX_FIRMWARE_LICENSE_FILES = LICENSE.txt
> +IMX_FIRMWARE_REDISTRIBUTE = NO
> +
> +IMX_FIRMWARE_FILES_$(BR2_PACKAGE_IMX_FIRMWARE_8801) += FwImage_8801_SD
> +IMX_FIRMWARE_FILES_$(BR2_PACKAGE_IMX_FIRMWARE_8987) += FwImage_8987
> +IMX_FIRMWARE_FILES_$(BR2_PACKAGE_IMX_FIRMWARE_8997_SD) += 
> FwImage_8997_SD
> +IMX_FIRMWARE_FILES_$(BR2_PACKAGE_IMX_FIRMWARE_8997_PCIE) += 
> FwImage_8997
> +IMX_FIRMWARE_FILES_$(BR2_PACKAGE_IMX_FIRMWARE_9098_SD) += 
> FwImage_9098_SD
> +IMX_FIRMWARE_FILES_$(BR2_PACKAGE_IMX_FIRMWARE_9098_PCIE) += 
> FwImage_9098_PCIE
> +IMX_FIRMWARE_FILES_$(BR2_PACKAGE_IMX_FIRMWARE_IW416) += 
> FwImage_IW416_SD
> +IMX_FIRMWARE_FILES_$(BR2_PACKAGE_IMX_FIRMWARE_IW612) += 
> FwImage_IW612_SD
> +
> +define IMX_FIRMWARE_INSTALL_TARGET_CMDS
> +	$(INSTALL) -m 0644 -D $(@D)/nxp/wifi_mod_para.conf \
> +		$(TARGET_DIR)/lib/firmware/nxp/wifi_mod_para.conf
> +	$(INSTALL) -m 0644 -D $(@D)/nxp/mfguart/helper_uart_3000000.bin \
> +		$(TARGET_DIR)/lib/firmware/nxp/helper_uart_3000000.bin
> +	$(foreach f,$(IMX_FIRMWARE_FILES_y), \
> +		$(INSTALL) -m 0644 -D $(@D)/nxp/$(f)/* 
> $(TARGET_DIR)/lib/firmware/nxp/
> +	)
> +endef
> +
> +$(eval $(generic-package))
> --
> 2.43.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

Best regards,

Julien.

[1] 
https://gitlab.com/buildroot.org/buildroot/-/tree/master/package/freescale-imx/firmware-imx
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/imx-firmware: new package
  2024-04-23 19:30 ` Julien Olivain
@ 2024-04-23 19:58   ` Sébastien Szymanski
  2024-04-24 11:55     ` Gilles Talis
  0 siblings, 1 reply; 4+ messages in thread
From: Sébastien Szymanski @ 2024-04-23 19:58 UTC (permalink / raw)
  To: Julien Olivain; +Cc: Thomas Petazzoni, buildroot

Hi Julien,

On 4/23/24 21:30, Julien Olivain wrote:
> Hi Sebastien,
> 
> Thanks for your patch!
> 
> On 19/04/2024 17:46, Sébastien Szymanski wrote:
>> This package provides firmwares for NXP WiFi + Bluetooth chipsets.
> 
> I would like to point out that there is already another package called
> "firmware-imx" in [1]. While it does provide firmwares for i.MX SoCs,
> it is a different set of firmwares compared to this
> "imx-firmware" you are proposing. This is a bit unfortunate as the
> names are directly coming from NXP.
> 
> If you agree with my proposals below, you can add:
> 
> Reviewed-by: Julien Olivain <ju.o@free.fr>
> 
>> Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
>> ---
>>  package/Config.in                      |  1 +
>>  package/imx-firmware/Config.in         | 62 ++++++++++++++++++++++++++
>>  package/imx-firmware/imx-firmware.hash |  3 ++
>>  package/imx-firmware/imx-firmware.mk   | 32 +++++++++++++
>>  4 files changed, 98 insertions(+)
>>  create mode 100644 package/imx-firmware/Config.in
>>  create mode 100644 package/imx-firmware/imx-firmware.hash
>>  create mode 100644 package/imx-firmware/imx-firmware.mk
>>
>> diff --git a/package/Config.in b/package/Config.in
>> index 1935077f0f45..3ecceefef4ec 100644
>> --- a/package/Config.in
>> +++ b/package/Config.in
>> @@ -450,6 +450,7 @@ menu "Firmware"
>>      source "package/armbian-firmware/Config.in"
>>      source "package/b43-firmware/Config.in"
>>      source "package/brcmfmac_sdio-firmware-rpi/Config.in"
>> +    source "package/imx-firmware/Config.in"
> 
> To keep some consistency within the Buildroot tree (and with upstream),
> I suggest to move this "imx-firmware" package alongside the other, in
> the "package/freescale-imx" directory. Maybe one day, we'll rename this
> directory to "package/nxp-imx".

I thought about adding this package under package/freescale-imx but 
those packages are for systems based on an i.MX SoC. This package 
provides firmwares for WiFi / Bluetooth chipsets that could be used on 
systems not based on an i.MX SoC.

> 
>>      source "package/linux-firmware/Config.in"
>>      source "package/murata-cyw-fw/Config.in"
>>      source "package/odroidc2-firmware/Config.in"
>> diff --git a/package/imx-firmware/Config.in 
>> b/package/imx-firmware/Config.in
>> new file mode 100644
>> index 000000000000..d2037b270865
>> --- /dev/null
>> +++ b/package/imx-firmware/Config.in
>> @@ -0,0 +1,62 @@
>> +config BR2_PACKAGE_IMX_FIRMWARE
>> +    bool "imx-firmware"
>> +    help
>> +      Firmware for NXP Bluetooth / WiFi chipsets based modules
> 
> Moreover, to avoid confusion, could you add a note here like:
> """
> Note: there is also a firmware-imx package containing another set of
> firmwares for SDMA, VPU, HDMI, EDPC and DDR training.
> """
> 
> Finally, this patch could also add the opposite note in the
> "firmware-imx" Kconfig help, like:
> """
> Note: for NXP Bluetooth / WiFi chipsets, see the imx-firmware package.
> """

Yes, I agree about adding those comments.

Thanks!

Regards,

> 
>> +
>> +      https://github.com/nxp-imx/imx-firmware
>> +
>> +if BR2_PACKAGE_IMX_FIRMWARE
>> +
>> +config BR2_PACKAGE_IMX_FIRMWARE_8801
>> +    bool "8801 (SD)"
>> +    help
>> +      NXP 8801 module firmware files.
>> +
>> +config BR2_PACKAGE_IMX_FIRMWARE_8987
>> +    bool "8987 (SD)"
>> +    help
>> +      NXP 8987 module firmware files.
>> +
>> +config BR2_PACKAGE_IMX_FIRMWARE_8997
>> +    bool "8997"
>> +    help
>> +      NXP 8997 module firmware files.
>> +
>> +choice
>> +    prompt "8997 WiFi interface" if BR2_PACKAGE_IMX_FIRMWARE_8997
>> +
>> +config BR2_PACKAGE_IMX_FIRMWARE_8997_SD
>> +    bool "SD"
>> +
>> +config BR2_PACKAGE_IMX_FIRMWARE_8997_PCIE
>> +    bool "PCIe"
>> +
>> +endchoice
>> +
>> +config BR2_PACKAGE_IMX_FIRMWARE_9098
>> +    bool "9098"
>> +    help
>> +      NXP 9098 module firmware files.
>> +
>> +choice
>> +    prompt "9098 WiFi interface" if BR2_PACKAGE_IMX_FIRMWARE_9098
>> +
>> +config BR2_PACKAGE_IMX_FIRMWARE_9098_SD
>> +    bool "SD"
>> +
>> +config BR2_PACKAGE_IMX_FIRMWARE_9098_PCIE
>> +    bool "PCIe"
>> +
>> +endchoice
>> +
>> +config BR2_PACKAGE_IMX_FIRMWARE_IW416
>> +    bool "IW416 (SD)"
>> +    help
>> +      NXP IW416 module firmware files.
>> +
>> +config BR2_PACKAGE_IMX_FIRMWARE_IW612
>> +    bool "IW612 (SD)"
>> +    help
>> +      NXP IW612 module firmware files.
>> +
>> +endif
>> diff --git a/package/imx-firmware/imx-firmware.hash 
>> b/package/imx-firmware/imx-firmware.hash
>> new file mode 100644
>> index 000000000000..323130d7c690
>> --- /dev/null
>> +++ b/package/imx-firmware/imx-firmware.hash
>> @@ -0,0 +1,3 @@
>> +# Locally calculated
>> +sha256 
>> 2feba2969db7b6fc86aa0a13a0993ca241e155c23c0024c41316e67924778f5f 
>> imx-firmware-lf-6.6.3_1.0.0.tar.gz
>> +sha256 
>> 3827bf3548bfd9de73bf51fbdd7a8c674dcecfb249cfa1a7cf17bd2dc4e08a8c 
>> LICENSE.txt
>> diff --git a/package/imx-firmware/imx-firmware.mk 
>> b/package/imx-firmware/imx-firmware.mk
>> new file mode 100644
>> index 000000000000..8b5c3fb4a5d5
>> --- /dev/null
>> +++ b/package/imx-firmware/imx-firmware.mk
>> @@ -0,0 +1,32 @@
>> +################################################################################
>> +#
>> +# imx-firmware
>> +#
>> +################################################################################
>> +
>> +IMX_FIRMWARE_VERSION = lf-6.6.3_1.0.0
>> +IMX_FIRMWARE_SITE = $(call 
>> github,nxp-imx,imx-firmware,$(IMX_FIRMWARE_VERSION))
>> +IMX_FIRMWARE_LICENSE = NXP Software License Agreement
>> +IMX_FIRMWARE_LICENSE_FILES = LICENSE.txt
>> +IMX_FIRMWARE_REDISTRIBUTE = NO
>> +
>> +IMX_FIRMWARE_FILES_$(BR2_PACKAGE_IMX_FIRMWARE_8801) += FwImage_8801_SD
>> +IMX_FIRMWARE_FILES_$(BR2_PACKAGE_IMX_FIRMWARE_8987) += FwImage_8987
>> +IMX_FIRMWARE_FILES_$(BR2_PACKAGE_IMX_FIRMWARE_8997_SD) += 
>> FwImage_8997_SD
>> +IMX_FIRMWARE_FILES_$(BR2_PACKAGE_IMX_FIRMWARE_8997_PCIE) += FwImage_8997
>> +IMX_FIRMWARE_FILES_$(BR2_PACKAGE_IMX_FIRMWARE_9098_SD) += 
>> FwImage_9098_SD
>> +IMX_FIRMWARE_FILES_$(BR2_PACKAGE_IMX_FIRMWARE_9098_PCIE) += 
>> FwImage_9098_PCIE
>> +IMX_FIRMWARE_FILES_$(BR2_PACKAGE_IMX_FIRMWARE_IW416) += FwImage_IW416_SD
>> +IMX_FIRMWARE_FILES_$(BR2_PACKAGE_IMX_FIRMWARE_IW612) += FwImage_IW612_SD
>> +
>> +define IMX_FIRMWARE_INSTALL_TARGET_CMDS
>> +    $(INSTALL) -m 0644 -D $(@D)/nxp/wifi_mod_para.conf \
>> +        $(TARGET_DIR)/lib/firmware/nxp/wifi_mod_para.conf
>> +    $(INSTALL) -m 0644 -D $(@D)/nxp/mfguart/helper_uart_3000000.bin \
>> +        $(TARGET_DIR)/lib/firmware/nxp/helper_uart_3000000.bin
>> +    $(foreach f,$(IMX_FIRMWARE_FILES_y), \
>> +        $(INSTALL) -m 0644 -D $(@D)/nxp/$(f)/* 
>> $(TARGET_DIR)/lib/firmware/nxp/
>> +    )
>> +endef
>> +
>> +$(eval $(generic-package))
>> -- 
>> 2.43.2
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot@buildroot.org
>> https://lists.buildroot.org/mailman/listinfo/buildroot
> 
> Best regards,
> 
> Julien.
> 
> [1] 
> https://gitlab.com/buildroot.org/buildroot/-/tree/master/package/freescale-imx/firmware-imx

-- 
Sébastien Szymanski, Armadeus Systems
Software engineer

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/imx-firmware: new package
  2024-04-23 19:58   ` Sébastien Szymanski
@ 2024-04-24 11:55     ` Gilles Talis
  0 siblings, 0 replies; 4+ messages in thread
From: Gilles Talis @ 2024-04-24 11:55 UTC (permalink / raw)
  To: Sébastien Szymanski; +Cc: Julien Olivain, Thomas Petazzoni, buildroot

Hi Sebastien, hi Julien,

Le mar. 23 avr. 2024 à 22:04, Sébastien Szymanski
<sebastien.szymanski@armadeus.com> a écrit :
>
> Hi Julien,
>
> On 4/23/24 21:30, Julien Olivain wrote:
> > Hi Sebastien,
> >
> > Thanks for your patch!
> >
> > On 19/04/2024 17:46, Sébastien Szymanski wrote:
> >> This package provides firmwares for NXP WiFi + Bluetooth chipsets.
> >
> > I would like to point out that there is already another package called
> > "firmware-imx" in [1]. While it does provide firmwares for i.MX SoCs,
> > it is a different set of firmwares compared to this
> > "imx-firmware" you are proposing. This is a bit unfortunate as the
> > names are directly coming from NXP.
> >
> > If you agree with my proposals below, you can add:
> >
> > Reviewed-by: Julien Olivain <ju.o@free.fr>
> >
> >> Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
> >> ---
> >>  package/Config.in                      |  1 +
> >>  package/imx-firmware/Config.in         | 62 ++++++++++++++++++++++++++
> >>  package/imx-firmware/imx-firmware.hash |  3 ++
> >>  package/imx-firmware/imx-firmware.mk   | 32 +++++++++++++
> >>  4 files changed, 98 insertions(+)
> >>  create mode 100644 package/imx-firmware/Config.in
> >>  create mode 100644 package/imx-firmware/imx-firmware.hash
> >>  create mode 100644 package/imx-firmware/imx-firmware.mk
> >>
> >> diff --git a/package/Config.in b/package/Config.in
> >> index 1935077f0f45..3ecceefef4ec 100644
> >> --- a/package/Config.in
> >> +++ b/package/Config.in
> >> @@ -450,6 +450,7 @@ menu "Firmware"
> >>      source "package/armbian-firmware/Config.in"
> >>      source "package/b43-firmware/Config.in"
> >>      source "package/brcmfmac_sdio-firmware-rpi/Config.in"
> >> +    source "package/imx-firmware/Config.in"
> >
> > To keep some consistency within the Buildroot tree (and with upstream),
> > I suggest to move this "imx-firmware" package alongside the other, in
> > the "package/freescale-imx" directory. Maybe one day, we'll rename this
> > directory to "package/nxp-imx".
>
> I thought about adding this package under package/freescale-imx but
> those packages are for systems based on an i.MX SoC. This package
> provides firmwares for WiFi / Bluetooth chipsets that could be used on
> systems not based on an i.MX SoC.
>
> >
> >>      source "package/linux-firmware/Config.in"
> >>      source "package/murata-cyw-fw/Config.in"
> >>      source "package/odroidc2-firmware/Config.in"
> >> diff --git a/package/imx-firmware/Config.in
> >> b/package/imx-firmware/Config.in
> >> new file mode 100644
> >> index 000000000000..d2037b270865
> >> --- /dev/null
> >> +++ b/package/imx-firmware/Config.in
> >> @@ -0,0 +1,62 @@
> >> +config BR2_PACKAGE_IMX_FIRMWARE
> >> +    bool "imx-firmware"
> >> +    help
> >> +      Firmware for NXP Bluetooth / WiFi chipsets based modules
> >
> > Moreover, to avoid confusion, could you add a note here like:
> > """
> > Note: there is also a firmware-imx package containing another set of
> > firmwares for SDMA, VPU, HDMI, EDPC and DDR training.
> > """
> >
> > Finally, this patch could also add the opposite note in the
> > "firmware-imx" Kconfig help, like:
> > """
> > Note: for NXP Bluetooth / WiFi chipsets, see the imx-firmware package.
> > """
>
> Yes, I agree about adding those comments.
>
> Thanks!
>
> Regards,
I agree with both your comments. Having a firmware-imx, and an
imx-firmware will be very misleading if you don't know what to look
for.
And this package deals with NXP BT/WIFI rather than i.MX SoC
I would suggest keeping the package in the "Firmware" section, but
naming it "nxp-bt-wifi-firmware". Could be less confusing that way.

thoughts?
thanks
Gilles.


>
> >
> >> +
> >> +      https://github.com/nxp-imx/imx-firmware
> >> +
> >> +if BR2_PACKAGE_IMX_FIRMWARE
> >> +
> >> +config BR2_PACKAGE_IMX_FIRMWARE_8801
> >> +    bool "8801 (SD)"
> >> +    help
> >> +      NXP 8801 module firmware files.
> >> +
> >> +config BR2_PACKAGE_IMX_FIRMWARE_8987
> >> +    bool "8987 (SD)"
> >> +    help
> >> +      NXP 8987 module firmware files.
> >> +
> >> +config BR2_PACKAGE_IMX_FIRMWARE_8997
> >> +    bool "8997"
> >> +    help
> >> +      NXP 8997 module firmware files.
> >> +
> >> +choice
> >> +    prompt "8997 WiFi interface" if BR2_PACKAGE_IMX_FIRMWARE_8997
> >> +
> >> +config BR2_PACKAGE_IMX_FIRMWARE_8997_SD
> >> +    bool "SD"
> >> +
> >> +config BR2_PACKAGE_IMX_FIRMWARE_8997_PCIE
> >> +    bool "PCIe"
> >> +
> >> +endchoice
> >> +
> >> +config BR2_PACKAGE_IMX_FIRMWARE_9098
> >> +    bool "9098"
> >> +    help
> >> +      NXP 9098 module firmware files.
> >> +
> >> +choice
> >> +    prompt "9098 WiFi interface" if BR2_PACKAGE_IMX_FIRMWARE_9098
> >> +
> >> +config BR2_PACKAGE_IMX_FIRMWARE_9098_SD
> >> +    bool "SD"
> >> +
> >> +config BR2_PACKAGE_IMX_FIRMWARE_9098_PCIE
> >> +    bool "PCIe"
> >> +
> >> +endchoice
> >> +
> >> +config BR2_PACKAGE_IMX_FIRMWARE_IW416
> >> +    bool "IW416 (SD)"
> >> +    help
> >> +      NXP IW416 module firmware files.
> >> +
> >> +config BR2_PACKAGE_IMX_FIRMWARE_IW612
> >> +    bool "IW612 (SD)"
> >> +    help
> >> +      NXP IW612 module firmware files.
> >> +
> >> +endif
> >> diff --git a/package/imx-firmware/imx-firmware.hash
> >> b/package/imx-firmware/imx-firmware.hash
> >> new file mode 100644
> >> index 000000000000..323130d7c690
> >> --- /dev/null
> >> +++ b/package/imx-firmware/imx-firmware.hash
> >> @@ -0,0 +1,3 @@
> >> +# Locally calculated
> >> +sha256
> >> 2feba2969db7b6fc86aa0a13a0993ca241e155c23c0024c41316e67924778f5f
> >> imx-firmware-lf-6.6.3_1.0.0.tar.gz
> >> +sha256
> >> 3827bf3548bfd9de73bf51fbdd7a8c674dcecfb249cfa1a7cf17bd2dc4e08a8c
> >> LICENSE.txt
> >> diff --git a/package/imx-firmware/imx-firmware.mk
> >> b/package/imx-firmware/imx-firmware.mk
> >> new file mode 100644
> >> index 000000000000..8b5c3fb4a5d5
> >> --- /dev/null
> >> +++ b/package/imx-firmware/imx-firmware.mk
> >> @@ -0,0 +1,32 @@
> >> +################################################################################
> >> +#
> >> +# imx-firmware
> >> +#
> >> +################################################################################
> >> +
> >> +IMX_FIRMWARE_VERSION = lf-6.6.3_1.0.0
> >> +IMX_FIRMWARE_SITE = $(call
> >> github,nxp-imx,imx-firmware,$(IMX_FIRMWARE_VERSION))
> >> +IMX_FIRMWARE_LICENSE = NXP Software License Agreement
> >> +IMX_FIRMWARE_LICENSE_FILES = LICENSE.txt
> >> +IMX_FIRMWARE_REDISTRIBUTE = NO
> >> +
> >> +IMX_FIRMWARE_FILES_$(BR2_PACKAGE_IMX_FIRMWARE_8801) += FwImage_8801_SD
> >> +IMX_FIRMWARE_FILES_$(BR2_PACKAGE_IMX_FIRMWARE_8987) += FwImage_8987
> >> +IMX_FIRMWARE_FILES_$(BR2_PACKAGE_IMX_FIRMWARE_8997_SD) +=
> >> FwImage_8997_SD
> >> +IMX_FIRMWARE_FILES_$(BR2_PACKAGE_IMX_FIRMWARE_8997_PCIE) += FwImage_8997
> >> +IMX_FIRMWARE_FILES_$(BR2_PACKAGE_IMX_FIRMWARE_9098_SD) +=
> >> FwImage_9098_SD
> >> +IMX_FIRMWARE_FILES_$(BR2_PACKAGE_IMX_FIRMWARE_9098_PCIE) +=
> >> FwImage_9098_PCIE
> >> +IMX_FIRMWARE_FILES_$(BR2_PACKAGE_IMX_FIRMWARE_IW416) += FwImage_IW416_SD
> >> +IMX_FIRMWARE_FILES_$(BR2_PACKAGE_IMX_FIRMWARE_IW612) += FwImage_IW612_SD
> >> +
> >> +define IMX_FIRMWARE_INSTALL_TARGET_CMDS
> >> +    $(INSTALL) -m 0644 -D $(@D)/nxp/wifi_mod_para.conf \
> >> +        $(TARGET_DIR)/lib/firmware/nxp/wifi_mod_para.conf
> >> +    $(INSTALL) -m 0644 -D $(@D)/nxp/mfguart/helper_uart_3000000.bin \
> >> +        $(TARGET_DIR)/lib/firmware/nxp/helper_uart_3000000.bin
> >> +    $(foreach f,$(IMX_FIRMWARE_FILES_y), \
> >> +        $(INSTALL) -m 0644 -D $(@D)/nxp/$(f)/*
> >> $(TARGET_DIR)/lib/firmware/nxp/
> >> +    )
> >> +endef
> >> +
> >> +$(eval $(generic-package))
> >> --
> >> 2.43.2
> >>
> >> _______________________________________________
> >> buildroot mailing list
> >> buildroot@buildroot.org
> >> https://lists.buildroot.org/mailman/listinfo/buildroot
> >
> > Best regards,
> >
> > Julien.
> >
> > [1]
> > https://gitlab.com/buildroot.org/buildroot/-/tree/master/package/freescale-imx/firmware-imx
>
> --
> Sébastien Szymanski, Armadeus Systems
> Software engineer
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-04-24 11:56 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-19 15:46 [Buildroot] [PATCH 1/1] package/imx-firmware: new package Sébastien Szymanski
2024-04-23 19:30 ` Julien Olivain
2024-04-23 19:58   ` Sébastien Szymanski
2024-04-24 11:55     ` Gilles Talis

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.