Re: [PATCH v3 08/13] usb: typec: ucsi_ccg: Remove ccgx,firmware-build property

From: Jon Hunter <jonathanh@nvidia.com>
To: Wayne Chang <waynec@nvidia.com>,
	gregkh@linuxfoundation.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, treding@nvidia.com,
	thierry.reding@gmail.com, heikki.krogerus@linux.intel.com,
	ajayg@nvidia.com, vkoul@kernel.org, p.zabel@pengutronix.de,
	balbi@kernel.org, mathias.nyman@intel.com, jckuo@nvidia.com
Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, singhanc@nvidia.com,
	linux-i2c@vger.kernel.org, linux-phy@lists.infradead.org,
	linux-tegra@vger.kernel.org
Subject: Re: [PATCH v3 08/13] usb: typec: ucsi_ccg: Remove ccgx,firmware-build property
Date: Tue, 15 Nov 2022 12:19:02 +0000	[thread overview]
Message-ID: <cdf81530-3bb8-ace5-e70f-a20403891c57@nvidia.com> (raw)
In-Reply-To: <20221114124053.1873316-9-waynec@nvidia.com>


On 14/11/2022 12:40, Wayne Chang wrote:
> Remove the property ccgx,firmware-build as we have added well-known
> regex cypress,firmware-build.
> 
> Signed-off-by: Wayne Chang <waynec@nvidia.com>
> ---
> V2 -> V3:nothing has changed
> V1 -> V2:nothing has changed
>   drivers/usb/typec/ucsi/ucsi_ccg.c | 5 -----
>   1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/usb/typec/ucsi/ucsi_ccg.c b/drivers/usb/typec/ucsi/ucsi_ccg.c
> index e412a457bbfc..eab3012e1b01 100644
> --- a/drivers/usb/typec/ucsi/ucsi_ccg.c
> +++ b/drivers/usb/typec/ucsi/ucsi_ccg.c
> @@ -1359,11 +1359,6 @@ static int ucsi_ccg_probe(struct i2c_client *client,
>   	INIT_WORK(&uc->pm_work, ccg_pm_workaround_work);
>   
>   	/* Only fail FW flashing when FW build information is not provided */
> -	status = device_property_read_u16(dev, "ccgx,firmware-build",
> -					  &uc->fw_build);
> -	if (status)
> -		dev_err(uc->dev, "failed to get FW build information\n");
> -
>   	status = device_property_read_string(dev, "cypress,firmware-build",
>   					  &of_fw_build);
>   	if (!status) {

Reviewed-by: Jon Hunter <jonathanh@nvidia.com>

Thanks
Jon

-- 
nvpublic