From: Baolin Wang <baolin.wang@linux.alibaba.com>
To: Luiz Capitulino <luizcap@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
david@kernel.org
Cc: ryan.roberts@arm.com, akpm@linux-foundation.org,
lorenzo.stoakes@oracle.com
Subject: Re: [PATCH v3 06/10] mm: shmem: drop has_transparent_hugepage() usage
Date: Sat, 11 Apr 2026 14:56:52 +0800 [thread overview]
Message-ID: <cdfcff0f-2849-4e16-98df-0bf18d894680@linux.alibaba.com> (raw)
In-Reply-To: <020a4fe05e8ac52ca47c27b0fbb6a07c163a118f.1775679721.git.luizcap@redhat.com>
On 4/9/26 4:23 AM, Luiz Capitulino wrote:
> Shmem uses has_transparent_hugepage() in the following ways:
>
> - shmem_parse_one() and shmem_parse_huge(): Check if THP is built-in and
> if the CPU supports PMD-sized pages
>
> - shmem_init(): Since the CONFIG_TRANSPARENT_HUGEPAGE guard is outside
> the code block calling has_transparent_hugepage(), the
> has_transparent_hugepage() call is exclusively checking if the CPU
> supports PMD-sized pages
>
> While it's necessary to check if CONFIG_TRANSPARENT_HUGEPAGE is enabled
> in all cases, shmem can determine mTHP size support at folio allocation
> time. Therefore, drop has_transparent_hugepage() usage while keeping the
> CONFIG_TRANSPARENT_HUGEPAGE checks.
>
> Signed-off-by: Luiz Capitulino <luizcap@redhat.com>
> ---
LGTM. Thanks.
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
next prev parent reply other threads:[~2026-04-11 6:57 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 20:22 [PATCH v3 00/10] mm: thp: always enable mTHP support Luiz Capitulino
2026-04-08 20:22 ` [PATCH v3 01/10] docs: tmpfs: remove implementation detail reference Luiz Capitulino
2026-04-09 15:11 ` Zi Yan
2026-04-10 16:00 ` Lance Yang
2026-04-08 20:22 ` [PATCH v3 02/10] mm: introduce pgtable_has_pmd_leaves() Luiz Capitulino
2026-04-09 12:26 ` Lance Yang
2026-04-09 18:22 ` Luiz Capitulino
2026-04-10 8:19 ` Lance Yang
2026-04-13 15:24 ` Luiz Capitulino
2026-04-13 15:45 ` Lance Yang
2026-04-17 9:57 ` David Hildenbrand (Arm)
2026-04-17 12:57 ` Luiz Capitulino
2026-04-20 6:55 ` Lance Yang
2026-04-08 20:22 ` [PATCH v3 03/10] drivers: dax: use pgtable_has_pmd_leaves() Luiz Capitulino
2026-04-08 20:22 ` [PATCH v3 04/10] drivers: nvdimm: " Luiz Capitulino
2026-04-09 15:21 ` Zi Yan
2026-04-09 18:51 ` Luiz Capitulino
2026-04-08 20:23 ` [PATCH v3 05/10] mm: debug_vm_pgtable: " Luiz Capitulino
2026-04-09 15:25 ` Zi Yan
2026-04-10 16:09 ` Lance Yang
2026-04-08 20:23 ` [PATCH v3 06/10] mm: shmem: drop has_transparent_hugepage() usage Luiz Capitulino
2026-04-09 15:26 ` Zi Yan
2026-04-10 15:59 ` Lance Yang
2026-04-11 4:00 ` Lance Yang
2026-04-11 6:56 ` Baolin Wang [this message]
2026-04-08 20:23 ` [PATCH v3 07/10] treewide: rename has_transparent_hugepage() to arch_has_pmd_leaves() Luiz Capitulino
2026-04-09 15:41 ` Zi Yan
2026-04-09 19:43 ` Luiz Capitulino
2026-04-13 15:32 ` Luiz Capitulino
2026-04-13 15:34 ` Zi Yan
2026-04-08 20:23 ` [PATCH v3 08/10] mm: replace thp_disabled_by_hw() with pgtable_has_pmd_leaves() Luiz Capitulino
2026-04-09 15:43 ` Zi Yan
2026-04-11 7:01 ` Baolin Wang
2026-04-12 14:44 ` Lance Yang
2026-04-08 20:23 ` [PATCH v3 09/10] mm: thp: always enable mTHP support Luiz Capitulino
2026-04-09 15:55 ` Zi Yan
2026-04-09 20:07 ` Luiz Capitulino
2026-04-09 20:10 ` Zi Yan
2026-04-09 21:19 ` Luiz Capitulino
2026-04-11 7:22 ` Baolin Wang
2026-04-13 15:39 ` Luiz Capitulino
2026-04-08 20:23 ` [PATCH v3 10/10] mm: thp: x86: cleanup PSE feature bit usage Luiz Capitulino
2026-04-09 15:57 ` Zi Yan
2026-04-09 20:10 ` Dave Hansen
2026-04-09 21:24 ` Luiz Capitulino
2026-04-09 8:29 ` [PATCH v3 00/10] mm: thp: always enable mTHP support Lance Yang
2026-04-09 8:36 ` Lorenzo Stoakes
2026-04-09 18:18 ` Luiz Capitulino
2026-04-09 12:35 ` Lance Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cdfcff0f-2849-4e16-98df-0bf18d894680@linux.alibaba.com \
--to=baolin.wang@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=luizcap@redhat.com \
--cc=ryan.roberts@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.