Re: [PATCH 0/3] ASoC: hda: capture-related fixes

[Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>]

On 3/8/19 2:38 AM, Rander Wang wrote:
> There are several sources of errors fixed in this series, such as mismatch
> between TX and RX mask used to store the stream_tag, the use of hw_param
> fixups not properly handled in the hdac_hda codec and registers set on capture
> when they should only be used on playback.
>
> The first patch fixes a issue caused by tx|rx_mask for TDM.
> The Second one fixes the mismatch between BE dai format and hda codec format.
> The last one removes the register of stream id setting on capture.
>
> this series was tested successfully with the Intel Skylake driver on a Skylake
> Dell XPS13 (same as Linus), KabyLake NUC, Whiskylake laptop and Apollolake LeafHill
> board. The two soc-pcm and hdac_hda fixes are needed by the SOF driver as well, but
> SOF-specific patches will be provided in the next batch and are not included here
>
> Rander Wang (3):
>    ASoC:soc-pcm:fix a codec fixup issue in TDM case
>    ASoC:hdac_hda:use correct format to setup hda codec
>    ASoC:intel:skl:fix a simultaneous playback & capture issue on hda platform

[adding Takashi who wasn't on CC: but is required for the HDaudio part]

I reviewed and tested this series so

Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

Note that this series supersedes an initial fix shared on February 25, which is now included as patch2 of this series.

>
>   sound/soc/codecs/hdac_hda.c       | 53 ++++++++++++++++++++++++++++-----------
>   sound/soc/codecs/hdac_hda.h       |  1 +
>   sound/soc/intel/skylake/skl-pcm.c | 19 ++++++++++----
>   sound/soc/soc-pcm.c               |  7 ++++--
>   4 files changed, 59 insertions(+), 21 deletions(-)
>