From: Florian Fainelli <f.fainelli@gmail.com>
To: Vladimir Oltean <olteanv@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>
Cc: Ivan Vecera <ivecera@redhat.com>, Andrew Lunn <andrew@lunn.ch>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Jiri Pirko <jiri@resnulli.us>,
Vignesh Raghavendra <vigneshr@ti.com>,
Vadym Kochan <vkochan@marvell.com>,
netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
Ioana Ciornei <ioana.ciornei@nxp.com>,
linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com,
Taras Chornyi <tchornyi@marvell.com>,
Ido Schimmel <idosch@idosch.org>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Nikolay Aleksandrov <nikolay@nvidia.com>,
Roopa Prabhu <roopa@nvidia.com>,
linux-omap@vger.kernel.org,
Vivien Didelot <vivien.didelot@gmail.com>
Subject: Re: [Bridge] [PATCH v5 net-next 02/10] net: bridge: offload all port flags at once in br_setport
Date: Fri, 12 Feb 2021 10:05:15 -0800 [thread overview]
Message-ID: <ce3cd74e-2f58-e368-e108-fd148d69d4cb@gmail.com> (raw)
In-Reply-To: <20210212151600.3357121-3-olteanv@gmail.com>
On 2/12/2021 7:15 AM, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@nxp.com>
>
> If for example this command:
>
> ip link set swp0 type bridge_slave flood off mcast_flood off learning off
>
> succeeded at configuring BR_FLOOD and BR_MCAST_FLOOD but not at
> BR_LEARNING, there would be no attempt to revert the partial state in
> any way. Arguably, if the user changes more than one flag through the
> same netlink command, this one _should_ be all or nothing, which means
> it should be passed through switchdev as all or nothing.
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: Vladimir Oltean <olteanv@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>
Cc: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
bridge@lists.linux-foundation.org,
Roopa Prabhu <roopa@nvidia.com>,
Nikolay Aleksandrov <nikolay@nvidia.com>,
Jiri Pirko <jiri@resnulli.us>, Ido Schimmel <idosch@idosch.org>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
UNGLinuxDriver@microchip.com, Vadym Kochan <vkochan@marvell.com>,
Taras Chornyi <tchornyi@marvell.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Ioana Ciornei <ioana.ciornei@nxp.com>,
Ivan Vecera <ivecera@redhat.com>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH v5 net-next 02/10] net: bridge: offload all port flags at once in br_setport
Date: Fri, 12 Feb 2021 10:05:15 -0800 [thread overview]
Message-ID: <ce3cd74e-2f58-e368-e108-fd148d69d4cb@gmail.com> (raw)
In-Reply-To: <20210212151600.3357121-3-olteanv@gmail.com>
On 2/12/2021 7:15 AM, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@nxp.com>
>
> If for example this command:
>
> ip link set swp0 type bridge_slave flood off mcast_flood off learning off
>
> succeeded at configuring BR_FLOOD and BR_MCAST_FLOOD but not at
> BR_LEARNING, there would be no attempt to revert the partial state in
> any way. Arguably, if the user changes more than one flag through the
> same netlink command, this one _should_ be all or nothing, which means
> it should be passed through switchdev as all or nothing.
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2021-02-12 18:05 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 15:15 [Bridge] [PATCH v5 net-next 00/10] Cleanup in brport flags switchdev offload for DSA Vladimir Oltean
2021-02-12 15:15 ` Vladimir Oltean
2021-02-12 15:15 ` [Bridge] [PATCH v5 net-next 01/10] net: switchdev: propagate extack to port attributes Vladimir Oltean
2021-02-12 15:15 ` Vladimir Oltean
2021-02-12 16:00 ` [Bridge] " Nikolay Aleksandrov
2021-02-12 16:00 ` Nikolay Aleksandrov
2021-02-12 17:03 ` Grygorii Strashko
2021-02-12 15:15 ` [Bridge] [PATCH v5 net-next 02/10] net: bridge: offload all port flags at once in br_setport Vladimir Oltean
2021-02-12 15:15 ` Vladimir Oltean
2021-02-12 15:57 ` [Bridge] " Nikolay Aleksandrov
2021-02-12 15:57 ` Nikolay Aleksandrov
2021-02-12 18:05 ` Florian Fainelli [this message]
2021-02-12 18:05 ` Florian Fainelli
2021-02-12 15:15 ` [Bridge] [PATCH v5 net-next 03/10] net: bridge: don't print in br_switchdev_set_port_flag Vladimir Oltean
2021-02-12 15:15 ` Vladimir Oltean
2021-02-12 15:59 ` [Bridge] " Nikolay Aleksandrov
2021-02-12 15:59 ` Nikolay Aleksandrov
2021-02-12 18:07 ` [Bridge] " Florian Fainelli
2021-02-12 18:07 ` Florian Fainelli
2021-02-12 15:15 ` [Bridge] [PATCH v5 net-next 04/10] net: dsa: configure better brport flags when ports leave the bridge Vladimir Oltean
2021-02-12 15:15 ` Vladimir Oltean
2021-02-12 15:15 ` [Bridge] [PATCH v5 net-next 05/10] net: switchdev: pass flags and mask to both {PRE_, }BRIDGE_FLAGS attributes Vladimir Oltean
2021-02-12 15:15 ` [PATCH v5 net-next 05/10] net: switchdev: pass flags and mask to both {PRE_,}BRIDGE_FLAGS attributes Vladimir Oltean
2021-02-12 17:06 ` Grygorii Strashko
2021-02-12 18:10 ` [Bridge] [PATCH v5 net-next 05/10] net: switchdev: pass flags and mask to both {PRE_, }BRIDGE_FLAGS attributes Florian Fainelli
2021-02-12 18:10 ` [PATCH v5 net-next 05/10] net: switchdev: pass flags and mask to both {PRE_,}BRIDGE_FLAGS attributes Florian Fainelli
2021-02-12 15:15 ` [Bridge] [PATCH v5 net-next 06/10] net: dsa: act as passthrough for bridge port flags Vladimir Oltean
2021-02-12 15:15 ` Vladimir Oltean
2021-02-12 18:19 ` [Bridge] " Florian Fainelli
2021-02-12 18:19 ` Florian Fainelli
2021-02-12 15:15 ` [Bridge] [PATCH v5 net-next 07/10] net: dsa: felix: restore multicast flood to CPU when NPI tagger reinitializes Vladimir Oltean
2021-02-12 15:15 ` Vladimir Oltean
2021-02-12 18:12 ` [Bridge] " Florian Fainelli
2021-02-12 18:12 ` Florian Fainelli
2021-02-12 15:15 ` [Bridge] [PATCH v5 net-next 08/10] net: mscc: ocelot: use separate flooding PGID for broadcast Vladimir Oltean
2021-02-12 15:15 ` Vladimir Oltean
2021-02-12 15:15 ` [Bridge] [PATCH v5 net-next 09/10] net: mscc: ocelot: offload bridge port flags to device Vladimir Oltean
2021-02-12 15:15 ` Vladimir Oltean
2021-02-12 15:16 ` [Bridge] [PATCH v5 net-next 10/10] net: dsa: sja1105: " Vladimir Oltean
2021-02-12 15:16 ` Vladimir Oltean
2021-02-13 1:20 ` [Bridge] [PATCH v5 net-next 00/10] Cleanup in brport flags switchdev offload for DSA patchwork-bot+netdevbpf
2021-02-13 1:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce3cd74e-2f58-e368-e108-fd148d69d4cb@gmail.com \
--to=f.fainelli@gmail.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=bridge@lists.linux-foundation.org \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=grygorii.strashko@ti.com \
--cc=idosch@idosch.org \
--cc=ioana.ciornei@nxp.com \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@nvidia.com \
--cc=olteanv@gmail.com \
--cc=roopa@nvidia.com \
--cc=tchornyi@marvell.com \
--cc=vigneshr@ti.com \
--cc=vivien.didelot@gmail.com \
--cc=vkochan@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.