From: "Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>
To: "Denis V. Lunev" <den@openvz.org>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, John Snow <jsnow@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [PATCH v2 07/17] hw/ide: factor out the IDENTIFY DEVICE current geometry words
Date: Thu, 20 Aug 2026 13:07:05 +0200 [thread overview]
Message-ID: <ce56dc4f-6042-4f80-8523-3fc2e3065451@oss.qualcomm.com> (raw)
In-Reply-To: <20260820100844.411717-8-den@openvz.org>
On 20/8/26 12:08, Denis V. Lunev wrote:
> From: Denis V. Lunev <den@openvz.org>
>
> Words 54 to 58 of IDENTIFY DEVICE describe the CHS translation in effect
> and the capacity it addresses. Both ide_identify() and
> ide_cfata_identify() fill them the same way while building their cached
> data.
>
> Move them into ide_identify_chs(), so that the next change can refresh
> them in place once the translation changes, the way ide_identify_size()
> does for the capacity words.
>
> No functional change.
>
> Cc: John Snow <jsnow@redhat.com>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Cc: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> ---
> hw/ide/core.c | 29 ++++++++++++++---------------
> 1 file changed, 14 insertions(+), 15 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com>
next prev parent reply other threads:[~2026-08-20 11:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-20 10:08 [PATCH v2 00/17] hw/ide: fix the logical CHS translation a guest selects Denis V. Lunev
2026-08-20 10:08 ` [PATCH v2 01/17] hw/ide: reject an unsupported CHS translation Denis V. Lunev
2026-08-20 10:08 ` [PATCH v2 02/17] tests/qtest/ide-test: cover a CHS translation with zero sectors Denis V. Lunev
2026-08-20 10:08 ` [PATCH v2 03/17] tests/qtest/libqos/ahci: allow a count and an expected error Denis V. Lunev
2026-08-20 10:08 ` [PATCH v2 04/17] tests/qtest/ahci: cover the sector count of INITIALIZE DEVICE PARAMETERS Denis V. Lunev
2026-08-20 10:08 ` [PATCH v2 05/17] hw/ide: report the default CHS translation in IDENTIFY DEVICE Denis V. Lunev
2026-08-20 10:08 ` [PATCH v2 06/17] hw/ide: name the retired IDENTIFY DEVICE words the device fills in Denis V. Lunev
2026-08-20 10:08 ` [PATCH v2 07/17] hw/ide: factor out the IDENTIFY DEVICE current geometry words Denis V. Lunev
2026-08-20 11:07 ` Philippe Mathieu-Daudé [this message]
2026-08-20 10:08 ` [PATCH v2 08/17] hw/ide: keep the IDENTIFY DEVICE current geometry in sync Denis V. Lunev
2026-08-20 10:08 ` [PATCH v2 09/17] hw/ide: restore the power-on device state before loading Denis V. Lunev
2026-08-20 10:08 ` [PATCH v2 10/17] hw/ide: migrate the logical CHS translation Denis V. Lunev
2026-08-20 10:08 ` [PATCH v2 11/17] hw/ide: migrate the power-on defaults revert flag Denis V. Lunev
2026-08-20 10:08 ` [PATCH v2 12/17] tests/qtest/ide-test: cover the CHS translation across migration Denis V. Lunev
2026-08-20 10:08 ` [PATCH v2 13/17] tests/qtest/ide-test: cover a rejected CHS translation in the stream Denis V. Lunev
2026-08-20 10:08 ` [PATCH v2 14/17] tests/qtest/ide-test: cover the IDENTIFY DEVICE geometry words Denis V. Lunev
2026-08-20 10:08 ` [PATCH v2 15/17] hw/ide: revert the CHS translation on a hardware reset Denis V. Lunev
2026-08-20 10:08 ` [PATCH v2 16/17] tests/qtest/ide-test: cover the CHS translation across resets Denis V. Lunev
2026-08-20 10:08 ` [PATCH v2 17/17] hw/ide: drop a redundant interrupt from INITIALIZE DEVICE PARAMETERS Denis V. Lunev
2026-08-20 11:08 ` Philippe Mathieu-Daudé
2026-08-20 13:09 ` [PATCH v2 00/17] hw/ide: fix the logical CHS translation a guest selects Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce56dc4f-6042-4f80-8523-3fc2e3065451@oss.qualcomm.com \
--to=philmd@oss.qualcomm.com \
--cc=den@openvz.org \
--cc=jsnow@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.