[PATCH 1/2] update drm.h

[PATCH 1/2] update drm.h

[Chunming Zhou]

   a) delta: only DRM_CAP_SYNCOBJ_TIMELINE
   b) Generated using make headers_install.
   c) Generated from origin/drm-misc-next commit 982c0500fd1a8012c31d3c9dd8de285129904656"

Signed-off-by: Chunming Zhou <david1.zhou@amd.com>
Suggested-by: Michel Dänzer <michel@daenzer.net>
---
 include/drm/drm.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/drm/drm.h b/include/drm/drm.h
index c893f3b4..438abde3 100644
--- a/include/drm/drm.h
+++ b/include/drm/drm.h
@@ -44,6 +44,7 @@ typedef unsigned int drm_handle_t;
 
 #else /* One of the BSDs */
 
+#include <stdint.h>
 #include <sys/ioccom.h>
 #include <sys/types.h>
 typedef int8_t   __s8;
@@ -643,6 +644,7 @@ struct drm_gem_open {
 #define DRM_CAP_PAGE_FLIP_TARGET	0x11
 #define DRM_CAP_CRTC_IN_VBLANK_EVENT	0x12
 #define DRM_CAP_SYNCOBJ		0x13
+#define DRM_CAP_SYNCOBJ_TIMELINE	0x14
 
 /** DRM_IOCTL_GET_CAP ioctl argument type */
 struct drm_get_cap {
-- 
2.17.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 2/2] enable syncobj test depending on capability

[Chunming Zhou]

Feature is controlled by DRM_CAP_SYNCOBJ_TIMELINE drm capability.

Signed-off-by: Chunming Zhou <david1.zhou@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
---
 tests/amdgpu/syncobj_tests.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/tests/amdgpu/syncobj_tests.c b/tests/amdgpu/syncobj_tests.c
index a0c627d7..869ed88e 100644
--- a/tests/amdgpu/syncobj_tests.c
+++ b/tests/amdgpu/syncobj_tests.c
@@ -22,6 +22,7 @@
 */
 
 #include "CUnit/Basic.h"
+#include "xf86drm.h"
 
 #include "amdgpu_test.h"
 #include "amdgpu_drm.h"
@@ -36,6 +37,13 @@ static void amdgpu_syncobj_timeline_test(void);
 
 CU_BOOL suite_syncobj_timeline_tests_enable(void)
 {
+	int r;
+	uint64_t cap = 0;
+
+	r = drmGetCap(drm_amdgpu[0], DRM_CAP_SYNCOBJ_TIMELINE, &cap);
+	if (r || cap == 0)
+		return CU_FALSE;
+
 	return CU_TRUE;
 }
 
-- 
2.17.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/2] update drm.h

[Koenig, Christian]

Am 22.05.19 um 11:07 schrieb Chunming Zhou:
>     a) delta: only DRM_CAP_SYNCOBJ_TIMELINE
>     b) Generated using make headers_install.
>     c) Generated from origin/drm-misc-next commit 982c0500fd1a8012c31d3c9dd8de285129904656"
>
> Signed-off-by: Chunming Zhou <david1.zhou@amd.com>
> Suggested-by: Michel Dänzer <michel@daenzer.net>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   include/drm/drm.h | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/include/drm/drm.h b/include/drm/drm.h
> index c893f3b4..438abde3 100644
> --- a/include/drm/drm.h
> +++ b/include/drm/drm.h
> @@ -44,6 +44,7 @@ typedef unsigned int drm_handle_t;
>   
>   #else /* One of the BSDs */
>   
> +#include <stdint.h>
>   #include <sys/ioccom.h>
>   #include <sys/types.h>
>   typedef int8_t   __s8;
> @@ -643,6 +644,7 @@ struct drm_gem_open {
>   #define DRM_CAP_PAGE_FLIP_TARGET	0x11
>   #define DRM_CAP_CRTC_IN_VBLANK_EVENT	0x12
>   #define DRM_CAP_SYNCOBJ		0x13
> +#define DRM_CAP_SYNCOBJ_TIMELINE	0x14
>   
>   /** DRM_IOCTL_GET_CAP ioctl argument type */
>   struct drm_get_cap {

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/2] update drm.h

[zhoucm1]

anyone can pick up to gitlab for libdrm?


Thanks,

-David


On 2019年05月22日 18:46, Koenig, Christian wrote:
> Am 22.05.19 um 11:07 schrieb Chunming Zhou:
>>      a) delta: only DRM_CAP_SYNCOBJ_TIMELINE
>>      b) Generated using make headers_install.
>>      c) Generated from origin/drm-misc-next commit 982c0500fd1a8012c31d3c9dd8de285129904656"
>>
>> Signed-off-by: Chunming Zhou <david1.zhou@amd.com>
>> Suggested-by: Michel Dänzer <michel@daenzer.net>
> Reviewed-by: Christian König <christian.koenig@amd.com>
>
>> ---
>>    include/drm/drm.h | 2 ++
>>    1 file changed, 2 insertions(+)
>>
>> diff --git a/include/drm/drm.h b/include/drm/drm.h
>> index c893f3b4..438abde3 100644
>> --- a/include/drm/drm.h
>> +++ b/include/drm/drm.h
>> @@ -44,6 +44,7 @@ typedef unsigned int drm_handle_t;
>>    
>>    #else /* One of the BSDs */
>>    
>> +#include <stdint.h>
>>    #include <sys/ioccom.h>
>>    #include <sys/types.h>
>>    typedef int8_t   __s8;
>> @@ -643,6 +644,7 @@ struct drm_gem_open {
>>    #define DRM_CAP_PAGE_FLIP_TARGET	0x11
>>    #define DRM_CAP_CRTC_IN_VBLANK_EVENT	0x12
>>    #define DRM_CAP_SYNCOBJ		0x13
>> +#define DRM_CAP_SYNCOBJ_TIMELINE	0x14
>>    
>>    /** DRM_IOCTL_GET_CAP ioctl argument type */
>>    struct drm_get_cap {

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/2] update drm.h

[Michel Dänzer]

On 2019-05-24 7:15 a.m., zhoucm1 wrote:
> anyone can pick up to gitlab for libdrm?

Can you create a merge request?


-- 
Earthling Michel Dänzer               |              https://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/2] update drm.h

[zhoucm1]

https://gitlab.freedesktop.org/mesa/drm, Where the merge request button?

-David


On 2019年06月06日 18:20, Michel Dänzer wrote:
> On 2019-05-24 7:15 a.m., zhoucm1 wrote:
>> anyone can pick up to gitlab for libdrm?
> Can you create a merge request?
>
>

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/2] update drm.h

[Koenig, Christian]

Seconded, I'm always totally confused about the web interface as well.

Christian.

Am 06.06.19 um 12:26 schrieb zhoucm1:
> https://gitlab.freedesktop.org/mesa/drm, Where the merge request button?
>
> -David
>
>
> On 2019年06月06日 18:20, Michel Dänzer wrote:
>> On 2019-05-24 7:15 a.m., zhoucm1 wrote:
>>> anyone can pick up to gitlab for libdrm?
>> Can you create a merge request?
>>
>>
>

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/2] update drm.h

[Michel Dänzer]

On 2019-06-06 12:26 p.m., zhoucm1 wrote:
> https://gitlab.freedesktop.org/mesa/drm, Where the merge request button?

If you push to a branch in your personal repository, the output of git
push contains an URL for creating a merge request.


-- 
Earthling Michel Dänzer               |              https://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/2] update drm.h

[Michel Dänzer]

On 2019-06-06 12:31 p.m., Michel Dänzer wrote:
> On 2019-06-06 12:26 p.m., zhoucm1 wrote:
>> https://gitlab.freedesktop.org/mesa/drm, Where the merge request button?
> 
> If you push to a branch in your personal repository, the output of git
> push contains an URL for creating a merge request.

Daniel Vetter pointed out on IRC that currently merge requests aren't
enabled yet for libdrm, which probably explains why you couldn't find a
way to create one. Sorry, I didn't realize this.

Meanwhile, can you just push to a branch in your personal repo, and make
sure the CI pipeline passes?


-- 
Earthling Michel Dänzer               |              https://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

RE: [PATCH 1/2] update drm.h

[Zhou, David(ChunMing)]

> -----Original Message-----
> From: Michel Dänzer <michel@daenzer.net>
> Sent: Thursday, June 06, 2019 10:09 PM
> To: Zhou, David(ChunMing) <David1.Zhou@amd.com>; Koenig, Christian
> <Christian.Koenig@amd.com>; Zhou, David(ChunMing)
> <David1.Zhou@amd.com>
> Cc: dri-devel@lists.freedesktop.org
> Subject: Re: [PATCH 1/2] update drm.h
> 
> On 2019-06-06 12:31 p.m., Michel Dänzer wrote:
> > On 2019-06-06 12:26 p.m., zhoucm1 wrote:
> >> https://gitlab.freedesktop.org/mesa/drm, Where the merge request
> button?
> >
> > If you push to a branch in your personal repository, the output of git
> > push contains an URL for creating a merge request.
> 
> Daniel Vetter pointed out on IRC that currently merge requests aren't
> enabled yet for libdrm, which probably explains why you couldn't find a way
> to create one. Sorry, I didn't realize this.
> 
> Meanwhile, can you just push to a branch in your personal repo, and make
> sure the CI pipeline passes?

Sorry, which personal repo? My problem to connect to gitlab.freedesktop isn't solved yet by our IT, I'm pushing them, but no response yet.

-David

> 
> 
> --
> Earthling Michel Dänzer               |              https://www.amd.com
> Libre software enthusiast             |             Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel