All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Dan Scally <dan.scally@ideasonboard.com>,
	Linux Media Mailing List <linux-media@vger.kernel.org>,
	"sakari.ailus@linux.intel.com" <sakari.ailus@linux.intel.com>
Subject: OV5693 Kconfig missing a select VIDEO_V4L2_SUBDEV_API ?
Date: Wed, 14 Jun 2023 17:47:01 +0200	[thread overview]
Message-ID: <ce81b73f-48db-038d-2671-bccbb3490786@redhat.com> (raw)

Hi All,

The ov5693 driver uses v4l2_subdev_get_try_crop() /
v4l2_subdev_get_try_format() both of which are
only defined if CONFIG_VIDEO_V4L2_SUBDEV_API=y .

Yet it does not do select VIDEO_V4L2_SUBDEV_API
in its Kconfig bits ?

Note I've not seen any build errors because of this,
I guess we somehow end up getting away with this...

But still I think the select should be added ?

Regards,

Hans



             reply	other threads:[~2023-06-14 15:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-14 15:47 Hans de Goede [this message]
2023-06-14 16:04 ` OV5693 Kconfig missing a select VIDEO_V4L2_SUBDEV_API ? Hans de Goede
2023-06-14 16:05 ` sakari.ailus
2023-06-14 16:50   ` Hans de Goede
2023-06-14 20:30     ` sakari.ailus
2023-06-14 21:22       ` Laurent Pinchart
2023-06-14 21:23         ` Laurent Pinchart
2023-06-15  8:22           ` sakari.ailus
2023-06-15  9:13             ` Laurent Pinchart
2023-06-15 11:31               ` sakari.ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ce81b73f-48db-038d-2671-bccbb3490786@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=dan.scally@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.