Re: OV5693 Kconfig missing a select VIDEO_V4L2_SUBDEV_API ?

[Hans de Goede <hdegoede@redhat.com>]

Hi,

On 6/14/23 17:47, Hans de Goede wrote:
> Hi All,
> 
> The ov5693 driver uses v4l2_subdev_get_try_crop() /
> v4l2_subdev_get_try_format() both of which are
> only defined if CONFIG_VIDEO_V4L2_SUBDEV_API=y .
> 
> Yet it does not do select VIDEO_V4L2_SUBDEV_API
> in its Kconfig bits ?
> 
> Note I've not seen any build errors because of this,
> I guess we somehow end up getting away with this...
> 
> But still I think the select should be added ?

Hmm, so while looking at the VIDEO_IMX290 entry
in drivers/media/i2c/Kconfig I notice that
the VIDEO_IMX274 entry directly above it seems
to be missing "select V4L2_FWNODE".

I am starting to think that we need a
V4L2_SENSOR_DRIVER_DEPS which can be selected
which then in turn selects all the bits modern
sensor drivers need ?

Regards,

Hans