All of lore.kernel.org
 help / color / mirror / Atom feed
From: Barret Rhoden <brho@google.com>
To: Liran Alon <liran.alon@oracle.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	David Hildenbrand <david@redhat.com>,
	Alexander Duyck <alexander.h.duyck@linux.intel.com>,
	linux-nvdimm@lists.01.org, x86@kernel.org, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org, jason.zeng@intel.com
Subject: Re: [PATCH v4 2/2] kvm: Use huge pages for DAX-backed files
Date: Thu, 12 Dec 2019 12:03:38 -0500	[thread overview]
Message-ID: <ce8fa354-4530-2a01-6ccc-3cffd0692547@google.com> (raw)
In-Reply-To: <376DB19A-4EF1-42BF-A73C-741558E397D4@oracle.com>

On 12/12/19 7:33 AM, Liran Alon wrote:
>> +	/*
>> +	 * Our caller grabbed the KVM mmu_lock with a successful
>> +	 * mmu_notifier_retry, so we're safe to walk the page table.
>> +	 */
>> +	switch (dev_pagemap_mapping_shift(hva, current->mm)) {
> Doesn’t dev_pagemap_mapping_shift() get “struct page” as first parameter?
> Was this changed by a commit I missed?

I changed this in Patch 1.  The place I call it in KVM has the address 
and mm available, which is the only think dev_pagemap_mapping_shift() 
really needs.  (The first thing it did was convert page to address).

I'll add some more text to patch 1's commit message about that.

Thanks,

Barret

_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org

WARNING: multiple messages have this Message-ID (diff)
From: Barret Rhoden <brho@google.com>
To: Liran Alon <liran.alon@oracle.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Dan Williams <dan.j.williams@intel.com>,
	David Hildenbrand <david@redhat.com>,
	Dave Jiang <dave.jiang@intel.com>,
	Alexander Duyck <alexander.h.duyck@linux.intel.com>,
	linux-nvdimm@lists.01.org, x86@kernel.org, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org, jason.zeng@intel.com
Subject: Re: [PATCH v4 2/2] kvm: Use huge pages for DAX-backed files
Date: Thu, 12 Dec 2019 12:03:38 -0500	[thread overview]
Message-ID: <ce8fa354-4530-2a01-6ccc-3cffd0692547@google.com> (raw)
In-Reply-To: <376DB19A-4EF1-42BF-A73C-741558E397D4@oracle.com>

On 12/12/19 7:33 AM, Liran Alon wrote:
>> +	/*
>> +	 * Our caller grabbed the KVM mmu_lock with a successful
>> +	 * mmu_notifier_retry, so we're safe to walk the page table.
>> +	 */
>> +	switch (dev_pagemap_mapping_shift(hva, current->mm)) {
> Doesn’t dev_pagemap_mapping_shift() get “struct page” as first parameter?
> Was this changed by a commit I missed?

I changed this in Patch 1.  The place I call it in KVM has the address 
and mm available, which is the only think dev_pagemap_mapping_shift() 
really needs.  (The first thing it did was convert page to address).

I'll add some more text to patch 1's commit message about that.

Thanks,

Barret



  parent reply	other threads:[~2019-12-12 17:03 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-11 21:32 [PATCH v4 0/2] kvm: Use huge pages for DAX-backed files Barret Rhoden
2019-12-11 21:32 ` Barret Rhoden
2019-12-11 21:32 ` [PATCH v4 1/2] mm: make dev_pagemap_mapping_shift() externally visible Barret Rhoden
2019-12-11 21:32   ` Barret Rhoden
2019-12-11 21:32 ` [PATCH v4 2/2] kvm: Use huge pages for DAX-backed files Barret Rhoden
2019-12-11 21:32   ` Barret Rhoden
2019-12-12  0:21   ` Paolo Bonzini
2019-12-12  0:21     ` Paolo Bonzini
2019-12-12 12:22   ` David Hildenbrand
2019-12-12 12:22     ` David Hildenbrand
2019-12-12 16:31     ` Barret Rhoden
2019-12-12 16:31       ` Barret Rhoden
2019-12-12 12:33   ` Liran Alon
2019-12-12 12:33     ` Liran Alon
2019-12-12 16:54     ` Dan Williams
2019-12-12 16:54       ` Dan Williams
2019-12-12 17:39       ` Liran Alon
2019-12-12 17:39         ` Liran Alon
2019-12-12 17:59         ` Dan Williams
2019-12-12 17:59           ` Dan Williams
2019-12-12 18:32           ` Liran Alon
2019-12-12 18:32             ` Liran Alon
2019-12-12 17:03     ` Barret Rhoden [this message]
2019-12-12 17:03       ` Barret Rhoden
2019-12-12 17:34   ` Sean Christopherson
2019-12-12 17:34     ` Sean Christopherson
2019-12-12 17:37     ` Dan Williams
2019-12-12 17:37       ` Dan Williams
2019-12-12 19:16       ` Barret Rhoden
2019-12-12 19:16         ` Barret Rhoden
2019-12-12 19:48         ` Dan Williams
2019-12-12 19:48           ` Dan Williams
2019-12-12 20:08           ` Barret Rhoden
2019-12-12 20:08             ` Barret Rhoden
2019-12-12 17:45     ` Liran Alon
2019-12-12 17:45       ` Liran Alon
2019-12-12  0:22 ` [PATCH v4 0/2] " Paolo Bonzini
2019-12-12  0:22   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ce8fa354-4530-2a01-6ccc-3cffd0692547@google.com \
    --to=brho@google.com \
    --cc=alexander.h.duyck@linux.intel.com \
    --cc=david@redhat.com \
    --cc=jason.zeng@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=liran.alon@oracle.com \
    --cc=pbonzini@redhat.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.