Re: Fwd: [PATCH v3 1/3] drm/xe: Toggle the D3Cold enable flag at runtime resume

["Poosa, Karthik" <karthik.poosa@intel.com>]

>
> We enable this flag during runtime suspend, need to set it back to
> false early during resume to maintain consistency in pci driver's
> internal state. d3cold_toggle() updates the root port's ability
> to go into d3cold via the dev->no_d3cold flag. With this patch, we
> are ensuring this internal state remains consistent with that of
> the endpoint.
>
> v2: Clarify the commit message (Matt Auld)
>
> Cc: Matthew Auld <matthew.auld@intel.com>
> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>

Fixes tag is missing

Fixes: f026520367be ("drm/xe: Only set PCI d3cold_allowed when we are 
really allowing.")

Patch looks fine.
Acked-by: Karthik Poosa <karthik.poosa@intel.com>
> ---
> drivers/gpu/drm/xe/xe_pci.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
> index 0c13eb901aa7..d13599d79ae9 100644
> --- a/drivers/gpu/drm/xe/xe_pci.c
> +++ b/drivers/gpu/drm/xe/xe_pci.c
> @@ -1456,6 +1456,9 @@ static int xe_pci_runtime_resume(struct device *dev)
> struct xe_device *xe = pdev_to_xe_device(pdev);
> int err;
> + if (xe->d3cold.allowed)
> + d3cold_toggle(pdev, D3COLD_DISABLE);
> +
> err = pci_set_power_state(pdev, PCI_D0);
> if (err)
> return err;
> -- 
> 2.53.0
>