Re: [PATCH mptcp-next v2 13/14] mptcp: pm: split in-kernel PM specific code

[Matthieu Baerts <matttbe@kernel.org>]

Hello,

On 28/02/2025 14:31, Matthieu Baerts (NGI0) wrote:
> Before this patch, the PM code was dispersed in different places:
> 
> - pm.c had common code for all PMs
> 
> - pm_netlink.c was supposed to be about the in-kernel PM, but also had
>   exported common Netlink helpers, NL events for PM userspace daemons,
>   etc. quite confusing.
> 
> To clarify the code, a reorganisation is suggested here, only by moving
> code around to avoid confusions:
> 
> - pm_netlink.c now only contains common PM Netlink code:
>   - PM events: this code was already there
>   - shared helpers around Netlink code that were already there as well
>   - more shared Netlink commands code from pm.c will come after
(...)

> diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c
> index e4abb94e8c0bd42533500587f5f6e88038b2db62..530b2362a5a35c5ef44d3bf495c8103bdfa08cff 100644
> --- a/net/mptcp/pm_netlink.c
> +++ b/net/mptcp/pm_netlink.c

(...)

> -void __init mptcp_pm_nl_init(void)
> -{
> -	if (register_pernet_subsys(&mptcp_pm_pernet_ops) < 0)
> -		panic("Failed to register MPTCP PM pernet subsystem.\n");
> -
> -	if (genl_register_family(&mptcp_genl_family))
> -		panic("Failed to register MPTCP PM netlink family\n");

I think it would make more sense to keep the mptcp_genl_family
registration here in pm_netlink.c.

I can do the modification when applying the patches.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.