From: "Wang, Zhi A" <zhi.a.wang@intel.com>
To: Rikard Falkeborn <rikard.falkeborn@gmail.com>,
Zhenyu Wang <zhenyuw@linux.intel.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>
Cc: "intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"intel-gvt-dev@lists.freedesktop.org"
<intel-gvt-dev@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH 6/9] drm/i915/gvt: Constify cmd_interrupt_events
Date: Fri, 10 Dec 2021 08:12:33 +0000 [thread overview]
Message-ID: <cf2911d7-dbd0-e38b-4c7d-c197bc4af306@intel.com> (raw)
In-Reply-To: <20211204105527.15741-7-rikard.falkeborn@gmail.com>
On 12/4/2021 12:55 PM, Rikard Falkeborn wrote:
> It is never modified, so make it const to allow the compiler to put it
> in read-only memory.
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
> ---
> drivers/gpu/drm/i915/gvt/cmd_parser.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gvt/cmd_parser.c b/drivers/gpu/drm/i915/gvt/cmd_parser.c
> index c4118b808268..ce9307546e7f 100644
> --- a/drivers/gpu/drm/i915/gvt/cmd_parser.c
> +++ b/drivers/gpu/drm/i915/gvt/cmd_parser.c
> @@ -1144,7 +1144,7 @@ struct cmd_interrupt_event {
> int mi_user_interrupt;
> };
>
> -static struct cmd_interrupt_event cmd_interrupt_events[] = {
> +static const struct cmd_interrupt_event cmd_interrupt_events[] = {
> [RCS0] = {
> .pipe_control_notify = RCS_PIPE_CONTROL,
> .mi_flush_dw = INTEL_GVT_EVENT_RESERVED,
Reviewed-by: Zhi Wang <zhi.a.wang@intel.com>
WARNING: multiple messages have this Message-ID (diff)
From: "Wang, Zhi A" <zhi.a.wang@intel.com>
To: Rikard Falkeborn <rikard.falkeborn@gmail.com>,
Zhenyu Wang <zhenyuw@linux.intel.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>
Cc: "intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"intel-gvt-dev@lists.freedesktop.org"
<intel-gvt-dev@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 6/9] drm/i915/gvt: Constify cmd_interrupt_events
Date: Fri, 10 Dec 2021 08:12:33 +0000 [thread overview]
Message-ID: <cf2911d7-dbd0-e38b-4c7d-c197bc4af306@intel.com> (raw)
In-Reply-To: <20211204105527.15741-7-rikard.falkeborn@gmail.com>
On 12/4/2021 12:55 PM, Rikard Falkeborn wrote:
> It is never modified, so make it const to allow the compiler to put it
> in read-only memory.
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
> ---
> drivers/gpu/drm/i915/gvt/cmd_parser.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gvt/cmd_parser.c b/drivers/gpu/drm/i915/gvt/cmd_parser.c
> index c4118b808268..ce9307546e7f 100644
> --- a/drivers/gpu/drm/i915/gvt/cmd_parser.c
> +++ b/drivers/gpu/drm/i915/gvt/cmd_parser.c
> @@ -1144,7 +1144,7 @@ struct cmd_interrupt_event {
> int mi_user_interrupt;
> };
>
> -static struct cmd_interrupt_event cmd_interrupt_events[] = {
> +static const struct cmd_interrupt_event cmd_interrupt_events[] = {
> [RCS0] = {
> .pipe_control_notify = RCS_PIPE_CONTROL,
> .mi_flush_dw = INTEL_GVT_EVENT_RESERVED,
Reviewed-by: Zhi Wang <zhi.a.wang@intel.com>
WARNING: multiple messages have this Message-ID (diff)
From: "Wang, Zhi A" <zhi.a.wang@intel.com>
To: Rikard Falkeborn <rikard.falkeborn@gmail.com>,
Zhenyu Wang <zhenyuw@linux.intel.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>
Cc: "intel-gvt-dev@lists.freedesktop.org"
<intel-gvt-dev@lists.freedesktop.org>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 6/9] drm/i915/gvt: Constify cmd_interrupt_events
Date: Fri, 10 Dec 2021 08:12:33 +0000 [thread overview]
Message-ID: <cf2911d7-dbd0-e38b-4c7d-c197bc4af306@intel.com> (raw)
In-Reply-To: <20211204105527.15741-7-rikard.falkeborn@gmail.com>
On 12/4/2021 12:55 PM, Rikard Falkeborn wrote:
> It is never modified, so make it const to allow the compiler to put it
> in read-only memory.
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
> ---
> drivers/gpu/drm/i915/gvt/cmd_parser.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gvt/cmd_parser.c b/drivers/gpu/drm/i915/gvt/cmd_parser.c
> index c4118b808268..ce9307546e7f 100644
> --- a/drivers/gpu/drm/i915/gvt/cmd_parser.c
> +++ b/drivers/gpu/drm/i915/gvt/cmd_parser.c
> @@ -1144,7 +1144,7 @@ struct cmd_interrupt_event {
> int mi_user_interrupt;
> };
>
> -static struct cmd_interrupt_event cmd_interrupt_events[] = {
> +static const struct cmd_interrupt_event cmd_interrupt_events[] = {
> [RCS0] = {
> .pipe_control_notify = RCS_PIPE_CONTROL,
> .mi_flush_dw = INTEL_GVT_EVENT_RESERVED,
Reviewed-by: Zhi Wang <zhi.a.wang@intel.com>
next prev parent reply other threads:[~2021-12-10 8:12 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-04 10:55 [Intel-gfx] [PATCH 0/9] drm/i915/gvt: Constify static structs Rikard Falkeborn
2021-12-04 10:55 ` Rikard Falkeborn
2021-12-04 10:55 ` Rikard Falkeborn
2021-12-04 10:55 ` [Intel-gfx] [PATCH 1/9] drm/i915/gvt: Constify intel_gvt_gtt_pte_ops Rikard Falkeborn
2021-12-04 10:55 ` Rikard Falkeborn
2021-12-04 10:55 ` Rikard Falkeborn
2021-12-10 8:59 ` [Intel-gfx] " Wang, Zhi A
2021-12-10 8:59 ` Wang, Zhi A
2021-12-10 8:59 ` Wang, Zhi A
2021-12-04 10:55 ` [Intel-gfx] [PATCH 2/9] " Rikard Falkeborn
2021-12-04 10:55 ` Rikard Falkeborn
2021-12-04 10:55 ` Rikard Falkeborn
2021-12-10 8:11 ` [Intel-gfx] " Wang, Zhi A
2021-12-10 8:11 ` Wang, Zhi A
2021-12-10 8:11 ` Wang, Zhi A
2021-12-04 10:55 ` [Intel-gfx] [PATCH 3/9] drm/i915/gvt: Constify intel_gvt_irq_ops Rikard Falkeborn
2021-12-04 10:55 ` Rikard Falkeborn
2021-12-04 10:55 ` Rikard Falkeborn
2021-12-10 8:11 ` [Intel-gfx] " Wang, Zhi A
2021-12-10 8:11 ` Wang, Zhi A
2021-12-10 8:11 ` Wang, Zhi A
2021-12-04 10:55 ` [Intel-gfx] [PATCH 4/9] drm/i915/gvt: Constify intel_gvt_sched_policy_ops Rikard Falkeborn
2021-12-04 10:55 ` Rikard Falkeborn
2021-12-04 10:55 ` Rikard Falkeborn
2021-12-10 8:11 ` [Intel-gfx] " Wang, Zhi A
2021-12-10 8:11 ` Wang, Zhi A
2021-12-10 8:11 ` Wang, Zhi A
2021-12-04 10:55 ` [Intel-gfx] [PATCH 5/9] drm/i915/gvt: Constify gvt_mmio_block Rikard Falkeborn
2021-12-04 10:55 ` Rikard Falkeborn
2021-12-04 10:55 ` Rikard Falkeborn
2021-12-10 8:12 ` [Intel-gfx] " Wang, Zhi A
2021-12-10 8:12 ` Wang, Zhi A
2021-12-10 8:12 ` Wang, Zhi A
2021-12-04 10:55 ` [Intel-gfx] [PATCH 6/9] drm/i915/gvt: Constify cmd_interrupt_events Rikard Falkeborn
2021-12-04 10:55 ` Rikard Falkeborn
2021-12-04 10:55 ` Rikard Falkeborn
2021-12-10 8:12 ` Wang, Zhi A [this message]
2021-12-10 8:12 ` Wang, Zhi A
2021-12-10 8:12 ` Wang, Zhi A
2021-12-04 10:55 ` [Intel-gfx] [PATCH 7/9] drm/i915/gvt: Constify formats Rikard Falkeborn
2021-12-04 10:55 ` Rikard Falkeborn
2021-12-04 10:55 ` Rikard Falkeborn
2021-12-10 8:20 ` [Intel-gfx] " Wang, Zhi A
2021-12-10 8:20 ` Wang, Zhi A
2021-12-10 8:20 ` Wang, Zhi A
2021-12-12 13:21 ` [Intel-gfx] " Rikard Falkeborn
2021-12-12 13:21 ` Rikard Falkeborn
2021-12-12 13:21 ` Rikard Falkeborn
2021-12-04 10:55 ` [Intel-gfx] [PATCH 8/9] drm/i915/gvt: Constify gtt_type_table_entry Rikard Falkeborn
2021-12-04 10:55 ` Rikard Falkeborn
2021-12-04 10:55 ` Rikard Falkeborn
2021-12-10 8:20 ` [Intel-gfx] " Wang, Zhi A
2021-12-10 8:20 ` Wang, Zhi A
2021-12-10 8:20 ` Wang, Zhi A
2021-12-04 10:55 ` [Intel-gfx] [PATCH 9/9] drm/i915/gvt: Constify vgpu_types Rikard Falkeborn
2021-12-04 10:55 ` Rikard Falkeborn
2021-12-04 10:55 ` Rikard Falkeborn
2021-12-10 8:20 ` [Intel-gfx] " Wang, Zhi A
2021-12-10 8:20 ` Wang, Zhi A
2021-12-10 8:20 ` Wang, Zhi A
2021-12-06 13:42 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gvt: Constify static structs Patchwork
2021-12-06 14:19 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2021-12-10 9:00 ` [Intel-gfx] [PATCH 0/9] " Wang, Zhi A
2021-12-10 9:00 ` Wang, Zhi A
2021-12-10 9:00 ` Wang, Zhi A
2021-12-12 13:25 ` [Intel-gfx] " Rikard Falkeborn
2021-12-12 13:25 ` Rikard Falkeborn
2021-12-12 13:25 ` Rikard Falkeborn
2021-12-16 19:21 ` [Intel-gfx] " Wang, Zhi A
2021-12-16 19:21 ` Wang, Zhi A
2021-12-16 19:21 ` Wang, Zhi A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf2911d7-dbd0-e38b-4c7d-c197bc4af306@intel.com \
--to=zhi.a.wang@intel.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rikard.falkeborn@gmail.com \
--cc=rodrigo.vivi@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
--cc=zhenyuw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.