From: Lu Baolu <baolu.lu@linux.intel.com>
To: Jacob Pan <jacob.jun.pan@linux.intel.com>
Cc: kevin.tian@intel.com, Yi Sun <yi.y.sun@linux.intel.com>,
ashok.raj@intel.com, kvm@vger.kernel.org,
sanjay.k.kumar@intel.com, yi.y.sun@intel.com,
linux-kernel@vger.kernel.org,
Alex Williamson <alex.williamson@redhat.com>,
iommu@lists.linux-foundation.org,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH v2 5/8] iommu/vt-d: Add first level page table interfaces
Date: Tue, 3 Dec 2019 10:36:48 +0800 [thread overview]
Message-ID: <cf76308c-e021-61d1-de74-01acc657c61c@linux.intel.com> (raw)
In-Reply-To: <20191202152732.3d9c6589@jacob-builder>
Hi,
On 12/3/19 7:27 AM, Jacob Pan wrote:
> On Thu, 28 Nov 2019 10:25:47 +0800
> Lu Baolu<baolu.lu@linux.intel.com> wrote:
>
>> This adds functions to manipulate first level page tables
>> which could be used by a scalale mode capable IOMMU unit.
>>
> FL and SL page tables are very similar, and I presume we are not using
> all the flag bits in FL paging structures for DMA mapping. Are there
> enough relevant differences to warrant a new set of helper functions
> for FL? Or we can merge into one.
>
I ever thought about this and I am still open for this suggestion.
We had a quick compare on these two page tables. The only concern is the
read/write/present encoding. The present bit in first level implies read
permission while second level page table explicitly has a READ bit.
(recalled from memory, correct me if it's bad. :-)).
Anyway, let's listen to more opinions.
Best regards,
baolu
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Lu Baolu <baolu.lu@linux.intel.com>
To: Jacob Pan <jacob.jun.pan@linux.intel.com>
Cc: baolu.lu@linux.intel.com, Joerg Roedel <joro@8bytes.org>,
David Woodhouse <dwmw2@infradead.org>,
Alex Williamson <alex.williamson@redhat.com>,
ashok.raj@intel.com, sanjay.k.kumar@intel.com,
kevin.tian@intel.com, yi.l.liu@intel.com, yi.y.sun@intel.com,
Peter Xu <peterx@redhat.com>,
iommu@lists.linux-foundation.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, Yi Sun <yi.y.sun@linux.intel.com>
Subject: Re: [PATCH v2 5/8] iommu/vt-d: Add first level page table interfaces
Date: Tue, 3 Dec 2019 10:36:48 +0800 [thread overview]
Message-ID: <cf76308c-e021-61d1-de74-01acc657c61c@linux.intel.com> (raw)
In-Reply-To: <20191202152732.3d9c6589@jacob-builder>
Hi,
On 12/3/19 7:27 AM, Jacob Pan wrote:
> On Thu, 28 Nov 2019 10:25:47 +0800
> Lu Baolu<baolu.lu@linux.intel.com> wrote:
>
>> This adds functions to manipulate first level page tables
>> which could be used by a scalale mode capable IOMMU unit.
>>
> FL and SL page tables are very similar, and I presume we are not using
> all the flag bits in FL paging structures for DMA mapping. Are there
> enough relevant differences to warrant a new set of helper functions
> for FL? Or we can merge into one.
>
I ever thought about this and I am still open for this suggestion.
We had a quick compare on these two page tables. The only concern is the
read/write/present encoding. The present bit in first level implies read
permission while second level page table explicitly has a READ bit.
(recalled from memory, correct me if it's bad. :-)).
Anyway, let's listen to more opinions.
Best regards,
baolu
next prev parent reply other threads:[~2019-12-03 2:37 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-28 2:25 [PATCH v2 0/8] Use 1st-level for DMA remapping Lu Baolu
2019-11-28 2:25 ` Lu Baolu
2019-11-28 2:25 ` [PATCH v2 1/8] iommu/vt-d: Add per domain page table ops Lu Baolu
2019-11-28 2:25 ` Lu Baolu
2019-11-28 2:25 ` [PATCH v2 2/8] iommu/vt-d: Move domain_flush_cache helper into header Lu Baolu
2019-11-28 2:25 ` Lu Baolu
2019-11-28 2:25 ` [PATCH v2 3/8] iommu/vt-d: Implement second level page table ops Lu Baolu
2019-11-28 2:25 ` Lu Baolu
2019-11-28 2:25 ` [PATCH v2 4/8] iommu/vt-d: Apply per domain " Lu Baolu
2019-11-28 2:25 ` Lu Baolu
2019-11-28 2:25 ` [PATCH v2 5/8] iommu/vt-d: Add first level page table interfaces Lu Baolu
2019-11-28 2:25 ` Lu Baolu
2019-12-02 23:27 ` Jacob Pan
2019-12-02 23:27 ` Jacob Pan
2019-12-03 2:36 ` Lu Baolu [this message]
2019-12-03 2:36 ` Lu Baolu
2019-12-11 1:56 ` Lu Baolu
2019-12-11 1:56 ` Lu Baolu
2019-11-28 2:25 ` [PATCH v2 6/8] iommu/vt-d: Implement first level page table ops Lu Baolu
2019-11-28 2:25 ` Lu Baolu
2019-11-28 2:25 ` [PATCH v2 7/8] iommu/vt-d: Identify domains using first level page table Lu Baolu
2019-11-28 2:25 ` Lu Baolu
2019-11-28 2:25 ` [PATCH v2 8/8] iommu/vt-d: Add set domain DOMAIN_ATTR_NESTING attr Lu Baolu
2019-11-28 2:25 ` Lu Baolu
2019-12-02 20:19 ` [PATCH v2 0/8] Use 1st-level for DMA remapping Jacob Pan
2019-12-02 20:19 ` Jacob Pan
2019-12-03 2:19 ` Lu Baolu
2019-12-03 2:19 ` Lu Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf76308c-e021-61d1-de74-01acc657c61c@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=alex.williamson@redhat.com \
--cc=ashok.raj@intel.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jacob.jun.pan@linux.intel.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sanjay.k.kumar@intel.com \
--cc=yi.y.sun@intel.com \
--cc=yi.y.sun@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.