* [PATCH 0/2] add support for meson a1 PWM in dts and bindings @ 2024-07-01 13:01 ` George Stark 0 siblings, 0 replies; 23+ messages in thread From: George Stark @ 2024-07-01 13:01 UTC (permalink / raw) To: ukleinek, robh, krzk+dt, conor+dt, neil.armstrong, khilman, jbrunet, martin.blumenstingl, hkallweit1 Cc: linux-pwm, devicetree, linux-amlogic, linux-arm-kernel, linux-kernel, kernel, George Stark Add support for meson a1 PWM in dts and bindings. Due to pwm driver code is fully the same for a1 and s4 then a1 compatible defined with s4 as fallback. George Stark (2): dt-bindings: pwm: amlogic: Add new bindings for meson A1 pwm arm64: dts: meson: a1: add definitions for meson pwm .../devicetree/bindings/pwm/pwm-amlogic.yaml | 2 + arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 215 ++++++++++++++++++ 2 files changed, 217 insertions(+) -- 2.25.1 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH 0/2] add support for meson a1 PWM in dts and bindings @ 2024-07-01 13:01 ` George Stark 0 siblings, 0 replies; 23+ messages in thread From: George Stark @ 2024-07-01 13:01 UTC (permalink / raw) To: ukleinek, robh, krzk+dt, conor+dt, neil.armstrong, khilman, jbrunet, martin.blumenstingl, hkallweit1 Cc: linux-pwm, devicetree, linux-amlogic, linux-arm-kernel, linux-kernel, kernel, George Stark Add support for meson a1 PWM in dts and bindings. Due to pwm driver code is fully the same for a1 and s4 then a1 compatible defined with s4 as fallback. George Stark (2): dt-bindings: pwm: amlogic: Add new bindings for meson A1 pwm arm64: dts: meson: a1: add definitions for meson pwm .../devicetree/bindings/pwm/pwm-amlogic.yaml | 2 + arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 215 ++++++++++++++++++ 2 files changed, 217 insertions(+) -- 2.25.1 ^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH 1/2] dt-bindings: pwm: amlogic: Add new bindings for meson A1 pwm 2024-07-01 13:01 ` George Stark @ 2024-07-01 13:01 ` George Stark -1 siblings, 0 replies; 23+ messages in thread From: George Stark @ 2024-07-01 13:01 UTC (permalink / raw) To: ukleinek, robh, krzk+dt, conor+dt, neil.armstrong, khilman, jbrunet, martin.blumenstingl, hkallweit1 Cc: linux-pwm, devicetree, linux-amlogic, linux-arm-kernel, linux-kernel, kernel, George Stark, Dmitry Rokosov The chip has 3 dual-channel PWM modules PWM_AB, PWM_CD, PWM_EF. Signed-off-by: George Stark <gnstark@salutedevices.com> Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com> --- Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml index 1d71d4f8f328..63c6018b6b7c 100644 --- a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml +++ b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml @@ -37,6 +37,7 @@ properties: - enum: - amlogic,meson8-pwm-v2 - amlogic,meson-s4-pwm + - amlogic,meson-a1-pwm, amlogic,meson-s4-pwm - items: - enum: - amlogic,meson8b-pwm-v2 @@ -126,6 +127,7 @@ allOf: contains: enum: - amlogic,meson-s4-pwm + - amlogic,meson-a1-pwm then: properties: clocks: -- 2.25.1 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH 1/2] dt-bindings: pwm: amlogic: Add new bindings for meson A1 pwm @ 2024-07-01 13:01 ` George Stark 0 siblings, 0 replies; 23+ messages in thread From: George Stark @ 2024-07-01 13:01 UTC (permalink / raw) To: ukleinek, robh, krzk+dt, conor+dt, neil.armstrong, khilman, jbrunet, martin.blumenstingl, hkallweit1 Cc: linux-pwm, devicetree, linux-amlogic, linux-arm-kernel, linux-kernel, kernel, George Stark, Dmitry Rokosov The chip has 3 dual-channel PWM modules PWM_AB, PWM_CD, PWM_EF. Signed-off-by: George Stark <gnstark@salutedevices.com> Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com> --- Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml index 1d71d4f8f328..63c6018b6b7c 100644 --- a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml +++ b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml @@ -37,6 +37,7 @@ properties: - enum: - amlogic,meson8-pwm-v2 - amlogic,meson-s4-pwm + - amlogic,meson-a1-pwm, amlogic,meson-s4-pwm - items: - enum: - amlogic,meson8b-pwm-v2 @@ -126,6 +127,7 @@ allOf: contains: enum: - amlogic,meson-s4-pwm + - amlogic,meson-a1-pwm then: properties: clocks: -- 2.25.1 ^ permalink raw reply related [flat|nested] 23+ messages in thread
* Re: [PATCH 1/2] dt-bindings: pwm: amlogic: Add new bindings for meson A1 pwm 2024-07-01 13:01 ` George Stark @ 2024-07-01 13:25 ` Krzysztof Kozlowski -1 siblings, 0 replies; 23+ messages in thread From: Krzysztof Kozlowski @ 2024-07-01 13:25 UTC (permalink / raw) To: George Stark, ukleinek, robh, krzk+dt, conor+dt, neil.armstrong, khilman, jbrunet, martin.blumenstingl, hkallweit1 Cc: linux-pwm, devicetree, linux-amlogic, linux-arm-kernel, linux-kernel, kernel, Dmitry Rokosov On 01/07/2024 15:01, George Stark wrote: > The chip has 3 dual-channel PWM modules PWM_AB, PWM_CD, PWM_EF. > > Signed-off-by: George Stark <gnstark@salutedevices.com> > Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com> > --- > Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml > index 1d71d4f8f328..63c6018b6b7c 100644 > --- a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml > +++ b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml > @@ -37,6 +37,7 @@ properties: > - enum: > - amlogic,meson8-pwm-v2 > - amlogic,meson-s4-pwm > + - amlogic,meson-a1-pwm, amlogic,meson-s4-pwm This is not valid, you cannot have such syntax (and there is no single DT schema file like this). It does not look like you tested the bindings, at least after quick look. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Maybe you need to update your dtschema and yamllint. Best regards, Krzysztof _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 1/2] dt-bindings: pwm: amlogic: Add new bindings for meson A1 pwm @ 2024-07-01 13:25 ` Krzysztof Kozlowski 0 siblings, 0 replies; 23+ messages in thread From: Krzysztof Kozlowski @ 2024-07-01 13:25 UTC (permalink / raw) To: George Stark, ukleinek, robh, krzk+dt, conor+dt, neil.armstrong, khilman, jbrunet, martin.blumenstingl, hkallweit1 Cc: linux-pwm, devicetree, linux-amlogic, linux-arm-kernel, linux-kernel, kernel, Dmitry Rokosov On 01/07/2024 15:01, George Stark wrote: > The chip has 3 dual-channel PWM modules PWM_AB, PWM_CD, PWM_EF. > > Signed-off-by: George Stark <gnstark@salutedevices.com> > Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com> > --- > Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml > index 1d71d4f8f328..63c6018b6b7c 100644 > --- a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml > +++ b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml > @@ -37,6 +37,7 @@ properties: > - enum: > - amlogic,meson8-pwm-v2 > - amlogic,meson-s4-pwm > + - amlogic,meson-a1-pwm, amlogic,meson-s4-pwm This is not valid, you cannot have such syntax (and there is no single DT schema file like this). It does not look like you tested the bindings, at least after quick look. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Maybe you need to update your dtschema and yamllint. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH 2/2] arm64: dts: meson: a1: add definitions for meson pwm 2024-07-01 13:01 ` George Stark @ 2024-07-01 13:01 ` George Stark -1 siblings, 0 replies; 23+ messages in thread From: George Stark @ 2024-07-01 13:01 UTC (permalink / raw) To: ukleinek, robh, krzk+dt, conor+dt, neil.armstrong, khilman, jbrunet, martin.blumenstingl, hkallweit1 Cc: linux-pwm, devicetree, linux-amlogic, linux-arm-kernel, linux-kernel, kernel, George Stark, Dmitry Rokosov From: George Stark <GNStark@sberdevices.ru> The chip has 3 dual-channel PWM modules PWM_AB, PWM_CD, PWM_EF those can be connected to various digital I/O pins. Each of 6 PWM is driven by individually selected clock parent and 8-bit divider. The PWM signal is generated using two 16-bit counters. Signed-off-by: George Stark <GNStark@sberdevices.ru> Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com> --- arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 215 ++++++++++++++++++++++ 1 file changed, 215 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi index 2a69e1e41bdc..d93b10bd156b 100644 --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi @@ -307,6 +307,188 @@ mux { }; }; + pwm_a_pins1: pwm-a-pins1 { + mux { + groups = "pwm_a_x6"; + function = "pwm_a"; + }; + }; + + pwm_a_pins2: pwm-a-pins2 { + mux { + groups = "pwm_a_x7"; + function = "pwm_a"; + }; + }; + + pwm_a_pins3: pwm-a-pins3 { + mux { + groups = "pwm_a_f10"; + function = "pwm_a"; + }; + }; + + pwm_a_pins4: pwm-a-pins4 { + mux { + groups = "pwm_a_f6"; + function = "pwm_a"; + }; + }; + + pwm_a_pins5: pwm-a-pins5 { + mux { + groups = "pwm_a_a"; + function = "pwm_a"; + }; + }; + + pwm_b_pins1: pwm-b-pins1 { + mux { + groups = "pwm_b_x"; + function = "pwm_b"; + }; + }; + + pwm_b_pins2: pwm-b-pins2 { + mux { + groups = "pwm_b_f"; + function = "pwm_b"; + }; + }; + + pwm_b_pins3: pwm-b-pins3 { + mux { + groups = "pwm_b_a"; + function = "pwm_b"; + }; + }; + + pwm_c_pins1: pwm-c-pins1 { + mux { + groups = "pwm_c_x"; + function = "pwm_c"; + }; + }; + + pwm_c_pins2: pwm-c-pins2 { + mux { + groups = "pwm_c_f3"; + function = "pwm_c"; + }; + }; + + pwm_c_pins3: pwm-c-pins3 { + mux { + groups = "pwm_c_f8"; + function = "pwm_c"; + }; + }; + + pwm_c_pins4: pwm-c-pins4 { + mux { + groups = "pwm_c_a"; + function = "pwm_c"; + }; + }; + + pwm_d_pins1: pwm-d-pins1 { + mux { + groups = "pwm_d_x15"; + function = "pwm_d"; + }; + }; + + pwm_d_pins2: pwm-d-pins2 { + mux { + groups = "pwm_d_x13"; + function = "pwm_d"; + }; + }; + + pwm_d_pins3: pwm-d-pins3 { + mux { + groups = "pwm_d_x10"; + function = "pwm_d"; + }; + }; + + pwm_d_pins4: pwm-d-pins4 { + mux { + groups = "pwm_d_f"; + function = "pwm_d"; + }; + }; + + pwm_e_pins1: pwm-e-pins1 { + mux { + groups = "pwm_e_p"; + function = "pwm_e"; + }; + }; + + pwm_e_pins2: pwm-e-pins2 { + mux { + groups = "pwm_e_x16"; + function = "pwm_e"; + }; + }; + + pwm_e_pins3: pwm-e-pins3 { + mux { + groups = "pwm_e_x14"; + function = "pwm_e"; + }; + }; + + pwm_e_pins4: pwm-e-pins4 { + mux { + groups = "pwm_e_x2"; + function = "pwm_e"; + }; + }; + + pwm_e_pins5: pwm-e-pins5 { + mux { + groups = "pwm_e_f"; + function = "pwm_e"; + }; + }; + + pwm_e_pins6: pwm-e-pins6 { + mux { + groups = "pwm_e_a"; + function = "pwm_e"; + }; + }; + + pwm_f_pins1: pwm-f-pins1 { + mux { + groups = "pwm_f_b"; + function = "pwm_f"; + }; + }; + + pwm_f_pins2: pwm-f-pins2 { + mux { + groups = "pwm_f_x"; + function = "pwm_f"; + }; + }; + + pwm_f_pins3: pwm-f-pins3 { + mux { + groups = "pwm_f_f4"; + function = "pwm_f"; + }; + }; + + pwm_f_pins4: pwm-f-pins4 { + mux { + groups = "pwm_f_f12"; + function = "pwm_f"; + }; + }; + sdio_pins: sdio { mux0 { groups = "sdcard_d0_x", @@ -648,6 +830,28 @@ uart_AO_B: serial@2000 { status = "disabled"; }; + pwm_ab: pwm@2400 { + compatible = "amlogic,meson-a1-pwm", + "amlogic,meson-s4-pwm"; + reg = <0x0 0x2400 0x0 0x24>; + #pwm-cells = <3>; + clocks = <&clkc_periphs CLKID_PWM_A>, + <&clkc_periphs CLKID_PWM_B>; + power-domains = <&pwrc PWRC_I2C_ID>; + status = "disabled"; + }; + + pwm_cd: pwm@2800 { + compatible = "amlogic,meson-a1-pwm", + "amlogic,meson-s4-pwm"; + reg = <0x0 0x2800 0x0 0x24>; + #pwm-cells = <3>; + clocks = <&clkc_periphs CLKID_PWM_C>, + <&clkc_periphs CLKID_PWM_D>; + power-domains = <&pwrc PWRC_I2C_ID>; + status = "disabled"; + }; + saradc: adc@2c00 { compatible = "amlogic,meson-g12a-saradc", "amlogic,meson-saradc"; @@ -731,6 +935,17 @@ sec_AO: ao-secure@5a20 { amlogic,has-chip-id; }; + pwm_ef: pwm@5400 { + compatible = "amlogic,meson-a1-pwm", + "amlogic,meson-s4-pwm"; + reg = <0x0 0x5400 0x0 0x24>; + #pwm-cells = <3>; + clocks = <&clkc_periphs CLKID_PWM_E>, + <&clkc_periphs CLKID_PWM_F>; + power-domains = <&pwrc PWRC_I2C_ID>; + status = "disabled"; + }; + clkc_pll: pll-clock-controller@7c80 { compatible = "amlogic,a1-pll-clkc"; reg = <0 0x7c80 0 0x18c>; -- 2.25.1 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH 2/2] arm64: dts: meson: a1: add definitions for meson pwm @ 2024-07-01 13:01 ` George Stark 0 siblings, 0 replies; 23+ messages in thread From: George Stark @ 2024-07-01 13:01 UTC (permalink / raw) To: ukleinek, robh, krzk+dt, conor+dt, neil.armstrong, khilman, jbrunet, martin.blumenstingl, hkallweit1 Cc: linux-pwm, devicetree, linux-amlogic, linux-arm-kernel, linux-kernel, kernel, George Stark, Dmitry Rokosov From: George Stark <GNStark@sberdevices.ru> The chip has 3 dual-channel PWM modules PWM_AB, PWM_CD, PWM_EF those can be connected to various digital I/O pins. Each of 6 PWM is driven by individually selected clock parent and 8-bit divider. The PWM signal is generated using two 16-bit counters. Signed-off-by: George Stark <GNStark@sberdevices.ru> Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com> --- arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 215 ++++++++++++++++++++++ 1 file changed, 215 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi index 2a69e1e41bdc..d93b10bd156b 100644 --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi @@ -307,6 +307,188 @@ mux { }; }; + pwm_a_pins1: pwm-a-pins1 { + mux { + groups = "pwm_a_x6"; + function = "pwm_a"; + }; + }; + + pwm_a_pins2: pwm-a-pins2 { + mux { + groups = "pwm_a_x7"; + function = "pwm_a"; + }; + }; + + pwm_a_pins3: pwm-a-pins3 { + mux { + groups = "pwm_a_f10"; + function = "pwm_a"; + }; + }; + + pwm_a_pins4: pwm-a-pins4 { + mux { + groups = "pwm_a_f6"; + function = "pwm_a"; + }; + }; + + pwm_a_pins5: pwm-a-pins5 { + mux { + groups = "pwm_a_a"; + function = "pwm_a"; + }; + }; + + pwm_b_pins1: pwm-b-pins1 { + mux { + groups = "pwm_b_x"; + function = "pwm_b"; + }; + }; + + pwm_b_pins2: pwm-b-pins2 { + mux { + groups = "pwm_b_f"; + function = "pwm_b"; + }; + }; + + pwm_b_pins3: pwm-b-pins3 { + mux { + groups = "pwm_b_a"; + function = "pwm_b"; + }; + }; + + pwm_c_pins1: pwm-c-pins1 { + mux { + groups = "pwm_c_x"; + function = "pwm_c"; + }; + }; + + pwm_c_pins2: pwm-c-pins2 { + mux { + groups = "pwm_c_f3"; + function = "pwm_c"; + }; + }; + + pwm_c_pins3: pwm-c-pins3 { + mux { + groups = "pwm_c_f8"; + function = "pwm_c"; + }; + }; + + pwm_c_pins4: pwm-c-pins4 { + mux { + groups = "pwm_c_a"; + function = "pwm_c"; + }; + }; + + pwm_d_pins1: pwm-d-pins1 { + mux { + groups = "pwm_d_x15"; + function = "pwm_d"; + }; + }; + + pwm_d_pins2: pwm-d-pins2 { + mux { + groups = "pwm_d_x13"; + function = "pwm_d"; + }; + }; + + pwm_d_pins3: pwm-d-pins3 { + mux { + groups = "pwm_d_x10"; + function = "pwm_d"; + }; + }; + + pwm_d_pins4: pwm-d-pins4 { + mux { + groups = "pwm_d_f"; + function = "pwm_d"; + }; + }; + + pwm_e_pins1: pwm-e-pins1 { + mux { + groups = "pwm_e_p"; + function = "pwm_e"; + }; + }; + + pwm_e_pins2: pwm-e-pins2 { + mux { + groups = "pwm_e_x16"; + function = "pwm_e"; + }; + }; + + pwm_e_pins3: pwm-e-pins3 { + mux { + groups = "pwm_e_x14"; + function = "pwm_e"; + }; + }; + + pwm_e_pins4: pwm-e-pins4 { + mux { + groups = "pwm_e_x2"; + function = "pwm_e"; + }; + }; + + pwm_e_pins5: pwm-e-pins5 { + mux { + groups = "pwm_e_f"; + function = "pwm_e"; + }; + }; + + pwm_e_pins6: pwm-e-pins6 { + mux { + groups = "pwm_e_a"; + function = "pwm_e"; + }; + }; + + pwm_f_pins1: pwm-f-pins1 { + mux { + groups = "pwm_f_b"; + function = "pwm_f"; + }; + }; + + pwm_f_pins2: pwm-f-pins2 { + mux { + groups = "pwm_f_x"; + function = "pwm_f"; + }; + }; + + pwm_f_pins3: pwm-f-pins3 { + mux { + groups = "pwm_f_f4"; + function = "pwm_f"; + }; + }; + + pwm_f_pins4: pwm-f-pins4 { + mux { + groups = "pwm_f_f12"; + function = "pwm_f"; + }; + }; + sdio_pins: sdio { mux0 { groups = "sdcard_d0_x", @@ -648,6 +830,28 @@ uart_AO_B: serial@2000 { status = "disabled"; }; + pwm_ab: pwm@2400 { + compatible = "amlogic,meson-a1-pwm", + "amlogic,meson-s4-pwm"; + reg = <0x0 0x2400 0x0 0x24>; + #pwm-cells = <3>; + clocks = <&clkc_periphs CLKID_PWM_A>, + <&clkc_periphs CLKID_PWM_B>; + power-domains = <&pwrc PWRC_I2C_ID>; + status = "disabled"; + }; + + pwm_cd: pwm@2800 { + compatible = "amlogic,meson-a1-pwm", + "amlogic,meson-s4-pwm"; + reg = <0x0 0x2800 0x0 0x24>; + #pwm-cells = <3>; + clocks = <&clkc_periphs CLKID_PWM_C>, + <&clkc_periphs CLKID_PWM_D>; + power-domains = <&pwrc PWRC_I2C_ID>; + status = "disabled"; + }; + saradc: adc@2c00 { compatible = "amlogic,meson-g12a-saradc", "amlogic,meson-saradc"; @@ -731,6 +935,17 @@ sec_AO: ao-secure@5a20 { amlogic,has-chip-id; }; + pwm_ef: pwm@5400 { + compatible = "amlogic,meson-a1-pwm", + "amlogic,meson-s4-pwm"; + reg = <0x0 0x5400 0x0 0x24>; + #pwm-cells = <3>; + clocks = <&clkc_periphs CLKID_PWM_E>, + <&clkc_periphs CLKID_PWM_F>; + power-domains = <&pwrc PWRC_I2C_ID>; + status = "disabled"; + }; + clkc_pll: pll-clock-controller@7c80 { compatible = "amlogic,a1-pll-clkc"; reg = <0 0x7c80 0 0x18c>; -- 2.25.1 ^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH 0/2] pwm: meson: add pwm support for A1 @ 2024-04-23 16:10 George Stark 2024-04-23 16:10 ` George Stark 0 siblings, 1 reply; 23+ messages in thread From: George Stark @ 2024-04-23 16:10 UTC (permalink / raw) To: u.kleine-koenig, neil.armstrong, khilman, jbrunet, martin.blumenstingl, thierry.reding, hkallweit1, robh+dt, krzysztof.kozlowski+dt, conor+dt Cc: linux-pwm, devicetree, linux-amlogic, linux-arm-kernel, linux-kernel, kernel, George Stark Add support for Amlogic meson A1 SoC family PWM. George Stark (2): dt-bindings: pwm: amlogic: Add new bindings for meson A1 pwm pwm: meson: support meson A1 SoC family .../devicetree/bindings/pwm/pwm-amlogic.yaml | 2 ++ drivers/pwm/pwm-meson.c | 35 +++++++++++++++++++ 2 files changed, 37 insertions(+) -- 2.25.1 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH 1/2] dt-bindings: pwm: amlogic: Add new bindings for meson A1 pwm 2024-04-23 16:10 [PATCH 0/2] pwm: meson: add pwm support for A1 George Stark 2024-04-23 16:10 ` George Stark @ 2024-04-23 16:10 ` George Stark 0 siblings, 0 replies; 23+ messages in thread From: George Stark @ 2024-04-23 16:10 UTC (permalink / raw) To: u.kleine-koenig, neil.armstrong, khilman, jbrunet, martin.blumenstingl, thierry.reding, hkallweit1, robh+dt, krzysztof.kozlowski+dt, conor+dt Cc: linux-pwm, devicetree, linux-amlogic, linux-arm-kernel, linux-kernel, kernel, George Stark, Dmitry Rokosov The chip has 3 dual channel PWM modules AB, CD, EF. Signed-off-by: George Stark <gnstark@salutedevices.com> Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com> --- Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml index 1d71d4f8f328..ef6daf1760ff 100644 --- a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml +++ b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml @@ -37,6 +37,7 @@ properties: - enum: - amlogic,meson8-pwm-v2 - amlogic,meson-s4-pwm + - amlogic,meson-a1-pwm - items: - enum: - amlogic,meson8b-pwm-v2 @@ -126,6 +127,7 @@ allOf: contains: enum: - amlogic,meson-s4-pwm + - amlogic,meson-a1-pwm then: properties: clocks: -- 2.25.1 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH 1/2] dt-bindings: pwm: amlogic: Add new bindings for meson A1 pwm @ 2024-04-23 16:10 ` George Stark 0 siblings, 0 replies; 23+ messages in thread From: George Stark @ 2024-04-23 16:10 UTC (permalink / raw) To: u.kleine-koenig, neil.armstrong, khilman, jbrunet, martin.blumenstingl, thierry.reding, hkallweit1, robh+dt, krzysztof.kozlowski+dt, conor+dt Cc: linux-pwm, devicetree, linux-amlogic, linux-arm-kernel, linux-kernel, kernel, George Stark, Dmitry Rokosov The chip has 3 dual channel PWM modules AB, CD, EF. Signed-off-by: George Stark <gnstark@salutedevices.com> Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com> --- Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml index 1d71d4f8f328..ef6daf1760ff 100644 --- a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml +++ b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml @@ -37,6 +37,7 @@ properties: - enum: - amlogic,meson8-pwm-v2 - amlogic,meson-s4-pwm + - amlogic,meson-a1-pwm - items: - enum: - amlogic,meson8b-pwm-v2 @@ -126,6 +127,7 @@ allOf: contains: enum: - amlogic,meson-s4-pwm + - amlogic,meson-a1-pwm then: properties: clocks: -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH 1/2] dt-bindings: pwm: amlogic: Add new bindings for meson A1 pwm @ 2024-04-23 16:10 ` George Stark 0 siblings, 0 replies; 23+ messages in thread From: George Stark @ 2024-04-23 16:10 UTC (permalink / raw) To: u.kleine-koenig, neil.armstrong, khilman, jbrunet, martin.blumenstingl, thierry.reding, hkallweit1, robh+dt, krzysztof.kozlowski+dt, conor+dt Cc: linux-pwm, devicetree, linux-amlogic, linux-arm-kernel, linux-kernel, kernel, George Stark, Dmitry Rokosov The chip has 3 dual channel PWM modules AB, CD, EF. Signed-off-by: George Stark <gnstark@salutedevices.com> Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com> --- Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml index 1d71d4f8f328..ef6daf1760ff 100644 --- a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml +++ b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml @@ -37,6 +37,7 @@ properties: - enum: - amlogic,meson8-pwm-v2 - amlogic,meson-s4-pwm + - amlogic,meson-a1-pwm - items: - enum: - amlogic,meson8b-pwm-v2 @@ -126,6 +127,7 @@ allOf: contains: enum: - amlogic,meson-s4-pwm + - amlogic,meson-a1-pwm then: properties: clocks: -- 2.25.1 ^ permalink raw reply related [flat|nested] 23+ messages in thread
* Re: [PATCH 1/2] dt-bindings: pwm: amlogic: Add new bindings for meson A1 pwm 2024-04-23 16:10 ` George Stark (?) @ 2024-04-23 16:56 ` Conor Dooley -1 siblings, 0 replies; 23+ messages in thread From: Conor Dooley @ 2024-04-23 16:56 UTC (permalink / raw) To: George Stark Cc: u.kleine-koenig, neil.armstrong, khilman, jbrunet, martin.blumenstingl, thierry.reding, hkallweit1, robh+dt, krzysztof.kozlowski+dt, conor+dt, linux-pwm, devicetree, linux-amlogic, linux-arm-kernel, linux-kernel, kernel, Dmitry Rokosov [-- Attachment #1.1: Type: text/plain, Size: 1260 bytes --] On Tue, Apr 23, 2024 at 07:10:05PM +0300, George Stark wrote: > The chip has 3 dual channel PWM modules AB, CD, EF. > > Signed-off-by: George Stark <gnstark@salutedevices.com> > Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com> a would sort before s. With the re-order, Acked-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor. > --- > Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml > index 1d71d4f8f328..ef6daf1760ff 100644 > --- a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml > +++ b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml > @@ -37,6 +37,7 @@ properties: > - enum: > - amlogic,meson8-pwm-v2 > - amlogic,meson-s4-pwm > + - amlogic,meson-a1-pwm > - items: > - enum: > - amlogic,meson8b-pwm-v2 > @@ -126,6 +127,7 @@ allOf: > contains: > enum: > - amlogic,meson-s4-pwm > + - amlogic,meson-a1-pwm > then: > properties: > clocks: > -- > 2.25.1 > [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] [-- Attachment #2: Type: text/plain, Size: 167 bytes --] _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 1/2] dt-bindings: pwm: amlogic: Add new bindings for meson A1 pwm @ 2024-04-23 16:56 ` Conor Dooley 0 siblings, 0 replies; 23+ messages in thread From: Conor Dooley @ 2024-04-23 16:56 UTC (permalink / raw) To: George Stark Cc: u.kleine-koenig, neil.armstrong, khilman, jbrunet, martin.blumenstingl, thierry.reding, hkallweit1, robh+dt, krzysztof.kozlowski+dt, conor+dt, linux-pwm, devicetree, linux-amlogic, linux-arm-kernel, linux-kernel, kernel, Dmitry Rokosov [-- Attachment #1.1: Type: text/plain, Size: 1260 bytes --] On Tue, Apr 23, 2024 at 07:10:05PM +0300, George Stark wrote: > The chip has 3 dual channel PWM modules AB, CD, EF. > > Signed-off-by: George Stark <gnstark@salutedevices.com> > Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com> a would sort before s. With the re-order, Acked-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor. > --- > Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml > index 1d71d4f8f328..ef6daf1760ff 100644 > --- a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml > +++ b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml > @@ -37,6 +37,7 @@ properties: > - enum: > - amlogic,meson8-pwm-v2 > - amlogic,meson-s4-pwm > + - amlogic,meson-a1-pwm > - items: > - enum: > - amlogic,meson8b-pwm-v2 > @@ -126,6 +127,7 @@ allOf: > contains: > enum: > - amlogic,meson-s4-pwm > + - amlogic,meson-a1-pwm > then: > properties: > clocks: > -- > 2.25.1 > [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 1/2] dt-bindings: pwm: amlogic: Add new bindings for meson A1 pwm @ 2024-04-23 16:56 ` Conor Dooley 0 siblings, 0 replies; 23+ messages in thread From: Conor Dooley @ 2024-04-23 16:56 UTC (permalink / raw) To: George Stark Cc: u.kleine-koenig, neil.armstrong, khilman, jbrunet, martin.blumenstingl, thierry.reding, hkallweit1, robh+dt, krzysztof.kozlowski+dt, conor+dt, linux-pwm, devicetree, linux-amlogic, linux-arm-kernel, linux-kernel, kernel, Dmitry Rokosov [-- Attachment #1: Type: text/plain, Size: 1260 bytes --] On Tue, Apr 23, 2024 at 07:10:05PM +0300, George Stark wrote: > The chip has 3 dual channel PWM modules AB, CD, EF. > > Signed-off-by: George Stark <gnstark@salutedevices.com> > Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com> a would sort before s. With the re-order, Acked-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor. > --- > Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml > index 1d71d4f8f328..ef6daf1760ff 100644 > --- a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml > +++ b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml > @@ -37,6 +37,7 @@ properties: > - enum: > - amlogic,meson8-pwm-v2 > - amlogic,meson-s4-pwm > + - amlogic,meson-a1-pwm > - items: > - enum: > - amlogic,meson8b-pwm-v2 > @@ -126,6 +127,7 @@ allOf: > contains: > enum: > - amlogic,meson-s4-pwm > + - amlogic,meson-a1-pwm > then: > properties: > clocks: > -- > 2.25.1 > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 1/2] dt-bindings: pwm: amlogic: Add new bindings for meson A1 pwm 2024-04-23 16:56 ` Conor Dooley (?) @ 2024-04-23 17:44 ` Jerome Brunet -1 siblings, 0 replies; 23+ messages in thread From: Jerome Brunet @ 2024-04-23 17:44 UTC (permalink / raw) To: Conor Dooley Cc: George Stark, u.kleine-koenig, neil.armstrong, khilman, jbrunet, martin.blumenstingl, thierry.reding, hkallweit1, robh+dt, krzysztof.kozlowski+dt, conor+dt, linux-pwm, devicetree, linux-amlogic, linux-arm-kernel, linux-kernel, kernel, Dmitry Rokosov On Tue 23 Apr 2024 at 17:56, Conor Dooley <conor@kernel.org> wrote: > [[PGP Signed Part:Undecided]] > On Tue, Apr 23, 2024 at 07:10:05PM +0300, George Stark wrote: >> The chip has 3 dual channel PWM modules AB, CD, EF. >> >> Signed-off-by: George Stark <gnstark@salutedevices.com> >> Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com> > > a would sort before s. > > With the re-order, > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > Thanks, > Conor. > >> --- >> Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml >> index 1d71d4f8f328..ef6daf1760ff 100644 >> --- a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml >> +++ b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml >> @@ -37,6 +37,7 @@ properties: >> - enum: >> - amlogic,meson8-pwm-v2 >> - amlogic,meson-s4-pwm >> + - amlogic,meson-a1-pwm AFAICT, the a1 interface is exactly as the s4 interface. So a1 should list s4 as a fallback and the driver should match on the s4. >> - items: >> - enum: >> - amlogic,meson8b-pwm-v2 >> @@ -126,6 +127,7 @@ allOf: >> contains: >> enum: >> - amlogic,meson-s4-pwm >> + - amlogic,meson-a1-pwm >> then: >> properties: >> clocks: >> -- >> 2.25.1 >> > > [[End of PGP Signed Part]] -- Jerome _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 1/2] dt-bindings: pwm: amlogic: Add new bindings for meson A1 pwm @ 2024-04-23 17:44 ` Jerome Brunet 0 siblings, 0 replies; 23+ messages in thread From: Jerome Brunet @ 2024-04-23 17:44 UTC (permalink / raw) To: Conor Dooley Cc: George Stark, u.kleine-koenig, neil.armstrong, khilman, jbrunet, martin.blumenstingl, thierry.reding, hkallweit1, robh+dt, krzysztof.kozlowski+dt, conor+dt, linux-pwm, devicetree, linux-amlogic, linux-arm-kernel, linux-kernel, kernel, Dmitry Rokosov On Tue 23 Apr 2024 at 17:56, Conor Dooley <conor@kernel.org> wrote: > [[PGP Signed Part:Undecided]] > On Tue, Apr 23, 2024 at 07:10:05PM +0300, George Stark wrote: >> The chip has 3 dual channel PWM modules AB, CD, EF. >> >> Signed-off-by: George Stark <gnstark@salutedevices.com> >> Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com> > > a would sort before s. > > With the re-order, > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > Thanks, > Conor. > >> --- >> Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml >> index 1d71d4f8f328..ef6daf1760ff 100644 >> --- a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml >> +++ b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml >> @@ -37,6 +37,7 @@ properties: >> - enum: >> - amlogic,meson8-pwm-v2 >> - amlogic,meson-s4-pwm >> + - amlogic,meson-a1-pwm AFAICT, the a1 interface is exactly as the s4 interface. So a1 should list s4 as a fallback and the driver should match on the s4. >> - items: >> - enum: >> - amlogic,meson8b-pwm-v2 >> @@ -126,6 +127,7 @@ allOf: >> contains: >> enum: >> - amlogic,meson-s4-pwm >> + - amlogic,meson-a1-pwm >> then: >> properties: >> clocks: >> -- >> 2.25.1 >> > > [[End of PGP Signed Part]] -- Jerome _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 1/2] dt-bindings: pwm: amlogic: Add new bindings for meson A1 pwm @ 2024-04-23 17:44 ` Jerome Brunet 0 siblings, 0 replies; 23+ messages in thread From: Jerome Brunet @ 2024-04-23 17:44 UTC (permalink / raw) To: Conor Dooley Cc: George Stark, u.kleine-koenig, neil.armstrong, khilman, jbrunet, martin.blumenstingl, thierry.reding, hkallweit1, robh+dt, krzysztof.kozlowski+dt, conor+dt, linux-pwm, devicetree, linux-amlogic, linux-arm-kernel, linux-kernel, kernel, Dmitry Rokosov On Tue 23 Apr 2024 at 17:56, Conor Dooley <conor@kernel.org> wrote: > [[PGP Signed Part:Undecided]] > On Tue, Apr 23, 2024 at 07:10:05PM +0300, George Stark wrote: >> The chip has 3 dual channel PWM modules AB, CD, EF. >> >> Signed-off-by: George Stark <gnstark@salutedevices.com> >> Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com> > > a would sort before s. > > With the re-order, > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > Thanks, > Conor. > >> --- >> Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml >> index 1d71d4f8f328..ef6daf1760ff 100644 >> --- a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml >> +++ b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml >> @@ -37,6 +37,7 @@ properties: >> - enum: >> - amlogic,meson8-pwm-v2 >> - amlogic,meson-s4-pwm >> + - amlogic,meson-a1-pwm AFAICT, the a1 interface is exactly as the s4 interface. So a1 should list s4 as a fallback and the driver should match on the s4. >> - items: >> - enum: >> - amlogic,meson8b-pwm-v2 >> @@ -126,6 +127,7 @@ allOf: >> contains: >> enum: >> - amlogic,meson-s4-pwm >> + - amlogic,meson-a1-pwm >> then: >> properties: >> clocks: >> -- >> 2.25.1 >> > > [[End of PGP Signed Part]] -- Jerome ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 1/2] dt-bindings: pwm: amlogic: Add new bindings for meson A1 pwm 2024-04-23 17:44 ` Jerome Brunet (?) @ 2024-04-24 6:02 ` Kelvin Zhang -1 siblings, 0 replies; 23+ messages in thread From: Kelvin Zhang @ 2024-04-24 6:02 UTC (permalink / raw) To: Jerome Brunet, Conor Dooley Cc: George Stark, u.kleine-koenig, neil.armstrong, khilman, martin.blumenstingl, thierry.reding, hkallweit1, robh+dt, krzysztof.kozlowski+dt, conor+dt, linux-pwm, devicetree, linux-amlogic, linux-arm-kernel, linux-kernel, kernel, Dmitry Rokosov, junyi.zhao On 2024/4/24 01:44, Jerome Brunet wrote: > > On Tue 23 Apr 2024 at 17:56, Conor Dooley <conor@kernel.org> wrote: > >> [[PGP Signed Part:Undecided]] >> On Tue, Apr 23, 2024 at 07:10:05PM +0300, George Stark wrote: >>> The chip has 3 dual channel PWM modules AB, CD, EF. >>> >>> Signed-off-by: George Stark <gnstark@salutedevices.com> >>> Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com> >> >> a would sort before s. >> >> With the re-order, >> Acked-by: Conor Dooley <conor.dooley@microchip.com> >> >> Thanks, >> Conor. >> >>> --- >>> Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml >>> index 1d71d4f8f328..ef6daf1760ff 100644 >>> --- a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml >>> +++ b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml >>> @@ -37,6 +37,7 @@ properties: >>> - enum: >>> - amlogic,meson8-pwm-v2 >>> - amlogic,meson-s4-pwm >>> + - amlogic,meson-a1-pwm > > AFAICT, the a1 interface is exactly as the s4 interface. > So a1 should list s4 as a fallback and the driver should match on the s4. Hi George, For your information, we are preparing S4 submission. Thanks! > >>> - items: >>> - enum: >>> - amlogic,meson8b-pwm-v2 >>> @@ -126,6 +127,7 @@ allOf: >>> contains: >>> enum: >>> - amlogic,meson-s4-pwm >>> + - amlogic,meson-a1-pwm >>> then: >>> properties: >>> clocks: >>> -- >>> 2.25.1 >>> >> >> [[End of PGP Signed Part]] > > > -- > Jerome > > _______________________________________________ > linux-amlogic mailing list > linux-amlogic@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-amlogic _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 1/2] dt-bindings: pwm: amlogic: Add new bindings for meson A1 pwm @ 2024-04-24 6:02 ` Kelvin Zhang 0 siblings, 0 replies; 23+ messages in thread From: Kelvin Zhang @ 2024-04-24 6:02 UTC (permalink / raw) To: Jerome Brunet, Conor Dooley Cc: George Stark, u.kleine-koenig, neil.armstrong, khilman, martin.blumenstingl, thierry.reding, hkallweit1, robh+dt, krzysztof.kozlowski+dt, conor+dt, linux-pwm, devicetree, linux-amlogic, linux-arm-kernel, linux-kernel, kernel, Dmitry Rokosov, junyi.zhao On 2024/4/24 01:44, Jerome Brunet wrote: > > On Tue 23 Apr 2024 at 17:56, Conor Dooley <conor@kernel.org> wrote: > >> [[PGP Signed Part:Undecided]] >> On Tue, Apr 23, 2024 at 07:10:05PM +0300, George Stark wrote: >>> The chip has 3 dual channel PWM modules AB, CD, EF. >>> >>> Signed-off-by: George Stark <gnstark@salutedevices.com> >>> Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com> >> >> a would sort before s. >> >> With the re-order, >> Acked-by: Conor Dooley <conor.dooley@microchip.com> >> >> Thanks, >> Conor. >> >>> --- >>> Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml >>> index 1d71d4f8f328..ef6daf1760ff 100644 >>> --- a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml >>> +++ b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml >>> @@ -37,6 +37,7 @@ properties: >>> - enum: >>> - amlogic,meson8-pwm-v2 >>> - amlogic,meson-s4-pwm >>> + - amlogic,meson-a1-pwm > > AFAICT, the a1 interface is exactly as the s4 interface. > So a1 should list s4 as a fallback and the driver should match on the s4. Hi George, For your information, we are preparing S4 submission. Thanks! > >>> - items: >>> - enum: >>> - amlogic,meson8b-pwm-v2 >>> @@ -126,6 +127,7 @@ allOf: >>> contains: >>> enum: >>> - amlogic,meson-s4-pwm >>> + - amlogic,meson-a1-pwm >>> then: >>> properties: >>> clocks: >>> -- >>> 2.25.1 >>> >> >> [[End of PGP Signed Part]] > > > -- > Jerome > > _______________________________________________ > linux-amlogic mailing list > linux-amlogic@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-amlogic _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 1/2] dt-bindings: pwm: amlogic: Add new bindings for meson A1 pwm @ 2024-04-24 6:02 ` Kelvin Zhang 0 siblings, 0 replies; 23+ messages in thread From: Kelvin Zhang @ 2024-04-24 6:02 UTC (permalink / raw) To: Jerome Brunet, Conor Dooley Cc: George Stark, u.kleine-koenig, neil.armstrong, khilman, martin.blumenstingl, thierry.reding, hkallweit1, robh+dt, krzysztof.kozlowski+dt, conor+dt, linux-pwm, devicetree, linux-amlogic, linux-arm-kernel, linux-kernel, kernel, Dmitry Rokosov, junyi.zhao On 2024/4/24 01:44, Jerome Brunet wrote: > > On Tue 23 Apr 2024 at 17:56, Conor Dooley <conor@kernel.org> wrote: > >> [[PGP Signed Part:Undecided]] >> On Tue, Apr 23, 2024 at 07:10:05PM +0300, George Stark wrote: >>> The chip has 3 dual channel PWM modules AB, CD, EF. >>> >>> Signed-off-by: George Stark <gnstark@salutedevices.com> >>> Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com> >> >> a would sort before s. >> >> With the re-order, >> Acked-by: Conor Dooley <conor.dooley@microchip.com> >> >> Thanks, >> Conor. >> >>> --- >>> Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml >>> index 1d71d4f8f328..ef6daf1760ff 100644 >>> --- a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml >>> +++ b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml >>> @@ -37,6 +37,7 @@ properties: >>> - enum: >>> - amlogic,meson8-pwm-v2 >>> - amlogic,meson-s4-pwm >>> + - amlogic,meson-a1-pwm > > AFAICT, the a1 interface is exactly as the s4 interface. > So a1 should list s4 as a fallback and the driver should match on the s4. Hi George, For your information, we are preparing S4 submission. Thanks! > >>> - items: >>> - enum: >>> - amlogic,meson8b-pwm-v2 >>> @@ -126,6 +127,7 @@ allOf: >>> contains: >>> enum: >>> - amlogic,meson-s4-pwm >>> + - amlogic,meson-a1-pwm >>> then: >>> properties: >>> clocks: >>> -- >>> 2.25.1 >>> >> >> [[End of PGP Signed Part]] > > > -- > Jerome > > _______________________________________________ > linux-amlogic mailing list > linux-amlogic@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 1/2] dt-bindings: pwm: amlogic: Add new bindings for meson A1 pwm 2024-04-23 17:44 ` Jerome Brunet (?) @ 2024-04-24 12:08 ` Conor Dooley -1 siblings, 0 replies; 23+ messages in thread From: Conor Dooley @ 2024-04-24 12:08 UTC (permalink / raw) To: Jerome Brunet Cc: George Stark, u.kleine-koenig, neil.armstrong, khilman, martin.blumenstingl, thierry.reding, hkallweit1, robh+dt, krzysztof.kozlowski+dt, conor+dt, linux-pwm, devicetree, linux-amlogic, linux-arm-kernel, linux-kernel, kernel, Dmitry Rokosov [-- Attachment #1.1: Type: text/plain, Size: 1414 bytes --] On Tue, Apr 23, 2024 at 07:44:35PM +0200, Jerome Brunet wrote: > > On Tue 23 Apr 2024 at 17:56, Conor Dooley <conor@kernel.org> wrote: > > > [[PGP Signed Part:Undecided]] > > On Tue, Apr 23, 2024 at 07:10:05PM +0300, George Stark wrote: > >> The chip has 3 dual channel PWM modules AB, CD, EF. > >> > >> Signed-off-by: George Stark <gnstark@salutedevices.com> > >> Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com> > > > > a would sort before s. > > > > With the re-order, > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > > > Thanks, > > Conor. > > > >> --- > >> Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml > >> index 1d71d4f8f328..ef6daf1760ff 100644 > >> --- a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml > >> +++ b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml > >> @@ -37,6 +37,7 @@ properties: > >> - enum: > >> - amlogic,meson8-pwm-v2 > >> - amlogic,meson-s4-pwm > >> + - amlogic,meson-a1-pwm > > AFAICT, the a1 interface is exactly as the s4 interface. > So a1 should list s4 as a fallback and the driver should match on the s4. Crap, I should have checked. Please make use of the fallback :) [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] [-- Attachment #2: Type: text/plain, Size: 167 bytes --] _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 1/2] dt-bindings: pwm: amlogic: Add new bindings for meson A1 pwm @ 2024-04-24 12:08 ` Conor Dooley 0 siblings, 0 replies; 23+ messages in thread From: Conor Dooley @ 2024-04-24 12:08 UTC (permalink / raw) To: Jerome Brunet Cc: George Stark, u.kleine-koenig, neil.armstrong, khilman, martin.blumenstingl, thierry.reding, hkallweit1, robh+dt, krzysztof.kozlowski+dt, conor+dt, linux-pwm, devicetree, linux-amlogic, linux-arm-kernel, linux-kernel, kernel, Dmitry Rokosov [-- Attachment #1.1: Type: text/plain, Size: 1414 bytes --] On Tue, Apr 23, 2024 at 07:44:35PM +0200, Jerome Brunet wrote: > > On Tue 23 Apr 2024 at 17:56, Conor Dooley <conor@kernel.org> wrote: > > > [[PGP Signed Part:Undecided]] > > On Tue, Apr 23, 2024 at 07:10:05PM +0300, George Stark wrote: > >> The chip has 3 dual channel PWM modules AB, CD, EF. > >> > >> Signed-off-by: George Stark <gnstark@salutedevices.com> > >> Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com> > > > > a would sort before s. > > > > With the re-order, > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > > > Thanks, > > Conor. > > > >> --- > >> Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml > >> index 1d71d4f8f328..ef6daf1760ff 100644 > >> --- a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml > >> +++ b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml > >> @@ -37,6 +37,7 @@ properties: > >> - enum: > >> - amlogic,meson8-pwm-v2 > >> - amlogic,meson-s4-pwm > >> + - amlogic,meson-a1-pwm > > AFAICT, the a1 interface is exactly as the s4 interface. > So a1 should list s4 as a fallback and the driver should match on the s4. Crap, I should have checked. Please make use of the fallback :) [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 1/2] dt-bindings: pwm: amlogic: Add new bindings for meson A1 pwm @ 2024-04-24 12:08 ` Conor Dooley 0 siblings, 0 replies; 23+ messages in thread From: Conor Dooley @ 2024-04-24 12:08 UTC (permalink / raw) To: Jerome Brunet Cc: George Stark, u.kleine-koenig, neil.armstrong, khilman, martin.blumenstingl, thierry.reding, hkallweit1, robh+dt, krzysztof.kozlowski+dt, conor+dt, linux-pwm, devicetree, linux-amlogic, linux-arm-kernel, linux-kernel, kernel, Dmitry Rokosov [-- Attachment #1: Type: text/plain, Size: 1414 bytes --] On Tue, Apr 23, 2024 at 07:44:35PM +0200, Jerome Brunet wrote: > > On Tue 23 Apr 2024 at 17:56, Conor Dooley <conor@kernel.org> wrote: > > > [[PGP Signed Part:Undecided]] > > On Tue, Apr 23, 2024 at 07:10:05PM +0300, George Stark wrote: > >> The chip has 3 dual channel PWM modules AB, CD, EF. > >> > >> Signed-off-by: George Stark <gnstark@salutedevices.com> > >> Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com> > > > > a would sort before s. > > > > With the re-order, > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > > > Thanks, > > Conor. > > > >> --- > >> Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml > >> index 1d71d4f8f328..ef6daf1760ff 100644 > >> --- a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml > >> +++ b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml > >> @@ -37,6 +37,7 @@ properties: > >> - enum: > >> - amlogic,meson8-pwm-v2 > >> - amlogic,meson-s4-pwm > >> + - amlogic,meson-a1-pwm > > AFAICT, the a1 interface is exactly as the s4 interface. > So a1 should list s4 as a fallback and the driver should match on the s4. Crap, I should have checked. Please make use of the fallback :) [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 23+ messages in thread
end of thread, other threads:[~2024-07-01 13:25 UTC | newest] Thread overview: 23+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-07-01 13:01 [PATCH 0/2] add support for meson a1 PWM in dts and bindings George Stark 2024-07-01 13:01 ` George Stark 2024-07-01 13:01 ` [PATCH 1/2] dt-bindings: pwm: amlogic: Add new bindings for meson A1 pwm George Stark 2024-07-01 13:01 ` George Stark 2024-07-01 13:25 ` Krzysztof Kozlowski 2024-07-01 13:25 ` Krzysztof Kozlowski 2024-07-01 13:01 ` [PATCH 2/2] arm64: dts: meson: a1: add definitions for meson pwm George Stark 2024-07-01 13:01 ` George Stark -- strict thread matches above, loose matches on Subject: below -- 2024-04-23 16:10 [PATCH 0/2] pwm: meson: add pwm support for A1 George Stark 2024-04-23 16:10 ` [PATCH 1/2] dt-bindings: pwm: amlogic: Add new bindings for meson A1 pwm George Stark 2024-04-23 16:10 ` George Stark 2024-04-23 16:10 ` George Stark 2024-04-23 16:56 ` Conor Dooley 2024-04-23 16:56 ` Conor Dooley 2024-04-23 16:56 ` Conor Dooley 2024-04-23 17:44 ` Jerome Brunet 2024-04-23 17:44 ` Jerome Brunet 2024-04-23 17:44 ` Jerome Brunet 2024-04-24 6:02 ` Kelvin Zhang 2024-04-24 6:02 ` Kelvin Zhang 2024-04-24 6:02 ` Kelvin Zhang 2024-04-24 12:08 ` Conor Dooley 2024-04-24 12:08 ` Conor Dooley 2024-04-24 12:08 ` Conor Dooley
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.