From: pheragu@codeaurora.org
To: Trilok Soni <tsoni@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
ckadabi@codeaurora.org, bryanh@codeaurora.org,
psodagud@codeaurora.org, rnayak@codeaurora.org,
Satya Durga Srinivasu Prabhala <satyap@codeaurora.org>
Subject: Re: [PATCH v1 2/2] Embedded USB Debugger (EUD) driver
Date: Mon, 20 Aug 2018 09:59:10 -0700 [thread overview]
Message-ID: <cffb39ab91d2922d5eb06fb9cf388d1f@codeaurora.org> (raw)
In-Reply-To: <589f8341-580b-d1d0-5efd-261d8d4821b0@codeaurora.org>
On 2018-08-17 12:47, Trilok Soni wrote:
> Hi Prakruthi,
>
> On 8/16/2018 5:05 PM, Prakruthi Deepak Heragu wrote:
>> +
>> +#define EUD_INT_VBUS BIT(2)
>> +#define EUD_INT_CHGR BIT(3)
>> +#define EUD_INT_SAFE_MODE BIT(4)
>> +
>> +#define EUD_NR 1
>
> I don't see any use of EUD_NR in the driver below. Do we need it?
Sorry about that. Will get rid of it.
WARNING: multiple messages have this Message-ID (diff)
From: Prakruthi Deepak Heragu <pheragu@codeaurora.org>
To: Trilok Soni <tsoni@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
ckadabi@codeaurora.org, bryanh@codeaurora.org,
psodagud@codeaurora.org, rnayak@codeaurora.org,
Satya Durga Srinivasu Prabhala <satyap@codeaurora.org>
Subject: [v1,2/2] Embedded USB Debugger (EUD) driver
Date: Mon, 20 Aug 2018 09:59:10 -0700 [thread overview]
Message-ID: <cffb39ab91d2922d5eb06fb9cf388d1f@codeaurora.org> (raw)
On 2018-08-17 12:47, Trilok Soni wrote:
> Hi Prakruthi,
>
> On 8/16/2018 5:05 PM, Prakruthi Deepak Heragu wrote:
>> +
>> +#define EUD_INT_VBUS BIT(2)
>> +#define EUD_INT_CHGR BIT(3)
>> +#define EUD_INT_SAFE_MODE BIT(4)
>> +
>> +#define EUD_NR 1
>
> I don't see any use of EUD_NR in the driver below. Do we need it?
Sorry about that. Will get rid of it.
next prev parent reply other threads:[~2018-08-20 16:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-17 0:05 [PATCH v1 0/2] Add Embedded USB Debugger (EUD) driver Prakruthi Deepak Heragu
2018-08-17 0:05 ` [PATCH v1 1/2] dt-bindings: Documentation for qcom,eud Prakruthi Deepak Heragu
2018-08-17 0:05 ` [v1,1/2] " Prakruthi Deepak Heragu
2018-08-17 0:05 ` [PATCH v1 2/2] Embedded USB Debugger (EUD) driver Prakruthi Deepak Heragu
2018-08-17 0:05 ` [v1,2/2] " Prakruthi Deepak Heragu
2018-08-17 19:47 ` [PATCH v1 2/2] " Trilok Soni
2018-08-17 19:47 ` [v1,2/2] " Trilok Soni
2018-08-20 16:59 ` pheragu [this message]
2018-08-20 16:59 ` Prakruthi Deepak Heragu
2018-08-31 16:03 ` [PATCH v1 0/2] Add " Trilok Soni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cffb39ab91d2922d5eb06fb9cf388d1f@codeaurora.org \
--to=pheragu@codeaurora.org \
--cc=bryanh@codeaurora.org \
--cc=ckadabi@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=psodagud@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=satyap@codeaurora.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.