xen-unstable pci passthrough: bug in accounting assigned pci devices when assignment has failed

xen-unstable pci passthrough: bug in accounting assigned pci devices when assignment has failed

[Sander Eikelenboom]

Hi Ian,

It was decided that the bug that domain creation does not fail on non assignable pci devices was deferred to 4.5.
(and it wouldn't prevent this bug anyhow when doing pci hotplug with xl pci-attach)

But there seems to be a bug in the error path:

root@creanuc:~# xl pci-assignable-list
0000:02:00.0

Now when i boot a VM with  pci=['00:19.0'] in it's config file ... which is not assignable:

root@creanuc:~# xl create /etc/xen/domU/router.hvm
Parsing config from /etc/xen/domU/router.hvm
libxl: error: libxl_pci.c:1060:libxl__device_pci_add: PCI device 0:0:19.0 is not assignable

That looks ok ... and the pci device is not visible / accessible in the guest ...  but it seems the entry is still in xenstore nevertheless:

root@creanuc:~# xl pci-list router
Vdev Device
00.0 0000:00:19.0

--
Sander

Re: xen-unstable pci passthrough: bug in accounting assigned pci devices when assignment has failed

[Ian Campbell]

graft 27 ^
thanks

Adding this info to the bug for the benefit of whoever ends up looking
at it. Thanks.

Ian.

On Fri, 2014-02-21 at 15:34 +0100, Sander Eikelenboom wrote:
> Hi Ian,
> 
> It was decided that the bug that domain creation does not fail on non assignable pci devices was deferred to 4.5.
> (and it wouldn't prevent this bug anyhow when doing pci hotplug with xl pci-attach)
> 
> But there seems to be a bug in the error path:
> 
> root@creanuc:~# xl pci-assignable-list
> 0000:02:00.0
> 
> Now when i boot a VM with  pci=['00:19.0'] in it's config file ... which is not assignable:
> 
> root@creanuc:~# xl create /etc/xen/domU/router.hvm
> Parsing config from /etc/xen/domU/router.hvm
> libxl: error: libxl_pci.c:1060:libxl__device_pci_add: PCI device 0:0:19.0 is not assignable
> 
> That looks ok ... and the pci device is not visible / accessible in the guest ...  but it seems the entry is still in xenstore nevertheless:
> 
> root@creanuc:~# xl pci-list router
> Vdev Device
> 00.0 0000:00:19.0
> 
> --
> Sander
> 

Processed: Re: xen-unstable pci passthrough: bug in accounting assigned pci devices when assignment has failed

[xen]

Processing commands for xen@bugs.xenproject.org:

> graft 27 ^
Graft `<974010162.20140221153400@eikelenboom.it>' onto #27
> thanks
Finished processing.

Modified/created Bugs:
 - 27: http://bugs.xenproject.org/xen/bug/27

---
Xen Hypervisor Bug Tracker
See http://wiki.xen.org/wiki/Reporting_Bugs_against_Xen for information on reporting bugs
Contact xen-bugs-owner@bugs.xenproject.org with any infrastructure issues