Xen compilation fails for ARM32 when recompiled on a ARM64 build

Xen compilation fails for ARM32 when recompiled on a ARM64 build

[Bhupinder Thakur]

[-- Attachment #1.1: Type: text/plain, Size: 1190 bytes --]

Hi,

I am facing an issue where the recompilation fails when you build for ARM32
architecture on an existing build of ARM64.

Even if I do make clean/make distclean before compiling for different
architecture it still fails.

Steps to reproduce the issue:

1. git clone git://xenbits.xen.org/xen.git xen.git
2. make dist-xen XEN_TARGET_ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu
3. make distclean
4. make dist-xen XEN_TARGET_ARCH=arm32 CROSS_COMPILE=arm-linux-gnueabihf-

Compilation fails at step 4.

If I manually remove the following files and recompile then compilation is
successful:

Remove xen/arch/arm/asm-offsets.s
Remove xen/arch/arm/xen.lds

The same issue happens if you build for ARM32 first and then try to build
for ARM64. After removing the 2 files manually, the compilation is
successful.

I am using the following toolchains:
gcc-linaro-4.9-2014.11-x86_64_aarch64-linux-gnu.tar.xz (for ARM64 build)
x86_64-gcc-4.9.0-nolibc_arm-unknown-linux-gnueabi.tar.xz (for ARM32 build -
https://www.kernel.org/pub/tools/crosstool/files/bin/x86_64/4.9.0/)

I think probably the above-mentioned two files need to be removed
automatically when make distclean is run.

Regards,
Bhupinder

[-- Attachment #1.2: Type: text/html, Size: 1598 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: Xen compilation fails for ARM32 when recompiled on a ARM64 build

[Andrew Cooper]

[-- Attachment #1.1: Type: text/plain, Size: 1399 bytes --]

On 24/11/16 15:48, Bhupinder Thakur wrote:
> Hi,
>
> I am facing an issue where the recompilation fails when you build for
> ARM32 architecture on an existing build of ARM64.
>
> Even if I do make clean/make distclean before compiling for different
> architecture it still fails.
>
> Steps to reproduce the issue:
>
> 1. git clone git://xenbits.xen.org/xen.git
> <http://xenbits.xen.org/xen.git> xen.git
> 2. make dist-xen XEN_TARGET_ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu
> 3. make distclean
> 4. make dist-xen XEN_TARGET_ARCH=arm32 CROSS_COMPILE=arm-linux-gnueabihf-
>
> Compilation fails at step 4.
>
> If I manually remove the following files and recompile then
> compilation is successful:
>
> Remove xen/arch/arm/asm-offsets.s
> Remove xen/arch/arm/xen.lds
>
> The same issue happens if you build for ARM32 first and then try to
> build for ARM64. After removing the 2 files manually, the compilation
> is successful.
>
> I am using the following toolchains:
> gcc-linaro-4.9-2014.11-x86_64_aarch64-linux-gnu.tar.xz (for ARM64 build)
> x86_64-gcc-4.9.0-nolibc_arm-unknown-linux-gnueabi.tar.xz (for ARM32
> build -
> https://www.kernel.org/pub/tools/crosstool/files/bin/x86_64/4.9.0/)
>
> I think probably the above-mentioned two files need to be removed
> automatically when make distclean is run.

They should be deleted on `make clean`.  They are temporary files just
like .o's

~Andrew

[-- Attachment #1.2: Type: text/html, Size: 2899 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: Xen compilation fails for ARM32 when recompiled on a ARM64 build

[Julien Grall]

On 24/11/16 15:48, Bhupinder Thakur wrote:
> Hi,

Hello Bhupinder,

> I am facing an issue where the recompilation fails when you build for
> ARM32 architecture on an existing build of ARM64.
>
> Even if I do make clean/make distclean before compiling for different
> architecture it still fails.
>
> Steps to reproduce the issue:
>
> 1. git clone git://xenbits.xen.org/xen.git
> <http://xenbits.xen.org/xen.git> xen.git
> 2. make dist-xen XEN_TARGET_ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu
> 3. make distclean
> 4. make dist-xen XEN_TARGET_ARCH=arm32 CROSS_COMPILE=arm-linux-gnueabihf-
>
> Compilation fails at step 4.
>
> If I manually remove the following files and recompile then compilation
> is successful:
>
> Remove xen/arch/arm/asm-offsets.s
> Remove xen/arch/arm/xen.lds
>
> The same issue happens if you build for ARM32 first and then try to
> build for ARM64. After removing the 2 files manually, the compilation is
> successful.
>
> I am using the following toolchains:
> gcc-linaro-4.9-2014.11-x86_64_aarch64-linux-gnu.tar.xz (for ARM64 build)
> x86_64-gcc-4.9.0-nolibc_arm-unknown-linux-gnueabi.tar.xz (for ARM32
> build - https://www.kernel.org/pub/tools/crosstool/files/bin/x86_64/4.9.0/)
>
> I think probably the above-mentioned two files need to be removed
> automatically when make distclean is run.

This is expected. You have to use make distclean will only clean the 
files of the host architecture (e.g x86). For cross-compilation, you 
will have to do make distclean XEN_TARGET_ARCH=arm64

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: Xen compilation fails for ARM32 when recompiled on a ARM64 build

[Julien Grall]

Hi Andrew,

On 24/11/16 15:53, Andrew Cooper wrote:
> On 24/11/16 15:48, Bhupinder Thakur wrote:
>> Hi,
>>
>> I am facing an issue where the recompilation fails when you build for
>> ARM32 architecture on an existing build of ARM64.
>>
>> Even if I do make clean/make distclean before compiling for different
>> architecture it still fails.
>>
>> Steps to reproduce the issue:
>>
>> 1. git clone git://xenbits.xen.org/xen.git
>> <http://xenbits.xen.org/xen.git> xen.git
>> 2. make dist-xen XEN_TARGET_ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu
>> 3. make distclean
>> 4. make dist-xen XEN_TARGET_ARCH=arm32 CROSS_COMPILE=arm-linux-gnueabihf-
>>
>> Compilation fails at step 4.
>>
>> If I manually remove the following files and recompile then
>> compilation is successful:
>>
>> Remove xen/arch/arm/asm-offsets.s
>> Remove xen/arch/arm/xen.lds
>>
>> The same issue happens if you build for ARM32 first and then try to
>> build for ARM64. After removing the 2 files manually, the compilation
>> is successful.
>>
>> I am using the following toolchains:
>> gcc-linaro-4.9-2014.11-x86_64_aarch64-linux-gnu.tar.xz (for ARM64 build)
>> x86_64-gcc-4.9.0-nolibc_arm-unknown-linux-gnueabi.tar.xz (for ARM32
>> build -
>> https://www.kernel.org/pub/tools/crosstool/files/bin/x86_64/4.9.0/)
>>
>> I think probably the above-mentioned two files need to be removed
>> automatically when make distclean is run.
>
> They should be deleted on `make clean`.  They are temporary files just
> like .o's

It will only happen if you do make clean XEN_TARGET_ARCH=arm64/arm32.

This is because target clean/distclean is only called for a given 
architecture (by the default the host one).

I am not sure whether we should clean for any architecture.

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: Xen compilation fails for ARM32 when recompiled on a ARM64 build

[Jan Beulich]

>>> On 24.11.16 at 16:58, <julien.grall@arm.com> wrote:
> On 24/11/16 15:53, Andrew Cooper wrote:
>> On 24/11/16 15:48, Bhupinder Thakur wrote:
>>> If I manually remove the following files and recompile then
>>> compilation is successful:
>>>
>>> Remove xen/arch/arm/asm-offsets.s
>>> Remove xen/arch/arm/xen.lds
>>>
>>> The same issue happens if you build for ARM32 first and then try to
>>> build for ARM64. After removing the 2 files manually, the compilation
>>> is successful.
>>>
>>> I am using the following toolchains:
>>> gcc-linaro-4.9-2014.11-x86_64_aarch64-linux-gnu.tar.xz (for ARM64 build)
>>> x86_64-gcc-4.9.0-nolibc_arm-unknown-linux-gnueabi.tar.xz (for ARM32
>>> build -
>>> https://www.kernel.org/pub/tools/crosstool/files/bin/x86_64/4.9.0/)
>>>
>>> I think probably the above-mentioned two files need to be removed
>>> automatically when make distclean is run.
>>
>> They should be deleted on `make clean`.  They are temporary files just
>> like .o's
> 
> It will only happen if you do make clean XEN_TARGET_ARCH=arm64/arm32.
> 
> This is because target clean/distclean is only called for a given 
> architecture (by the default the host one).
> 
> I am not sure whether we should clean for any architecture.

I think it would be nice if "clean" affected the whole tree, but for
now I think those who really can't afford separate build trees
will need to live with having to pass XEN_TARGET_ARCH= on
the clean invocation.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: Xen compilation fails for ARM32 when recompiled on a ARM64 build

[Julien Grall]

Hi Jan,

On 24/11/16 16:12, Jan Beulich wrote:
>>>> On 24.11.16 at 16:58, <julien.grall@arm.com> wrote:
>> On 24/11/16 15:53, Andrew Cooper wrote:
>>> On 24/11/16 15:48, Bhupinder Thakur wrote:
>>>> If I manually remove the following files and recompile then
>>>> compilation is successful:
>>>>
>>>> Remove xen/arch/arm/asm-offsets.s
>>>> Remove xen/arch/arm/xen.lds
>>>>
>>>> The same issue happens if you build for ARM32 first and then try to
>>>> build for ARM64. After removing the 2 files manually, the compilation
>>>> is successful.
>>>>
>>>> I am using the following toolchains:
>>>> gcc-linaro-4.9-2014.11-x86_64_aarch64-linux-gnu.tar.xz (for ARM64 build)
>>>> x86_64-gcc-4.9.0-nolibc_arm-unknown-linux-gnueabi.tar.xz (for ARM32
>>>> build -
>>>> https://www.kernel.org/pub/tools/crosstool/files/bin/x86_64/4.9.0/)
>>>>
>>>> I think probably the above-mentioned two files need to be removed
>>>> automatically when make distclean is run.
>>>
>>> They should be deleted on `make clean`.  They are temporary files just
>>> like .o's
>>
>> It will only happen if you do make clean XEN_TARGET_ARCH=arm64/arm32.
>>
>> This is because target clean/distclean is only called for a given
>> architecture (by the default the host one).
>>
>> I am not sure whether we should clean for any architecture.
>
> I think it would be nice if "clean" affected the whole tree, but for
> now I think those who really can't afford separate build trees
> will need to live with having to pass XEN_TARGET_ARCH= on
> the clean invocation.

It could be a nice task newcomers on Xen. I will keep it in mind.

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: Xen compilation fails for ARM32 when recompiled on a ARM64 build

[Julien Grall]

create ^
title it makefile: clean target should affect the whole tree
severity it wishlist
thanks

On 24/11/16 16:12, Jan Beulich wrote:
>>>> On 24.11.16 at 16:58, <julien.grall@arm.com> wrote:
>> On 24/11/16 15:53, Andrew Cooper wrote:
>>> On 24/11/16 15:48, Bhupinder Thakur wrote:
>>>> If I manually remove the following files and recompile then
>>>> compilation is successful:
>>>>
>>>> Remove xen/arch/arm/asm-offsets.s
>>>> Remove xen/arch/arm/xen.lds
>>>>
>>>> The same issue happens if you build for ARM32 first and then try to
>>>> build for ARM64. After removing the 2 files manually, the compilation
>>>> is successful.
>>>>
>>>> I am using the following toolchains:
>>>> gcc-linaro-4.9-2014.11-x86_64_aarch64-linux-gnu.tar.xz (for ARM64 build)
>>>> x86_64-gcc-4.9.0-nolibc_arm-unknown-linux-gnueabi.tar.xz (for ARM32
>>>> build -
>>>> https://www.kernel.org/pub/tools/crosstool/files/bin/x86_64/4.9.0/)
>>>>
>>>> I think probably the above-mentioned two files need to be removed
>>>> automatically when make distclean is run.
>>>
>>> They should be deleted on `make clean`.  They are temporary files just
>>> like .o's
>>
>> It will only happen if you do make clean XEN_TARGET_ARCH=arm64/arm32.
>>
>> This is because target clean/distclean is only called for a given
>> architecture (by the default the host one).
>>
>> I am not sure whether we should clean for any architecture.
>
> I think it would be nice if "clean" affected the whole tree, but for
> now I think those who really can't afford separate build trees
> will need to live with having to pass XEN_TARGET_ARCH= on
> the clean invocation.
>
> Jan
>

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Processed: Re: Xen compilation fails for ARM32 when recompiled on a ARM64 build

[xen]

Processing commands for xen@bugs.xenproject.org:

> create ^
Created new bug #54 rooted at `<58371F760200007800121E3F@prv-mh.provo.novell.com>'
Title: `Re: [Xen-devel] Xen compilation fails for ARM32 when recompiled on a ARM64 build'
> title it makefile: clean target should affect the whole tree
Set title for #54 to `makefile: clean target should affect the whole tree'
> severity it wishlist
Change severity for #54 to `wishlist'
> thanks
Finished processing.

Modified/created Bugs:
 - 54: http://bugs.xenproject.org/xen/bug/54 (new)

---
Xen Hypervisor Bug Tracker
See http://wiki.xen.org/wiki/Reporting_Bugs_against_Xen for information on reporting bugs
Contact xen-bugs-owner@bugs.xenproject.org with any infrastructure issues

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel