All of lore.kernel.org
 help / color / mirror / Atom feed
From: matt mooney <mfmooney@gmail.com>
To: Greg Kroah-Hartman <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH 00/12] staging: usbip: miscellaneous code cleanup
Date: Wed, 11 May 2011 08:54:12 +0000	[thread overview]
Message-ID: <cover.1305103212.git.mfm@muteddisk.com> (raw)

Hi Greg,

I am interested in hearing your thoughts on the userspace interface?

Even as is, it definitely needs some work. For one thing I was thinking
of removing the debug flag from userspace. The userspace utilites are
not using it anyway, and it is not 100% working yet.

Thanks,
matt

matt mooney (12):
  staging: usbip: change debug configuration option
  staging: usbip: use single version for all modules
  staging: usbip: fix header includes
  staging: usbip: replace usbip_u{dbg,err,info} and printk with pr_
    equivalent
  staging: usbip: remove unnecessary lines and extra return statements
  staging: usbip: stub_main.c: code cleanup
  staging: usbip: stub_main.c: change __init/__exit prefix and use
    KMEM_CACHE
  staging: usbip: usbip_common.c: fix misspelled function name
  staging: usbip: edit Kconfig and rename CONFIG options
  staging: usbip: stub.h: reorganize
  staging: usbip: vhci.h: reorganize
  staging: usbip: usbip_common.h: reorganize and document request
    headers

 drivers/staging/Makefile             |    2 +-
 drivers/staging/usbip/Kconfig        |   52 +++---
 drivers/staging/usbip/Makefile       |   11 +-
 drivers/staging/usbip/stub.h         |   29 ++--
 drivers/staging/usbip/stub_dev.c     |   30 ++--
 drivers/staging/usbip/stub_main.c    |  225 ++++++++++++--------------
 drivers/staging/usbip/stub_rx.c      |   29 ++--
 drivers/staging/usbip/stub_tx.c      |   31 ++--
 drivers/staging/usbip/usbip_common.c |  262 ++++++++++++++----------------
 drivers/staging/usbip/usbip_common.h |  302 ++++++++++++++++------------------
 drivers/staging/usbip/usbip_event.c  |    4 +-
 drivers/staging/usbip/vhci.h         |   16 ++-
 drivers/staging/usbip/vhci_hcd.c     |  107 +++++-------
 drivers/staging/usbip/vhci_rx.c      |   37 ++---
 drivers/staging/usbip/vhci_sysfs.c   |   19 +-
 drivers/staging/usbip/vhci_tx.c      |   10 +-
 16 files changed, 541 insertions(+), 625 deletions(-)

-- 
1.7.5.1


WARNING: multiple messages have this Message-ID (diff)
From: matt mooney <mfmooney@gmail.com>
To: Greg Kroah-Hartman <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH 00/12] staging: usbip: miscellaneous code cleanup
Date: Wed, 11 May 2011 01:54:12 -0700	[thread overview]
Message-ID: <cover.1305103212.git.mfm@muteddisk.com> (raw)

Hi Greg,

I am interested in hearing your thoughts on the userspace interface?

Even as is, it definitely needs some work. For one thing I was thinking
of removing the debug flag from userspace. The userspace utilites are
not using it anyway, and it is not 100% working yet.

Thanks,
matt

matt mooney (12):
  staging: usbip: change debug configuration option
  staging: usbip: use single version for all modules
  staging: usbip: fix header includes
  staging: usbip: replace usbip_u{dbg,err,info} and printk with pr_
    equivalent
  staging: usbip: remove unnecessary lines and extra return statements
  staging: usbip: stub_main.c: code cleanup
  staging: usbip: stub_main.c: change __init/__exit prefix and use
    KMEM_CACHE
  staging: usbip: usbip_common.c: fix misspelled function name
  staging: usbip: edit Kconfig and rename CONFIG options
  staging: usbip: stub.h: reorganize
  staging: usbip: vhci.h: reorganize
  staging: usbip: usbip_common.h: reorganize and document request
    headers

 drivers/staging/Makefile             |    2 +-
 drivers/staging/usbip/Kconfig        |   52 +++---
 drivers/staging/usbip/Makefile       |   11 +-
 drivers/staging/usbip/stub.h         |   29 ++--
 drivers/staging/usbip/stub_dev.c     |   30 ++--
 drivers/staging/usbip/stub_main.c    |  225 ++++++++++++--------------
 drivers/staging/usbip/stub_rx.c      |   29 ++--
 drivers/staging/usbip/stub_tx.c      |   31 ++--
 drivers/staging/usbip/usbip_common.c |  262 ++++++++++++++----------------
 drivers/staging/usbip/usbip_common.h |  302 ++++++++++++++++------------------
 drivers/staging/usbip/usbip_event.c  |    4 +-
 drivers/staging/usbip/vhci.h         |   16 ++-
 drivers/staging/usbip/vhci_hcd.c     |  107 +++++-------
 drivers/staging/usbip/vhci_rx.c      |   37 ++---
 drivers/staging/usbip/vhci_sysfs.c   |   19 +-
 drivers/staging/usbip/vhci_tx.c      |   10 +-
 16 files changed, 541 insertions(+), 625 deletions(-)

-- 
1.7.5.1


             reply	other threads:[~2011-05-11  8:54 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-11  8:54 matt mooney [this message]
2011-05-11  8:54 ` [PATCH 00/12] staging: usbip: miscellaneous code cleanup matt mooney
2011-05-11  8:54 ` [PATCH 01/12] staging: usbip: change debug configuration option matt mooney
2011-05-11  8:54   ` matt mooney
2011-05-11  8:54 ` [PATCH 02/12] staging: usbip: use single version for all modules matt mooney
2011-05-11  8:54   ` matt mooney
2011-05-11  8:54 ` [PATCH 03/12] staging: usbip: fix header includes matt mooney
2011-05-11  8:54   ` matt mooney
2011-05-11 21:07   ` Greg KH
2011-05-11 21:07     ` Greg KH
2011-05-11 22:54     ` matt mooney
2011-05-11 22:54       ` matt mooney
2011-05-11  8:54 ` [PATCH 04/12] staging: usbip: replace usbip_u{dbg,err,info} and printk with pr_ equivalent matt mooney
2011-05-11  8:54   ` matt mooney
2011-05-11 21:06   ` [PATCH 04/12] staging: usbip: replace usbip_u{dbg,err,info} and Greg KH
2011-05-11 21:06     ` [PATCH 04/12] staging: usbip: replace usbip_u{dbg,err,info} and printk with pr_ equivalent Greg KH
2011-05-11 22:51     ` [PATCH 04/12] staging: usbip: replace usbip_u{dbg,err,info} and matt mooney
2011-05-11 22:51       ` [PATCH 04/12] staging: usbip: replace usbip_u{dbg,err,info} and printk with pr_ equivalent matt mooney
2011-05-11 23:19       ` [PATCH 04/12] staging: usbip: replace usbip_u{dbg,err,info} and Greg KH
2011-05-11 23:19         ` [PATCH 04/12] staging: usbip: replace usbip_u{dbg,err,info} and printk with pr_ equivalent Greg KH
2011-05-11  8:54 ` [PATCH 05/12] staging: usbip: remove unnecessary lines and extra return statements matt mooney
2011-05-11  8:54   ` matt mooney
2011-05-11  8:54 ` [PATCH 06/12] staging: usbip: stub_main.c: code cleanup matt mooney
2011-05-11  8:54   ` matt mooney
2011-05-11 21:08   ` Greg KH
2011-05-11 21:08     ` Greg KH
2011-05-11 22:56     ` matt mooney
2011-05-11 22:56       ` matt mooney
2011-05-11  8:54 ` [PATCH 07/12] staging: usbip: stub_main.c: change __init/__exit prefix and use KMEM_CACHE matt mooney
2011-05-11  8:54   ` matt mooney
2011-05-11  8:54 ` [PATCH 08/12] staging: usbip: usbip_common.c: fix misspelled function name matt mooney
2011-05-11  8:54   ` matt mooney
2011-05-11  8:54 ` [PATCH 09/12] staging: usbip: edit Kconfig and rename CONFIG options matt mooney
2011-05-11  8:54   ` matt mooney
2011-05-11 21:09   ` [PATCH 09/12] staging: usbip: edit Kconfig and rename CONFIG Greg KH
2011-05-11 21:09     ` [PATCH 09/12] staging: usbip: edit Kconfig and rename CONFIG options Greg KH
2011-05-11  8:54 ` [PATCH 10/12] staging: usbip: stub.h: reorganize matt mooney
2011-05-11  8:54   ` matt mooney
2011-05-11  8:54 ` [PATCH 11/12] staging: usbip: vhci.h: reorganize matt mooney
2011-05-11  8:54   ` matt mooney
2011-05-11  8:54 ` [PATCH 12/12] staging: usbip: usbip_common.h: reorganize and document request headers matt mooney
2011-05-11  8:54   ` matt mooney
2011-05-11 21:14 ` [PATCH 00/12] staging: usbip: miscellaneous code cleanup Greg KH
2011-05-11 21:14   ` Greg KH
2011-05-11 23:08   ` matt mooney
2011-05-11 23:08     ` matt mooney
2011-05-11 23:18     ` Greg KH
2011-05-11 23:18       ` Greg KH
2011-05-12  3:24       ` matt mooney
2011-05-12  3:24         ` matt mooney
2011-05-12  5:31         ` Greg KH
2011-05-12  5:31           ` Greg KH
2011-05-12  5:41           ` matt mooney
2011-05-12  5:41             ` matt mooney
2011-05-12 16:38             ` Greg KH
2011-05-12 16:38               ` Greg KH
2011-05-12  5:08 ` [PATCH 09/12 v2] staging: usbip: edit Kconfig and rename CONFIG options mfmooney
2011-05-12  5:08   ` mfmooney
2011-05-12  5:08 ` [PATCH 03/12 v2] staging: usbip: fix header includes mfmooney
2011-05-12  5:08   ` mfmooney
2011-05-12  5:17 ` [PATCH 09/12 v3] staging: usbip: edit Kconfig and rename CONFIG options mfmooney
2011-05-12  5:17   ` mfmooney
2011-05-12  5:32   ` [PATCH 09/12 v3] staging: usbip: edit Kconfig and rename CONFIG Greg KH
2011-05-12  5:32     ` [PATCH 09/12 v3] staging: usbip: edit Kconfig and rename CONFIG options Greg KH
2011-05-12  5:32     ` matt mooney
2011-05-12  5:32       ` matt mooney
2011-05-12 13:34 ` [PATCH 00/12] staging: usbip: miscellaneous code cleanup Matthew Wilcox
2011-05-12 13:34   ` Matthew Wilcox
2011-05-12 18:37   ` matt mooney
2011-05-12 18:37     ` matt mooney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1305103212.git.mfm@muteddisk.com \
    --to=mfmooney@gmail.com \
    --cc=greg@kroah.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.