* [PATCH 0/1] poky-lsb.conf: Instead of += with _append
@ 2011-06-23 7:49 Xiaofeng Yan
2011-06-23 7:50 ` [PATCH 1/1] " Xiaofeng Yan
2011-06-23 10:19 ` [PATCH 0/1] " Richard Purdie
0 siblings, 2 replies; 3+ messages in thread
From: Xiaofeng Yan @ 2011-06-23 7:49 UTC (permalink / raw)
To: poky
From: Xiaofeng Yan <xiaofeng.yan@windriver.com>
Hi Richard,
The variable "DISTRO_FEATURES += " lost its function because it has been moved to defaultsetup.conf.
Defaultsetup.conf is included after poky-lsb.conf. So the variable is empty. I use "_append" to take place of "+=".
Please check patch for detailed information.
Pull URL: git://git.pokylinux.org/poky-contrib.git
Branch: xiaofeng/poky-lsb
Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=xiaofeng/poky-lsb
Thanks,
Xiaofeng Yan <xiaofeng.yan@windriver.com>
---
Xiaofeng Yan (1):
poky-lsb.conf: Instead of += with _append
meta-yocto/conf/distro/poky-lsb.conf | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH 1/1] poky-lsb.conf: Instead of += with _append
2011-06-23 7:49 [PATCH 0/1] poky-lsb.conf: Instead of += with _append Xiaofeng Yan
@ 2011-06-23 7:50 ` Xiaofeng Yan
2011-06-23 10:19 ` [PATCH 0/1] " Richard Purdie
1 sibling, 0 replies; 3+ messages in thread
From: Xiaofeng Yan @ 2011-06-23 7:50 UTC (permalink / raw)
To: poky
From: Xiaofeng Yan <xiaofeng.yan@windriver.com>
The default variable DISTRO_FEATURES was set in poky.conf before \
moving to defaultsetup.conf. Defaultsetup.conf is included after poky-lsb.conf \
So poky-lsb.conf sets the variable using += but since its empty, \
it might as well be an = and then the later ?= doesn't do anything since the \
variable is already set.
Signed-off-by: Xiaofeng Yan <xiaofeng.yan@windriver.com>
---
meta-yocto/conf/distro/poky-lsb.conf | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/meta-yocto/conf/distro/poky-lsb.conf b/meta-yocto/conf/distro/poky-lsb.conf
index eb1cf82..49d12da 100644
--- a/meta-yocto/conf/distro/poky-lsb.conf
+++ b/meta-yocto/conf/distro/poky-lsb.conf
@@ -3,7 +3,7 @@ require conf/distro/poky.conf
DISTRO = "poky-lsb"
DISTROOVERRIDES = "poky:linuxstdbase"
-DISTRO_FEATURES += "pam largefile"
+DISTRO_FEATURES_append = " pam largefile"
PREFERRED_PROVIDER_virtual/libx11 = "libx11"
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 0/1] poky-lsb.conf: Instead of += with _append
2011-06-23 7:49 [PATCH 0/1] poky-lsb.conf: Instead of += with _append Xiaofeng Yan
2011-06-23 7:50 ` [PATCH 1/1] " Xiaofeng Yan
@ 2011-06-23 10:19 ` Richard Purdie
1 sibling, 0 replies; 3+ messages in thread
From: Richard Purdie @ 2011-06-23 10:19 UTC (permalink / raw)
To: Xiaofeng Yan; +Cc: poky
On Thu, 2011-06-23 at 15:49 +0800, Xiaofeng Yan wrote:
> From: Xiaofeng Yan <xiaofeng.yan@windriver.com>
>
> Hi Richard,
>
> The variable "DISTRO_FEATURES += " lost its function because it has been moved to defaultsetup.conf.
> Defaultsetup.conf is included after poky-lsb.conf. So the variable is empty. I use "_append" to take place of "+=".
> Please check patch for detailed information.
>
> Pull URL: git://git.pokylinux.org/poky-contrib.git
> Branch: xiaofeng/poky-lsb
> Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=xiaofeng/poky-lsb
>
> Thanks,
> Xiaofeng Yan <xiaofeng.yan@windriver.com>
> ---
>
>
> Xiaofeng Yan (1):
> poky-lsb.conf: Instead of += with _append
Merged to master, thanks.
Richard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-06-23 10:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-23 7:49 [PATCH 0/1] poky-lsb.conf: Instead of += with _append Xiaofeng Yan
2011-06-23 7:50 ` [PATCH 1/1] " Xiaofeng Yan
2011-06-23 10:19 ` [PATCH 0/1] " Richard Purdie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.