All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-oe][PATCH 0/2] Import ckermit recipe
@ 2011-08-16  9:24 Anders Darander
  2011-08-16  9:24 ` [meta-oe][PATCH 1/2] ckermit: import from OE rev 84812c64e7146d75004b3eeecae22b6d1118c1fb Anders Darander
  2011-08-16  9:24 ` [meta-oe][PATCH 2/2] ckermit: update to version 9.0 Anders Darander
  0 siblings, 2 replies; 6+ messages in thread
From: Anders Darander @ 2011-08-16  9:24 UTC (permalink / raw)
  To: openembedded-devel; +Cc: Anders Darander


Ckermit is useful, not least as an alternative to lrzsz for serial port
file-transfer (it has been a lot more robust in a number of cases).

This patch series imports the ckermit recipe from oe-dev. Thereafter, ckermit
gets updated to the latest version, which also has the licensed change to BSD
3-clause.

The following changes since commit 4edc680bfd93f9358f099e1513f916c46347f538:

  libx11: skip self if x11 not in DISTRO_FEATURES (2011-08-16 10:03:11 +0200)

are available in the git repository at:
  git://github.com/darander/meta-oe ckermit
  https://github.com/darander/meta-oe/tree/ckermit

Anders Darander (2):
  ckermit: import from OE rev 84812c64e7146d75004b3eeecae22b6d1118c1fb
  ckermit: update to version 9.0

 meta-oe/recipes-support/ckermit/ckermit_301.bb |   58 ++++++++++++++++++++++++
 1 files changed, 58 insertions(+), 0 deletions(-)
 create mode 100644 meta-oe/recipes-support/ckermit/ckermit_301.bb

-- 
1.7.5.4




^ permalink raw reply	[flat|nested] 6+ messages in thread

* [meta-oe][PATCH 1/2] ckermit: import from OE rev 84812c64e7146d75004b3eeecae22b6d1118c1fb
  2011-08-16  9:24 [meta-oe][PATCH 0/2] Import ckermit recipe Anders Darander
@ 2011-08-16  9:24 ` Anders Darander
  2011-08-16 10:18   ` Paul Menzel
  2011-08-16  9:24 ` [meta-oe][PATCH 2/2] ckermit: update to version 9.0 Anders Darander
  1 sibling, 1 reply; 6+ messages in thread
From: Anders Darander @ 2011-08-16  9:24 UTC (permalink / raw)
  To: openembedded-devel

Adding LIC_FILES_CHKSUM, otherwise it is identical to the oe version.

Signed-off-by: Anders Darander <anders@chargestorm.se>
---
 meta-oe/recipes-support/ckermit/ckermit_211.bb |   98 ++++++++++++++++++++++++
 1 files changed, 98 insertions(+), 0 deletions(-)
 create mode 100644 meta-oe/recipes-support/ckermit/ckermit_211.bb

diff --git a/meta-oe/recipes-support/ckermit/ckermit_211.bb b/meta-oe/recipes-support/ckermit/ckermit_211.bb
new file mode 100644
index 0000000..86330d3
--- /dev/null
+++ b/meta-oe/recipes-support/ckermit/ckermit_211.bb
@@ -0,0 +1,98 @@
+DESCRIPTION = "C-Kermit is a combined serial and network communication \
+software package offering a consistent, medium-independent, \
+cross-platform approach to connection establishment, terminal \
+sessions, file transfer, character-set translation, and automation \
+of communication tasks."
+LICENSE = "Kermit"
+LIC_FILES_CHKSUM = "file://COPYING.TXT;md5=17dabbd2543933464b6d32083c3a3596"
+HOMEPAGE = "http://www.columbia.edu/kermit/"
+SECTION = "console/network"
+SRC_URI = "ftp://kermit.columbia.edu/kermit/archives/cku${PV}.tar.gz;subdir=${BPN}-${PV}"
+PR = "r3"
+
+#
+# From http://www.columbia.edu/kermit/ck80.html#license
+#
+#	"Free Unix Distributions: C-Kermit may be included in "free Unix"
+#	distributions such as GNU/Linux, FreeBSD, NetBSD, and OpenBSD. See the
+#	license for details."
+#
+# A distributions based on OpenEmbedded (OpenZaurus, OpenSimpad etc) is a
+# "free Unix" distribution, therefore we can include the package.
+#
+#
+# Please note that the license is not 100% because it limits what you can
+# do:
+#
+#	"The C-Kermit source code may not be changed without the consent of
+#	the Kermit Project, which will not be unreasonably withheld (this is
+#	simply a matter of keeping a consistent and supportable code base)."
+#
+# But we don't change the source code in any way, so we comply to the license.
+# So, essentially for us C-Kermit is free as in beer, but not in freedom.
+#
+# That is true for other distros. C-Kkermit is distributed by:
+#
+#	Debian:	http://packages.debian.org/unstable/comm/ckermit
+#	Gentoo: http://mirror.pudas.net/gentoo-x86-portage/app-misc/ckermit/ckermit-8.0.211.ebuild
+#	SuSE: http://www.novell.com/products/linuxpackages/enterpriseserver/s390/ckermit.html
+#	Fedora Core: http://cvs.fedora.redhat.com/viewcvs/devel/ckermit/
+#	PLD: http://cvs.pld.org.pl/SPECS/ckermit.spec
+#
+# and, according to the Kermit website http://www.columbia.edu/kermit/ck80.html also with
+#
+#	Red Hat 9 (on earlier Red Hat's it was on the PowerTools CD)
+#	HP-UX
+#	FreeBSD
+#	NetBSD
+#	OpenBSD
+#
+# ... and probably other distro's as well.
+#
+
+export CC2 = "${CC}"
+export BINDIR = "${bindir}"
+export MANDIR = "${mandir}/man1"
+export INFODIR = "${infodir}"
+
+# Additional flags. For uclibc we add -DNOARROWKEYS which stops ckermit
+# trying to look inside the stdio headers.
+CKERMIT_ADDITIONAL = ""
+CKERMIT_ADDITIONAL_libc-uclibc = "-DNOARROWKEYS"
+
+TARGET_CC_ARCH += "${LDFLAGS}"
+
+do_compile () {
+	# The original makefile doesn't differentiate between CC and CC_FOR_BUILD,
+	# so we build wart manually. Note that you need a ckwart.o with the proper
+	# timestamp to make this hack work:
+	${BUILD_CC} -c ckwart.c
+	${BUILD_CC} -o wart ckwart.o
+	./wart ckcpro.w ckcpro.c
+
+	# read ${S}/ckccfg.txt to understand this :-)
+	oe_runmake wermit CFLAGS="${CFLAGS} -DLINUX -DCK_POSIX_SIG \
+		-DNOTCPOPTS -DLINUXFSSTND -DNOCOTFMC -DPOSIX -DUSE_STRERROR \
+		-DNOSYSLOG -DHAVE_PTMX -DNO_DNS_SRV -DNOGFTIMER \
+		-DNOB_50 -DNOB_75 -DNOB_134 -DNOB_150 -DNOB_200 \
+		-DNOB_1800 -DNOB_3600 -DNOB_7200 -DNOB_76K -DNOB_230K \
+		-DNOB_460K -DNOB_921K \
+		-DNOAPC -DNOCSETS -DNONET -DNOUNICODE -DNOHELP -DNODEBUG \
+		-DNOFRILLS -DNOFTP -DNODIAL -DNOPUSH -DNOIKSD -DNOHTTP -DNOFLOAT \
+		-DNOSERVER -DNOSEXP -DNORLOGIN -DNOOLDMODEMS -DNOSSH -DNOLISTEN \
+		-DNORESEND -DNOAUTODL -DNOSTREAMING -DNOHINTS -DNOCKXYZ -DNOLEARN \
+		-DNOMKDIR -DNOPERMS -DNOCKTIMERS -DNOCKREGEX -DNOREALPATH \
+		-DCK_SMALL -DNOLOGDIAL -DNORENAME -DNOWHATAMI \
+		${CKERMIT_ADDITIONAL}"
+}
+
+do_install () {
+	install -d ${D}${BINDIR} ${D}${MANDIR} ${D}${INFODIR}
+	oe_runmake 'DESTDIR=${D}' 'MANDIR=${D}${MANDIR}' install
+	# Fix up dangling symlink
+	rm ${D}${BINDIR}/kermit-sshsub
+	(cd ${D}${BINDIR} && ln -s ${BINDIR}/kermit kermit-sshusb)
+}
+
+SRC_URI[md5sum] = "5767ec5e6ff0857cbfe2d3ec1ee0e2bc"
+SRC_URI[sha256sum] = "39e7cd4892502344a635952843487d9b4bfa98e59d1e1acad5ef8aa969abba93"
-- 
1.7.5.4




^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [meta-oe][PATCH 2/2] ckermit: update to version 9.0
  2011-08-16  9:24 [meta-oe][PATCH 0/2] Import ckermit recipe Anders Darander
  2011-08-16  9:24 ` [meta-oe][PATCH 1/2] ckermit: import from OE rev 84812c64e7146d75004b3eeecae22b6d1118c1fb Anders Darander
@ 2011-08-16  9:24 ` Anders Darander
  2011-08-16 10:23   ` Paul Menzel
  1 sibling, 1 reply; 6+ messages in thread
From: Anders Darander @ 2011-08-16  9:24 UTC (permalink / raw)
  To: openembedded-devel

The update changes the license from kermit to BSD.
Remove the NOAPCS compile flag to make the new version compile cleanly.

Signed-off-by: Anders Darander <anders@chargestorm.se>
---
 meta-oe/recipes-support/ckermit/ckermit_211.bb |   98 ------------------------
 meta-oe/recipes-support/ckermit/ckermit_301.bb |   58 ++++++++++++++
 2 files changed, 58 insertions(+), 98 deletions(-)
 delete mode 100644 meta-oe/recipes-support/ckermit/ckermit_211.bb
 create mode 100644 meta-oe/recipes-support/ckermit/ckermit_301.bb

diff --git a/meta-oe/recipes-support/ckermit/ckermit_211.bb b/meta-oe/recipes-support/ckermit/ckermit_211.bb
deleted file mode 100644
index 86330d3..0000000
--- a/meta-oe/recipes-support/ckermit/ckermit_211.bb
+++ /dev/null
@@ -1,98 +0,0 @@
-DESCRIPTION = "C-Kermit is a combined serial and network communication \
-software package offering a consistent, medium-independent, \
-cross-platform approach to connection establishment, terminal \
-sessions, file transfer, character-set translation, and automation \
-of communication tasks."
-LICENSE = "Kermit"
-LIC_FILES_CHKSUM = "file://COPYING.TXT;md5=17dabbd2543933464b6d32083c3a3596"
-HOMEPAGE = "http://www.columbia.edu/kermit/"
-SECTION = "console/network"
-SRC_URI = "ftp://kermit.columbia.edu/kermit/archives/cku${PV}.tar.gz;subdir=${BPN}-${PV}"
-PR = "r3"
-
-#
-# From http://www.columbia.edu/kermit/ck80.html#license
-#
-#	"Free Unix Distributions: C-Kermit may be included in "free Unix"
-#	distributions such as GNU/Linux, FreeBSD, NetBSD, and OpenBSD. See the
-#	license for details."
-#
-# A distributions based on OpenEmbedded (OpenZaurus, OpenSimpad etc) is a
-# "free Unix" distribution, therefore we can include the package.
-#
-#
-# Please note that the license is not 100% because it limits what you can
-# do:
-#
-#	"The C-Kermit source code may not be changed without the consent of
-#	the Kermit Project, which will not be unreasonably withheld (this is
-#	simply a matter of keeping a consistent and supportable code base)."
-#
-# But we don't change the source code in any way, so we comply to the license.
-# So, essentially for us C-Kermit is free as in beer, but not in freedom.
-#
-# That is true for other distros. C-Kkermit is distributed by:
-#
-#	Debian:	http://packages.debian.org/unstable/comm/ckermit
-#	Gentoo: http://mirror.pudas.net/gentoo-x86-portage/app-misc/ckermit/ckermit-8.0.211.ebuild
-#	SuSE: http://www.novell.com/products/linuxpackages/enterpriseserver/s390/ckermit.html
-#	Fedora Core: http://cvs.fedora.redhat.com/viewcvs/devel/ckermit/
-#	PLD: http://cvs.pld.org.pl/SPECS/ckermit.spec
-#
-# and, according to the Kermit website http://www.columbia.edu/kermit/ck80.html also with
-#
-#	Red Hat 9 (on earlier Red Hat's it was on the PowerTools CD)
-#	HP-UX
-#	FreeBSD
-#	NetBSD
-#	OpenBSD
-#
-# ... and probably other distro's as well.
-#
-
-export CC2 = "${CC}"
-export BINDIR = "${bindir}"
-export MANDIR = "${mandir}/man1"
-export INFODIR = "${infodir}"
-
-# Additional flags. For uclibc we add -DNOARROWKEYS which stops ckermit
-# trying to look inside the stdio headers.
-CKERMIT_ADDITIONAL = ""
-CKERMIT_ADDITIONAL_libc-uclibc = "-DNOARROWKEYS"
-
-TARGET_CC_ARCH += "${LDFLAGS}"
-
-do_compile () {
-	# The original makefile doesn't differentiate between CC and CC_FOR_BUILD,
-	# so we build wart manually. Note that you need a ckwart.o with the proper
-	# timestamp to make this hack work:
-	${BUILD_CC} -c ckwart.c
-	${BUILD_CC} -o wart ckwart.o
-	./wart ckcpro.w ckcpro.c
-
-	# read ${S}/ckccfg.txt to understand this :-)
-	oe_runmake wermit CFLAGS="${CFLAGS} -DLINUX -DCK_POSIX_SIG \
-		-DNOTCPOPTS -DLINUXFSSTND -DNOCOTFMC -DPOSIX -DUSE_STRERROR \
-		-DNOSYSLOG -DHAVE_PTMX -DNO_DNS_SRV -DNOGFTIMER \
-		-DNOB_50 -DNOB_75 -DNOB_134 -DNOB_150 -DNOB_200 \
-		-DNOB_1800 -DNOB_3600 -DNOB_7200 -DNOB_76K -DNOB_230K \
-		-DNOB_460K -DNOB_921K \
-		-DNOAPC -DNOCSETS -DNONET -DNOUNICODE -DNOHELP -DNODEBUG \
-		-DNOFRILLS -DNOFTP -DNODIAL -DNOPUSH -DNOIKSD -DNOHTTP -DNOFLOAT \
-		-DNOSERVER -DNOSEXP -DNORLOGIN -DNOOLDMODEMS -DNOSSH -DNOLISTEN \
-		-DNORESEND -DNOAUTODL -DNOSTREAMING -DNOHINTS -DNOCKXYZ -DNOLEARN \
-		-DNOMKDIR -DNOPERMS -DNOCKTIMERS -DNOCKREGEX -DNOREALPATH \
-		-DCK_SMALL -DNOLOGDIAL -DNORENAME -DNOWHATAMI \
-		${CKERMIT_ADDITIONAL}"
-}
-
-do_install () {
-	install -d ${D}${BINDIR} ${D}${MANDIR} ${D}${INFODIR}
-	oe_runmake 'DESTDIR=${D}' 'MANDIR=${D}${MANDIR}' install
-	# Fix up dangling symlink
-	rm ${D}${BINDIR}/kermit-sshsub
-	(cd ${D}${BINDIR} && ln -s ${BINDIR}/kermit kermit-sshusb)
-}
-
-SRC_URI[md5sum] = "5767ec5e6ff0857cbfe2d3ec1ee0e2bc"
-SRC_URI[sha256sum] = "39e7cd4892502344a635952843487d9b4bfa98e59d1e1acad5ef8aa969abba93"
diff --git a/meta-oe/recipes-support/ckermit/ckermit_301.bb b/meta-oe/recipes-support/ckermit/ckermit_301.bb
new file mode 100644
index 0000000..818a571
--- /dev/null
+++ b/meta-oe/recipes-support/ckermit/ckermit_301.bb
@@ -0,0 +1,58 @@
+DESCRIPTION = "C-Kermit is a combined serial and network communication \
+software package offering a consistent, medium-independent, \
+cross-platform approach to connection establishment, terminal \
+sessions, file transfer, character-set translation, and automation \
+of communication tasks."
+LICENSE = "BSD-3-Clause"
+LIC_FILES_CHKSUM = "file://COPYING.TXT;md5=932ca542d6c6cb8a59a0bcd76ab67cc3"
+HOMEPAGE = "http://www.columbia.edu/kermit/"
+SECTION = "console/network"
+SRC_URI = "ftp://www.columbia.edu/kermit/archives/cku${PV}.tar.gz;subdir=${BPN}-${PV}"
+PR = "r0"
+
+export CC2 = "${CC}"
+export BINDIR = "${bindir}"
+export MANDIR = "${mandir}/man1"
+export INFODIR = "${infodir}"
+
+# Additional flags. For uclibc we add -DNOARROWKEYS which stops ckermit
+# trying to look inside the stdio headers.
+CKERMIT_ADDITIONAL = ""
+CKERMIT_ADDITIONAL_libc-uclibc = "-DNOARROWKEYS"
+
+TARGET_CC_ARCH += "${LDFLAGS}"
+
+do_compile () {
+	# The original makefile doesn't differentiate between CC and CC_FOR_BUILD,
+	# so we build wart manually. Note that you need a ckwart.o with the proper
+	# timestamp to make this hack work:
+	${BUILD_CC} -c ckwart.c
+	${BUILD_CC} -o wart ckwart.o
+	./wart ckcpro.w ckcpro.c
+
+	# read ${S}/ckccfg.txt to understand this :-)
+	oe_runmake wermit CFLAGS="${CFLAGS} -DLINUX -DCK_POSIX_SIG \
+		-DNOTCPOPTS -DLINUXFSSTND -DNOCOTFMC -DPOSIX -DUSE_STRERROR \
+		-DNOSYSLOG -DHAVE_PTMX -DNO_DNS_SRV -DNOGFTIMER \
+		-DNOB_50 -DNOB_75 -DNOB_134 -DNOB_150 -DNOB_200 \
+		-DNOB_1800 -DNOB_3600 -DNOB_7200 -DNOB_76K -DNOB_230K \
+		-DNOB_460K -DNOB_921K \
+		-DNOCSETS -DNONET -DNOUNICODE -DNOHELP -DNODEBUG \
+		-DNOFRILLS -DNOFTP -DNODIAL -DNOPUSH -DNOIKSD -DNOHTTP -DNOFLOAT \
+		-DNOSERVER -DNOSEXP -DNORLOGIN -DNOOLDMODEMS -DNOSSH -DNOLISTEN \
+		-DNORESEND -DNOAUTODL -DNOSTREAMING -DNOHINTS -DNOCKXYZ -DNOLEARN \
+		-DNOMKDIR -DNOPERMS -DNOCKTIMERS -DNOCKREGEX -DNOREALPATH \
+		-DCK_SMALL -DNOLOGDIAL -DNORENAME -DNOWHATAMI \
+		${CKERMIT_ADDITIONAL}"
+}
+
+do_install () {
+	install -d ${D}${BINDIR} ${D}${MANDIR} ${D}${INFODIR}
+	oe_runmake 'DESTDIR=${D}' install
+	# Fix up dangling symlink
+	rm ${D}${BINDIR}/kermit-sshsub
+	(cd ${D}${BINDIR} && ln -s ${BINDIR}/kermit kermit-sshusb)
+}
+
+SRC_URI[md5sum] = "59e80f909edf305933af8e0348dcc5d7"
+SRC_URI[sha256sum] = "9793eb125f8936b079c6d7e5c3d2ff885cfedc07f9d2dd1e7db928e3029a211a"
-- 
1.7.5.4




^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [meta-oe][PATCH 1/2] ckermit: import from OE rev 84812c64e7146d75004b3eeecae22b6d1118c1fb
  2011-08-16  9:24 ` [meta-oe][PATCH 1/2] ckermit: import from OE rev 84812c64e7146d75004b3eeecae22b6d1118c1fb Anders Darander
@ 2011-08-16 10:18   ` Paul Menzel
  0 siblings, 0 replies; 6+ messages in thread
From: Paul Menzel @ 2011-08-16 10:18 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 3643 bytes --]

Dear Anders,


Am Dienstag, den 16.08.2011, 11:24 +0200 schrieb Anders Darander:
> Adding LIC_FILES_CHKSUM, otherwise it is identical to the oe version.

I always would like to see people adding their build/test configuration
to the commit summary so that people can reproduce this when having
problems.

> Signed-off-by: Anders Darander <anders@chargestorm.se>
> ---
>  meta-oe/recipes-support/ckermit/ckermit_211.bb |   98 ++++++++++++++++++++++++
>  1 files changed, 98 insertions(+), 0 deletions(-)
>  create mode 100644 meta-oe/recipes-support/ckermit/ckermit_211.bb
> 
> diff --git a/meta-oe/recipes-support/ckermit/ckermit_211.bb b/meta-oe/recipes-support/ckermit/ckermit_211.bb
> new file mode 100644
> index 0000000..86330d3
> --- /dev/null
> +++ b/meta-oe/recipes-support/ckermit/ckermit_211.bb
> @@ -0,0 +1,98 @@
> +DESCRIPTION = "C-Kermit is a combined serial and network communication \
> +software package offering a consistent, medium-independent, \
> +cross-platform approach to connection establishment, terminal \
> +sessions, file transfer, character-set translation, and automation \
> +of communication tasks."
> +LICENSE = "Kermit"
> +LIC_FILES_CHKSUM = "file://COPYING.TXT;md5=17dabbd2543933464b6d32083c3a3596"
> +HOMEPAGE = "http://www.columbia.edu/kermit/"
> +SECTION = "console/network"

Please order the variables according to the style guide [1][2].

> +SRC_URI = "ftp://kermit.columbia.edu/kermit/archives/cku${PV}.tar.gz;subdir=${BPN}-${PV}"
> +PR = "r3"

Please start with "r0" when importing recipes.

> +
> +#
> +# From http://www.columbia.edu/kermit/ck80.html#license
> +#
> +#	"Free Unix Distributions: C-Kermit may be included in "free Unix"
> +#	distributions such as GNU/Linux, FreeBSD, NetBSD, and OpenBSD. See the
> +#	license for details."
> +#
> +# A distributions based on OpenEmbedded (OpenZaurus, OpenSimpad etc) is a
> +# "free Unix" distribution, therefore we can include the package.
> +#
> +#
> +# Please note that the license is not 100% because it limits what you can
> +# do:
> +#
> +#	"The C-Kermit source code may not be changed without the consent of
> +#	the Kermit Project, which will not be unreasonably withheld (this is
> +#	simply a matter of keeping a consistent and supportable code base)."
> +#
> +# But we don't change the source code in any way, so we comply to the license.
> +# So, essentially for us C-Kermit is free as in beer, but not in freedom.
> +#
> +# That is true for other distros. C-Kkermit is distributed by:
> +#
> +#	Debian:	http://packages.debian.org/unstable/comm/ckermit
> +#	Gentoo: http://mirror.pudas.net/gentoo-x86-portage/app-misc/ckermit/ckermit-8.0.211.ebuild
> +#	SuSE: http://www.novell.com/products/linuxpackages/enterpriseserver/s390/ckermit.html
> +#	Fedora Core: http://cvs.fedora.redhat.com/viewcvs/devel/ckermit/
> +#	PLD: http://cvs.pld.org.pl/SPECS/ckermit.spec
> +#
> +# and, according to the Kermit website http://www.columbia.edu/kermit/ck80.html also with
> +#
> +#	Red Hat 9 (on earlier Red Hat's it was on the PowerTools CD)
> +#	HP-UX
> +#	FreeBSD
> +#	NetBSD
> +#	OpenBSD
> +#
> +# ... and probably other distro's as well.
> +#

I fixed some typos and committed the patch to oe.dev [3].

[…]


Thanks,

Paul


[1] http://wiki.openembedded.org/index.php/Styleguide
[2] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/recipes/ckermit/ckermit_211.bb?id=9a13ec3a5b1dfc0100fbe1a7716db4ceaff6df7a
[3] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/recipes/ckermit/ckermit_211.bb?id=5350bbef01b8979617e3d0fd38939f94f1fa5315

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [meta-oe][PATCH 2/2] ckermit: update to version 9.0
  2011-08-16  9:24 ` [meta-oe][PATCH 2/2] ckermit: update to version 9.0 Anders Darander
@ 2011-08-16 10:23   ` Paul Menzel
  2011-08-16 12:08     ` Anders Darander
  0 siblings, 1 reply; 6+ messages in thread
From: Paul Menzel @ 2011-08-16 10:23 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 1070 bytes --]

Am Dienstag, den 16.08.2011, 11:24 +0200 schrieb Anders Darander:
> The update changes the license from kermit to BSD.
> Remove the NOAPCS compile flag to make the new version compile cleanly.

What configuration did you use for build and run testing?

> Signed-off-by: Anders Darander <anders@chargestorm.se>
> ---
>  meta-oe/recipes-support/ckermit/ckermit_211.bb |   98 ------------------------
>  meta-oe/recipes-support/ckermit/ckermit_301.bb |   58 ++++++++++++++
>  2 files changed, 58 insertions(+), 98 deletions(-)
>  delete mode 100644 meta-oe/recipes-support/ckermit/ckermit_211.bb
>  create mode 100644 meta-oe/recipes-support/ckermit/ckermit_301.bb

Please pass `-M -M -C -C -C`(?) to `git format-patch` to make reviews
easier.

[…]

> diff --git a/meta-oe/recipes-support/ckermit/ckermit_301.bb b/meta-oe/recipes-support/ckermit/ckermit_301.bb

The version numbers seem quite confusing. Why is this 9.0? But that is
an upstream problem.

[…]

Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>


Thanks,

Paul

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [meta-oe][PATCH 2/2] ckermit: update to version 9.0
  2011-08-16 10:23   ` Paul Menzel
@ 2011-08-16 12:08     ` Anders Darander
  0 siblings, 0 replies; 6+ messages in thread
From: Anders Darander @ 2011-08-16 12:08 UTC (permalink / raw)
  To: openembedded-devel

* Paul Menzel <paulepanter@users.sourceforge.net> [110816 12:23]:
> Am Dienstag, den 16.08.2011, 11:24 +0200 schrieb Anders Darander:
> > ---
> >  meta-oe/recipes-support/ckermit/ckermit_211.bb |   98 ------------------------
> >  meta-oe/recipes-support/ckermit/ckermit_301.bb |   58 ++++++++++++++
> >  2 files changed, 58 insertions(+), 98 deletions(-)
> >  delete mode 100644 meta-oe/recipes-support/ckermit/ckermit_211.bb
> >  create mode 100644 meta-oe/recipes-support/ckermit/ckermit_301.bb

> Please pass `-M -M -C -C -C`(?) to `git format-patch` to make reviews
> easier.

-M40 seemed to do it this time. The main question is where to put that
threshold between seeing a rename or an add/delete-pair. I might make a
suggestion in a patch for the create-pull-request script in oe-core.

> > diff --git a/meta-oe/recipes-support/ckermit/ckermit_301.bb b/meta-oe/recipes-support/ckermit/ckermit_301.bb

> The version numbers seem quite confusing. Why is this 9.0? But that is
> an upstream problem.

I agree that they are using a really confusing version numbering
scheme... Unfortunately, that's something we'll have to live with.

Cheers,
Anders

-- 
Anders Darander
ChargeStorm AB		Tel: +46 702 44 84 36
Laxholmstorget 3	Email: anders@chargestorm.se
602 21 Norrköping	Web: www.chargestorm.se



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2011-08-16 12:13 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-16  9:24 [meta-oe][PATCH 0/2] Import ckermit recipe Anders Darander
2011-08-16  9:24 ` [meta-oe][PATCH 1/2] ckermit: import from OE rev 84812c64e7146d75004b3eeecae22b6d1118c1fb Anders Darander
2011-08-16 10:18   ` Paul Menzel
2011-08-16  9:24 ` [meta-oe][PATCH 2/2] ckermit: update to version 9.0 Anders Darander
2011-08-16 10:23   ` Paul Menzel
2011-08-16 12:08     ` Anders Darander

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.