* [PATCH 0/1] Fix git fetcher subpath option
@ 2011-09-16 13:21 Paul Eggleton
2011-09-16 13:21 ` [PATCH 1/1] fetch2/git: fix subpath destination directory Paul Eggleton
0 siblings, 1 reply; 3+ messages in thread
From: Paul Eggleton @ 2011-09-16 13:21 UTC (permalink / raw)
To: bitbake-devel
This patch makes the git fetcher (fetch2) subpath option work the way
the Opie git recipes (the main user of the option) expect.
The patch (against poky, but applies cleanly to bitbake master with
-p2) is available at:
git://git.pokylinux.org/poky-contrib paule/subpath
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=paule/subpath
Paul Eggleton (1):
fetch2/git: fix subpath destination directory
bitbake/lib/bb/fetch2/git.py | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
--
1.7.4.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/1] fetch2/git: fix subpath destination directory
2011-09-16 13:21 [PATCH 0/1] Fix git fetcher subpath option Paul Eggleton
@ 2011-09-16 13:21 ` Paul Eggleton
2011-09-17 10:54 ` Paul Eggleton
0 siblings, 1 reply; 3+ messages in thread
From: Paul Eggleton @ 2011-09-16 13:21 UTC (permalink / raw)
To: bitbake-devel
Make the git fetcher's subpath (path within the git repo to fetch)
option set the destsuffix (destination directory) option by default.
This reverts the behaviour of subpath to the same as when it was
introduced.
Based on a patch by Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
---
bitbake/lib/bb/fetch2/git.py | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/bitbake/lib/bb/fetch2/git.py b/bitbake/lib/bb/fetch2/git.py
index 9a578ae..5e9e817 100644
--- a/bitbake/lib/bb/fetch2/git.py
+++ b/bitbake/lib/bb/fetch2/git.py
@@ -210,10 +210,12 @@ class Git(FetchMethod):
subdir = ud.parm.get("subpath", "")
if subdir != "":
readpathspec = ":%s" % (subdir)
+ def_destsuffix = "%s/" % subdir
else:
readpathspec = ""
+ def_destsuffix = "git/"
- destsuffix = ud.parm.get("destsuffix", "git/")
+ destsuffix = ud.parm.get("destsuffix", def_destsuffix)
destdir = os.path.join(destdir, destsuffix)
if os.path.exists(destdir):
bb.utils.prunedir(destdir)
--
1.7.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] fetch2/git: fix subpath destination directory
2011-09-16 13:21 ` [PATCH 1/1] fetch2/git: fix subpath destination directory Paul Eggleton
@ 2011-09-17 10:54 ` Paul Eggleton
0 siblings, 0 replies; 3+ messages in thread
From: Paul Eggleton @ 2011-09-17 10:54 UTC (permalink / raw)
To: bitbake-devel
Hmm, this patch is broken for subpath depth > 1. Please disregard; will send a
v2 soon.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-09-17 11:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-16 13:21 [PATCH 0/1] Fix git fetcher subpath option Paul Eggleton
2011-09-16 13:21 ` [PATCH 1/1] fetch2/git: fix subpath destination directory Paul Eggleton
2011-09-17 10:54 ` Paul Eggleton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.