From: Nikolaus Voss <n.voss-+umVssTZoCsb1SvskN2V4Q@public.gmane.org>
To: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org
Subject: [PATCH v8 0/7] AT91: replace broken TWI driver i2c-at91.c
Date: Mon, 28 Nov 2011 12:16:57 +0100 [thread overview]
Message-ID: <cover.1322479017.git.n.voss@weinmann.de> (raw)
The old driver has two main deficencies:
i) No repeated start (Sr) condiction is possible, this makes it unusable
e.g. for most SMBus transfers.
ii) I/O was done with polling/busy waiting what caused over-/underruns
even at light system loads and clock speeds.
The new driver overcomes these deficencies and in addition allows for
more than one TWI interface.
A remaining limitation is the fact, that only one repeated start is
possible (two concatenated messages). This limitation is imposed by
the hardware. However, this should not be a problem as all common
i2c-client communication does not rely on more than one repeated start.
v8: Patch 6/7: remove local include
Patch 7/7: remove cpu_is_rm9200() and put twi hw bug info
in platform_device
Patch 3/7: use readl/writel_relaxed instead of __raw_readl/writel
v7: Patch 4/5: i) fix bug if internal address > 1 byte
ii) send stop when len == 1
(both reported by Carsten Behling)
v6: Patch 5/5: support for I2C_SMBUS_BLOCK_DATA transfers.
Better use of clk_(un)prepare().
More sensible transfer timeout.
v5: Another round of review comments from Ryan Mallon, Felipe Balbi
and Russell King: convert twi clk to use .dev_id, cleanups
v4: Integrated more review comments from Ryan Mallon and Felipe Balbi:
Moved register include file to local include, code cleanups
v3: Integrated review comments from Ryan Mallon and Felipe Balbi
v2: Fixed whitespace issue
Nikolaus Voss (7):
drivers/i2c/busses/i2c-at91.c: remove broken driver
Replace clk_lookup.con_id with clk_lookup.dev_id entries for twi clk
drivers/i2c/busses/i2c-at91.c: add new driver
G45 TWI: remove open drain setting for twi function gpios
i2c-at91.c: add SMBUS_READ_BLOCK_DATA functionality
i2c-at91: removed local include
i2c-at91: make ckdiv bug a property of the platform_device
arch/arm/mach-at91/at91cap9.c | 1 +
arch/arm/mach-at91/at91cap9_devices.c | 9 +
arch/arm/mach-at91/at91rm9200.c | 1 +
arch/arm/mach-at91/at91rm9200_devices.c | 9 +
arch/arm/mach-at91/at91sam9260.c | 1 +
arch/arm/mach-at91/at91sam9260_devices.c | 9 +
arch/arm/mach-at91/at91sam9261.c | 1 +
arch/arm/mach-at91/at91sam9261_devices.c | 9 +
arch/arm/mach-at91/at91sam9263.c | 1 +
arch/arm/mach-at91/at91sam9263_devices.c | 9 +
arch/arm/mach-at91/at91sam9g45.c | 2 +
arch/arm/mach-at91/at91sam9g45_devices.c | 16 +-
arch/arm/mach-at91/at91sam9rl.c | 2 +
arch/arm/mach-at91/at91sam9rl_devices.c | 9 +
arch/arm/mach-at91/include/mach/at91_twi.h | 68 ----
drivers/i2c/busses/Kconfig | 11 +-
drivers/i2c/busses/i2c-at91.c | 563 +++++++++++++++++-----------
17 files changed, 424 insertions(+), 297 deletions(-)
delete mode 100644 arch/arm/mach-at91/include/mach/at91_twi.h
--
1.7.5.4
WARNING: multiple messages have this Message-ID (diff)
From: Nikolaus Voss <n.voss@weinmann.de>
To: linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: ben-linux@fluff.org
Subject: [PATCH v8 0/7] AT91: replace broken TWI driver i2c-at91.c
Date: Mon, 28 Nov 2011 12:16:57 +0100 [thread overview]
Message-ID: <cover.1322479017.git.n.voss@weinmann.de> (raw)
The old driver has two main deficencies:
i) No repeated start (Sr) condiction is possible, this makes it unusable
e.g. for most SMBus transfers.
ii) I/O was done with polling/busy waiting what caused over-/underruns
even at light system loads and clock speeds.
The new driver overcomes these deficencies and in addition allows for
more than one TWI interface.
A remaining limitation is the fact, that only one repeated start is
possible (two concatenated messages). This limitation is imposed by
the hardware. However, this should not be a problem as all common
i2c-client communication does not rely on more than one repeated start.
v8: Patch 6/7: remove local include
Patch 7/7: remove cpu_is_rm9200() and put twi hw bug info
in platform_device
Patch 3/7: use readl/writel_relaxed instead of __raw_readl/writel
v7: Patch 4/5: i) fix bug if internal address > 1 byte
ii) send stop when len == 1
(both reported by Carsten Behling)
v6: Patch 5/5: support for I2C_SMBUS_BLOCK_DATA transfers.
Better use of clk_(un)prepare().
More sensible transfer timeout.
v5: Another round of review comments from Ryan Mallon, Felipe Balbi
and Russell King: convert twi clk to use .dev_id, cleanups
v4: Integrated more review comments from Ryan Mallon and Felipe Balbi:
Moved register include file to local include, code cleanups
v3: Integrated review comments from Ryan Mallon and Felipe Balbi
v2: Fixed whitespace issue
Nikolaus Voss (7):
drivers/i2c/busses/i2c-at91.c: remove broken driver
Replace clk_lookup.con_id with clk_lookup.dev_id entries for twi clk
drivers/i2c/busses/i2c-at91.c: add new driver
G45 TWI: remove open drain setting for twi function gpios
i2c-at91.c: add SMBUS_READ_BLOCK_DATA functionality
i2c-at91: removed local include
i2c-at91: make ckdiv bug a property of the platform_device
arch/arm/mach-at91/at91cap9.c | 1 +
arch/arm/mach-at91/at91cap9_devices.c | 9 +
arch/arm/mach-at91/at91rm9200.c | 1 +
arch/arm/mach-at91/at91rm9200_devices.c | 9 +
arch/arm/mach-at91/at91sam9260.c | 1 +
arch/arm/mach-at91/at91sam9260_devices.c | 9 +
arch/arm/mach-at91/at91sam9261.c | 1 +
arch/arm/mach-at91/at91sam9261_devices.c | 9 +
arch/arm/mach-at91/at91sam9263.c | 1 +
arch/arm/mach-at91/at91sam9263_devices.c | 9 +
arch/arm/mach-at91/at91sam9g45.c | 2 +
arch/arm/mach-at91/at91sam9g45_devices.c | 16 +-
arch/arm/mach-at91/at91sam9rl.c | 2 +
arch/arm/mach-at91/at91sam9rl_devices.c | 9 +
arch/arm/mach-at91/include/mach/at91_twi.h | 68 ----
drivers/i2c/busses/Kconfig | 11 +-
drivers/i2c/busses/i2c-at91.c | 563 +++++++++++++++++-----------
17 files changed, 424 insertions(+), 297 deletions(-)
delete mode 100644 arch/arm/mach-at91/include/mach/at91_twi.h
--
1.7.5.4
next reply other threads:[~2011-11-28 11:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 11:16 Nikolaus Voss [this message]
2011-11-28 11:16 ` [PATCH v8 0/7] AT91: replace broken TWI driver i2c-at91.c Nikolaus Voss
2011-11-08 10:49 ` [PATCH v8 1/7] drivers/i2c/busses/i2c-at91.c: remove broken driver Nikolaus Voss
[not found] ` <cover.1322479017.git.n.voss-+umVssTZoCsb1SvskN2V4Q@public.gmane.org>
2011-11-08 10:49 ` [PATCH v8 3/7] drivers/i2c/busses/i2c-at91.c: add new driver Nikolaus Voss
2011-11-08 10:49 ` Nikolaus Voss
2011-11-18 11:38 ` [PATCH v8 5/7] i2c-at91.c: add SMBUS_READ_BLOCK_DATA functionality Nikolaus Voss
2011-11-18 11:38 ` Nikolaus Voss
2011-11-28 11:12 ` [PATCH v8 7/7] i2c-at91: make ckdiv bug a property of the platform_device Nikolaus Voss
2011-11-28 11:12 ` Nikolaus Voss
2011-11-08 11:09 ` [PATCH v8 2/7] Replace clk_lookup.con_id with clk_lookup.dev_id entries for twi clk Nikolaus Voss
2011-11-08 11:11 ` [PATCH v8 4/7] G45 TWI: remove open drain setting for twi function gpios Nikolaus Voss
2011-11-28 11:06 ` [PATCH v8 6/7] i2c-at91: removed local include Nikolaus Voss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1322479017.git.n.voss@weinmann.de \
--to=n.voss-+umvsstzocsb1svskn2v4q@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.