From: rubini@gnudd.com (Alessandro Rubini)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/1] Renaming AMBA to PRIMECELL
Date: Fri, 6 Apr 2012 00:21:54 +0200 [thread overview]
Message-ID: <cover.1333663714.git.rubini@gnudd.com> (raw)
The only patch in this series renames CONFIG_ARM_AMBA to
CONFIG_ARM_PRIMECELL in Kconfig and the only source file with
#ifdef.
I compile-tested on the following defconfigs: "integrator realview
versatile vexpress bcmring ep93xx lpc32xx u300 u8500 nhk8815 spear3xx
spear6xx", diffing the stderr of the two compilations.
While this patch is self-contained and works, there are other
open points. I think only 4- below is worth doing, but I need
confirmation before doing that.
1- drivers/of/platform.c still has "amba" in its names. Worse, it has
"amba-bus" in its device tree compatibility list (and some drivers
have it too). I think this should stay.
2- Actually, grepping for "amba" or "AMBA" finds a lot of related
code. Some uses are correct and some are not. I don't think an
audit here is worth the effort; users will adapt over time, only
where it makes sense and only when otherwise touching the code.
3- Should drivers/amba/bus.c be renamed to drivers/primecell/bus.c
or drivers/amba/primecell.c (I think the former but I'm not sure
it's the bext name anyways)
4- Should linux/amba/bus.h be renamed to linux/primecell/bus.h or
linux/amba/primecell.h? (I think the former, leaving the old
name around for a while, so out-of-tree drivers are happy
and #warn'ed about the change.
/alessandro
Alessandro Rubini (1):
ARM: Rename CONFIG_ARM_AMBA to CONFIG_ARM_PRIMECELL
arch/arm/Kconfig | 36 ++++++++++++++++++++++--------------
arch/arm/Kconfig.debug | 2 +-
arch/arm/mach-exynos/Kconfig | 4 ++--
arch/arm/mach-mxs/devices/Kconfig | 2 +-
arch/arm/mach-netx/Kconfig | 4 ++--
arch/arm/mach-omap2/Kconfig | 2 +-
arch/arm/plat-samsung/Kconfig | 2 +-
drivers/Makefile | 2 +-
drivers/dma/Kconfig | 4 ++--
drivers/gpio/Kconfig | 2 +-
drivers/input/serio/Kconfig | 2 +-
drivers/mmc/host/Kconfig | 2 +-
drivers/of/platform.c | 10 +++++-----
drivers/rtc/Kconfig | 4 ++--
drivers/spi/Kconfig | 2 +-
drivers/tty/serial/Kconfig | 4 ++--
drivers/video/Kconfig | 2 +-
drivers/watchdog/Kconfig | 2 +-
sound/arm/Kconfig | 2 +-
19 files changed, 49 insertions(+), 41 deletions(-)
--
1.7.7.2
WARNING: multiple messages have this Message-ID (diff)
From: Alessandro Rubini <rubini@gnudd.com>
To: linux-kernel@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
Russell King - ARM Linux <linux@arm.linux.org.uk>
Subject: [PATCH 0/1] Renaming AMBA to PRIMECELL
Date: Fri, 6 Apr 2012 00:21:54 +0200 [thread overview]
Message-ID: <cover.1333663714.git.rubini@gnudd.com> (raw)
The only patch in this series renames CONFIG_ARM_AMBA to
CONFIG_ARM_PRIMECELL in Kconfig and the only source file with
#ifdef.
I compile-tested on the following defconfigs: "integrator realview
versatile vexpress bcmring ep93xx lpc32xx u300 u8500 nhk8815 spear3xx
spear6xx", diffing the stderr of the two compilations.
While this patch is self-contained and works, there are other
open points. I think only 4- below is worth doing, but I need
confirmation before doing that.
1- drivers/of/platform.c still has "amba" in its names. Worse, it has
"amba-bus" in its device tree compatibility list (and some drivers
have it too). I think this should stay.
2- Actually, grepping for "amba" or "AMBA" finds a lot of related
code. Some uses are correct and some are not. I don't think an
audit here is worth the effort; users will adapt over time, only
where it makes sense and only when otherwise touching the code.
3- Should drivers/amba/bus.c be renamed to drivers/primecell/bus.c
or drivers/amba/primecell.c (I think the former but I'm not sure
it's the bext name anyways)
4- Should linux/amba/bus.h be renamed to linux/primecell/bus.h or
linux/amba/primecell.h? (I think the former, leaving the old
name around for a while, so out-of-tree drivers are happy
and #warn'ed about the change.
/alessandro
Alessandro Rubini (1):
ARM: Rename CONFIG_ARM_AMBA to CONFIG_ARM_PRIMECELL
arch/arm/Kconfig | 36 ++++++++++++++++++++++--------------
arch/arm/Kconfig.debug | 2 +-
arch/arm/mach-exynos/Kconfig | 4 ++--
arch/arm/mach-mxs/devices/Kconfig | 2 +-
arch/arm/mach-netx/Kconfig | 4 ++--
arch/arm/mach-omap2/Kconfig | 2 +-
arch/arm/plat-samsung/Kconfig | 2 +-
drivers/Makefile | 2 +-
drivers/dma/Kconfig | 4 ++--
drivers/gpio/Kconfig | 2 +-
drivers/input/serio/Kconfig | 2 +-
drivers/mmc/host/Kconfig | 2 +-
drivers/of/platform.c | 10 +++++-----
drivers/rtc/Kconfig | 4 ++--
drivers/spi/Kconfig | 2 +-
drivers/tty/serial/Kconfig | 4 ++--
drivers/video/Kconfig | 2 +-
drivers/watchdog/Kconfig | 2 +-
sound/arm/Kconfig | 2 +-
19 files changed, 49 insertions(+), 41 deletions(-)
--
1.7.7.2
next reply other threads:[~2012-04-05 22:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-05 22:21 Alessandro Rubini [this message]
2012-04-05 22:21 ` [PATCH 0/1] Renaming AMBA to PRIMECELL Alessandro Rubini
2012-04-05 22:22 ` [PATCH 1/1] ARM: Rename CONFIG_ARM_AMBA to CONFIG_ARM_PRIMECELL Alessandro Rubini
2012-04-05 22:22 ` Alessandro Rubini
2012-04-11 22:47 ` Linus Walleij
2012-04-11 22:47 ` Linus Walleij
2012-04-06 16:59 ` [PATCH 0/1] Renaming AMBA to PRIMECELL Rob Herring
2012-04-06 16:59 ` Rob Herring
2012-04-06 17:21 ` Alessandro Rubini
2012-04-06 17:21 ` Alessandro Rubini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1333663714.git.rubini@gnudd.com \
--to=rubini@gnudd.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.