* [PATCH 0/1] sanity.bbclass: Avoid empty $PATH components
@ 2012-05-09 20:19 Peter Seebach
2012-05-09 20:19 ` [PATCH 1/1] sanity.bbclass: Detect empty $PATH components too Peter Seebach
2012-05-11 17:35 ` [PATCH 0/1] sanity.bbclass: Avoid empty $PATH components Saul Wold
0 siblings, 2 replies; 3+ messages in thread
From: Peter Seebach @ 2012-05-09 20:19 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
Empty components (including $PATHs starting or ending with a colon)
have the same harmful effects as a "." in $PATH.
The following changes since commit 8de7f8045f28aecfe796afcdb013c557ce9d1372:
Martin Jansa (1):
kmod: fix upgrade path from module-init-tools
are available in the git repository at:
git://git.yoctoproject.org/poky-contrib seebs/cleanup
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=seebs/cleanup
Peter Seebach (1):
sanity.bbclass: Detect empty $PATH components too
meta/classes/sanity.bbclass | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/1] sanity.bbclass: Detect empty $PATH components too
2012-05-09 20:19 [PATCH 0/1] sanity.bbclass: Avoid empty $PATH components Peter Seebach
@ 2012-05-09 20:19 ` Peter Seebach
2012-05-11 17:35 ` [PATCH 0/1] sanity.bbclass: Avoid empty $PATH components Saul Wold
1 sibling, 0 replies; 3+ messages in thread
From: Peter Seebach @ 2012-05-09 20:19 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
Empty components in $PATH have the same effect as a . in $PATH,
and are a common side-effect of inserting a misspelled or unset
shell variable in $PATH.
Signed-off-by: Peter Seebach <peter.seebach@windriver.com>
---
meta/classes/sanity.bbclass | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index 687ddeb..1384592 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -298,8 +298,9 @@ def check_sanity(e):
if not check_app_exists("qemu-arm", e.data):
messages = messages + "qemu-native was in ASSUME_PROVIDED but the QEMU binaries (qemu-arm) can't be found in PATH"
- if "." in data.getVar('PATH', e.data, True).split(":"):
- messages = messages + "PATH contains '.' which will break the build, please remove this"
+ paths = data.getVar('PATH', e.data, True).split(":")
+ if "." in paths or "" in paths:
+ messages = messages + "PATH contains '.' or '', which will break the build, please remove this."
if data.getVar('TARGET_ARCH', e.data, True) == "arm":
# This path is no longer user-readable in modern (very recent) Linux
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 0/1] sanity.bbclass: Avoid empty $PATH components
2012-05-09 20:19 [PATCH 0/1] sanity.bbclass: Avoid empty $PATH components Peter Seebach
2012-05-09 20:19 ` [PATCH 1/1] sanity.bbclass: Detect empty $PATH components too Peter Seebach
@ 2012-05-11 17:35 ` Saul Wold
1 sibling, 0 replies; 3+ messages in thread
From: Saul Wold @ 2012-05-11 17:35 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On 05/09/2012 01:19 PM, Peter Seebach wrote:
> Empty components (including $PATHs starting or ending with a colon)
> have the same harmful effects as a "." in $PATH.
>
> The following changes since commit 8de7f8045f28aecfe796afcdb013c557ce9d1372:
> Martin Jansa (1):
> kmod: fix upgrade path from module-init-tools
>
> are available in the git repository at:
>
> git://git.yoctoproject.org/poky-contrib seebs/cleanup
> http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=seebs/cleanup
>
> Peter Seebach (1):
> sanity.bbclass: Detect empty $PATH components too
>
> meta/classes/sanity.bbclass | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
>
Merged into OE-Core
Thanks
Sau!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-05-11 17:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-09 20:19 [PATCH 0/1] sanity.bbclass: Avoid empty $PATH components Peter Seebach
2012-05-09 20:19 ` [PATCH 1/1] sanity.bbclass: Detect empty $PATH components too Peter Seebach
2012-05-11 17:35 ` [PATCH 0/1] sanity.bbclass: Avoid empty $PATH components Saul Wold
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.