[PATCH 0/1] Include locale in the package manifest

[PATCH 0/1] Include locale in the package manifest

[Elizabeth Flanagan]

This patch is removes the exclusion of *locale* from the package and license
manifests. Doing so, allows us to accurately audit the packages installed
on an image with what the manifests contain.

This was tested by:

ssh root@192.168.7.4 'rpm -qa|sort' >> pkg_list
pr -m -t -s package.manifest pkg_list | gawk '{print $2 " " $1}'

and then manually comparing the results.

The following changes since commit 381c4b69c7e8b452f4d3de2f8214e6e5f6a9abe7:

  sstate.bbclass: fix detection of owners matching sstate files (2012-12-05 15:34:07 +0000)

are available in the git repository at:

  git://git.yoctoproject.org/poky-contrib eflanagan/locale_license
  http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=eflanagan/locale_license

Elizabeth Flanagan (1):
  license.bbclass: Including locale packages

 meta/classes/license.bbclass |    7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

-- 
1.7.9.5

[PATCH 1/1] license.bbclass: Including locale packages

[Elizabeth Flanagan]

As locale packages are installed on the image, we should
be including them in the package/license manifest.

This ensures that the manifests are accurate and complete.

[ YOCTO #2461 ]

Signed-off-by: Elizabeth Flanagan <elizabeth.flanagan@intel.com>
---
 meta/classes/license.bbclass |    7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/meta/classes/license.bbclass b/meta/classes/license.bbclass
index c7ca4a6..8c03c42 100644
--- a/meta/classes/license.bbclass
+++ b/meta/classes/license.bbclass
@@ -13,7 +13,7 @@ do_populate_lic[cleandirs] = "${LICSSTATEDIR}"
 license_create_manifest() {
 	mkdir -p ${LICENSE_DIRECTORY}/${IMAGE_NAME}
 	# Get list of installed packages
-	list_installed_packages | grep -v "locale" |sort > ${LICENSE_DIRECTORY}/${IMAGE_NAME}/package.manifest
+	list_installed_packages |sort > ${LICENSE_DIRECTORY}/${IMAGE_NAME}/package.manifest
 	INSTALLED_PKGS=`cat ${LICENSE_DIRECTORY}/${IMAGE_NAME}/package.manifest`
 	LICENSE_MANIFEST="${LICENSE_DIRECTORY}/${IMAGE_NAME}/license.manifest"
 	# remove existing license.manifest file
@@ -26,11 +26,6 @@ license_create_manifest() {
 		filename=`ls ${TMPDIR}/pkgdata/*/runtime-reverse/${pkg}| head -1`
 		pkged_pn="$(sed -n 's/^PN: //p' ${filename})"
 
-		# exclude locale recipes
-		if [ "${pkged_pn}" = "*locale*" ]; then
-			continue
-		fi
-
 		# check to see if the package name exists in the manifest. if so, bail.
 		if grep -q "^PACKAGE NAME: ${pkg}" ${LICENSE_MANIFEST}; then
 			continue
-- 
1.7.9.5

Re: [PATCH 1/1] license.bbclass: Including locale packages

[Otavio Salvador]

[-- Attachment #1: Type: text/plain, Size: 628 bytes --]

On Wed, Dec 5, 2012 at 9:37 PM, Elizabeth Flanagan <
elizabeth.flanagan@intel.com> wrote:

> As locale packages are installed on the image, we should
> be including them in the package/license manifest.
>
> This ensures that the manifests are accurate and complete.
>
> [ YOCTO #2461 ]
>
> Signed-off-by: Elizabeth Flanagan <elizabeth.flanagan@intel.com>
>

Do you see any problem in it being add to danny as well?

-- 
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

[-- Attachment #2: Type: text/html, Size: 1220 bytes --]

Re: [PATCH 1/1] license.bbclass: Including locale packages

[Flanagan, Elizabeth]

On Thu, Dec 6, 2012 at 4:01 AM, Otavio Salvador <otavio@ossystems.com.br> wrote:
>
>
>
> On Wed, Dec 5, 2012 at 9:37 PM, Elizabeth Flanagan
> <elizabeth.flanagan@intel.com> wrote:
>>
>> As locale packages are installed on the image, we should
>> be including them in the package/license manifest.
>>
>> This ensures that the manifests are accurate and complete.
>>
>> [ YOCTO #2461 ]
>>
>> Signed-off-by: Elizabeth Flanagan <elizabeth.flanagan@intel.com>
>
>
> Do you see any problem in it being add to danny as well?
>

If it applies cleanly, no, I don't see an issue. It may not apply
clean though, so we may need to cherry-pick a few commits.

-b

> --
> Otavio Salvador                             O.S. Systems
> E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
> Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
>



-- 
Elizabeth Flanagan
Yocto Project
Build and Release